Re: [RESEND PATCH v4] devres: Refactor using guards

2024-09-11 Thread Greg KH
Converting working code for no real reason other than "let's change this!" isn't always a good idea. For new code going forward, or if you are touching the same area, sure, that makes sense, but be careful about stuff like this. > Signed-off-by: Andrea Calabrese > >

Re: [PATCH] fbdev/xen-fbfront: Assign fb_info->device

2024-09-10 Thread Greg KH
On Tue, Sep 10, 2024 at 02:18:35PM +0200, Arthur Borsboom wrote: > On Tue, 10 Sept 2024 at 10:33, Greg KH wrote: > > > > On Tue, Sep 10, 2024 at 10:13:01AM +0200, Roger Pau Monné wrote: > > > On Tue, Sep 10, 2024 at 09:29:30AM +0200, Thomas Zimmermann wrote: > > >

Re: [PATCH] fbdev/xen-fbfront: Assign fb_info->device

2024-09-10 Thread Greg KH
On Tue, Sep 10, 2024 at 10:13:01AM +0200, Roger Pau Monné wrote: > On Tue, Sep 10, 2024 at 09:29:30AM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 10.09.24 um 09:22 schrieb Roger Pau Monné: > > > On Mon, Sep 09, 2024 at 10:09:16PM -0400, Jason Andryuk wrote: > > > > From: Jason Andryuk > > >

Re: [PATCH v5.15-v5.10] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

2024-09-08 Thread Greg KH
On Fri, Sep 06, 2024 at 11:02:32AM -0400, Alex Deucher wrote: > On Fri, Sep 6, 2024 at 4:50 AM Mukul Sikka wrote: > > > > On Fri, Sep 6, 2024 at 12:05 AM Alex Deucher wrote: > > > > > > On Tue, Sep 3, 2024 at 5:53 AM sikkamukul > > > wrote: > > > > > > > > From: Bob Zhou > > > > > > > > [ Upst

Re: [PATCH v5.15-v5.10] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

2024-09-05 Thread Greg KH
On Tue, Sep 03, 2024 at 04:58:09AM +, sikkamukul wrote: > From: Bob Zhou > > [ Upstream commit 50151b7f1c79a09117837eb95b76c2de76841dab ] > > Check return value and conduct null pointer handling to avoid null pointer > dereference. > > Signed-off-by: Bob Zhou > Reviewed-by: Tim Huang > S

Re: [PATCH v2] drm/imx/ipuv3: ipuv3-plane: Round up plane width for IPUV3_CHANNEL_MEM_DC_SYNC

2024-09-04 Thread Greg KH
On Wed, Sep 04, 2024 at 04:48:51PM +0800, Liu Ying wrote: > On 09/04/2024, Paul Pu wrote: > > Cc: sta...@vger.kernel.org # 5.15+ > > Why 5.15+ ? Because the commit referenced in Fixes: was backported there. If you want to be picky, just drop the "# 5.15+" and our tools will rely on the Fixes: ta

Re: [PATCH] drm: imx: ipuv3-plane: fix HDMI cannot work for odd screen resolutions

2024-09-03 Thread Greg KH
On Wed, Sep 04, 2024 at 05:43:15AM +0300, Paul Pu wrote: > This changes the judgement of if needing to round up the width or not, > from using the `dp_flow` to the plane's type. > > The `dp_flow` can be -22(-EINVAL) even the plane is a PRIMARY one. > See `client_reg[]` in `ipu-common.c`. > > [

Re: [PATCH v4.19-v6.1] drm/amdgpu: Using uninitialized value *size when calling

2024-08-29 Thread Greg KH
On Wed, Aug 28, 2024 at 10:15:56AM -0500, Vamsi Krishna Brahmajosyula wrote: > From: Jesse Zhang > > [ Upstream commit 88a9a467c548d0b3c7761b4fd54a68e70f9c0944 ] > > Initialize the size before calling amdgpu_vce_cs_reloc, such as case > 0x0301. > V2: To really improve the handling we would

Re: [PATCH 6.10] drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()

2024-08-17 Thread Greg KH
On Sat, Aug 17, 2024 at 10:30:41PM +0200, Kevin Holm wrote: > > > On 17.08.24 10:42, Greg KH wrote: > > On Tue, Jul 30, 2024 at 08:53:39PM +0200, Kevin Holm wrote: > > > From: Wayne Lin > > > > > > [ Upstream commit fa57924c76d995e87c

Re: [PATCH 6.10] drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()

2024-08-17 Thread Greg KH
On Tue, Jul 30, 2024 at 08:53:39PM +0200, Kevin Holm wrote: > From: Wayne Lin > > [ Upstream commit fa57924c76d995e87ca3533ec60d1d5e55769a27 ] > > [Why] > dm_dp_mst_is_port_support_mode() is a bit not following the original design > rule and cause > light up issue with multiple 4k monitors afte

Re: [PATCH v1] misc: fastrpc: Trigger a panic using BUG_ON in device release

2024-08-13 Thread Greg KH
On Mon, Aug 05, 2024 at 04:36:28PM +0530, Abhishek Singh wrote: > > On 7/30/2024 12:46 PM, Greg KH wrote: > > On Tue, Jul 30, 2024 at 12:39:45PM +0530, Abhishek Singh wrote: > >> The user process on ARM closes the device node while closing the > >> session, triggers

Re: [PATCH 6.10] drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()

2024-08-11 Thread Greg KH
On Tue, Jul 30, 2024 at 08:53:39PM +0200, Kevin Holm wrote: > From: Wayne Lin > > [ Upstream commit fa57924c76d995e87ca3533ec60d1d5e55769a27 ] > > [Why] > dm_dp_mst_is_port_support_mode() is a bit not following the original design > rule and cause > light up issue with multiple 4k monitors afte

Re: [PATCH] staging: vme_user: vme_bridge.h: Fix mutex without comment warning

2024-07-31 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [PATCH] staging: vme_user: vme_bridge.h: Fix mutex without comment warning

2024-07-31 Thread Greg KH
On Wed, Jul 31, 2024 at 01:06:05PM +0530, Riyan Dhiman wrote: > Adhere to Linux kernel coding style > > Reported by checkpatch: > > CHECK: mutex definition without comment > > Signed-off-by: Riyan Dhiman > --- > drivers/staging/vme_user/vme_bridge.h | 4 > 1 file changed, 4 insertions(+)

Re: [PATCH] staging: fbtft: Remove trailing semicolon in macro.

2024-07-30 Thread Greg KH
On Tue, Jul 30, 2024 at 07:14:55AM +, Sakirnth Nagarasa wrote: > Fix checkpath warning: "WARNING: macros should not use a trailing semicolon > in fbtft.h:356. > > Signed-off-by: Sakirnth Nagarasa > > --- > > Hello, this is my first patch to the kernel. > --- > drivers/staging/fbtft/fbtft.h

Re: [PATCH v1] misc: fastrpc: Trigger a panic using BUG_ON in device release

2024-07-30 Thread Greg KH
On Tue, Jul 30, 2024 at 12:39:45PM +0530, Abhishek Singh wrote: > The user process on ARM closes the device node while closing the > session, triggers a remote call to terminate the PD running on the > DSP. If the DSP is in an unstable state and cannot process the remote > request from the HLOS, gl

Re: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-29 Thread Greg KH
On Tue, Jul 30, 2024 at 05:56:42AM +, Lin, Wayne wrote: > [Public] > > Hi, > Thanks for the report. > > Patch fa57924c76d995 ("drm/amd/display: Refactor function > dm_dp_mst_is_port_support_mode()") > is kind of correcting problems causing by commit: > 4df96ba6676034 ("drm/amd/display: Add t

Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

2024-07-24 Thread Greg KH
On Wed, Jul 24, 2024 at 06:22:55PM +0530, Riyan Dhiman wrote: > Hi, > > Thank you for your feedback on my patch submission. > I understand that the fix provided by my patch is not needed. As this is my > first contribution to the Linux kernel, I am eager to learn and make > valuable contributions.

Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

2024-07-23 Thread Greg KH
On Tue, Jul 23, 2024 at 06:28:19PM +0530, Riyan Dhiman wrote: > Hi, > > Thank you for your feedback on my patch submission. > I have reviewed the mailing list traffic and noted that the last patch > addressing the same coding style issue was submitted in April. Given this > timeframe, I believed i

Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

2024-07-23 Thread Greg KH
On Tue, Jul 23, 2024 at 11:33:11AM +0530, Riyan Dhiman wrote: > Adhere to Linux kernel coding style. > > Reported by checkpatch: > > CHECK: Unnecessary parentheses around 'devcode != 0x' > CHECK: Unnecessary parentheses around 'devcode != 0x9320' > CHECK: Unnecessary parentheses around 'par->

Re: [PATCH v5 1/2] misc: fastrpc: Define a new initmem size for user PD

2024-07-22 Thread Greg KH
On Mon, Jul 22, 2024 at 11:42:52AM +0530, Ekansh Gupta wrote: > > > On 7/22/2024 11:28 AM, Greg KH wrote: > > On Mon, Jul 22, 2024 at 11:24:36AM +0530, Ekansh Gupta wrote: > >> For user PD initialization, initmem is allocated and sent to DSP for > >> initi

Re: [PATCH v5 2/2] misc: fastrpc: Increase unsigned PD initmem size

2024-07-21 Thread Greg KH
On Mon, Jul 22, 2024 at 11:24:37AM +0530, Ekansh Gupta wrote: > For unsigned PD offloading requirement, additional memory is required > because of additional static heap initialization. Without this > additional memory, PD initialization would fail. Increase the initmem > size by 2MB for unsigned P

Re: [PATCH v5 1/2] misc: fastrpc: Define a new initmem size for user PD

2024-07-21 Thread Greg KH
On Mon, Jul 22, 2024 at 11:24:36AM +0530, Ekansh Gupta wrote: > For user PD initialization, initmem is allocated and sent to DSP for > initial memory requirements like shell loading. The size of this memory > is decided based on the shell size that is passed by the user space. > With the current im

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Greg KH
On Tue, Jul 09, 2024 at 12:04:02PM +0200, Jocelyn Falempe wrote: > > > On 09/07/2024 11:12, Greg KH wrote: > > On Tue, Jul 09, 2024 at 11:11:35AM +0200, Greg KH wrote: > > > On Tue, Jul 09, 2024 at 10:40:10AM +0200, Jocelyn Falempe wrote: > > > >

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Greg KH
On Tue, Jul 09, 2024 at 11:11:35AM +0200, Greg KH wrote: > On Tue, Jul 09, 2024 at 10:40:10AM +0200, Jocelyn Falempe wrote: > > +config DRM_PANIC_SCREEN_QR_CODE_URL > > + string "Base url of the QR code in the panic screen" > > + depends on DRM_PANIC_SCREEN_QR_C

Re: [PATCH v2 4/4] drm/panic: Add a qr_code panic screen

2024-07-09 Thread Greg KH
On Tue, Jul 09, 2024 at 10:40:10AM +0200, Jocelyn Falempe wrote: > +config DRM_PANIC_SCREEN_QR_CODE_URL > + string "Base url of the QR code in the panic screen" > + depends on DRM_PANIC_SCREEN_QR_CODE > + help > + This option sets the base url to report the kernel panic. If it's s

Re: [PATCH 4/4] drm/panic: Add a qr_code panic screen

2024-07-04 Thread Greg KH
On Thu, Jul 04, 2024 at 09:11:09AM +, Alice Ryhl wrote: > As long as the above requirements are satisfied, calling > `drm_panic_qr_generate` should never cause memory unsafety, so this is > an appropriate list of safety requirements. > > (You also require that `data_len <= data_size`, but if t

Re: [PATCH v1] misc: fastrpc: Add support for multiple PD from one process

2024-07-03 Thread Greg KH
On Thu, Jul 04, 2024 at 11:47:22AM +0530, Ekansh Gupta wrote: > > > On 7/3/2024 4:09 PM, Greg KH wrote: > > On Wed, Jul 03, 2024 at 12:22:00PM +0530, Ekansh Gupta wrote: > >> @@ -268,6 +272,7 @@ struct fastrpc_channel_ctx { > >>struct fastrpc_session

Re: [PATCH 0/4] drm/panic: Add a qr_code panic screen

2024-07-03 Thread Greg KH
On Wed, Jul 03, 2024 at 05:33:57PM +0200, Jocelyn Falempe wrote: > This series adds a new panic screen, with the kmsg data embedded in a QR-code. > > The main advantage of QR-code, is that you can copy/paste the debug data to a > bug report. > > The QR-code encoder is written in rust, and is ver

Re: [PATCH v1] misc: fastrpc: Add support for multiple PD from one process

2024-07-03 Thread Greg KH
On Wed, Jul 03, 2024 at 12:22:00PM +0530, Ekansh Gupta wrote: > @@ -268,6 +272,7 @@ struct fastrpc_channel_ctx { > struct fastrpc_session_ctx session[FASTRPC_MAX_SESSIONS]; > spinlock_t lock; > struct idr ctx_idr; > + struct ida dsp_pgid_ida; You have an idr and an ida? Why

Re: [PATCH v2] misc: fastrpc: Remove user PD initmem size check

2024-06-28 Thread Greg KH
On Fri, Jun 28, 2024 at 04:12:10PM +0530, Ekansh Gupta wrote: > > > On 6/28/2024 3:59 PM, Ekansh Gupta wrote: > > > > On 6/27/2024 4:43 PM, Dmitry Baryshkov wrote: > >> On Thu, Jun 27, 2024 at 11:35:18AM GMT, Ekansh Gupta wrote: > >>> For user PD initialization, initmem is allocated and sent to D

Re: [PATCH v2] drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes

2024-06-27 Thread Greg KH
On Thu, Jun 27, 2024 at 01:33:40PM +0200, Markus Elfring wrote: > > In cdv_intel_lvds_get_modes(), the return value of drm_mode_duplicate() > > is assigned to mode, which will lead to a NULL pointer dereference on > > failure of drm_mode_duplicate(). Add a check to avoid npd. > > A) Can a wording

Re: [PATCH v2] misc: fastrpc: Remove user PD initmem size check

2024-06-27 Thread Greg KH
On Thu, Jun 27, 2024 at 01:20:15PM +0200, Greg KH wrote: > On Thu, Jun 27, 2024 at 11:35:18AM +0530, Ekansh Gupta wrote: > > For user PD initialization, initmem is allocated and sent to DSP for > > initial memory requirements like shell loading. This size is passed > > by user

Re: [PATCH v2] misc: fastrpc: Remove user PD initmem size check

2024-06-27 Thread Greg KH
On Thu, Jun 27, 2024 at 11:35:18AM +0530, Ekansh Gupta wrote: > For user PD initialization, initmem is allocated and sent to DSP for > initial memory requirements like shell loading. This size is passed > by user space and is checked against a max size. For unsigned PD > offloading, more than 2MB s

Re: [PATCH v3] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-27 Thread Greg KH
On Thu, Jun 27, 2024 at 04:12:44PM +0530, Ekansh Gupta wrote: > Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned > to be added for PD notifications and other missing features. Adding > and maintaining new files from within fastrpc directory would be easy. > > Example of feature

Re: [PATCH] drm/nouveau/dispnv04: fix null pointer dereference in nv17_tv_get_ld_modes

2024-06-25 Thread Greg KH
On Tue, Jun 25, 2024 at 03:43:37PM +0200, Markus Elfring wrote: > > In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate() is > > assigned to mode, which will lead to a possible NULL pointer dereference > > on failure of drm_mode_duplicate(). Add a check to avoid npd. > > Can a wordin

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-18 Thread Greg KH
On Wed, Jun 19, 2024 at 12:15:03PM +0530, Ekansh Gupta wrote: > > > On 6/12/2024 11:58 PM, Dmitry Baryshkov wrote: > > On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: > >> Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned > >> to be added for PD notifications and o

Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate

2024-06-12 Thread Greg KH
On Wed, Jun 12, 2024 at 03:28:01PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > On 23.05.24 20:58, Måns Rullgård wrote: > > Måns Rullgård writes: > >> Frank Oltmanns writes: > >>> 21.05.2024 15:43:10 Måns Rullgård : > Frank Oltmanns writes: > > > The Allwinner SoC

Re: [PATCH] Revert "drm/amdgpu: init iommu after amdkfd device init"

2024-06-12 Thread Greg KH
On Wed, Jun 12, 2024 at 12:10:37PM +1200, Matthew Ruffell wrote: > Hi Greg KH, Sasha, > > Please pick up this patch for 5.15 stable tree. I have built a test kernel and > can confirm that it fixes affected users. > > Downstream bug: > https://bugs.launchpad.net/ubuntu/+sour

Re: [PATCH v3] devres: Refactor using guards

2024-06-12 Thread Greg KH
On Wed, Jun 12, 2024 at 12:00:06PM +0200, Andrea Calabrese wrote: > Hi Lucas, > > On 12/06/2024 11:26, Lucas Stach wrote: > > Am Dienstag, dem 11.06.2024 um 11:37 +0200 schrieb Andrea Calabrese: > > > Code refactoring using the recent guard and scoped_guard macros > > > for automatic cleanup of th

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Greg KH
On Fri, Jun 07, 2024 at 03:33:39PM +0200, Danilo Krummrich wrote: > On Fri, Jun 07, 2024 at 02:36:50PM +0200, Greg KH wrote: > > Anyway, that's all hand-wavy right now, sorry, to get back to the point > > here, again, let's take this, which will allow the firmware bindi

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-06-07 Thread Greg KH
On Fri, Jun 07, 2024 at 09:11:32PM +0900, FUJITA Tomonori wrote: > Hi, > > On Fri, 31 May 2024 11:59:47 +0200 > Danilo Krummrich wrote: > > > Once we get to a conclusion I can send a series with only the device and > > firmare > > abstractions such that we can get them in outside of the scope o

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-29 Thread Greg KH
On Wed, May 29, 2024 at 09:28:21AM +0900, FUJITA Tomonori wrote: > Hi, > > On Tue, 28 May 2024 14:45:02 +0200 > Greg KH wrote: > > > On Tue, May 28, 2024 at 02:19:24PM +0200, Danilo Krummrich wrote: > >> However, if you have a driver that needs the firmware

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-28 Thread Greg KH
On Tue, May 28, 2024 at 02:19:24PM +0200, Danilo Krummrich wrote: > However, if you have a driver that needs the firmware abstractions, I would be > surprised if there were any hesitations to already merge the minimum device > abstractions [1] and this one (once reviewed) without the rest. At least

Re: Kernel 5.15.150 black screen with AMD Raven/Picasso GPU

2024-05-23 Thread Greg KH
On Thu, May 23, 2024 at 05:59:39PM +0200, Armin Wolf wrote: > Am 23.05.24 um 15:13 schrieb Barry Kauler: > > > On Wed, May 22, 2024 at 12:58 AM Armin Wolf wrote: > > > Am 20.05.24 um 18:22 schrieb Alex Deucher: > > > > > > > On Sat, May 18, 2024 at 8:17 PM Armin Wolf wrote: > > > > > Am 17.05.2

Re: [PATCH 1/2] drm/rockchip: vop: clear DMA stop bit on flush on RK3066

2024-05-19 Thread Greg KH
On Sun, May 19, 2024 at 05:38:24AM -0300, Val Packett wrote: > > > On Sun, May 19 2024 at 09:59:47 +02:00:00, Greg KH > wrote: > > On Sun, May 19, 2024 at 04:31:31AM -0300, Val Packett wrote: > > > On the RK3066, there is a bit that must be cleared on flush, >

Re: [PATCH 1/2] drm/rockchip: vop: clear DMA stop bit on flush on RK3066

2024-05-19 Thread Greg KH
On Sun, May 19, 2024 at 04:31:31AM -0300, Val Packett wrote: > On the RK3066, there is a bit that must be cleared on flush, otherwise > we do not get display output (at least for RGB). > > Signed-off-by: Val Packett > Cc: sta...@vger.kernel.org > --- > Hi! This was required to get display working

Re: [PATCH 2/2] drm/rockchip: vop: enable VOP_FEATURE_INTERNAL_RGB on RK3066

2024-05-19 Thread Greg KH
On Sun, May 19, 2024 at 04:31:32AM -0300, Val Packett wrote: > Signed-off-by: Val Packett > Cc: sta...@vger.kernel.org > --- > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + > 1 file changed, 1 insertion(+) Maybe the DRM subsystem has more lax rules, but I know I can't take patches without a

Re: [Regression] 6.9.0: WARNING: workqueue: WQ_MEM_RECLAIM ttm:ttm_bo_delayed_delete [ttm] is flushing !WQ_MEM_RECLAIM events:qxl_gc_work [qxl]

2024-05-13 Thread Greg KH
On Wed, May 08, 2024 at 02:51:10PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > On 08.05.24 14:35, Anders Blomdell wrote: > > On 2024-05-07 07:04, Linux regression tracking (Thorsten Leemhuis) wrote: > >> On 06.05.24 16:30, David Wang wrote: > On 30.04.24 08:13, David Wang wr

Re: [linux-next:master] BUILD REGRESSION 9c6ecb3cb6e20c4fd7997047213ba0efcf9ada1a

2024-05-02 Thread Greg KH
On Fri, May 03, 2024 at 11:30:50AM +0530, Krishna Kurapati PSSNV wrote: > > > On 5/3/2024 10:42 AM, Greg KH wrote: > > Ok, I'm getting tired of seeing these for the USB portion of the tree, > > so I went to look for: > > > > On Fri, May 03, 2024 at 04:

Re: [linux-next:master] BUILD REGRESSION 9c6ecb3cb6e20c4fd7997047213ba0efcf9ada1a

2024-05-02 Thread Greg KH
Ok, I'm getting tired of seeing these for the USB portion of the tree, so I went to look for: On Fri, May 03, 2024 at 04:44:42AM +0800, kernel test robot wrote: > |-- arc-randconfig-002-20240503 > | `-- drivers-usb-dwc3-core.c:warning:variable-hw_mode-set-but-not-used This warning (same for all

Re: 答复: [PATCH v5.10] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-18 Thread Greg KH
On Thu, Apr 18, 2024 at 03:19:46AM +, wangzhu wrote: > Hi Greg, thanks for your reply. Since there is no patch to fix CVE-2023-52624 > in linux-5.10, there is a patch in the linux-6.7 branch to fix it, its commit > is 2ef98c6d753a744e333b7e34b9cf687040fba57d ("drm/amd/display: Wake DMCUB > b

Re: 答复: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-17 Thread Greg KH
On Thu, Apr 18, 2024 at 01:51:33AM +, wangzhu wrote: > Hi Greg, thanks for your reply. Since there is no patch to fix CVE-2023-52624 > in linux-5.10, there is a patch in the linux-6.7 branch, its commit is > 2ef98c6d753a744e333b7e34b9cf687040fba57d ("drm/amd/display: Wake DMCUB before > exec

Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-15 Thread Greg KH
On Tue, Apr 16, 2024 at 03:52:40AM +, Zhu Wang wrote: > From: Nicholas Kazlauskas > > stable inclusion > from stable-v6.7.3 > commit 2ef98c6d753a744e333b7e34b9cf687040fba57d > category: bugfix > bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9BV4C > CVE: CVE-2023-52624 > > Referenc

Re: [PATCH v5.10] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-15 Thread Greg KH
On Tue, Apr 16, 2024 at 02:43:47AM +, Zhu Wang wrote: > From: Nicholas Kazlauskas > > stable inclusion > from stable-v6.7.3 > commit2ef98c6d753a7 ("drm/amd/display: Wake DMCUB before executing > GPINT commands") > category: bugfix > bugzilla: https://gitee.com/src-openeuler/kernel/is

Re: [PATCH 4.19.y] drm/vkms: call drm_atomic_helper_shutdown before drm_dev_put()

2024-04-11 Thread Greg KH
On Tue, Apr 09, 2024 at 10:38:34AM +0800, guomengqi (A) wrote: > > 在 2024/4/5 17:30, Greg KH 写道: > > On Wed, Apr 03, 2024 at 05:47:16PM +0800, Guo Mengqi wrote: > > > commit 73a82b22963d ("drm/atomic: Fix potential use-after-free > > > in nonblocking commit

Re: [PATCH] staging: fbtft: fb_st7789v: support setting offset

2024-04-09 Thread Greg KH
On Wed, Apr 10, 2024 at 01:28:06AM +0800, Yuguo Pei wrote: > On Tue, 9 Apr 2024 17:49:25 +0200, Greg KH wrote: > > So you are now hard-coding the size? > > Yes, the change just helps developers who want to adapt to different screen > sizes. So there is no change? I don

Re: [PATCH] staging: fbtft: fb_st7789v: support setting offset

2024-04-09 Thread Greg KH
On Sat, Apr 06, 2024 at 12:57:47AM +0800, purofle wrote: > Some screen sizes using st7789v chips are different from 240x320, > and offsets need to be set to display all images properly. > > Signed-off-by: purofle We need a semi-real name here please. > --- > drivers/staging/fbtft/fb_st7789v.c

Re: [PATCH 4.19.y] drm/vkms: call drm_atomic_helper_shutdown before drm_dev_put()

2024-04-05 Thread Greg KH
On Wed, Apr 03, 2024 at 05:47:16PM +0800, Guo Mengqi wrote: > commit 73a82b22963d ("drm/atomic: Fix potential use-after-free > in nonblocking commits") introduced drm_dev_get/put() to > drm_atomic_helper_shutdown(). And this cause problem in vkms driver exit > process. > > vkms_exit() > drm_dev_

Re: [PATCH v2 1/1] Revert "drm/qxl: simplify qxl_fence_wait"

2024-04-04 Thread Greg KH
On Thu, Apr 04, 2024 at 07:14:48PM +0100, Alex Constantino wrote: > This reverts commit 5a838e5d5825c85556011478abde708251cc0776. > > Changes from commit 5a838e5d5825 ("drm/qxl: simplify qxl_fence_wait") would > result in a '[TTM] Buffer eviction failed' exception whenever it reached a > timeout.

Re: [PATCH] drm/vkms: call drm_atomic_helper_shutdown before drm_dev_put()

2024-03-29 Thread Greg KH
On Thu, Mar 21, 2024 at 03:55:37PM +0800, guomengqi (A) wrote: > > 在 2024/3/21 15:39, Greg KH 写道: > > On Thu, Mar 21, 2024 at 03:07:52PM +0800, Guo Mengqi wrote: > > > commit 73a82b22963d ("drm/atomic: Fix potential use-after-free > > > in nonblocking commit

Re: [PATCH v2 5/6] staging: fbtft: Remove reference to fb_blank

2024-03-22 Thread Greg KH
On Tue, Mar 19, 2024 at 10:37:24AM +0100, Thomas Zimmermann wrote: > The field fb_blank in struct backlight_properties is deprecated and > should not be used. Don't output its value in the driver's debug print. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Dan Carpenter Acked-by: Greg Kro

Re: [PATCH] drm/vkms: call drm_atomic_helper_shutdown before drm_dev_put()

2024-03-21 Thread Greg KH
On Thu, Mar 21, 2024 at 03:07:52PM +0800, Guo Mengqi wrote: > commit 73a82b22963d ("drm/atomic: Fix potential use-after-free > in nonblocking commits") introduced drm_dev_get/put() to > drm_atomic_helper_shutdown(). And this cause problem in vkms driver exit > process. > > vkms_exit() > drm_dev_

Re: Nova and staging Rust abstractions

2024-03-20 Thread Greg KH
On Wed, Mar 20, 2024 at 06:58:43PM +0100, Danilo Krummrich wrote: > @Greg, can you please have a first quick look at rust-device [5]? If they are sent as patches to review, yes, I can get to them as part of my normal patch review cycle. Otherwise I have no cyeles to dig through random github tree

Re: [PATCH stable v6.7] drm/nouveau: don't fini scheduler before entity flush

2024-03-04 Thread Greg KH
On Mon, Mar 04, 2024 at 07:10:56PM +0100, Danilo Krummrich wrote: > On 3/4/24 18:55, Greg KH wrote: > > On Mon, Mar 04, 2024 at 06:01:46PM +0100, Danilo Krummrich wrote: > > > Cc: # v6.7 only > > You say 6.7 only, but this commit is in 6.6, so why not 6.6 also? >

Re: [PATCH stable v6.7] drm/nouveau: don't fini scheduler before entity flush

2024-03-04 Thread Greg KH
On Mon, Mar 04, 2024 at 06:01:46PM +0100, Danilo Krummrich wrote: > This bug is present in v6.7 only, since the scheduler design has been > re-worked in v6.8. Now queued up, thanks. greg k-h

Re: [PATCH stable v6.7] drm/nouveau: don't fini scheduler before entity flush

2024-03-04 Thread Greg KH
On Mon, Mar 04, 2024 at 06:01:46PM +0100, Danilo Krummrich wrote: > This bug is present in v6.7 only, since the scheduler design has been > re-worked in v6.8. > > Client scheduler entities must be flushed before an associated GPU > scheduler is teared down. Otherwise the entitiy might still hold a

Re: [PATCH v2 2/8] staging/fbtft: Include

2024-02-17 Thread Greg KH
On Tue, Feb 13, 2024 at 09:42:20AM +0100, Thomas Zimmermann wrote: > Resolved the proxy include via , which does not require the > backlight header. > > Signed-off-by: Thomas Zimmermann Acked-by: Greg Kroah-Hartman

Re: [PATCH 0/2] drm/vmwgfx backport two fixes to v6.1.x branch

2024-01-22 Thread Greg KH
On Mon, Jan 22, 2024 at 06:10:11PM +0100, Jocelyn Falempe wrote: > Hi, > > I've backported this two commits: > f9e96bf19054 drm/vmwgfx: Fix possible invalid drm gem put calls > 91398b413d03 drm/vmwgfx: Keep a gem reference to user bos in surfaces > > They both fixes a950b989ea29 ("drm/vmwgfx: Do

Re: [PATCH 31/45] tty: vt: use VESA blanking constants

2024-01-18 Thread Greg KH
On Thu, Jan 18, 2024 at 09:41:34AM +0100, Thomas Zimmermann wrote: > Hi > > Am 18.01.24 um 09:32 schrieb Jiri Slaby: > > On 18. 01. 24, 9:30, Thomas Zimmermann wrote: > > > Am 18.01.24 um 08:57 schrieb Jiri Slaby (SUSE): > > > > There are VESA blanking constants defined in console.h already. So us

Re: [RFC PATCH] drm/amd/display: fix bandwidth validation failure on DCN 2.1

2024-01-03 Thread Greg KH
On Wed, Jan 03, 2024 at 09:44:18AM -0500, Hamza Mahfooz wrote: > On 12/29/23 11:25, Melissa Wen wrote: > > IGT `amdgpu/amd_color/crtc-lut-accuracy` fails right at the beginning of > > the test execution, during atomic check, because DC rejects the > > bandwidth state for a fb sizing 64x64. The test

Re: [PATCH 1/1] Revert "drm/edid: Fix csync detailed mode parsing"

2023-12-09 Thread Greg KH
On Wed, Dec 06, 2023 at 11:49:46AM +0300, kova...@altlinux.org wrote: > From: Vasiliy Kovalev > > This reverts commit 5a46dc8e4a064769e916d87bf9bccae75afc7289. > > Commit 50b6f2c8297793f7f3315623db78dcff85158e96 upstream. > > Commit 5a46dc8e4a0647 ("drm/edid: Fix csync detailed mode parsing") f

Re: [PATCH v2 1/2] driver core: Export device_is_dependent() to modules

2023-11-27 Thread Greg KH
On Mon, Nov 27, 2023 at 05:38:13PM +0100, Maxime Ripard wrote: > Greg, Rafael, > > On Mon, Nov 27, 2023 at 01:14:13PM +0800, Liu Ying wrote: > > Export device_is_dependent() since the drm_kms_helper module is starting > > to use it. > > > > Signed-off-by: Liu Ying > > --- > > v2: > > * Newly int

Re: [PATCH v7 1/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-17 Thread Greg KH
On Fri, Nov 17, 2023 at 01:46:32PM -0800, Hsin-Yi Wang wrote: > Generic edp gets mode from edid. However, some panels report incorrect > mode in this way, resulting in glitches on panel. Introduce a new quirk > additional_mode to the generic edid to pick a correct hardcoded mode. > > Signed-off-by

Re: [PATCH] drm/amd/pm: replace 1-element arrays with flexible-array members

2023-11-09 Thread Greg KH
On Thu, Nov 09, 2023 at 10:43:50AM +0200, José Pekkarinen wrote: > On 2023-11-08 09:29, Greg KH wrote: > > On Wed, Nov 08, 2023 at 08:54:35AM +0200, José Pekkarinen wrote: > > > The following case seems to be safe to be replaced with a flexible > > > array > > &

Re: [PATCH] drm/amd/pm: replace 1-element arrays with flexible-array members

2023-11-07 Thread Greg KH
On Wed, Nov 08, 2023 at 08:54:35AM +0200, José Pekkarinen wrote: > The following case seems to be safe to be replaced with a flexible array > to clean up the added coccinelle warning. This patch will just do it. > > drivers/gpu/drm/amd/pm/powerplay/smumgr/smu8_smumgr.h:76:38-63: WARNING use > fle

Re: [PATCH v6 4/5] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-07 Thread Greg KH
On Tue, Nov 07, 2023 at 12:41:54PM -0800, Hsin-Yi Wang wrote: > Generic edp gets mode from edid. However, some panels report incorrect > mode in this way, resulting in glitches on panel. Introduce a new quirk > additional_mode to the generic edid to pick a correct hardcoded mode. > > Signed-off-by

Re: [PATCH v6 3/5] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-07 Thread Greg KH
On Tue, Nov 07, 2023 at 12:41:53PM -0800, Hsin-Yi Wang wrote: > Add a few generic edp panels used by mt8186 chromebooks. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Douglas Anderson > --- > no change. > --- > drivers/gpu/drm/panel/panel-edp.c | 51 +++ > 1 file ch

Re: [PATCH] drm/amd/display: remove redundant check

2023-10-31 Thread Greg KH
On Tue, Oct 31, 2023 at 01:42:17PM +0200, José Pekkarinen wrote: > On 2023-10-31 07:48, Greg KH wrote: > > On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote: > > > This patch addresses the following warning spotted by > > > using coccinelle where the

Re: [PATCH] drm/amd/display: remove redundant check

2023-10-30 Thread Greg KH
On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote: > This patch addresses the following warning spotted by > using coccinelle where the case checked does the same > than the else case. > > drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: > WARNING: poss

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-10-09 Thread Greg KH
On Mon, Oct 09, 2023 at 02:46:40PM +0200, Christian König wrote: > Am 07.10.23 um 11:50 schrieb Greg KH: > > On Sun, Sep 10, 2023 at 03:43:01PM -0500, Bryan Jennings wrote: > > > This is also causing log spam on 5.15. It was included in 5.15.1

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-10-07 Thread Greg KH
On Sun, Sep 10, 2023 at 03:43:01PM -0500, Bryan Jennings wrote: > This is also causing log spam on 5.15. It was included in 5.15.128 as > commit 4921792e04f2125b5eadef9dbe9417a8354c7eff. I encountered this and > found https://gitlab.freedesktop.org/drm/amd/-/issues/2820 while researching > the pr

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-09-12 Thread Greg KH
On Sun, Sep 10, 2023 at 03:43:01PM -0500, Bryan Jennings wrote: > This is also causing log spam on 5.15. It was included in 5.15.128 as > commit 4921792e04f2125b5eadef9dbe9417a8354c7eff. I encountered this and > found https://gitlab.freedesktop.org/drm/amd/-/issues/2820 while researching > the pr

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Greg KH
On Thu, Aug 31, 2023 at 03:26:28PM +0200, Christian König wrote: > Am 31.08.23 um 12:56 schrieb Greg KH: > > On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote: > > > Am 30.08.23 um 20:53 schrieb Chia-I Wu: > > > > On Sun, Jul 23, 2023 at 6:24 PM Sash

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Greg KH
On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote: > Am 30.08.23 um 20:53 schrieb Chia-I Wu: > > On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote: > > > From: Lang Yu > > > > > > [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] > > > > > > When using cpu to update pag

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Greg KH
On Wed, Aug 30, 2023 at 11:53:29AM -0700, Chia-I Wu wrote: > On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote: > > > > From: Lang Yu > > > > [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] > > > > When using cpu to update page tables, vm update fences are unused. > > Install stub fe

Re: [PATCH 8/8] staging/fbtft: Use fb_ops helpers for deferred I/O

2023-08-28 Thread Greg KH
On Mon, Aug 28, 2023 at 03:14:24PM +0200, Thomas Zimmermann wrote: > Generate callback functions for struct fb_ops with the fbdev macro > FB_GEN_DEFAULT_DEFERRED_SYSMEM_OPS(). Initialize struct fb_ops to > the generated functions with an fbdev initializer macro. > > Signed-off-by: Thomas Zimmerman

Re: [PATCH 7/8] staging/fbtft: Initialize fb_op struct as static const

2023-08-28 Thread Greg KH
On Mon, Aug 28, 2023 at 03:14:23PM +0200, Thomas Zimmermann wrote: > Replace dynamic allocation of the fb_ops instance with static > allocation. Initialize the fields at module-load time. The owner > field changes to THIS_MODULE, as in all other fbdev drivers. > > Signed-off-by: Thomas Zimmermann

Re: [PATCH v2 4/4] staging/sm750fb: Do not include

2023-07-06 Thread Greg KH
On Thu, Jul 06, 2023 at 12:42:17PM +0200, Thomas Zimmermann wrote: > The sm750fb driver does not need anything from . > Remove the include statements. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Javier Martinez Canillas > Cc: Sudip Mukherjee > Cc: Teddy Wang > --- > drivers/staging/sm

Re: [PATCH v10 00/25] DEPT(Dependency Tracker)

2023-06-26 Thread Greg KH
On Mon, Jun 26, 2023 at 08:56:35PM +0900, Byungchul Park wrote: > >From now on, I can work on LKML again! I'm wondering if DEPT has been > helping kernel debugging well even though it's a form of patches yet. > > I'm happy to see that DEPT reports a real problem in practice. See: > > > https:

Re: [PATCH] dma-buf: keep the signaling time of merged fences

2023-06-21 Thread Greg KH
On Wed, Jun 21, 2023 at 02:05:07PM +0200, Christian König wrote: > Am 21.06.23 um 13:02 schrieb Greg KH: > > On Wed, Jun 21, 2023 at 09:32:04AM +0200, Christian König wrote: > > > Some Android CTS is testing for that. > > > > > > Signed-off-by: Christian Kön

Re: [PATCH] dma-buf: keep the signaling time of merged fences

2023-06-21 Thread Greg KH
On Wed, Jun 21, 2023 at 09:32:04AM +0200, Christian König wrote: > Some Android CTS is testing for that. > > Signed-off-by: Christian König > CC: sta...@vger.kernel.org What commit id does this fix? thanks, greg k-h

Re: [PATCH] dma-buf: keep the signaling time of merged fences

2023-06-21 Thread Greg KH
On Wed, Jun 21, 2023 at 09:32:04AM +0200, Christian König wrote: > Some Android CTS is testing for that. > > Signed-off-by: Christian König > CC: sta...@vger.kernel.org > --- > drivers/dma-buf/dma-fence-unwrap.c | 11 +-- > drivers/dma-buf/dma-fence.c| 5 +++-- > drivers/gpu/drm

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

2023-06-05 Thread Greg KH
On Mon, Jun 05, 2023 at 04:48:12PM +0200, Thomas Zimmermann wrote: > Add Kconfig option CONFIG_FB_DEVICE and make the virtual fbdev > device optional. If the new option has not been selected, fbdev > does not create a files in devfs or sysfs. > > Most modern Linux systems run a DRM-based graphics

Re: [PATCH v2] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-25 Thread Greg KH
On Tue, Apr 25, 2023 at 11:17:14PM -0700, Chia-I Wu wrote: > mgr->ctx_handles should be protected by mgr->lock. > > v2: improve commit message > > Signed-off-by: Chia-I Wu > Cc: sta...@vger.kernel.org What commit id does this fix? How far back in stable kernels should this go? thanks, greg k

Re: [PATCH] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-25 Thread Greg KH
On Tue, Apr 25, 2023 at 05:48:27PM -0700, Chia-I Wu wrote: > Signed-off-by: Chia-I Wu > Cc: sta...@vger.kernel.org I know I can not take patches without any changelog text at all, maybe the DRM developers are more lax, but it's not a good idea at all. thanks, greg k-h

Re: [PATCH] Revert "accel/qaic: Add mhi_qaic_cntl"

2023-04-12 Thread Greg KH
On Wed, Apr 12, 2023 at 07:57:44AM -0600, Jeffrey Hugo wrote: > This reverts commit 566fc96198b4bb07ca6806386956669881225271. > > This exposes a userspace API that is still under debate. Revert the > change before the uAPI gets exposed to avoid making a mistake. QAIC is > otherwise still functio

Re: linux-next: build failure after merge of the driver-core tree

2023-04-11 Thread Greg KH
10:31 AM, Daniel Vetter wrote: > > > > > On Tue, Apr 11, 2023 at 09:29:27AM -0600, Jeffrey Hugo wrote: > > > > > > On 4/11/2023 9:26 AM, Jeffrey Hugo wrote: > > > > > > > On 4/11/2023 9:13 AM, Greg KH wrote: > > > > > > > >

Re: linux-next: build failure after merge of the driver-core tree

2023-04-11 Thread Greg KH
On Tue, Apr 11, 2023 at 09:08:39AM -0600, Jeffrey Hugo wrote: > On 4/11/2023 9:01 AM, Daniel Vetter wrote: > > On Tue, Apr 11, 2023 at 12:40:28PM +0200, Greg KH wrote: > > > On Tue, Apr 11, 2023 at 11:55:20AM +0200, Daniel Vetter wrote: > > > > On Tue, Apr 11, 202

Re: linux-next: build failure after merge of the driver-core tree

2023-04-11 Thread Greg KH
On Tue, Apr 11, 2023 at 11:55:20AM +0200, Daniel Vetter wrote: > On Tue, Apr 11, 2023 at 02:38:12PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > After merging the driver-core tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > In file included from include/lin

  1   2   3   4   5   6   7   8   >