Re: [PATCH] drm/msm: Fix gen_header.py for older python3 versions

Hi all, On 12/04/2024 17:54, Jon Hunter wrote: The gen_header.py script is failing for older versions of python3 such as python 3.5. Two issues observed with python 3.5 are ... 1. Python 3 versions prior to 3.6 do not support the f-string format. 2. Early python 3 versions do not support

[PATCH] drm/msm: Fix gen_header.py for older python3 versions

add_subparsers(). Fix both of the above so that older versions of python 3 still work. Fixes: 8f7abf0b86fe ("drm/msm: generate headers on the fly") Signed-off-by: Jon Hunter --- drivers/gpu/drm/msm/registers/gen_header.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v5 11/18] drm/msm: generate headers on the fly

On 12/04/2024 17:19, Dmitry Baryshkov wrote: On Fri, 12 Apr 2024 at 19:15, Jon Hunter wrote: Hi Dmitry, On 01/04/2024 03:42, Dmitry Baryshkov wrote: Generate DRM/MSM headers on the fly during kernel build. This removes a need to push register changes to Mesa with the following manual

Re: [PATCH v5 11/18] drm/msm: generate headers on the fly

Hi Dmitry, On 01/04/2024 03:42, Dmitry Baryshkov wrote: Generate DRM/MSM headers on the fly during kernel build. This removes a need to push register changes to Mesa with the following manual synchronization step. Existing headers will be removed in the following commits (split away to ease

Re: [PATCH] gpu: host1x: Do not setup DMA for virtual devices

Hi Thierry, On 15/03/2024 11:25, Jon Hunter wrote: On 14/03/2024 15:49, Thierry Reding wrote: From: Thierry Reding The host1x devices are virtual compound devices and do not perform DMA accesses themselves, so they do not need to be set up for DMA. Ideally we would also not need to set up

Re: [PATCH] gpu: host1x: Do not setup DMA for virtual devices

ice->dev.dma_parms = >dma_parms; dma_set_max_seg_size(>dev, UINT_MAX); Tested-by: Jon Hunter Acked-by: Jon Hunter Thanks! Jon -- nvpublic

Re: [PATCH] gpu: host1x: Skip reset assert on Tegra186

this fixes a suspend regression on Tegra186. Thierry, would you be able to add the fixes-tag and send out as a fix for v6.8? Otherwise ... Reviewed-by: Jon Hunter Tested-by: Jon Hunter Thanks! Jon -- nvpublic

Re: [PATCH] drm/tegra: Remove of_dma_configure() from host1x_device_add()

On 02/02/2024 14:35, Jason Gunthorpe wrote: On Fri, Feb 02, 2024 at 10:40:36AM +, Jon Hunter wrote: But, what is the actual log output you see, is it -EEXIST? I see ... ERR KERN host1x drm: iommu configuration for device failed with -ENOENT So that shouldn't happen in you case

Re: [PATCH] drm/tegra: Remove of_dma_configure() from host1x_device_add()

On 01/02/2024 20:02, Jason Gunthorpe wrote: On Thu, Feb 01, 2024 at 07:35:24PM +, Jon Hunter wrote: You mean this sequence? err = device_add(>dev); if (err) { dev_err(host1x->dev, "could not add context device %d: %d

Re: [PATCH] drm/tegra: Remove of_dma_configure() from host1x_device_add()

On 31/01/2024 15:33, Jason Gunthorpe wrote: On Tue, Jan 30, 2024 at 09:55:18PM +, Jon Hunter wrote: On 30/01/2024 16:15, Jason Gunthorpe wrote: This was added in commit c95469aa5a18 ("gpu: host1x: Set DMA ops on device creation") with the note: Currently host1x-in

Re: [PATCH] drm/tegra: Remove of_dma_configure() from host1x_device_add()

ses: https://lore.kernel.org/all/bbmhcoghrprmbdibnjum6lefix2eoquxrde7wyqeulm4xabmlm@b6jy32saugqh/ Reported-by: Jon Hunter Closes: https://lore.kernel.org/all/b0334c5e-3a6c-4b58-b525-e72bed889...@nvidia.com/ Signed-off-by: Jason Gunthorpe --- drivers/gpu/host1x/bus.c | 2 -- 1 file changed, 2 deletions(-)

Re: [PATCH] drm/nouveau: Fixup gk20a instobj hierarchy

ctor_dma(imem, size >> PAGE_SHIFT, align, ); - *pmemory = node ? >memory : NULL; + *pmemory = node ? >base.memory : NULL; if (ret) return ret; Tested-by: Jon Hunter Thanks! Jon -- nvpublic

Re: [PATCH] gpu: host1x: fix uninitialized variable use

On 08/03/2023 16:56, Nathan Chancellor wrote: Ping? This warning is now in 6.3-rc1. Thierry is away at the moment. David, Daniel, do you want to pick this up directly in the meantime as a fix for 6.3? Mikko has already reviewed and FWIW ... Reviewed-by: Jon Hunter Thanks Jon On Thu

Re: [PATCH v2] gpu: host1x: Avoid trying to use GART on Tegra20

Thierry, On 21/10/2022 08:41, Jon Hunter wrote: On 20/10/2022 15:23, Robin Murphy wrote: Since commit c7e3ca515e78 ("iommu/tegra: gart: Do not register with bus") quite some time ago, the GART driver has effectively disabled itself to avoid issues with the GPU driver expecting

Re: [PATCH v3 1/8] memory: tegra: Add API for retrieving carveout bounds

On 04/11/2022 15:48, Krzysztof Kozlowski wrote: On 04/11/2022 11:46, Jon Hunter wrote: On 04/11/2022 15:35, Krzysztof Kozlowski wrote: On 04/11/2022 11:33, Jon Hunter wrote: Hi Thierry, Krzysztof, On 24/10/2022 14:15, Thierry Reding wrote: On Tue, Sep 20, 2022 at 11:11:56AM +0300, Mikko

Re: [PATCH v3 1/8] memory: tegra: Add API for retrieving carveout bounds

On 04/11/2022 15:35, Krzysztof Kozlowski wrote: On 04/11/2022 11:33, Jon Hunter wrote: Hi Thierry, Krzysztof, On 24/10/2022 14:15, Thierry Reding wrote: On Tue, Sep 20, 2022 at 11:11:56AM +0300, Mikko Perttunen wrote: From: Mikko Perttunen On Tegra234 NVDEC firmware is loaded from

Re: [PATCH v3 1/8] memory: tegra: Add API for retrieving carveout bounds

Hi Thierry, Krzysztof, On 24/10/2022 14:15, Thierry Reding wrote: On Tue, Sep 20, 2022 at 11:11:56AM +0300, Mikko Perttunen wrote: From: Mikko Perttunen On Tegra234 NVDEC firmware is loaded from a secure carveout, where it has been loaded by a bootloader. When booting NVDEC, we need to tell

Re: [PATCH v2] gpu: host1x: Avoid trying to use GART on Tegra20

365a04c921 ("iommu: Move bus setup to IOMMU device registration") that bodge no longer works, but really the GPU driver should be responsible for its own behaviour anyway. Make the workaround explicit. Reported-by: Jon Hunter Suggested-by: Dmitry Osipenko Signed-off-by: Robin Murphy

Re: [PATCH] gpu: host1x: Avoid trying to use GART on Tegra20

of commit 57365a04c921 ("iommu: Move bus setup to IOMMU device registration") that bodge no longer works, but really the GPU driver should be responsible for its own behaviour anyway. Make the workaround explicit. Reported-by: Jon Hunter Suggested-by: Dmitry Osipenko Signed-off-by: Robin M

Re: [PATCH v8 01/16] clk: generalize devm_clk_get() a bit

On 21/06/2022 21:49, Uwe Kleine-König wrote: On Tue, Jun 21, 2022 at 08:57:00PM +0100, Jon Hunter wrote: Some of our Tegra boards are not booting with the current -next and bisect is pointing to this commit. Looking at the boot log I am seeing the following panic ... [2.097048] 8

Re: [PATCH v8 01/16] clk: generalize devm_clk_get() a bit

Hi Uwe, On 14/03/2022 14:16, Uwe Kleine-König wrote: Allow to add an exit hook to devm managed clocks. Also use clk_get_optional() in devm_clk_get_optional instead of open coding it. The generalisation will be used in the next commit to add some more devm_clk helpers. Reviewed-by: Jonathan

Re: [PATCH v2 0/4] drm/nvdla: Add driver support for NVDLA

for this accelerator." Hi, nice to see this work going on. For subsequent revisions, can you please also Cc the Tegra mailing list (linux-te...@vger.kernel.org) as well as the Tegra platform maintainers (that's Jon Hunter and myself). This will make sure that more people with an interest in this wil

Re: [PATCH] gpu: host1x: Do not use mapping cache for job submissions

the need to explicitly remove the final reference to the mapping in the cache. Signed-off-by: Thierry Reding I have tested this and verified that it is working well. Reviewed-by: Jon Hunter Tested-by: Jon Hunter Thanks Jon -- nvpublic

Re: [PATCH] drm: tegra: fix memory leak in error handling path

On 29/03/2022 11:37, cgel@gmail.com wrote: From: Lv Ruyi Before leave the nvdec_load_firmware, we shuold free virt which is alloced s/shuold/should s/alloced/allocated by dma_alloc_coherent, so change "return err" to "goto cleanup". Reported-by: Zeal Robot Signed-off-by: Lv Ruyi

[PATCH] drm/tegra: Fix cast to restricted __le32

Sparse warns about the following cast in the function falcon_copy_firmware_image() ... drivers/gpu/drm/tegra/falcon.c:66:27: warning: cast to restricted __le32 Fix this by casting the firmware data array to __le32 instead of u32. Signed-off-by: Jon Hunter --- drivers/gpu/drm/tegra/falcon.c

[PATCH] gpu: host1x: Show all allocated syncpts via debugfs

if they have not been used yet. Note that when the syncpt status is dumped by the kernel itself for debugging only the active syncpt are shown. Signed-off-by: Jon Hunter --- drivers/gpu/host1x/debug.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/host1x

Re: [PATCH v16 08/40] gpu: host1x: Add initial runtime PM and OPP support

On 22/12/2021 19:01, Dmitry Osipenko wrote: ... diff --git a/drivers/gpu/host1x/syncpt.c b/drivers/gpu/host1x/syncpt.c index e08e331e46ae..8194826c9ce3 100644 --- a/drivers/gpu/host1x/syncpt.c +++ b/drivers/gpu/host1x/syncpt.c @@ -137,6 +137,15 @@ void host1x_syncpt_restore(struct host1x

Re: [PATCH v16 08/40] gpu: host1x: Add initial runtime PM and OPP support

On 22/12/2021 09:47, Jon Hunter wrote: On 21/12/2021 20:58, Dmitry Osipenko wrote: Hi, Thank you for testing it all. 21.12.2021 21:55, Jon Hunter пишет: Hi Dmitry, Thierry, On 30/11/2021 23:23, Dmitry Osipenko wrote: Add runtime PM and OPP support to the Host1x driver. For the starter

Re: [PATCH v16 08/40] gpu: host1x: Add initial runtime PM and OPP support

On 21/12/2021 20:58, Dmitry Osipenko wrote: Hi, Thank you for testing it all. 21.12.2021 21:55, Jon Hunter пишет: Hi Dmitry, Thierry, On 30/11/2021 23:23, Dmitry Osipenko wrote: Add runtime PM and OPP support to the Host1x driver. For the starter we will keep host1x always-on because

Re: [PATCH v16 08/40] gpu: host1x: Add initial runtime PM and OPP support

Hi Dmitry, Thierry, On 30/11/2021 23:23, Dmitry Osipenko wrote: Add runtime PM and OPP support to the Host1x driver. For the starter we will keep host1x always-on because dynamic power management require a major refactoring of the driver code since lot's of code paths are missing the RPM

Re: [PATCH v2 0/8] Host1x context isolation support

On 14/12/2021 15:38, Robin Murphy wrote: ... IOMMU/DT folks, any thoughts about this approach? The patches that are of interest outside of Host1x/TegraDRM specifics are patches 1, 2, 4, and 5. FWIW it looks fairly innocuous to me. I don't understand host1x - neither hardware nor driver

Re: [PATCH v2 0/8] Host1x context isolation support

Hi all, Still no response on this :-( On 06/12/2021 09:55, Jon Hunter wrote: Will, Joerg, Rob, On 08/11/2021 10:36, Mikko Perttunen wrote: On 9/16/21 5:32 PM, Mikko Perttunen wrote: Hi all, *** New in v2: Added support for Tegra194 Use standard iommu-map property instead of custom

Re: [PATCH v2 0/8] Host1x context isolation support

Will, Joerg, Rob, On 08/11/2021 10:36, Mikko Perttunen wrote: On 9/16/21 5:32 PM, Mikko Perttunen wrote: Hi all, *** New in v2: Added support for Tegra194 Use standard iommu-map property instead of custom mechanism *** this series adds support for Host1x 'context isolation'. Since when

[PATCH] drm/tegra: Fix compilation of variadic macro

f GCC. Fix this by using the '##__VA_ARGS__' macro instead. Fixes: 43636451db8c ("drm/tegra: Implement job submission part of new UAPI") Reported-by: Linux Kernel Functional Testing Signed-off-by: Jon Hunter --- drivers/gpu/drm/tegra/submit.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH v7 13/15] drm/tegra: Implement job submission part of new UAPI

Hi Mikko, On 10/06/2021 12:04, Mikko Perttunen wrote: > Implement the job submission IOCTL with a minimum feature set. > > Signed-off-by: Mikko Perttunen > --- > v7: > * Allocate gather BO with DMA API to get page-aligned > memory > * Add error prints to a few places where they were missing >

Re: [PATCH v7 13/15] drm/tegra: Implement job submission part of new UAPI

On 10/06/2021 12:04, Mikko Perttunen wrote: > Implement the job submission IOCTL with a minimum feature set. > > Signed-off-by: Mikko Perttunen > --- > v7: > * Allocate gather BO with DMA API to get page-aligned > memory > * Add error prints to a few places where they were missing > v6: > *

Re: [PATCH 2/2] drm/tegra: sor: Fully initialize SOR before registration

dev_err(>dev, "failed to register host1x client: %d\n", > + err); > + goto uninit; > } > > return 0; > > -unregister: > - host1x_client_unregister(>client); > -rpm_disable: > +uninit: > + h

Re: [PATCH 3/3] drm/tegra: Add NVDEC driver

On 13/02/2021 10:15, Mikko Perttunen wrote: > Add support for booting and using NVDEC on Tegra210, Tegra186 > and Tegra194 to the Host1x and TegraDRM drivers. Booting in > secure mode is not currently supported. > > Signed-off-by: Mikko Perttunen > --- > drivers/gpu/drm/tegra/Makefile | 3

Re: [PATCH v10 17/19] ARM: tegra: Add EMC OPP properties to Tegra20 device-trees

On 30/11/2020 22:57, Dmitry Osipenko wrote: > 01.12.2020 00:17, Jon Hunter пишет: >> Hi Dmitry, >> >> On 23/11/2020 00:27, Dmitry Osipenko wrote: >>> Add EMC OPP DVFS tables and update board device-trees by removing >>> unsupported OPPs. >>> &g

Re: [PATCH v10 17/19] ARM: tegra: Add EMC OPP properties to Tegra20 device-trees

Hi Dmitry, On 23/11/2020 00:27, Dmitry Osipenko wrote: > Add EMC OPP DVFS tables and update board device-trees by removing > unsupported OPPs. > > Signed-off-by: Dmitry Osipenko This change is generating the following warning on Tegra20 Ventana and prevents the EMC from probing ... [

[PATCH V3] drm/tegra: sor: Don't warn on probe deferral

Deferred probe is an expected return value for tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users. Signed-off-by: Jon Hunter --- Changes since V2: - Removed duplicate errno print Changes since V1: - This time

Re: [PATCH V2] drm/tegra: sor: Don't warn on probe deferral

On 04/11/2020 10:49, Dmitry Osipenko wrote: > 04.11.2020 12:23, Jon Hunter пишет: >> Deferred probe is an expected return value for tegra_output_probe(). >> Given that the driver deals with it properly, there's no need to output >> a warning that may potentially confuse us

[PATCH V2] drm/tegra: sor: Don't warn on probe deferral

Deferred probe is an expected return value for tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users. Signed-off-by: Jon Hunter --- Changes since V1: - This time, I actually validated it! drivers/gpu/drm

Re: [PATCH] drm/tegra: sor: Don't warn on probe deferral

On 03/11/2020 11:44, Jon Hunter wrote: > Deferred probe is an expected return value for tegra_output_probe(). > Given that the driver deals with it properly, there's no need to output > a warning that may potentially confuse users. > > Signed-off-by: Jon Hunter > --- >

[PATCH] drm/tegra: sor: Don't warn on probe deferral

Deferred probe is an expected return value for tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users. Signed-off-by: Jon Hunter --- drivers/gpu/drm/tegra/sor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] backlight: lp855x: Ensure regulators are disabled on probe failure

Hi Lee, On 16/03/2020 09:05, Daniel Thompson wrote: > On Fri, Mar 13, 2020 at 02:16:16PM +0000, Jon Hunter wrote: >> Hi Lee, Daniel, >> >> On 24/02/2020 14:37, Daniel Thompson wrote: >>> On Mon, Feb 24, 2020 at 02:07:48PM +, Jon Hunter wrote: >>>> I

Re: [PATCH 2/2] gpu: host1x: Use SMMU on Tegra124 and Tegra210

ensure that all > the system memory can be used for command buffers, irrespective of > whether or not the host1x firewall is enabled. > > Signed-off-by: Thierry Reding > --- > drivers/gpu/host1x/dev.c | 46 > 1 file changed, 42 insertions(+), 4

Re: [PATCH 1/2] drm/tegra: Fix SMMU support on Tegra124 and Tegra210

s: 2d9384ff9177 ("drm/tegra: Relax IOMMU usage criteria on old Tegra") > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/tegra/drm.c | 3 ++- > drivers/gpu/host1x/dev.c| 13 + > include/linux/host1x.h | 3 +++ > 3 files changed, 18 ins

Re: [PATCH] backlight: lp855x: Ensure regulators are disabled on probe failure

Hi Lee, Daniel, On 24/02/2020 14:37, Daniel Thompson wrote: > On Mon, Feb 24, 2020 at 02:07:48PM +0000, Jon Hunter wrote: >> If probing the LP885x backlight fails after the regulators have been >> enabled, then the following warning is seen when releasing the >> regulators ..

[PATCH] backlight: lp855x: Ensure regulators are disabled on probe failure

el0_sync_handler+0xf4/0x1b0 el0_sync+0x140/0x180 Fix this by ensuring that the regulators are disabled, if enabled, on probe failure. Finally, ensure that the vddio regulator is disabled in the driver remove handler. Signed-off-by: Jon Hunter --- drivers/video/backlight/lp855x_bl.c | 20

Re: [PATCH v3] drm/tegra: sor: Enable HDA interrupts at plug-in

On 24/07/2019 10:27, Dmitry Osipenko wrote: > 23.07.2019 15:40, Viswanath L пишет: >> HDMI plugout calls runtime suspend, which clears interrupt registers >> and causes audio functionality to break on subsequent plug-in; setting >> interrupt registers in sor_audio_prepare() solves the issue. >>

Re: [PATCH v1] drm/tegra: Fix gpiod_get_from_of_node() regression

_gpio)) { > + if (PTR_ERR(output->hpd_gpio) == -ENOENT) > + output->hpd_gpio = NULL; > + else > + return PTR_ERR(output->hpd_gpio); > + } > > if (output->hpd_gpio) { > err = gpiod_to_irq(output->hpd_gpio); > Acked-by: Jon Hunter Cheers Jon -- nvpublic

Re: [PATCH v5 05/12] drm/modes: Rewrite the command line parser

On 09/07/2019 14:26, Jon Hunter wrote: > > On 09/07/2019 13:52, Dmitry Osipenko wrote: >> 09.07.2019 15:45, Maxime Ripard пишет: >>> Hi, >>> >>> On Fri, Jul 05, 2019 at 07:54:47PM +0300, Dmitry Osipenko wrote: >>>> 17.06.2019 17

Re: [PATCH v5 05/12] drm/modes: Rewrite the command line parser

On 09/07/2019 13:52, Dmitry Osipenko wrote: > 09.07.2019 15:45, Maxime Ripard пишет: >> Hi, >> >> On Fri, Jul 05, 2019 at 07:54:47PM +0300, Dmitry Osipenko wrote: >>> 17.06.2019 17:51, Maxime Ripard пишет: From: Maxime Ripard Rewrite the command line parser in order to get away

Re: drm connectors, tegra, and the web they weave (was Re: [PATCH 58/59] drm/todo: Add new debugfs todo)

On 18/06/2019 16:19, Greg Kroah-Hartman wrote: > On Fri, Jun 14, 2019 at 10:36:14PM +0200, Daniel Vetter wrote: >> Greg is busy already, but maybe he won't do everything ... >> >> Cc: Greg Kroah-Hartman >> Signed-off-by: Daniel Vetter >> --- >> Documentation/gpu/todo.rst | 3 +++ >> 1 file

Re: [PATCH] Revert "dma-contiguous: do not allocate a single page from CMA area"

t first and then find a safer solution instead. > > Reported-by: Tony Lindgren > Signed-off-by: Nicolin Chen > --- > Tony, > > Would you please test and verify? Thanks! This also fixes various memory allocation failures we have seen on 32-bit Tegra as well. Tested

Re: [PATCH 1/3] drm/tegra: vic: Implement explicit reset support

On 29/11/2018 14:51, Thierry Reding wrote: > On Thu, Nov 29, 2018 at 01:40:32PM +0000, Jon Hunter wrote: >> >> On 23/11/2018 12:06, Thierry Reding wrote: >>> From: Thierry Reding >>> >>> Tegra supports generic PM domains on 64-bit ARM, and if that is en

Re: [PATCH 1/3] drm/tegra: vic: Implement explicit reset support

On 23/11/2018 12:06, Thierry Reding wrote: > From: Thierry Reding > > Tegra supports generic PM domains on 64-bit ARM, and if that is enabled, > the power domain code will make sure that resets are asserted and > deasserted at appropriate points in time. > > If generic PM domains are not

Re: [PATCH v1] drm/tegra: dpaux: Fix always-failing probing of the driver

y the same, which > is a good explanation for why the driver performs flawlessly. > > That said, your change is obviously correct. I've applied it, but since > it doesn't actually fix anything, and doesn't change anything from a > binary point of view, I've removed the Fixes: and Cc: st

Re: [PATCH] [v3] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m

On 07/09/18 12:42, Maxime Ripard wrote: > On Fri, Sep 07, 2018 at 01:26:30PM +0200, Arnd Bergmann wrote: >> On Fri, Sep 7, 2018 at 11:41 AM Jon Hunter wrote: >>> >>> >>> On 11/07/18 15:43, Arnd Bergmann wrote: >>>> Having DRM_SUN4I built-in

Re: [PATCH] [v3] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m

On 11/07/18 15:43, Arnd Bergmann wrote: > Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module results in > a link error, as we try to access a symbol from the sun8i_tcon_top.ko module: > > ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun8i-drm-hdmi.ko] > undefined! >

Re: [PATCH 1/3] soc/tegra: pmc: set IO pad power state and voltage via pinctrl fw

On 02/08/18 12:59, Venkat Reddy Talla wrote: > The IO pins of Tegra SoCs are grouped for common control > of IO interface like setting voltage signal levels and > power state of the interface. These groups are referred > to as IO pads.The power state and voltage control of IO pins > can be done

[PATCH] drm/nouveau/bar/gk20a: Avoid bar teardown during init

e teardown helper for gk20a. This is based upon a previous patch by Guillaume Tucker but limits the workaround to only gk20a GPUs. Fixes: bbb163e18960 ("drm/nouveau/bar: implement bar1 teardown") Reported-by: Guillaume Tucker <guillaume.tuc...@collabora.com> Signed-off-by: Jon Hu

Re: [RFC PATCH v2 1/1] drm/tegra: sor: Fix hang on tegra124 due to NULL clk_out

nd perhaps we just didn't implement clocks > correctly back in the Tegra124 timeframe. > > Maybe Peter knows. So the above change from Thierry works for me and we need this for v4.15 (otherwise nyan-big does not boot) so you can have my ... Tested-by: Jon Hunter <jonath...@nvidi

Re: [PATCH 1/2] drm/nouveau/bar/gf100: fix hang when calling ->fini() before ->init()

On 06/12/17 17:18, Jon Hunter wrote: > > On 06/12/17 09:22, Guillaume Tucker wrote: >> On 05/12/17 18:32, Ben Skeggs wrote: >>> On Wed, Dec 6, 2017 at 12:30 AM, Jon Hunter <jonath...@nvidia.com> wrote: >>> >>>> >>>> On 04/12/17 18:37,

Re: [PATCH 1/2] drm/nouveau/bar/gf100: fix hang when calling ->fini() before ->init()

On 06/12/17 09:22, Guillaume Tucker wrote: > On 05/12/17 18:32, Ben Skeggs wrote: >> On Wed, Dec 6, 2017 at 12:30 AM, Jon Hunter <jonath...@nvidia.com> wrote: >> >>> >>> On 04/12/17 18:37, Guillaume Tucker wrote: >>>> If the firmwar

Re: [PATCH 1/2] drm/nouveau/bar/gf100: fix hang when calling ->fini() before ->init()

1704, 0x8000, 0x); > + struct nvkm_device *device = base->subdev.device; > + > + if (base->subdev.oneinit) > + nvkm_mask(device, 0x001704, 0x8000, 0x); > } > > void I have tested this and it works for me. Thanks for fixi

Re: Build error for NVIDIA Tegra DRM since 4.14-rc1

Hi Linus, On 28/09/17 08:10, Linus Lüssing wrote: > Hi, > > Sorry, did not search for the exact commit yet, but since v4.14-rc1 > I get a build error when trying to build the ARM multi_v7_defconfig > target: > > ~~ > $ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- LOADADDR=0x00208000

Re: [PATCH] drm: tegra: add CONFIG_OF dependency

epends on OF > select DRM_KMS_HELPER > select DRM_MIPI_DSI > select DRM_PANEL Thanks Arnd. I am curious if it can still fail if PINCTRL is not selected in whatever config you are using? That said ... Acked-by: Jon Hunter <jonath...@nvidia.com> Cheers Jon -- n

Re: [PATCH] drm/tegra: sor: add NULL check on of_match_device() return value

On 07/07/17 07:11, Gustavo A. R. Silva wrote: > Check return value from call to of_match_device() > in order to prevent a NULL pointer dereference. > > In case of NULL print error message and return. > > Signed-off-by: Gustavo A. R. Silva > --- >

Re: [PATCH -next] gpu: host1x: Fix wrong pointer passed to PTR_ERR()

On 16/04/17 05:08, Wei Yongjun wrote: > From: Wei Yongjun > > PTR_ERR should access the value just tested by IS_ERR, otherwise > the wrong error code will be returned. > > Fixes: b386c6b73ac6 ("gpu: host1x: Support module reset") > Signed-off-by: Wei Yongjun

[PATCH] drm/tegra: dpaux: Fix error handling

ODEV; > + return PTR_ERR(dpaux->pinctrl); > } > #endif > /* enable and clear all interrupts */ Thanks for the fix! Acked-by: Jon Hunter Cheers Jon -- nvpublic

[PATCH v8 2/4] drm: Add API for capturing frame CRCs

On 04/10/16 12:25, Daniel Vetter wrote: > On Tue, Oct 4, 2016 at 12:10 PM, Jon Hunter wrote: >> Looks like crtc is a errno in the above case. I see this function is >> called by looping through all the crtc and we never check to see if >> they are valid. Should we? >

[PATCH v8 2/4] drm: Add API for capturing frame CRCs

Hi Tomeu, On 09/09/16 10:56, Tomeu Vizoso wrote: > Adds files and directories to debugfs for controlling and reading frame > CRCs, per CRTC: > > dri/0/crtc-0/crc > dri/0/crtc-0/crc/control > dri/0/crtc-0/crc/data > > Drivers can implement the set_crc_source callback() in drm_crtc_funcs to >

[PATCH] drm/tegra: dsi: Enhance runtime power management

unter > Signed-off-by: Thierry Reding This patch along with the fix from Vince [0] fixes the hang during boot on Tegra114. So ... Tested-by: Jon Hunter Cheers Jon [0] http://marc.info/?l=linux-kernel=144017122430016=2 -- nvpublic

[PATCH v2] drm/tegra: dpaux: Modify error handling

> dev_err(>dev, "failed to register pincontrol\n"); > - return -ENODEV; > + return PTR_ERR(dpaux->pinctrl); > } > #endif > /* enable and clear all interrupts */ > Acked-by: Jon Hunter Cheers! Jon -- nvpublic

[PATCH 08/12] i2c: core: Add support for 'i2c-bus' subnode

On 02/08/16 07:26, Tomeu Vizoso wrote: > On 23 June 2016 at 17:59, Jon Hunter wrote: >> If the 'i2c-bus' device-tree node is present for an I2C adapter then >> parse this subnode for I2C slaves. >> >> Signed-off-by: Jon Hunter >> --- >> drivers/i2c/i2c-co

[PATCH 3/3] arm64: tegra: Populate SOR power domain for DSI

The DSI device requires that the SOR power partition is enabled when active. Populate this power partition for the Tegra210 DSI nodes. Signed-off-by: Jon Hunter --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra210

[PATCH 2/3] drm/tegra: Prepare SOR for supporting generic PM domains

because we cannot guarantee that the reset will be asserted/de-asserted at the appropriate time. Therefore, given that the Tegra generic PM domain code will handle the resets, do not request the reset in the SOR driver if the SOR device has a PM domain associated. Signed-off-by: Jon Hunter

[PATCH 1/3] drm/tegra: Prepare DSI for supporting generic PM domains

because we cannot guarantee that the reset will be asserted/de-asserted at the appropriate time. Therefore, given that the Tegra generic PM domain code will handle the resets, do not request the reset in the DSI driver if the DSI device has a PM domain associated. Signed-off-by: Jon Hunter

[PATCH V2 11/11] arm64: tegra: Add DPAUX pinctrl bindings

e, etc) because the SOR driver will directly set the state needed. For I2C clients only the I2C mode is used and so we can simplify matters by using the generic pinctrl states for default and idle. Signed-off-by: Jon Hunter --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 54

[PATCH V2 10/11] arm64: tegra: Add SOR power-domain node

power-domain will be turned on before probing SOR or DPAUX devices and kept on while the devices are bound. Signed-off-by: Jon Hunter --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi

[PATCH V2 09/11] drm/tegra: Add pinctrl support for DPAUX

-by: Jon Hunter --- drivers/gpu/drm/tegra/dpaux.c | 122 -- 1 file changed, 119 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 61821f457209..7b2abaf33a7a 100644 --- a/drivers/gpu/drm/tegra/dpaux.c

[PATCH V2 08/11] dt-bindings: Add bindings for Tegra DPAUX pinctrl driver

ate the main DPAUX binding documentation to reference the DPAUX pad controller binding document and add the 'i2c-bus' subnode. The 'i2c-bus' subnode is used for populating I2C slaves for the DPAUX device so that the I2C driver core does not attempt to add the DPAUX pad controller nodes as I2C slaves.

[PATCH V2 07/11] i2c: core: Add support for 'i2c-bus' subnode

If the 'i2c-bus' device-tree node is present for an I2C adapter then parse this subnode for I2C slaves. Signed-off-by: Jon Hunter Acked-by: Wolfram Sang --- drivers/i2c/i2c-core.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core.c b/drivers

[PATCH V2 06/11] dt-bindings: i2c: Add support for 'i2c-bus' subnode

that are not parsed by the I2C driver core, add support for an optional 'i2c-bus' subnode where I2C slaves can be placed. If the 'i2c-bus' subnode is present then all I2C slaves must be placed under this subnode. Signed-off-by: Jon Hunter Acked-by: Thierry Reding Acked-by: Rob Herring --- Documentation

[PATCH V2 05/11] drm/tegra: Prepare DPAUX for supporting generic PM domains

-by: Jon Hunter --- drivers/gpu/drm/tegra/dpaux.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 4014ec57ed31..61821f457209 100644 --- a/drivers/gpu/drm/tegra/dpaux.c +++ b/drivers/gpu/drm

[PATCH V2 04/11] dt-bindings: display: Update Tegra DPAUX documentation

Update the DPAUX compatibility string information for Tegra124, Tegra132 and Tegra210. Signed-off-by: Jon Hunter Acked-by: Rob Herring --- .../devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH V2 03/11] drm/tegra: Add helper functions for setting up DPAUX pads

modes, a case statement is used because when integrating with the pinctrl framework, we need to be able to handle invalid modes that could be passed. Signed-off-by: Jon Hunter --- drivers/gpu/drm/tegra/dpaux.c | 81 +++ 1 file changed, 51 insertions(+), 30

[PATCH V2 02/11] drm/tegra: Clean-up if probing DPAUX fails

If the probing of the DPAUX fails, then clocks are left enabled and the DPAUX reset de-asserted. Add code to perform the necessary clean-up on probe failure by disabling clocks and asserting the reset. Signed-off-by: Jon Hunter --- drivers/gpu/drm/tegra/dpaux.c | 22 -- 1

[PATCH V2 01/11] soc/tegra: pmc: Initialise resets associated with a power partition

in the correct state (based upon the partition's current state) when obtaining the resets for a partition. Signed-off-by: Jon Hunter --- drivers/soc/tegra/pmc.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c

[PATCH V2 00/11] Add support for Tegra DPAUX pinctrl

in the Tegra210 TRM. [0] http://marc.info/?l=linux-tegra=146667915802019=2 [1] http://marc.info/?l=linux-tegra=146669759407988=2 Jon Hunter (11): soc/tegra: pmc: Initialise resets associated with a power partition drm/tegra: Clean-up if probing DPAUX fails drm/tegra: Add helper functions for setting up

[PATCH 07/12] dt-bindings: i2c: Add support for 'i2c-bus' subnode

On 28/06/16 22:32, Wolfram Sang wrote: > * PGP Signed by an unknown key > >> For >> example some Tegra devices have an I2C interface which may share its >> pins with other devices and to share these pins subnodes for >> representing these pins so they have be shared via the pinctrl framework >>

[PATCH 07/12] dt-bindings: i2c: Add support for 'i2c-bus' subnode

On 27/06/16 13:04, Peter Rosin wrote: > On 2016-06-23 17:59, Jon Hunter wrote: >> The I2C driver core for boards using device-tree assumes any subnode of >> an I2C adapter in the device-tree blob as being a I2C slave device. >> Although this makes complete sense, some

[PATCH 12/12] arm64: tegra: Add DPAUX pinctrl bindings

e, etc) because the SOR driver will directly set the state needed. For I2C clients only the I2C mode is used and so we can simplify matters by using the generic pinctrl states for default and idle. Signed-off-by: Jon Hunter --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 54

[PATCH 11/12] arm64: tegra: Add SOR power-domain node

power-domain will be turned on before probing SOR or DPAUX devices and kept on while the devices are bound. Signed-off-by: Jon Hunter --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi

[PATCH 10/12] drm/tegra: Add pinctrl support for DPAUX

-by: Jon Hunter --- drivers/gpu/drm/tegra/dpaux.c | 122 -- 1 file changed, 119 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 61821f457209..7b2abaf33a7a 100644 --- a/drivers/gpu/drm/tegra/dpaux.c

[PATCH 09/12] dt-bindings: Add bindings for Tegra DPAUX pinctrl driver

ate the main DPAUX binding documentation to reference the DPAUX pad controller binding document and add the 'i2c-bus' subnode. The 'i2c-bus' subnode is used for populating I2C slaves for the DPAUX device so that the I2C driver core does not attempt to add the DPAUX pad controller nodes as I2C slaves. Sig

[PATCH 08/12] i2c: core: Add support for 'i2c-bus' subnode

If the 'i2c-bus' device-tree node is present for an I2C adapter then parse this subnode for I2C slaves. Signed-off-by: Jon Hunter --- drivers/i2c/i2c-core.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index

[PATCH 07/12] dt-bindings: i2c: Add support for 'i2c-bus' subnode

driver core by adding support for a 'i2c-bus' subnode where I2C slaves can be placed. If the 'i2c-bus' subnode is present then all I2C slaves must be placed under this subnode. Signed-off-by: Jon Hunter Acked-by: Thierry Reding --- Documentation/devicetree/bindings/i2c/i2c.txt | 8 1

  1   2   >