Re: [PATCH] drm/connector: Fix warning in debug message

2019-06-24 Thread Maxime Ripard
On Mon, Jun 24, 2019 at 10:44:33AM +0200, Daniel Vetter wrote: > On Mon, Jun 24, 2019 at 10:40:16AM +0200, Maxime Ripard wrote: > > The commit 3aeeb13d8996 ("drm/modes: Support modes names on the command > > line") added name support to the DRM modes, and added that name

Re: [linux-sunxi] Re: [PATCH v10 04/11] drm/sun4i: tcon: Compute DCLK dividers based on format, lanes

2019-06-24 Thread Maxime Ripard
On Fri, Jun 14, 2019 at 05:33:23PM +0530, Jagan Teki wrote: > On Thu, Jun 13, 2019 at 7:28 PM Maxime Ripard > wrote: > > > > On Wed, Jun 05, 2019 at 01:11:44PM +0530, Jagan Teki wrote: > > > On Tue, Jun 4, 2019 at 8:00 PM Maxime Ripard > > > wrote: > >

[PATCH] drm/connector: Fix warning in debug message

2019-06-24 Thread Maxime Ripard
le content zero'd. That means that if the name is not declared, the array will be all zeros, which will not print anything. Cc: Nick Desaulniers Reported-by: kbuild test robot Fixes: 3aeeb13d8996 ("drm/modes: Support modes names on the command line") Signed-off-by: Maxime Ripard

Re: [RFC PATCH 4/4] dt-bindings: display: Convert innolux, ee101ia-01 panel to DT schema

2019-06-20 Thread Maxime Ripard
On Wed, Jun 19, 2019 at 03:51:56PM -0600, Rob Herring wrote: > Convert the innolux,ee101ia-01 LVDS panel binding to DT schema. > > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Maxime Ripard > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Signed-off-by

Re: [RFC PATCH 2/4] dt-bindings: display: Convert ampire,am-480272h3tmqw-t01h panel to DT schema

2019-06-20 Thread Maxime Ripard
On Wed, Jun 19, 2019 at 03:51:54PM -0600, Rob Herring wrote: > Convert the ampire,am-480272h3tmqw-t01h panel binding to DT schema. > > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Maxime Ripard > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Signed-off-by

Re: [RFC PATCH 3/4] dt-bindings: display: Convert panel-lvds to DT schema

2019-06-20 Thread Maxime Ripard
Sam Ravnborg > Cc: Maxime Ripard > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Rob Herring Reviewed-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [RFC PATCH 1/4] dt-bindings: display: Convert common panel bindings to DT schema

2019-06-20 Thread Maxime Ripard
l the bindings are > converted. > > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Maxime Ripard > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Rob Herring Reviewed-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and

Re: [PATCH v5 07/12] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-19 Thread Maxime Ripard
,rotate=180 - 720x480 mode, rotated by 180 > > degrees > > + > > +Valid options are: > > + > > + - reflect_x (boolean): Perform an axial symetry on the X axis > > + - reflect_y (boolean): Perform an axial symetry on the Y axis > > 2x s/symetry/symmet

Re: [linux-sunxi] Re: [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-17 Thread Maxime Ripard
On Mon, Jun 17, 2019 at 09:01:33PM +0800, Chen-Yu Tsai wrote: > On Mon, Jun 17, 2019 at 7:45 PM Maxime Ripard > wrote: > > > > On Fri, Jun 14, 2019 at 10:13:20PM +0530, Jagan Teki wrote: > > > TCON TOP have clock gates for TV0, TV1, dsi and right > > > now

[PATCH v5 08/12] drm/connector: Introduce a TV margins structure

2019-06-17 Thread Maxime Ripard
The TV margins has been defined as a structure inside the drm_connector_state structure so far. However, we will need it in other structures as well, so let's move that structure definition so that it can be reused. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- include/drm

[PATCH v5 04/12] drm/client: Change drm_client_panel_rotation name

2019-06-17 Thread Maxime Ripard
the panel mention. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_client_modeset.c | 12 ++-- drivers/gpu/drm/drm_fb_helper.c | 2 +- include/drm/drm_client.h | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH v5 06/12] drm/modes: Support modes names on the command line

2019-06-17 Thread Maxime Ripard
From: Maxime Ripard The drm subsystem also uses the video= kernel parameter, and in the documentation refers to the fbdev documentation for that parameter. However, that documentation also says that instead of giving the mode using its resolution we can also give a name. However, DRM doesn't

[PATCH v5 09/12] drm/modes: Parse overscan properties

2019-06-17 Thread Maxime Ripard
Properly configuring the overscan properties might be needed for the initial setup of the framebuffer for display that still have overscan. Let's allow for more properties on the kernel command line to setup each margin. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard

[PATCH v5 05/12] drm/modes: Rewrite the command line parser

2019-06-17 Thread Maxime Ripard
From: Maxime Ripard Rewrite the command line parser in order to get away from the state machine parsing the video mode lines. Hopefully, this will allow to extend it more easily to support named modes and / or properties set directly on the command line. Reviewed-by: Noralf Trønnes Signed-off

[PATCH v5 07/12] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-17 Thread Maxime Ripard
to accomodate this, let's create a video mode parameter to deal with the rotation and reflexion. Signed-off-by: Maxime Ripard --- Documentation/fb/modedb.rst | 11 +++- drivers/gpu/drm/drm_client_modeset.c | 30 +++- drivers/gpu/drm/drm_modes.c | 114

[PATCH v5 03/12] drm/client: Restrict the rotation check to the rotation itself

2019-06-17 Thread Maxime Ripard
for no particular reason. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_client_modeset.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c index 8264c3a732b0..b4e5fb0a17cf 100644

[PATCH v5 11/12] drm/selftests: Add command line parser selftests

2019-06-17 Thread Maxime Ripard
The command line parser is pretty tough to get right and very error prone, so let's add a selftest to try to catch any regression. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- drivers/gpu/drm/selftests/Makefile | 2 +- drivers/gpu/drm/selftests

[PATCH v5 02/12] drm/client: Restrict the plane_state scope

2019-06-17 Thread Maxime Ripard
from the compiler since value would have been initialized. Fix this by moving the variable declaration to the proper scope. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_client_modeset.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v5 12/12] drm/vc4: hdmi: Set default state margin at reset

2019-06-17 Thread Maxime Ripard
Now that the TV margins are properly parsed and filled into drm_cmdline_mode, we just need to initialise the first state at reset to get those values and start using them. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 8 +++- 1 file changed

[PATCH v5 10/12] drm/atomic: Add a function to reset connector TV properties

2019-06-17 Thread Maxime Ripard
During the connector reset, if that connector has a TV property, it needs to be reset to the value provided on the command line. Provide a helper to do that. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic_state_helper.c | 18 ++ include

[PATCH v5 01/12] drm/connector: Add documentation for drm_cmdline_mode

2019-06-17 Thread Maxime Ripard
The struct drm_cmdline_mode holds the result of the command line parsers. However, it wasn't documented so far, so let's do that. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- include/drm/drm_connector.h | 86 +- 1 file changed, 84 insertions

[PATCH v5 00/12] drm/vc4: Allow for more boot-time configuration

2019-06-17 Thread Maxime Ripard
and Noralf series - Moved the property initialisation to vc4 reset hook - Added documentation for the new drm_cmdline_mode - Renamed overscan to tv_margins to be consistent with the APIs Changes from v1: - Dropped the patches to deal with EDID - Added the unit test as selftest - Rebased on ne

Re: [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe

2019-06-17 Thread Maxime Ripard
PHY There's no loop, right? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-06-14 Thread Maxime Ripard
On Fri, Jun 14, 2019 at 12:03:13PM +0530, Jagan Teki wrote: > On Thu, Jun 13, 2019 at 6:56 PM Maxime Ripard > wrote: > > > > On Wed, Jun 05, 2019 at 01:17:11PM +0530, Jagan Teki wrote: > > > On Tue, Jun 4, 2019 at 3:30 PM Maxime Ripard > > > wrote: > >

Re: [PATCH v10 02/11] drm/sun4i: dsi: Update start value in video start delay

2019-06-14 Thread Maxime Ripard
On Thu, Jun 13, 2019 at 01:34:04PM +0530, Jagan Teki wrote: > On Fri, May 31, 2019 at 12:23 AM Maxime Ripard > wrote: > > > > On Fri, May 24, 2019 at 03:55:42PM +0530, Jagan Teki wrote: > > > On Fri, May 24, 2019 at 2:07 AM Maxime Ripard > > > wrote: > &

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-06-14 Thread Maxime Ripard
On Wed, Jun 05, 2019 at 01:03:16PM +0530, Jagan Teki wrote: > On Wed, Jun 5, 2019 at 12:19 PM Maxime Ripard > wrote: > > > > Hi, > > > > I've reordered the mail a bit to work on chunks > > > > On Fri, May 24, 2019 at 03:37:42PM +0530, Jagan Teki wrote

Re: [PATCH v4 02/12] drm/client: Restrict the plane_state scope

2019-06-14 Thread Maxime Ripard
Hi Jani, On Fri, Jun 14, 2019 at 03:28:59PM +0300, Jani Nikula wrote: > On Fri, 14 Jun 2019, Maxime Ripard wrote: > > The drm_client_modeset_commit_atomic function uses two times the > > plane_state variable in inner blocks of code, but the variable has a scope > > gl

[PATCH v4 06/12] drm/modes: Support modes names on the command line

2019-06-14 Thread Maxime Ripard
From: Maxime Ripard The drm subsystem also uses the video= kernel parameter, and in the documentation refers to the fbdev documentation for that parameter. However, that documentation also says that instead of giving the mode using its resolution we can also give a name. However, DRM doesn't

[PATCH v4 07/12] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-14 Thread Maxime Ripard
to accomodate this, let's create a video mode parameter to deal with the rotation and reflexion. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_client_modeset.c | 20 +- drivers/gpu/drm/drm_modes.c | 110 ++-- include/drm/drm_connector.h | 9 ++- 3 files

[PATCH v4 04/12] drm/client: Change drm_client_panel_rotation name

2019-06-14 Thread Maxime Ripard
the panel mention. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_client_modeset.c | 12 ++-- drivers/gpu/drm/drm_fb_helper.c | 2 +- include/drm/drm_client.h | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_client_modeset.c

[PATCH v4 12/12] drm/vc4: hdmi: Set default state margin at reset

2019-06-14 Thread Maxime Ripard
Now that the TV margins are properly parsed and filled into drm_cmdline_mode, we just need to initialise the first state at reset to get those values and start using them. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion

[PATCH v4 10/12] drm/modes: Parse overscan properties

2019-06-14 Thread Maxime Ripard
Properly configuring the overscan properties might be needed for the initial setup of the framebuffer for display that still have overscan. Let's allow for more properties on the kernel command line to setup each margin. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- drivers/gpu

[PATCH v4 11/12] drm/selftests: Add command line parser selftests

2019-06-14 Thread Maxime Ripard
The command line parser is pretty tough to get right and very error prone, so let's add a selftest to try to catch any regression. Reviewed-by: Noralf Trønnes Signed-off-by: Maxime Ripard --- drivers/gpu/drm/selftests/Makefile | 2 +- drivers/gpu/drm/selftests

[PATCH v4 08/12] drm/connector: Introduce a TV margins structure

2019-06-14 Thread Maxime Ripard
The TV margins has been defined as a structure inside the drm_connector_state structure so far. However, we will need it in other structures as well, so let's move that structure definition so that it can be reused. Signed-off-by: Maxime Ripard --- include/drm/drm_connector.h | 34

[PATCH v4 09/12] drm/atomic: Add a function to reset connector TV properties

2019-06-14 Thread Maxime Ripard
During the connector reset, if that connector has a TV property, it needs to be reset to the value provided on the command line. Provide a helper to do that. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic_state_helper.c | 18 ++ include/drm

[PATCH v4 05/12] drm/modes: Rewrite the command line parser

2019-06-14 Thread Maxime Ripard
From: Maxime Ripard Rewrite the command line parser in order to get away from the state machine parsing the video mode lines. Hopefully, this will allow to extend it more easily to support named modes and / or properties set directly on the command line. Signed-off-by: Maxime Ripard

[PATCH v4 03/12] drm/client: Restrict the rotation check to the rotation itself

2019-06-14 Thread Maxime Ripard
for no particular reason. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_client_modeset.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c index 8264c3a732b0..b4e5fb0a17cf 100644 --- a/drivers/gpu/drm

[PATCH v4 02/12] drm/client: Restrict the plane_state scope

2019-06-14 Thread Maxime Ripard
from the compiler since value would have been initialized. Fix this by moving the variable declaration to the proper scope. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_client_modeset.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH v4 01/12] drm/connector: Add documentation for drm_cmdline_mode

2019-06-14 Thread Maxime Ripard
The struct drm_cmdline_mode holds the result of the command line parsers. However, it wasn't documented so far, so let's do that. Signed-off-by: Maxime Ripard --- include/drm/drm_connector.h | 86 +- 1 file changed, 84 insertions(+), 2 deletions(-) diff

[PATCH v4 00/12] drm/vc4: Allow for more boot-time configuration

2019-06-14 Thread Maxime Ripard
ialisation to vc4 reset hook - Added documentation for the new drm_cmdline_mode - Renamed overscan to tv_margins to be consistent with the APIs Changes from v1: - Dropped the patches to deal with EDID - Added the unit test as selftest - Rebased on next Maxime Ripard (12): drm/conn

Re: [linux-sunxi] Re: [PATCH v10 04/11] drm/sun4i: tcon: Compute DCLK dividers based on format, lanes

2019-06-13 Thread Maxime Ripard
On Wed, Jun 05, 2019 at 01:11:44PM +0530, Jagan Teki wrote: > On Tue, Jun 4, 2019 at 8:00 PM Maxime Ripard > wrote: > > > > On Fri, May 24, 2019 at 03:37:36PM +0530, Jagan Teki wrote: > > > On Fri, May 24, 2019 at 2:18 AM Maxime Ripard > > > wrote: > >

Re: [PATCH v10 09/11] drm/sun4i: sun6i_mipi_dsi: Add VCC-DSI regulator support

2019-06-13 Thread Maxime Ripard
On Thu, Jun 13, 2019 at 01:25:52PM +0530, Jagan Teki wrote: > On Mon, Jun 3, 2019 at 7:19 PM Maxime Ripard > wrote: > > > > On Mon, May 20, 2019 at 02:33:16PM +0530, Jagan Teki wrote: > > > Allwinner MIPI DSI controllers are supplied with SoC > >

Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-06-13 Thread Maxime Ripard
On Wed, Jun 05, 2019 at 01:17:11PM +0530, Jagan Teki wrote: > On Tue, Jun 4, 2019 at 3:30 PM Maxime Ripard > wrote: > > > > On Wed, May 29, 2019 at 11:44:56PM +0530, Jagan Teki wrote: > > > On Wed, May 29, 2019 at 8:24 PM Maxime Ripard > > > wrote: > >

Re: [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-13 Thread Maxime Ripard
how userspace deals with rotation on top of orientation. The orientation is exposed through the property, and the result is available through the plane's rotation, so I guess that it's enough? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc

Re: [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-13 Thread Maxime Ripard
Hi, On Wed, Jun 12, 2019 at 02:43:44PM +0200, Noralf Trønnes wrote: > Den 11.06.2019 14.49, skrev Maxime Ripard: > >>> + } else if (!strncmp(option, "reflect_x", delim - option)) { > >>> + rotation |= DRM_MODE_REFLECT_X

Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-06-13 Thread Maxime Ripard
Hi, On Wed, Jun 12, 2019 at 12:00:21PM +0200, Andrzej Hajda wrote: > On 07.06.2019 11:40, Torsten Duwe wrote: > > On Fri, Jun 07, 2019 at 08:28:02AM +0200, Maxime Ripard wrote: > >> On Thu, Jun 06, 2019 at 03:59:27PM +0200, Harald Geyer wrote: > >>> If think val

Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-06-13 Thread Maxime Ripard
On Fri, Jun 07, 2019 at 11:40:30AM +0200, Torsten Duwe wrote: > On Fri, Jun 07, 2019 at 08:28:02AM +0200, Maxime Ripard wrote: > > On Thu, Jun 06, 2019 at 03:59:27PM +0200, Harald Geyer wrote: > > > > > > If think valid compatible properties would be: > > > com

Re: [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-11 Thread Maxime Ripard
Hi Noralf, On Fri, Apr 19, 2019 at 10:53:28AM +0200, Noralf Trønnes wrote: > Den 18.04.2019 18.40, skrev Noralf Trønnes: > > > > > > Den 18.04.2019 14.41, skrev Maxime Ripard: > >> Rotations and reflections setup are needed in some scenarios to initialise > &g

Re: [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-11 Thread Maxime Ripard
Hi Noralf, On Thu, Apr 18, 2019 at 06:40:42PM +0200, Noralf Trønnes wrote: > Den 18.04.2019 14.41, skrev Maxime Ripard: > > + /** > > +* We want the rotation on the command line to overwrite > > +* whatever comes from the panel. > > +*/ >

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

2019-06-07 Thread Maxime Ripard
On Thu, Jun 06, 2019 at 04:03:57PM +0200, Hans de Goede wrote: > Hi, > > On 06-06-19 15:38, Maxime Ripard wrote: > > On Thu, Jun 06, 2019 at 01:13:40PM +0200, Hans de Goede wrote: > > > On 06-06-19 11:14, Maxime Ripard wrote: > > > > On Fri, May 24, 2019 at 0

Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-06-07 Thread Maxime Ripard
On Thu, Jun 06, 2019 at 03:59:27PM +0200, Harald Geyer wrote: > Guys, this discussion is getting heated for no reason. Let's put > personal frustrations aside and discuss the issue on its merits: > > Maxime Ripard writes: > > On Wed, Jun 05, 2019 at 12:13:17PM +0200,

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

2019-06-06 Thread Maxime Ripard
On Thu, Jun 06, 2019 at 01:13:40PM +0200, Hans de Goede wrote: > On 06-06-19 11:14, Maxime Ripard wrote: > > On Fri, May 24, 2019 at 02:57:59PM +0200, Hans de Goede wrote: > > > GPD has done it again, make a nice device (good), use way too generic > > > DMI strings (bad

Re: [PATCH v2 2/2] drm: panel-orientation-quirks: Add quirk for GPD MicroPC

2019-06-06 Thread Maxime Ripard
e > matching, so the gpd_micropc data struct may very well need to be updated > with some extra bios-dates in the future. > > Signed-off-by: Hans de Goede For both patches, Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://boo

Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-06-05 Thread Maxime Ripard
already used in > some other places? (there's a space missing btw...) It's non-existent and imaginable only because you've been ignoring everyone that said that you should do it. So it's self-inflicted, really. And the DT is considered an ABI, so yeah, we will witheld everything that doe

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-06-05 Thread Maxime Ripard
ork.freedesktop.org/series/60847/ > > Hope this explanation helps? It doesn't. The clock tree is this one: PLL(s) -> TCON module clock -> TCON dotclock. The links I mentioned above show that the clock set to lcd_rate is the TCON module clocks (and it should be the one taking the

Re: [PATCH v10 04/11] drm/sun4i: tcon: Compute DCLK dividers based on format, lanes

2019-06-04 Thread Maxime Ripard
On Fri, May 24, 2019 at 03:37:36PM +0530, Jagan Teki wrote: > On Fri, May 24, 2019 at 2:18 AM Maxime Ripard > wrote: > > > > On Mon, May 20, 2019 at 02:33:11PM +0530, Jagan Teki wrote: > > > pll-video => pll-mipi => tcon0 => tcon0-pixel-clock is the typical &g

Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-06-04 Thread Maxime Ripard
On Wed, May 29, 2019 at 11:44:56PM +0530, Jagan Teki wrote: > On Wed, May 29, 2019 at 8:24 PM Maxime Ripard > wrote: > > > > On Fri, May 24, 2019 at 03:48:51PM +0530, Jagan Teki wrote: > > > On Fri, May 24, 2019 at 2:04 AM Maxime Ripard > > > wrote: > &

Re: [linux-sunxi] [PATCH v6 0/6] Add support for Orange Pi 3

2019-06-03 Thread Maxime Ripard
support (patches 1-3) > > - these should be ready now > > - HDMI support (patches 4-6) > > - should be ready > > If there are no futher comments, can all these patches please be merged? I'm waiting for some feedback on the stmmac and the DW-HDMI developpers to merge the rest Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v10 09/11] drm/sun4i: sun6i_mipi_dsi: Add VCC-DSI regulator support

2019-06-03 Thread Maxime Ripard
n Wajer > Signed-off-by: Jagan Teki This creates a lot of warnings at boot time on my board this is missing vcc-dsi-supply. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature _

Re: [PATCH v9 2/9] dt-bindings: sun6i-dsi: Add A64 DPHY compatible (w/ A31 fallback)

2019-05-31 Thread Maxime Ripard
ner,sun6i-a31-mipi-dphy - items: - const: allwinner,sun50i-a64-mipi-dphy - const: allwinner,sun6i-a31-mipi-dphy Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v9 1/9] dt-bindings: sun6i-dsi: Add A64 MIPI-DSI compatible

2019-05-31 Thread Maxime Ripard
s: phandles to the clocks feeding the DSI encoder We've switch to YAML now, and the compatible should be expressed that way now: compatible: enum: - allwinner,sun6i-a31-mipi-dsi - allwinner,sun50i-a64-mipi-dsi Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bo

Re: [PATCH v9 0/9] drm/sun4i: Allwinner A64 MIPI-DSI support

2019-05-31 Thread Maxime Ripard
e tested in Allwinner A64 with > 2, 4 lanes devices and whose pixel clocks are 27.5 MHz, > 30MHz, 55MHz and 147MHz. I wanted to apply this, but it wouldn't apply, can you send it without dependencies? Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] dt-bindings: display: Convert Allwinner DSI to a schema

2019-05-30 Thread Maxime Ripard
Hi, On Thu, May 30, 2019 at 09:48:02PM +0800, Chen-Yu Tsai wrote: > On Mon, May 27, 2019 at 8:09 PM Maxime Ripard > wrote: > > > > The Allwinner SoCs have a MIPI-DSI and MIPI-D-PHY controllers supported in > > Linux, with a matching Device Tree binding. > &g

Re: [PATCH v10 02/11] drm/sun4i: dsi: Update start value in video start delay

2019-05-30 Thread Maxime Ripard
On Fri, May 24, 2019 at 03:55:42PM +0530, Jagan Teki wrote: > On Fri, May 24, 2019 at 2:07 AM Maxime Ripard > wrote: > > > > On Mon, May 20, 2019 at 02:33:09PM +0530, Jagan Teki wrote: > > > start value in video start delay computation done in below commit > > &

Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-05-29 Thread Maxime Ripard
On Fri, May 24, 2019 at 03:48:51PM +0530, Jagan Teki wrote: > On Fri, May 24, 2019 at 2:04 AM Maxime Ripard > wrote: > > > > On Mon, May 20, 2019 at 02:33:08PM +0530, Jagan Teki wrote: > > > According to "DRM kernel-internal display mode structure" in >

[PATCH] dt-bindings: display: Convert Allwinner DSI to a schema

2019-05-27 Thread Maxime Ripard
The Allwinner SoCs have a MIPI-DSI and MIPI-D-PHY controllers supported in Linux, with a matching Device Tree binding. Now that we have the DT validation in place, let's convert the device tree bindings for that controller over to a YAML schemas. Signed-off-by: Maxime Ripard --- .../display

Re: [PATCH] drm/sun4i: fix warning PTR_ERR_OR_ZERO can be used

2019-05-26 Thread Maxime Ripard
clk)) > - return PTR_ERR(tcon->dclk); > > - return 0; > + return PTR_ERR_OR_ZERO(tcon->dclk); Unfortunately, that was on purpose. It's much easier to extend if we ever need to change anything there. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel eng

Re: [PATCH 6/6] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-05-24 Thread Maxime Ripard
a132-norrin.dts That's not really an argument though. These are using rather old bindings, and realising that they are flawed and fixing these flaws is a natural process. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP s

Re: [PATCH v2 3/6] drm/sun4i: dsi: Add bridge support

2019-05-24 Thread Maxime Ripard
drm_bridge_pre_enable(dsi->bridge); > + drm_panel_bridge provides what's needed to deal with both a panel and a bridge, I guess it would make sense to use this instead of duplicating everything. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-24 Thread Maxime Ripard
On Thu, May 23, 2019 at 11:10:39AM -0500, Rob Herring wrote: > On Thu, May 23, 2019 at 6:54 AM Maxime Ripard > wrote: > > > > On Tue, May 21, 2019 at 10:51:51AM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > Today's linux-n

Re: [PATCH v10 04/11] drm/sun4i: tcon: Compute DCLK dividers based on format, lanes

2019-05-23 Thread Maxime Ripard
BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1127 > [4] > https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1161 In that mail, I've pointed out that clk_div isn't used for the TCON dclk divider: http://list

Re: [PATCH v10 03/11] drm/sun4i: dsi: Fix video start delay computation

2019-05-23 Thread Maxime Ripard
alue > (no sync timings included). > > This is clearly confirmed from the legacy [1] and new [2] bsp codes > that the second parameter on the video start delay is "front porch" > > Here is the detailed evidence for calculating front porch as per > bsp code. > >

Re: [PATCH v10 02/11] drm/sun4i: dsi: Update start value in video start delay

2019-05-23 Thread Maxime Ripard
1 in new bsp. Then start_delay is never reassigned to 1 in that link, and is clamped between 8 and 100 as the code that you are removing is doing. > Unfortunately we don't have any evidence or documentation for this > reassignment to 1 in new bsp, but it is working with all supported > panels in A33, A64. No, it's not. That was added to fix a panel that is supported today. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits

2019-05-23 Thread Maxime Ripard
lcd_hbp - 20 > => tt->hor_front_porch - 20 The thing is, while your explanation on the DRM side is sound, Allwinner has been using the hbp field of their panel description to store what DRM calls the backporch and the sync period. And nowhere in that commit log you are describing whether it's still an issue or not, and if it's not anymore how you did test that it's not the case anymore. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 5/6] drm: sun4i: Add support for enabling DDC I2C bus to sun8i_dw_hdmi glue

2019-05-23 Thread Maxime Ripard
On Tue, May 21, 2019 at 02:15:19PM +0200, Ondřej Jirman wrote: > Hi Maxime, > > On Tue, May 21, 2019 at 01:46:11PM +0200, Maxime Ripard wrote: > > Hi, > > > > On Tue, May 21, 2019 at 01:50:08AM +0200, meg...@megous.com wrote: > > > From: Ondrej Jirman &g

Re: linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-23 Thread Maxime Ripard
shed a temp branch there: https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git/commit/?h=drm-misc-next=3832f2cad5307ebcedeead13fbd8d3cf06ba5e90 Rob, Stephen, are you ok with the change? If so, I'll push it. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signat

Re: [PATCH 5/6] dt-bindings: Add ANX6345 DP/eDP transmitter binding

2019-05-23 Thread Maxime Ripard
+Optional properties: > + > + - Video ports for RGB input and eDP output using the DT bindings > + defined in [1] The output node can be optional, but the input one is probably going to be needed all the time, since otherwise you won't be able to fill the output port of the upstream devic

Re: linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-23 Thread Maxime Ripard
"^tfc,.*": > +description: Three Five Corp >"^thine,.*": > description: THine Electronics, Inc. >"^ti,.*": > @@ -925,6 +929,8 @@ patternProperties: > description: Voipac Technologies s.r.o. >"^vot,.*": > descr

Re: [PATCH] drm/fourcc: Fix the parameters name in the documentation

2019-05-21 Thread Maxime Ripard
On Tue, May 21, 2019 at 02:41:30PM +0200, Daniel Vetter wrote: > On Tue, May 21, 2019 at 01:09:06PM +0200, Maxime Ripard wrote: > > We introduced new functions in the commit bf39607c1614 ("drm/fourcc: Pass > > the format_info pointer to drm_format_plane_width/height") b

Re: [PATCH v5 5/6] drm: sun4i: Add support for enabling DDC I2C bus to sun8i_dw_hdmi glue

2019-05-21 Thread Maxime Ripard
dev_err(dev, "Failed to enable regulator\n"); > - return ret; > + goto err_unref_ddc_en; > } > > + gpiod_set_value(hdmi->ddc_en, 1); > + Do you really need this to be done all the time? I'm guessing you would only need this when running .get_modes, right? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

[PATCH] drm/fourcc: Fix the parameters name in the documentation

2019-05-21 Thread Maxime Ripard
quot;drm/fourcc: Pass the format_info pointer to drm_format_plane_width/height") Reported-by: kbuild test robot Signed-off-by: Maxime Ripard --- include/drm/drm_fourcc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.

Re: [PATCH v3 7/7] drm: Remove users of drm_format_num_planes

2019-05-20 Thread Maxime Ripard
On Mon, May 20, 2019 at 01:20:45PM +0200, Paul Kocialkowski wrote: > Hi, > > On Thu 16 May 19, 12:31, Maxime Ripard wrote: > > drm_format_info_plane_cpp() basically just returns the cpp array content > > found in the drm_format_info structure. > > > > Since

Re: [PATCH v2 3/4] arm64: DTS: allwinner: a64: Enable audio on Teres-I

2019-05-20 Thread Maxime Ripard
s + mic), "CTIA" (android) pinout. > > > > The headphone and mic detect lines of the A64 are connected properly, > > but AFAIK currently unsupported by the driver. > > > > Signed-off-by: Harald Geyer > > Signed-off-by: Torsten Duwe > > Looks

Re: [PATCH v2 1/4] arm64: DTS: allwinner: a64: Add pinmux for RGB666 LCD

2019-05-20 Thread Maxime Ripard
Applied, with sed/DTS/dts/ in the commit title Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freed

Re: [PATCH 4/4] arm64: DTS: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-05-17 Thread Maxime Ripard
On Fri, May 17, 2019 at 10:14:18AM +0200, Torsten Duwe wrote: > On Fri, 17 May 2019 09:27:38 +0200 > Maxime Ripard wrote: > > > On Thu, May 16, 2019 at 06:48:59PM +0200, Torsten Duwe wrote: > > > On Thu, May 16, 2019 at 09:06:41AM -0700, Vasily Khoruzhick wrote: > &g

Re: [PATCH 4/4] arm64: DTS: allwinner: a64: enable ANX6345 bridge on Teres-I

2019-05-17 Thread Maxime Ripard
r-on. The boot loader needs to deal with this. The bootloader can deal with it, but the kernel will also need to. The bootloader might not be doing this because it's not been updated, the regulator might have been disabled between the time the kernel was started and the time the bridge driver prob

[PATCH v3 3/7] drm: Remove users of drm_format_(horz|vert)_chroma_subsampling

2019-05-16 Thread Maxime Ripard
Reviewed-by: Paul Kocialkowski Reviewed-by: Philipp Zabel Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arm/malidp_planes.c | 6 +-- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 9 + drivers/gpu/drm/drm_fourcc.c| 34 +-- drivers/gpu/drm/imx

[PATCH v3 4/7] drm/fourcc: Pass the format_info pointer to drm_format_plane_cpp

2019-05-16 Thread Maxime Ripard
that function to drm_format_info_plane_cpp and to a static function in the header to match the current policy. Reviewed-by: Emil Velikov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 4 +++- drivers/gpu/drm/arm/malidp_hw.c| 3 ++- drivers/gpu/drm/arm

[PATCH v3 6/7] drm: Replace instances of drm_format_info by drm_get_format_info

2019-05-16 Thread Maxime Ripard
. Reviewed-by: Emil Velikov Reviewed-by: Paul Kocialkowski Signed-off-by: Maxime Ripard --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 4 ++-- drivers/gpu/drm/gma500/framebuffer.c | 2 +- drivers/gpu/drm/omapdrm/omap_fb.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v3 5/7] drm/fourcc: Pass the format_info pointer to drm_format_plane_width/height

2019-05-16 Thread Maxime Ripard
, also rename that function to drm_format_info_plane_cpp and to a static function in the header to match the current policy. The parameters order have also be changed to match the other functions prototype. Reviewed-by: Emil Velikov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_fourcc.c

[PATCH v3 7/7] drm: Remove users of drm_format_num_planes

2019-05-16 Thread Maxime Ripard
drm_format_info_plane_cpp() basically just returns the cpp array content found in the drm_format_info structure. Since it's pretty trivial, let's remove the function and have the users use the array directly Suggested-by: Ville Syrjälä Signed-off-by: Maxime Ripard --- Changes from v2

[PATCH v3 1/7] drm/rockchip: Change the scl_vop_cal_scl_fac to pass drm_format_info

2019-05-16 Thread Maxime Ripard
of that function to pass the drm_format_info structure directly, removing the need for an extra lookup. Suggested-by: Philipp Zabel Signed-off-by: Maxime Ripard --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v3 2/7] drm: Remove users of drm_format_num_planes

2019-05-16 Thread Maxime Ripard
multiple fields from the drm_format_info structure. Reviewed-by: Emil Velikov Reviewed-by: Paul Kocialkowski Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arm/malidp_mw.c | 2 +- drivers/gpu/drm/armada/armada_fb.c | 3 ++- drivers/gpu/drm/drm_fourcc.c| 16

Re: [PATCH v10 0/2] drm/sun4i: sun6i_mipi_dsi: Fixes/updates

2019-05-16 Thread Maxime Ripard
On Mon, May 13, 2019 at 12:11:25AM +0530, Jagan Teki wrote: > This is v10 for the previous series[1] and few pathes are dropped > as part of this series since it would require separate rework same > will send in separately or another series. APplied both, thanks Maxime -- Maxime Ripard

Re: [PATCH 1/4] arm64: DTS: allwinner: a64: Add pinmux for RGB666 LCD

2019-05-16 Thread Maxime Ripard
function = "i2c1"; > }; > > + /omit-if-no-ref/ > + lcd_rgb666_pins: lcd-rgb666 { This should have the -pins suffix Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH 0/2] drm/sun4i: Fix sun8i HDMI PHY initialization

2019-05-16 Thread Maxime Ripard
s), I've > added fix anyway, to be conformant with vendor documentation. Applied both, thanks Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v2 4/6] drm/fourcc: Pass the format_info pointer to drm_format_plane_cpp

2019-05-12 Thread Maxime Ripard
Hi Ville, On Fri, May 10, 2019 at 07:00:31PM +0300, Ville Syrjälä wrote: > On Fri, May 10, 2019 at 01:08:49PM +0200, Maxime Ripard wrote: > > So far, the drm_format_plane_cpp function was operating on the format's > > fourcc and was doing a lookup to retrieve the drm_format

[PATCH v2 5/6] drm/fourcc: Pass the format_info pointer to drm_format_plane_width/height

2019-05-10 Thread Maxime Ripard
, also rename that function to drm_format_info_plane_cpp and to a static function in the header to match the current policy. The parameters order have also be changed to match the other functions prototype. Reviewed-by: Emil Velikov Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_fourcc.c

[PATCH v2 1/6] drm/rockchip: Change the scl_vop_cal_scl_fac to pass drm_format_info

2019-05-10 Thread Maxime Ripard
of that function to pass the drm_format_info structure directly, removing the need for an extra lookup. Suggested-by: Philipp Zabel Signed-off-by: Maxime Ripard --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 2/6] drm: Remove users of drm_format_num_planes

2019-05-10 Thread Maxime Ripard
multiple fields from the drm_format_info structure. Reviewed-by: Emil Velikov Reviewed-by: Paul Kocialkowski Signed-off-by: Maxime Ripard --- drivers/gpu/drm/arm/malidp_mw.c | 2 +- drivers/gpu/drm/armada/armada_fb.c | 3 ++- drivers/gpu/drm/drm_fourcc.c| 16

  1   2   3   4   5   6   7   8   9   10   >