Re: [PATCH v4 RESEND 0/9] Increase coverage on drm_framebuffer.c

2024-09-13 Thread Maxime Ripard
On Fri, Sep 13, 2024 at 10:31:08AM GMT, Jani Nikula wrote: > On Wed, 11 Sep 2024, Maxime Ripard wrote: > > On Tue, 10 Sep 2024 21:15:25 -0300, Carlos Eduardo Gallo Filho wrote: > >> This patchset includes new KUnit tests for 5 untested functions from > >> drm_framebuffe

Re: [PATCH] drm/tidss: Add MIT license along with GPL-2.0

2024-09-12 Thread Maxime Ripard
On Thu, Sep 12, 2024 at 06:04:11PM GMT, Maxime Ripard wrote: > On Thu, 12 Sep 2024 22:41:42 +0530, Devarsh Thakkar wrote: > > Modify license to include dual licensing as GPL-2.0-only OR MIT license for > > tidss display driver. This allows other operating system ecosystems such as

Re: [PATCH] drm/tidss: Add MIT license along with GPL-2.0

2024-09-12 Thread Maxime Ripard
from this > display driver in a more permissive manner. > > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [EXT] Re: [PATCH v16 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-09-12 Thread Maxime Ripard
On Fri, Sep 06, 2024 at 02:50:08AM GMT, Sandor Yu wrote: > > On Tue, Sep 03, 2024 at 06:07:25AM GMT, Sandor Yu wrote: > > > > -Original Message- > > > > From: dri-devel On Behalf > > > > Of Maxime Ripard > > > > Sent: 2024年7月2日

Re: [PATCH] drm/doc: Update drm_bridge_connector path

2024-09-12 Thread Maxime Ripard
On Thu, Sep 12, 2024 at 12:46:50PM GMT, Dmitry Baryshkov wrote: > On Thu, Sep 12, 2024 at 10:45:40AM GMT, Maxime Ripard wrote: > > Commit 9da7ec9b19d8 ("drm/bridge-connector: move to DRM_DISPLAY_HELPER > > module") recently moved the drm_bridge_connector file, but

Re: linux-next: build warning after merge of the drm-misc-fixes tree

2024-09-12 Thread Maxime Ripard
Hi, On Wed, Sep 11, 2024 at 06:07:41PM GMT, Stephen Rothwell wrote: > Hi all, > > On Wed, 4 Sep 2024 16:30:18 +1000 Stephen Rothwell > wrote: > > > > After merging the drm-misc-fixes tree, today's linux-next build (htmldocs) > > produced this warning: > > > > Error: Cannot open file drivers/gp

[PULL] drm-misc-fixes

2024-09-12 Thread Maxime Ripard
Hi, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2024-09-12: An off-by-one fix for the CMA DMA-buf heap, An init fix for nouveau, a config dependency fix for stm, a syncobj leak fix, and two iommu fixes for tegra and rockchip. The following changes since commit 5a498d4d06d6d9bad76d8a

[PATCH] drm/doc: Update drm_bridge_connector path

2024-09-12 Thread Maxime Ripard
ISPLAY_HELPER module") Closes: https://lore.kernel.org/dri-devel/20240904163018.214ef...@canb.auug.org.au/ Reported-by: Stephen Rothwell Signed-off-by: Maxime Ripard --- Documentation/gpu/drm-kms-helpers.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentatio

Re: [PATCH] MAINTAINERS: Add myself as VKMS Maintainer

2024-09-11 Thread Maxime Ripard
On Wed, Sep 11, 2024 at 02:15:05PM GMT, Louis Chauvet wrote: > Le 10/09/24 - 15:57, Maira Canal a écrit : > > On 9/10/24 12:10, Louis Chauvet wrote: > > > I've been actively working on VKMS to provide new features and > > > participated in reviews and testing. To help Maìra with her work, add > > >

Re: [PATCH v4 RESEND 0/9] Increase coverage on drm_framebuffer.c

2024-09-11 Thread Maxime Ripard
On Tue, 10 Sep 2024 21:15:25 -0300, Carlos Eduardo Gallo Filho wrote: > This patchset includes new KUnit tests for 5 untested functions from > drm_framebuffer.c and improvements to the existent one. > > The first patch replace the use of dev_private member from drm_device > mock on the existent te

Re: dw_mipi_dsi-stm.c:(.text+0x8db9a3): undefined reference to `clk_hw_unregister'

2024-09-10 Thread Maxime Ripard
On Tue, Sep 10, 2024 at 12:48:49PM GMT, Raphael Gallais-Pou wrote: > > On 9/9/24 10:45, Borislav Petkov wrote: > > On Mon, Sep 09, 2024 at 08:57:57AM +0200, Raphael Gallais-Pou wrote: > >> Arnd Bergmann sent a patch regarding this issue on x86 that I merged > >> several > >> weeks ago. > >> > >>

Re: [RFC PATCH] drm: allow encoder mode_set even when connectors change for crtc

2024-09-10 Thread Maxime Ripard
Hi, On Mon, Sep 09, 2024 at 12:59:47PM GMT, Abhinav Kumar wrote: > On 9/9/2024 6:37 AM, Maxime Ripard wrote: > > Hi, > > > > On Thu, Sep 05, 2024 at 03:11:24PM GMT, Abhinav Kumar wrote: > > > In certain use-cases, a CRTC could switch between two encoders &g

Re: [PATCH v6 1/3] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library

2024-09-09 Thread Maxime Ripard
Hi, On Fri, Sep 06, 2024 at 04:17:40AM GMT, Cristian Ciocaltea wrote: > +static enum drm_connector_status > +dw_hdmi_qp_bridge_detect(struct drm_bridge *bridge) > +{ > + struct dw_hdmi_qp *hdmi = bridge->driver_private; > + enum drm_connector_status status; > + > + status = hdmi->phy.o

Re: [RFC PATCH] drm: allow encoder mode_set even when connectors change for crtc

2024-09-09 Thread Maxime Ripard
Hi, On Thu, Sep 05, 2024 at 03:11:24PM GMT, Abhinav Kumar wrote: > In certain use-cases, a CRTC could switch between two encoders > and because the mode being programmed on the CRTC remains > the same during this switch, the CRTC's mode_changed remains false. > In such cases, the encoder's mode_se

Re: Time for drm-ci-next?

2024-09-09 Thread Maxime Ripard
Hi, On Tue, Jul 09, 2024 at 01:27:51AM GMT, Dmitry Baryshkov wrote: > On Mon, 8 Jul 2024 at 21:38, Rob Clark wrote: > > > > On Mon, Jul 8, 2024 at 1:52 AM Daniel Vetter wrote: > > > > > > On Fri, Jul 05, 2024 at 12:31:36PM -0700, Rob Clark wrote: > > > > On Fri, Jul 5, 2024 at 3:36 AM Daniel Vet

Re: i.MX8MP IMX-LCDIF Underrun Question(s)

2024-09-06 Thread Maxime Ripard
On Fri, Sep 06, 2024 at 08:03:38AM GMT, Peng Fan wrote: > > Subject: i.MX8MP IMX-LCDIF Underrun Question(s) > > > > I have been testing various settings on the HDMI out of the i.MX8MP. > > > > I noticed that sometimes my monitor would not sync, but sometimes it > > would on the same resolution/re

Re: [PATCH] drm/bridge: imx8mp-hdmi-tx: allow 0.5% margin with selected clock

2024-09-06 Thread Maxime Ripard
On Thu, Sep 05, 2024 at 08:23:51PM GMT, Adam Ford wrote: > On Wed, Sep 4, 2024 at 3:31 AM Dominique Martinet > wrote: > > > > This allows the hdmi driver to pick e.g. 64.8MHz instead of 65Mhz when we > > cannot output the exact frequency, enabling the imx8mp HDMI output to > > support more modes >

[PULL] drm-misc-fixes

2024-09-05 Thread Maxime Ripard
Hi, Here's this week drm-misc-fixes PR. Maxime drm-misc-fixes-2024-09-05: A zpos normalization fix for komeda, a register bitmask fix for nouveau, a memory leak fix for imagination, three fixes for the recent bridge HDMI work, a potential DoS fix and a cache coherency for panthor, a change of pa

Re: [PATCH 0/2] drm: add two missing DRM_DISPLAY_DSC_HELPER selects

2024-09-05 Thread Maxime Ripard
On Thu, 05 Sep 2024 06:08:20 +0300, Dmitry Baryshkov wrote: > Add two selects for DRM_DISPLAY_DSC_HELPER which got missed in the > original commit ca097d4d94d8 ("drm/display: split DSC helpers from DP > helpers") and were later reported by LKP. > > Applied to misc/kernel.git (drm-misc-next). Th

Re: (subset) [PATCH v3 2/2] drm: panel: nv3052c: Correct WL-355608-A8 panel compatible

2024-09-05 Thread Maxime Ripard
On Wed, 04 Sep 2024 13:23:22 +1200, Ryan Walklin wrote: > As per the previous dt-binding commit, update the WL-355608-A8 panel > compatible to reflect the the integrating device vendor and name as the > panel OEM is unknown. > > Signed-off-by: Ryan Walklin > > -- > Changelog v2..v3: > - Use inte

Re: (subset) [PATCH v3 1/2] dt-bindings: display: panel: Rename WL-355608-A8 panel to rg35xx-*-panel

2024-09-05 Thread Maxime Ripard
On Wed, 04 Sep 2024 13:23:21 +1200, Ryan Walklin wrote: > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown > OEM used in a number of handheld gaming devices made by Anbernic. > Previously committed using the OEM serial without a vendor prefix, > however following subsequent d

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-09-03 Thread Maxime Ripard
On Mon, Sep 02, 2024 at 03:31:28PM GMT, Tomi Valkeinen wrote: > Hi, > > On 02/09/2024 13:50, Daniel Vetter wrote: > > On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Va

Re: [RFC PATCH 2/6] drm/cgroup: Add memory accounting DRM cgroup

2024-09-03 Thread Maxime Ripard
On Tue, Aug 06, 2024 at 05:26:21PM GMT, Daniel Vetter wrote: > On Tue, Aug 06, 2024 at 04:09:43PM +0200, Maxime Ripard wrote: > > On Tue, Aug 06, 2024 at 03:01:44PM GMT, Daniel Vetter wrote: > > > On Mon, Jul 01, 2024 at 06:01:41PM +0100, Tvrtko Ursulin wrote: > > > >

Re: [PATCH v16 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-09-03 Thread Maxime Ripard
On Tue, Sep 03, 2024 at 06:07:25AM GMT, Sandor Yu wrote: > Hi Maxime, > > Thanks for your comments, > > > -Original Message- > > From: dri-devel On Behalf Of > > Maxime Ripard > > Sent: 2024年7月2日 21:25 > > To: Sandor Yu > > Cc: dmit

Re: [PATCH v5 0/3] drm: fix two issues related to HDMI Connector implementation

2024-09-03 Thread Maxime Ripard
On Tue, 03 Sep 2024 05:01:55 +0300, Dmitry Baryshkov wrote: > Running IGT tests on Qualcomm Dragonboard820c uncovered two issues with > the HDMI Connector implementation and with its integration into the > drm_bridge_connector. Fix those issues. > > Note, I'm not fully satisfied with the drm_bridg

Re: [PATCH v4 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library

2024-09-03 Thread Maxime Ripard
On Tue, Sep 03, 2024 at 12:12:02AM GMT, Cristian Ciocaltea wrote: > On 9/2/24 10:36 AM, Maxime Ripard wrote: > > On Sat, Aug 31, 2024 at 01:21:48AM GMT, Cristian Ciocaltea wrote: > >> On 8/27/24 11:58 AM, Maxime Ripard wrote: > >>> On Mon, Aug 19, 2024 at 01:29:29AM

Re: [PATCH v1 1/1] drm/panel: ili9341: Remove duplicate code

2024-09-02 Thread Maxime Ripard
On Tue, 13 Aug 2024 12:12:58 +0300, Andy Shevchenko wrote: > Remove duplicate code that is handled by tinyDRM, > i.e. drivers/gpu/drm/tiny/ili9341.c. > > Applied to misc/kernel.git (drm-misc-next). Thanks! Maxime

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-09-02 Thread Maxime Ripard
Hi, On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Valkeinen wrote: > On 25/07/2024 14:28, Maxime Ripard wrote: > > On Mon, Jul 15, 2024 at 11:32:34AM GMT, Tomi Valkeinen wrote: > > > On 02/07/2024 14:43, Maxime Ripard wrote: > > > > Hi Tomi, > > > > >

Re: [PATCH v4 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library

2024-09-02 Thread Maxime Ripard
On Sat, Aug 31, 2024 at 01:21:48AM GMT, Cristian Ciocaltea wrote: > On 8/27/24 11:58 AM, Maxime Ripard wrote: > > On Mon, Aug 19, 2024 at 01:29:29AM GMT, Cristian Ciocaltea wrote: > >> +static irqreturn_t dw_hdmi_qp_main_hardirq(int irq, void *dev_id) > >> +{ >

[PULL] drm-misc-fixes

2024-08-29 Thread Maxime Ripard
Hi, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2024-08-29: A revert for a previous TTM commit causing stuttering, 3 fixes for vmwgfx related to buffer operations, a fix for video/aperture with non-VGA primary devices, and a preemption status fix for v3d The following changes since

Re: [PATCH RFC 11/15] drm: writeback: Add drm_writeback_connector cleanup

2024-08-28 Thread Maxime Ripard
On Wed, Aug 28, 2024 at 11:07:37AM GMT, Louis Chauvet wrote: > Le 28/08/24 - 11:35, Jani Nikula a écrit : > > On Tue, 27 Aug 2024, Louis Chauvet wrote: > > > Le 27/08/24 - 16:33, Maxime Ripard a écrit : > > >> Hi, > > >> > > >> On We

Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

2024-08-28 Thread Maxime Ripard
On Tue, Aug 27, 2024 at 06:28:21PM GMT, Neil Armstrong wrote: > On 30/06/2024 10:16, Ryan Walklin wrote: > > On Fri, 28 Jun 2024, at 5:59 AM, Maxime Ripard wrote: > > > On Wed, Jun 26, 2024 at 04:34:11PM GMT, Conor Dooley wrote: > > > > On Wed, Jun 26, 2024 at 05:04:1

Re: [PATCH v4] drm/connector: hdmi: Fix writing Dynamic Range Mastering infoframes

2024-08-27 Thread Maxime Ripard
gt; [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v2 1/6] drm/vkms: Switch to managed for connector

2024-08-27 Thread Maxime Ripard
On Tue, Aug 27, 2024 at 05:08:08PM GMT, Louis Chauvet wrote: > Le 27/08/24 - 16:39, Maxime Ripard a écrit : > > On Tue, Aug 27, 2024 at 03:24:10PM GMT, Louis Chauvet wrote: > > > Le 27/08/24 - 15:15, Maxime Ripard a écrit : > > > > Hi, > > > > > > &

Re: [PATCH RFC 11/15] drm: writeback: Add drm_writeback_connector cleanup

2024-08-27 Thread Maxime Ripard
Hi, On Wed, Aug 14, 2024 at 04:36:33PM GMT, Louis Chauvet wrote: > Currently drm_writeback_connector are created by > drm_writeback_connector_init or drm_writeback_connector_init_with_encoder. > Both of the function uses drm_connector_init and drm_encoder_init, but > there is no way to properly cl

Re: [PATCH v2 1/6] drm/vkms: Switch to managed for connector

2024-08-27 Thread Maxime Ripard
On Tue, Aug 27, 2024 at 03:24:10PM GMT, Louis Chauvet wrote: > Le 27/08/24 - 15:15, Maxime Ripard a écrit : > > Hi, > > > > On Tue, Aug 27, 2024 at 11:57:36AM GMT, Louis Chauvet wrote: > > > The current VKMS driver uses non-managed function to create connectors. It

Re: [PATCH v2 2/6] drm/vkms: Switch to managed for encoder

2024-08-27 Thread Maxime Ripard
On Tue, Aug 27, 2024 at 11:57:37AM GMT, Louis Chauvet wrote: > The current VKMS driver uses non-managed function to create encoders. It > is not an issue yet, but in order to support multiple devices easily, > convert this code to use drm and device managed helpers. > > Signed-off-by: Louis Chauve

Re: [PATCH v2 1/6] drm/vkms: Switch to managed for connector

2024-08-27 Thread Maxime Ripard
Hi, On Tue, Aug 27, 2024 at 11:57:36AM GMT, Louis Chauvet wrote: > The current VKMS driver uses non-managed function to create connectors. It > is not an issue yet, but in order to support multiple devices easily, > convert this code to use drm and device managed helpers. > > Signed-off-by: Louis

Re: [PATCH 0/3] Correct WL-355608-A8 panel compatible

2024-08-27 Thread Maxime Ripard
Hi, On Wed, Jun 26, 2024 at 11:17:47PM GMT, Ryan Walklin wrote: > The previous patch adding support for this panel [1] referred to previously > by its serial number only. As discussed after the patch was committed, the > preference is to use the integrating device vendor and name in this > circ

Re: [PATCH v3] drm/connector: hdmi: Fix writing Dynamic Range Mastering infoframes

2024-08-27 Thread Maxime Ripard
Hi, On Mon, Aug 26, 2024 at 07:10:11AM GMT, Derek Foreman wrote: > The largest infoframe we create is the DRM (Dynamic Range Mastering) > infoframe which is 26 bytes + a 4 byte header, for a total of 30 > bytes. > > With HDMI_MAX_INFOFRAME_SIZE set to 29 bytes, as it is now, we > allocate too lit

Re: [PATCH v4 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library

2024-08-27 Thread Maxime Ripard
On Mon, Aug 19, 2024 at 01:29:29AM GMT, Cristian Ciocaltea wrote: > +static irqreturn_t dw_hdmi_qp_main_hardirq(int irq, void *dev_id) > +{ > + struct dw_hdmi_qp *hdmi = dev_id; > + struct dw_hdmi_qp_i2c *i2c = hdmi->i2c; > + u32 stat; > + > + stat = dw_hdmi_qp_read(hdmi, MAINUNIT_1

[PULL] drm-misc-fixes

2024-08-08 Thread Maxime Ripard
Hi, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2024-08-08: A fix for drm/client to prevent a null pointer dereference, a fix for a double-free in drm/bridge-connector, a fix for a gem shmem test, and a fix for async flips updates. The following changes since commit 9c685f61722d30a2

Re: [RFC PATCH 2/6] drm/cgroup: Add memory accounting DRM cgroup

2024-08-06 Thread Maxime Ripard
On Tue, Aug 06, 2024 at 03:01:44PM GMT, Daniel Vetter wrote: > On Mon, Jul 01, 2024 at 06:01:41PM +0100, Tvrtko Ursulin wrote: > > > > On 01/07/2024 10:25, Maarten Lankhorst wrote: > > > Den 2024-06-28 kl. 16:04, skrev Maxime Ripard: > > > > Hi, > > >

Re: [RFC PATCH 2/6] drm/cgroup: Add memory accounting DRM cgroup

2024-08-06 Thread Maxime Ripard
Hi Maarten, On Mon, Jul 01, 2024 at 11:25:12AM GMT, Maarten Lankhorst wrote: > Den 2024-06-28 kl. 16:04, skrev Maxime Ripard: > > On Thu, Jun 27, 2024 at 09:22:56PM GMT, Maarten Lankhorst wrote: > >> Den 2024-06-27 kl. 19:16, skrev Maxime Ripard: > >>> Hi, > >

Re: [PATCH] drm/rockchip: inno-hdmi: Fix infoframe upload

2024-08-05 Thread Maxime Ripard
(now) empty and superfluous packed_frame variable. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH] drm/test: fix the gem shmem test to map the sg table.

2024-08-02 Thread Maxime Ripard
On Mon, 15 Jul 2024 18:35:51 +1000, Dave Airlie wrote: > The test here creates an sg table, but never maps it, when > we get to drm_gem_shmem_free, the helper tries to unmap and this > causes warnings on some platforms and debug kernels. > > This also sets a 64-bit dma mask, as I see an swiotlb wa

[PULL] drm-misc-fixes

2024-08-01 Thread Maxime Ripard
drm/vmwgfx: Trigger a modeset when the screen moves Jammy Huang (1): drm/ast: Fix black screen after resume Maxime Ripard (2): Merge drm/drm-fixes into drm-misc-fixes Merge drm-misc/drm-misc-next-fixes into drm-misc-fixes Philip Mueller (1): drm: panel-orientation-quirks: Add

Re: [PATCH v15 00/29] drm/connector: Create HDMI Connector infrastructure

2024-08-01 Thread Maxime Ripard
Hi Hans, On Wed, Jul 31, 2024 at 04:56:16PM GMT, Hans Verkuil wrote: > Hi Maxime, > > On 27/05/2024 15:57, Maxime Ripard wrote: > > > > Hans Verkuil also expressed interest in implementing a mechanism in v4l2 > > to retrieve infoframes from HDMI receiver and implem

Re: [PATCH V2 08/16] drm/vc4: hdmi: add PM suspend/resume support

2024-07-30 Thread Maxime Ripard
gt; [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH V2 06/16] drm/vc4: hdmi: Handle error case of pm_runtime_resume_and_get

2024-07-30 Thread Maxime Ripard
nately it just print a warning if pm_runtime_resume_and_get() > fails and proceed anyway. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-30 Thread Maxime Ripard
On Tue, Jul 30, 2024 at 11:46:24AM GMT, Dmitry Baryshkov wrote: > On Tue, 30 Jul 2024 at 11:27, Maxime Ripard wrote: > > > > On Wed, Jul 24, 2024 at 07:59:21PM GMT, Marc Gonzalez wrote: > > > On 15/07/2024 16:40, Maxime Ripard wrote: > > > > On Thu, Jul 04, 2

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-30 Thread Maxime Ripard
On Wed, Jul 24, 2024 at 07:28:41PM GMT, Marc Gonzalez wrote: > On 24/07/2024 19:25, Dmitry Baryshkov wrote: > > On Wed, Jul 24, 2024 at 07:18:39PM GMT, Marc Gonzalez wrote: > >> On 15/07/2024 16:42, Maxime Ripard wrote: > >>> On Mon, Jul 08, 2024 at 11:29:46

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-30 Thread Maxime Ripard
On Wed, Jul 24, 2024 at 07:59:21PM GMT, Marc Gonzalez wrote: > On 15/07/2024 16:40, Maxime Ripard wrote: > > On Thu, Jul 04, 2024 at 07:04:41PM GMT, Marc Gonzalez wrote: > >> On 01/07/2024 15:50, Maxime Ripard wrote: > >> > >>> The i2c register access (an

Re: [PATCH v2 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-07-29 Thread Maxime Ripard
On Tue, Jul 30, 2024 at 11:36:58AM GMT, Tejas Vipin wrote: > Add more functions that can benefit from being multi style and mark > older variants as deprecated to eventually convert all mipi_dsi functions > to multi style. > > Signed-off-by: Tejas Vipin Acked-by: Maxime Ripard

Re: [PATCH V2 07/16] drm/vc4: Get the rid of DRM_ERROR()

2024-07-29 Thread Maxime Ripard
op DRM_ERROR(), because kcalloc already logs errors. > > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH 2/2] drm/mipi-dsi: Change multi functions to use quiet member of mipi_dsi_multi_context

2024-07-26 Thread Maxime Ripard
Hi, On Thu, Jul 25, 2024 at 10:12:46AM GMT, Doug Anderson wrote: > On Thu, Jul 25, 2024 at 1:28 AM Maxime Ripard wrote: > > > > On Wed, Jul 24, 2024 at 06:32:14PM GMT, Jani Nikula wrote: > > > On Wed, 24 Jul 2024, Tejas Vipin wrote: > > > > Changes all

[PULL] drm-misc-next-fixes

2024-07-25 Thread Maxime Ripard
Hi, Here's this week drm-misc-next-fixes PR Maxime drm-misc-next-fixes-2024-07-25: A single fix for a panel compatible The following changes since commit 1fe1c66274fb80cc1ac42e0d38917d53adc7d7a3: drm/v3d: Fix Indirect Dispatch configuration for V3D 7.1.6 and later (2024-07-15 12:49:52 -0300)

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-07-25 Thread Maxime Ripard
On Mon, Jul 15, 2024 at 11:32:34AM GMT, Tomi Valkeinen wrote: > On 02/07/2024 14:43, Maxime Ripard wrote: > > Hi Tomi, > > > > On Wed, Jun 26, 2024 at 06:53:40PM GMT, Tomi Valkeinen wrote: > > > On 26/06/2024 18:07, Maxime Ripard wrote: > > > > On

Re: [PATCH RFC 3/5] drm/connector: implement generic HDMI codec helpers

2024-07-25 Thread Maxime Ripard
On Thu, Jun 27, 2024 at 04:29:49PM GMT, Dmitry Baryshkov wrote: > On Thu, Jun 27, 2024 at 11:49:37AM GMT, Maxime Ripard wrote: > > On Wed, Jun 26, 2024 at 07:09:34PM GMT, Dmitry Baryshkov wrote: > > > On Wed, Jun 26, 2024 at 04:05:01PM GMT, Maxime Ripard wrote: > > > &

Re: [PATCH 2/2] drm/mipi-dsi: Change multi functions to use quiet member of mipi_dsi_multi_context

2024-07-25 Thread Maxime Ripard
On Wed, Jul 24, 2024 at 06:32:14PM GMT, Jani Nikula wrote: > On Wed, 24 Jul 2024, Tejas Vipin wrote: > > Changes all the multi functions to check if the current context requires > > errors to be printed or not using the quiet member. > > > > Signed-off-by: Tejas Vipin > > --- > > drivers/gpu/drm

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-24 Thread Maxime Ripard
On Tue, Jul 23, 2024 at 08:57:03PM GMT, Conor Dooley wrote: > On Tue, Jul 23, 2024 at 05:17:12PM +0200, Marc Gonzalez wrote: > > On 27/06/2024 18:25, Conor Dooley wrote: > > > > > On Thu, Jun 27, 2024 at 01:13:03PM +0200, Marc Gonzalez wrote: > > > > > >> TDP158 is an AC-coupled DVI / HDMI to TMDS

[PULL] drm-misc-next-fixes

2024-07-19 Thread Maxime Ripard
Hi, Here's this week drm-misc-next-fixes PR Thanks! Maxime drm-misc-next-fixes-2024-07-19: Two fixes for v3d to fix an array indexing on newer V3D revisions. The following changes since commit c537fb4e3d36e7cd1a0837dd577cd30d3d64f1bc: drm/qxl: Pin buffer objects for internal mappings (2024-07

Re: [PATCH 02/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine

2024-07-18 Thread Maxime Ripard
On Tue, Jul 09, 2024 at 08:50:35AM GMT, Krzysztof Kozlowski wrote: > On 08/07/2024 16:52, Maxime Ripard wrote: > > On Mon, Jul 08, 2024 at 04:04:21PM GMT, Krzysztof Kozlowski wrote: > >> On 08/07/2024 08:40, Liu Ying wrote: > >>>>> + > >>>>>

Re: [PATCH v4 2/5] drm/drm_property: require DRM_MODE_PROP_IMMUTABLE for single-value props

2024-07-17 Thread Maxime Ripard
Hi, On Mon, Jul 15, 2024 at 09:33:02AM GMT, Dmitry Baryshkov wrote: > Document that DRM_MODE_PROP_IMMUTABLE must be set for the properties > that are immutable by definition - e.g. ranges with min == max or enums > with a single value. This matches the behaviour of the IGT tests, see > kms_propert

Re: [PATCH v4 3/5] drm/connector: automatically set immutable flag for max_bpc property

2024-07-16 Thread Maxime Ripard
t the > flag if the driver asks for the max_bpc property with min == max. > > Fixes: aadb3e16b8f3 ("drm/connector: hdmi: Add output BPC to the connector > state") > Signed-off-by: Dmitry Baryshkov Assuming that someone on the uapi sides agrees to patch 3: Acked-by: Maxime

Re: [PATCH v4 4/5] drm/bridge-connector: move to DRM_DISPLAY_HELPER module

2024-07-16 Thread Maxime Ripard
On Mon, 15 Jul 2024 09:33:04 +0300, Dmitry Baryshkov wrote: > drm_bridge_connector is a "leaf" driver, belonging to the display > helper, rather than the "CRTC" drm_kms_helper module. Move the driver > to the drm/display and add necessary Kconfig selection clauses. >

Re: [PATCH v4 5/5] drm/bridge-connector: reset the HDMI connector state

2024-07-16 Thread Maxime Ripard
; properties. > > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-16 Thread Maxime Ripard
Hi, On Mon, Jul 15, 2024 at 07:38:34PM GMT, Dmitry Baryshkov wrote: > On Mon, 15 Jul 2024 at 17:42, Maxime Ripard wrote: > > > > On Mon, Jul 08, 2024 at 11:29:46PM GMT, Dmitry Baryshkov wrote: > > > On Mon, Jul 08, 2024 at 04:59:23PM GMT, Maxime Ripard wrote: > >

Re: [PATCH 2/7] drm/probe-helper: Optionally report single connected output per CRTC

2024-07-16 Thread Maxime Ripard
Hi, On Mon, Jul 15, 2024 at 11:38:58AM GMT, Thomas Zimmermann wrote: > For CRTCs with multiple outputs (i.e., encoders plus connectors), > only report at most a single connected output to userspace. Make > this configurable via CONFIG_DRM_REPORT_SINGLE_CONNECTED_CRTC_OUTPUT. > > Having multiple c

Re: [PATCH 1/7] drm/probe-helper: Call connector detect functions in single helper

2024-07-16 Thread Maxime Ripard
On Mon, 15 Jul 2024 11:38:57 +0200, Thomas Zimmermann wrote: > Move the logic to call the connector's detect helper into a single > internal function. Reduces code dupliction. > > Signed-off-by: Thomas Zimmermann Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-15 Thread Maxime Ripard
On Mon, Jul 08, 2024 at 11:29:46PM GMT, Dmitry Baryshkov wrote: > On Mon, Jul 08, 2024 at 04:59:23PM GMT, Maxime Ripard wrote: > > On Mon, Jul 01, 2024 at 05:36:18PM GMT, Marc Gonzalez wrote: > > > On 01/07/2024 15:50, Maxime Ripard wrote: > > > > > > >

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-15 Thread Maxime Ripard
On Thu, Jul 04, 2024 at 07:04:41PM GMT, Marc Gonzalez wrote: > On 01/07/2024 15:50, Maxime Ripard wrote: > > > The i2c register access (and the whole behaviour of the device) is > > constrained on the I2C_EN pin status, and you can't read it from the > > device, so i

[PULL] drm-misc-next-fixes

2024-07-11 Thread Maxime Ripard
event unpinned buffer access under certain conditions. Douglas Anderson (1): drm/panel: sharp-lq101r1sx01: Fixed reversed "if" in remove Maxime Ripard (1): Merge drm-misc-next-2024-07-04 into drm-misc-next-fixes

Re: [PATCH] drm/rockchip: cdn-dp: Remove redundant workarounds for firmware loading

2024-07-11 Thread Maxime Ripard
On Wed, Jul 10, 2024 at 04:22:12PM GMT, Dragan Simic wrote: > Hello Maxime, > > On 2024-07-10 09:13, Maxime Ripard wrote: > > On Tue, Jul 09, 2024 at 06:36:08PM GMT, Dragan Simic wrote: > > > > > > > As I already wrote earlier, and as the above-linked discuss

Re: [PATCH 0/8] dma-buf: heaps: Support carved-out heaps and ECC related-flags

2024-07-10 Thread Maxime Ripard
On Fri, Jul 05, 2024 at 04:31:34PM GMT, Thierry Reding wrote: > On Thu, Jul 04, 2024 at 02:24:49PM GMT, Maxime Ripard wrote: > > On Fri, Jun 28, 2024 at 04:42:35PM GMT, Thierry Reding wrote: > > > On Fri, Jun 28, 2024 at 03:08:46PM GMT, Maxime Ripard wrote: > > > > Hi

Re: [PATCH] drm/rockchip: cdn-dp: Remove redundant workarounds for firmware loading

2024-07-10 Thread Maxime Ripard
On Tue, Jul 09, 2024 at 06:36:08PM GMT, Dragan Simic wrote: > > > > > As I already wrote earlier, and as the above-linked discussions > > > > > conclude, solving these issues doesn't belong to any specific driver. > > > > > It should be resolved within the kernel's firmware loading mechanism > > >

Re: [PATCH v1] drm/rockchip: rk3066_hdmi: change to bridge driver mode

2024-07-10 Thread Maxime Ripard
Hi, On Tue, Jul 09, 2024 at 08:01:26PM GMT, Johan Jonker wrote: > Change rk3066_hdmi.c to bridge driver mode. > > Signed-off-by: Johan Jonker Generally speaking, I think you should use the new HDMI bridge infrastructure that recently landed in drm-misc-next. Maxime signature.asc Description:

Re: [PATCH] drm/rockchip: cdn-dp: Remove redundant workarounds for firmware loading

2024-07-09 Thread Maxime Ripard
On Tue, Jul 09, 2024 at 12:10:51PM GMT, Dragan Simic wrote: > On 2024-07-09 11:10, Andy Yan wrote: > > At 2024-07-09 16:17:06, "Dragan Simic" wrote: > > > On 2024-07-08 09:46, Andy Yan wrote: > > > > At 2024-07-04 18:35:42, "Dragan Simic" wrote: > > > > > On 2024-07-04 04:10, Andy Yan wrote: > >

Re: (subset) [PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-07-09 Thread Maxime Ripard
On Tue, 02 Jul 2024 16:30:16 +0200, Sebastian Wick wrote: > The initial idea of the Colorspace prop was that this maps 1:1 to > InfoFrames/SDP but KMS does not give user space enough information nor > control over the output format to figure out which variants can be used > for a given KMS commit.

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-08 Thread Maxime Ripard
On Mon, Jul 01, 2024 at 05:36:18PM GMT, Marc Gonzalez wrote: > On 01/07/2024 15:50, Maxime Ripard wrote: > > > On Thu, Jun 27, 2024 at 01:13:03PM GMT, Marc Gonzalez wrote: > > > >> TDP158 is an AC-coupled DVI / HDMI to TMDS level shifting Redriver. > >> It

Re: [PATCH] MAINTAINERS: drm/sti: mark it as Odd Fixes

2024-07-08 Thread Maxime Ripard
On Fri, Jul 05, 2024 at 05:14:36PM GMT, Alain Volmat wrote: > Hi Krzysztof, Daniel, and Maxime, > > On Fri, Jul 05, 2024 at 03:41:26PM +0200, Daniel Vetter wrote: > > On Fri, Jul 05, 2024 at 01:33:38PM +0200, Krzysztof Kozlowski wrote: > > > On 05/07/2024 13:22, Maxime

Re: [PATCH 02/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine

2024-07-08 Thread Maxime Ripard
On Mon, Jul 08, 2024 at 04:04:21PM GMT, Krzysztof Kozlowski wrote: > On 08/07/2024 08:40, Liu Ying wrote: > >>> + > >>> + "^framegen@[0-9a-f]+$": > >>> +type: object > >>> +additionalProperties: true > >>> + > >>> +properties: > >>> + compatible: > >>> +const: fsl,imx8qxp-

Re: [PATCH v3 9/9] drm/tests: Add test for drm_framebuffer_free()

2024-07-08 Thread Maxime Ripard
On Wed, 3 Jul 2024 14:22:28 -0300, Carlos Eduardo Gallo Filho wrote: > Add a single KUnit test case for the drm_framebuffer_free function. > > Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 8/9] drm/tests: Add test for drm_framebuffer_init()

2024-07-08 Thread Maxime Ripard
On Wed, Jul 03, 2024 at 02:22:27PM GMT, Carlos Eduardo Gallo Filho wrote: > Add three KUnit test cases for the drm_framebuffer_init function: > > 1. Test if expected values are being set after drm_framebuffer_init() call. > 2. Try to init a framebuffer without setting its format. > 3. Try calling

Re: [PATCH v3 7/9] drm/tests: Add test for drm_framebuffer_lookup()

2024-07-08 Thread Maxime Ripard
amebuffer. > > Signed-off-by: Carlos Eduardo Gallo Filho > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 6/9] drm/tests: Add test for drm_framebuffer_cleanup()

2024-07-08 Thread Maxime Ripard
On Wed, 3 Jul 2024 14:22:25 -0300, Carlos Eduardo Gallo Filho wrote: > Add a single KUnit test case for the drm_framebuffer_cleanup function. > > Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 5/9] drm/tests: Add test for drm_framebuffer_check_src_coords()

2024-07-08 Thread Maxime Ripard
On Wed, 3 Jul 2024 14:22:24 -0300, Carlos Eduardo Gallo Filho wrote: > Add a parametrized test for the drm_framebuffer_check_src_coords function. > > Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 4/9] drm/tests: Add test case for drm_internal_framebuffer_create()

2024-07-08 Thread Maxime Ripard
On Wed, Jul 03, 2024 at 02:22:23PM GMT, Carlos Eduardo Gallo Filho wrote: > Introduce a test to cover the creation of framebuffer with > modifier on a device that doesn't support it. > > Signed-off-by: Carlos Eduardo Gallo Filho > --- > v2: > - Reorder kunit cases alphabetically. > v3: > - Re

Re: [PATCH v3 3/9] drm/tests: Replace strcpy to strscpy on drm_test_framebuffer_create test

2024-07-08 Thread Maxime Ripard
On Wed, 3 Jul 2024 14:22:22 -0300, Carlos Eduardo Gallo Filho wrote: > Replace the use of strcpy to strscpy on the test_to_desc of the > drm_test_framebuffer_create test for better security and reliability. > > Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 2/9] drm/tests: Add parameters to the drm_test_framebuffer_create test

2024-07-08 Thread Maxime Ripard
nexistent plane > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 1/9] drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests

2024-07-08 Thread Maxime Ripard
mocks > over the tests in a cleaner way than using dev_private void pointer. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH] drm/rockchip: cdn-dp: Remove redundant workarounds for firmware loading

2024-07-08 Thread Maxime Ripard
On Mon, Jul 08, 2024 at 03:46:16PM GMT, Andy Yan wrote: > > Hi Dragan, > At 2024-07-04 18:35:42, "Dragan Simic" wrote: > >Hello Andy, > > > >On 2024-07-04 04:10, Andy Yan wrote: > >> At 2024-07-04 07:32:02, "Dragan Simic" wrote: > >>> After the additional firmware-related module information was

Re: [PATCH] drm: renesas: shmobile: shmo_drm_crtc: Fix PM imbalance if RPM_ACTIVE is true

2024-07-08 Thread Maxime Ripard
Hi, On Mon, Jul 08, 2024 at 09:27:09AM GMT, Biju Das wrote: > The pm_runtime_resume_and_get() returns 1 if RPM is active, in this > case it won't call a put. This will result in PM imbalance as it > treat this as an error and propagate this to caller and the caller > never calls corresponding put(

Re: [PATCH v6] drm/display: split DSC helpers from DP helpers

2024-07-05 Thread Maxime Ripard
plit the DSC code to be guarded by the separate > DRM_DISPLAY_DSC_HELPER Kconfig symbol. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH] MAINTAINERS: drm/sti: mark it as Odd Fixes

2024-07-05 Thread Maxime Ripard
On Fri, Jul 05, 2024 at 01:19:50PM GMT, Daniel Vetter wrote: > On Fri, Jul 05, 2024 at 12:03:56PM +0200, Krzysztof Kozlowski wrote: > > Patches to STI DRM are not being picked up, so even though there is > > maintainer activity, it seems that these drivers are not being actively > > looked at. Ref

Re: [PATCH 1/4] drm/sti: dvo: drop driver owner assignment

2024-07-05 Thread Maxime Ripard
On Sat, 30 Mar 2024 21:38:28 +0100, Krzysztof Kozlowski wrote: > Core in platform_driver_register() already sets the .owner, so driver > does not need to. Whatever is set here will be anyway overwritten by > main driver calling platform_driver_register(). > > Applied to misc/kernel.git (drm-mis

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

2024-07-05 Thread Maxime Ripard
+Alain On Tue, Jun 04, 2024 at 03:18:55PM GMT, Krzysztof Kozlowski wrote: > On 27/05/2024 16:47, Alain Volmat wrote: > > Hi Krzysztof, > > > > thanks for your patch, sorry for the delay. > > > > On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote: > >> Core in platform_driver_reg

[PULL] drm-misc-next

2024-07-04 Thread Maxime Ripard
Hi, Here's this week drm-misc-next PR, and the last PR for the 6.11 release cycle. Thanks! Maxime drm-misc-next-2024-07-04: drm-misc-next for $kernel-version: UAPI Changes: Cross-subsystem Changes: Core Changes: - dp/mst: Fix daisy-chaining at resume - dsc: Add helper to dump the DSC conf

Re: [PATCH v3 4/4] drm/bridge-connector: reset the HDMI connector state

2024-07-04 Thread Maxime Ripard
R > config DRM_BRIDGE_CONNECTOR > bool > depends on DRM && DRM_BRIDGE && DRM_DISPLAY_HELPER > + select DRM_DISPLAY_HDMI_STATE_HELPER Sorry, I notice it on that patch, but it's really on the previous one: both DRM_BRIDGE and DRM_DISPLAY_HELPER are meant to be selected, not depended on. Otherwise, Reviewed-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v3 3/4] drm/bridge-connector: move to DRM_DISPLAY_HELPER module

2024-07-04 Thread Maxime Ripard
On Tue, Jul 02, 2024 at 12:48:54PM GMT, Dmitry Baryshkov wrote: > drm_bridge_connector is a "leaf" driver, belonging to the display > helper, rather than the "CRTC" drm_kms_helper module. Move the driver > to the drm/display and add necessary Kconfig selection claus

  1   2   3   4   5   6   7   8   9   10   >