[PATCH 0/7] [RFC] drm/exynos: Add IOMMU support to DRM

2012-07-13 Thread Subash Patel
On 07/13/2012 12:09 PM, Inki Dae wrote: > >> -Original Message- >> From: Prathyush K [mailto:prathyush.k at samsung.com] >> Sent: Wednesday, July 11, 2012 6:40 PM >> To: dri-devel at lists.freedesktop.org >> Cc: prathyush at chromium.org; m.szyprowski at samsung.com; > inki.dae at

Re: [PATCH 0/7] [RFC] drm/exynos: Add IOMMU support to DRM

2012-07-13 Thread Subash Patel
On 07/13/2012 12:09 PM, Inki Dae wrote: -Original Message- From: Prathyush K [mailto:prathyus...@samsung.com] Sent: Wednesday, July 11, 2012 6:40 PM To: dri-devel@lists.freedesktop.org Cc: prathy...@chromium.org; m.szyprow...@samsung.com; inki@samsung.com;

[PATCH 2/2] DRM: Exynos: check for null in return value of dma_buf_map_attachment()

2012-06-25 Thread Subash Patel
From: Subash Patel <subash...@samsung.com> dma_buf_map_attachment() can return NULL and valid sg as return value. Hence the check for the returned scatter-gather must be using the inline function IS_ERR_OR_NULL() in place of IS_ERR() Change-Id: I33218480e220f6a26a1e726b336bf533a95363de

[PATCH 1/2] DRM: Exynos: return NULL if exynos_pages_to_sg fails

2012-06-25 Thread Subash Patel
From: Subash Patel <subash...@samsung.com> exynos_pages_to_sg() internally calls sg_kmalloc() which can return no pages when the system is under high memory crunch. One such instance is chromeos-install in the chromeos. This patch adds check for the return value of the function in s

[PATCH 0/2] Add return value checks in the drm-dmabuf

2012-06-25 Thread Subash Patel
From: Subash Patel <subash...@samsung.com> This patch series is split and re-send of my original patch, after request from Inki Dae. Below two patches add the required error checks in drm dmabuf when the system fails to allocate pages for the scatter-gather. This is very rare sit

[PATCH 2/2] DRM: Exynos: check for null in return value of dma_buf_map_attachment()

2012-06-25 Thread Subash Patel
From: Subash Patel <subash...@samsung.com> dma_buf_map_attachment() can return NULL and valid sg as return value. Hence the check for the returned scatter-gather must be using the inline function IS_ERR_OR_NULL() in place of IS_ERR() Change-Id: I33218480e220f6a26a1e726b336bf533a95363de

[PATCH 1/2] DRM: Exynos: return NULL if exynos_pages_to_sg fails

2012-06-25 Thread Subash Patel
From: Subash Patel <subash...@samsung.com> exynos_pages_to_sg() internally calls sg_kmalloc() which can return no pages when the system is under high memory crunch. One such instance is chromeos-install in the chromeos. This patch adds check for the return value of the function in s

[PATCH 1/2] DRM: Exynos: return NULL if exynos_pages_to_sg fails

2012-06-25 Thread Subash Patel
From: Subash Patel subash...@samsung.com exynos_pages_to_sg() internally calls sg_kmalloc() which can return no pages when the system is under high memory crunch. One such instance is chromeos-install in the chromeos. This patch adds check for the return value of the function in subject to return

[PATCH 2/2] DRM: Exynos: check for null in return value of dma_buf_map_attachment()

2012-06-25 Thread Subash Patel
From: Subash Patel subash...@samsung.com dma_buf_map_attachment() can return NULL and valid sg as return value. Hence the check for the returned scatter-gather must be using the inline function IS_ERR_OR_NULL() in place of IS_ERR() Change-Id: I33218480e220f6a26a1e726b336bf533a95363de Signed-off

[PATCH 0/2] Add return value checks in the drm-dmabuf

2012-06-25 Thread Subash Patel
From: Subash Patel subash...@samsung.com This patch series is split and re-send of my original patch, after request from Inki Dae. Below two patches add the required error checks in drm dmabuf when the system fails to allocate pages for the scatter-gather. This is very rare situation, and occurs

[PATCH 1/2] DRM: Exynos: return NULL if exynos_pages_to_sg fails

2012-06-25 Thread Subash Patel
From: Subash Patel subash...@samsung.com exynos_pages_to_sg() internally calls sg_kmalloc() which can return no pages when the system is under high memory crunch. One such instance is chromeos-install in the chromeos. This patch adds check for the return value of the function in subject to return

[PATCH 2/2] DRM: Exynos: check for null in return value of dma_buf_map_attachment()

2012-06-25 Thread Subash Patel
From: Subash Patel subash...@samsung.com dma_buf_map_attachment() can return NULL and valid sg as return value. Hence the check for the returned scatter-gather must be using the inline function IS_ERR_OR_NULL() in place of IS_ERR() Change-Id: I33218480e220f6a26a1e726b336bf533a95363de Signed-off

Re: [PATCH] DRM: exynos: return NULL if exynos_pages_to_sg fails

2012-06-23 Thread Subash Patel (ಸುಭಾಷ್)
Hi Olof, I will then rework this patch commit message and send it. I will copy Samsung-soc list (dri-devel is already in copy) Regards, Subash On 06/22/2012 05:47 PM, Olof Johansson wrote: Hi, On Fri, Jun 22, 2012 at 5:41 PM, Subash Patel subas...@gmail.com mailto:subas...@gmail.com wrote

[PATCH] DRM: exynos: return NULL if exynos_pages_to_sg fails

2012-06-23 Thread Subash Patel
From: Subash Patel subash...@samsung.com exynos_pages_to_sg() internally calls sg_kmalloc() which can return no pages when the system is under high memory crunch. One such instance is chromeos-install in the chromeos. This patch adds check for the return value of the function in subject to return

[PATCH] DRM: exynos: return NULL if exynos_pages_to_sg fails

2012-06-22 Thread Subash Patel
From: Subash Patel <subash...@samsung.com> exynos_pages_to_sg() internally calls sg_kmalloc() which can return no pages when the system is under high memory crunch. One such instance is chromeos-install in the chromeos. This patch adds check for the return value of the function in s

[PATCH] DRM: exynos: return NULL if exynos_pages_to_sg fails

2012-06-22 Thread &quot;Subash Patel (ಸುಭಾಷ್)"
Hi Olof, I will then rework this patch commit message and send it. I will copy Samsung-soc list (dri-devel is already in copy) Regards, Subash On 06/22/2012 05:47 PM, Olof Johansson wrote: > Hi, > > On Fri, Jun 22, 2012 at 5:41 PM, Subash Patel <mailto:subashrp at gmail

[PATCH] DRM: exynos: return NULL if exynos_pages_to_sg fails

2012-06-22 Thread Subash Patel
From: Subash Patel <subash...@samsung.com> exynos_pages_to_sg() internally calls sg_kmalloc() which can return no pages when the system is under high memory crunch. One such instance is chromeos-install in the chromeos. This patch adds check for the return value of the function in s

Re: [PATCH 04/12] v4l: vb2-dma-contig: add setup of sglist for MMAP buffers

2012-06-12 Thread Subash Patel
Hi Laurent, Tomasz, On 06/10/2012 11:28 PM, Laurent Pinchart wrote: Hi Tomasz, On Friday 08 June 2012 16:31:31 Tomasz Stanislawski wrote: Hi Laurent and Subash, I confirm the issue found by Subash. The function vb2_dc_kaddr_to_pages does fail for some occasions. The failures are rather

[PATCH 04/12] v4l: vb2-dma-contig: add setup of sglist for MMAP buffers

2012-06-11 Thread Subash Patel
Hi Laurent, Tomasz, On 06/10/2012 11:28 PM, Laurent Pinchart wrote: > Hi Tomasz, > > On Friday 08 June 2012 16:31:31 Tomasz Stanislawski wrote: >> Hi Laurent and Subash, >> >> I confirm the issue found by Subash. The function vb2_dc_kaddr_to_pages does >> fail for some occasions. The failures are

Re: [PATCH 04/12] v4l: vb2-dma-contig: add setup of sglist for MMAP buffers

2012-06-08 Thread Subash Patel
. Hence I created a patch(attached) which is based on [1] series. One can apply it for using your present patch-set in the meantime. Regards, Subash [1] http://www.spinics.net/lists/kernel/msg1343092.html From f9b2eace2eef0038a1830e5e6dd55f3bb6017e1a Mon Sep 17 00:00:00 2001 From: Subash Patel

[PATCH 04/12] v4l: vb2-dma-contig: add setup of sglist for MMAP buffers

2012-06-07 Thread Subash Patel
Hello Tomasz, On 06/07/2012 06:06 AM, Laurent Pinchart wrote: > Hi Tomasz, > > On Wednesday 06 June 2012 13:56:42 Tomasz Stanislawski wrote: >> On 06/06/2012 10:06 AM, Laurent Pinchart wrote: >>> On Wednesday 23 May 2012 15:07:27 Tomasz Stanislawski wrote: This patch adds the setup of sglist

[PATCH] v4l2: vb2: use dma_get_sgtable

2012-06-07 Thread Subash Patel
, the later call was temporary patch until dma-mapping author finalizes the implementation of dma_get_sgtable(). One can use this patch to use this vb2 patch-set for his/her work in the meantime. Signed-off-by: Subash Patel --- drivers/media/video/videobuf2-dma-contig.c | 53

[PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-05-09 Thread Subash Patel
Hello Tomasz, Laurent, I have printed some logs during the dmabuf export and attach for the SGT issue below. Please find it in the attachment. I hope it will be useful. Regards, Subash On 05/08/2012 04:45 PM, Subash Patel wrote: > Hi Laurent, > > On 05/08/2012 02:44 PM, Laurent Pinch

Re: [PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-05-09 Thread Subash Patel
Hi Laurent, On 05/08/2012 02:44 PM, Laurent Pinchart wrote: Hi Subash, On Monday 07 May 2012 20:08:25 Subash Patel wrote: Hello Thomasz, Laurent, I found an issue in the function vb2_dc_pages_to_sgt() below. I saw that during the attach, the size of the SGT and size requested mis-matched

Re: [PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-05-09 Thread Subash Patel
Hello Tomasz, Laurent, I have printed some logs during the dmabuf export and attach for the SGT issue below. Please find it in the attachment. I hope it will be useful. Regards, Subash On 05/08/2012 04:45 PM, Subash Patel wrote: Hi Laurent, On 05/08/2012 02:44 PM, Laurent Pinchart wrote

[PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-05-08 Thread Subash Patel
Hi Thomasz, I have extended the MFC-FIMC testcase posted by Kamil sometime ago to sanity test the UMM patches. This test is multi-threaded(further explanation for developers who may not have seen it yet), where thread one parses the encoded stream and feeds into the codec IP driver(aka MFC

Re: [PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-05-08 Thread Subash Patel
Hello Thomasz, Laurent, I found an issue in the function vb2_dc_pages_to_sgt() below. I saw that during the attach, the size of the SGT and size requested mis-matched (by atleast 8k bytes). Hence I made a small correction to the code as below. I could then attach the importer properly.

Re: [PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-05-08 Thread Subash Patel
Hi Thomasz, I have extended the MFC-FIMC testcase posted by Kamil sometime ago to sanity test the UMM patches. This test is multi-threaded(further explanation for developers who may not have seen it yet), where thread one parses the encoded stream and feeds into the codec IP driver(aka MFC

[PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-05-07 Thread Subash Patel
Hello Thomasz, Laurent, I found an issue in the function vb2_dc_pages_to_sgt() below. I saw that during the attach, the size of the SGT and size requested mis-matched (by atleast 8k bytes). Hence I made a small correction to the code as below. I could then attach the importer properly.

Linux 3.4-rc1

2012-04-04 Thread Subash Patel
On 04/02/2012 02:11 PM, Daniel Vetter wrote: > On Mon, Apr 02, 2012 at 12:40:39PM +0900, Kyungmin Park wrote: >> On Mon, Apr 2, 2012 at 12:34 AM, Rob Clark wrote: >>> On Sat, Mar 31, 2012 at 6:58 PM, Linus Torvalds >>> wrote: - drm dma-buf prime support. Dave Airlie sent me the pull

Re: Linux 3.4-rc1

2012-04-04 Thread Subash Patel
On 04/02/2012 02:11 PM, Daniel Vetter wrote: On Mon, Apr 02, 2012 at 12:40:39PM +0900, Kyungmin Park wrote: On Mon, Apr 2, 2012 at 12:34 AM, Rob Clarkrob.cl...@linaro.org wrote: On Sat, Mar 31, 2012 at 6:58 PM, Linus Torvalds torva...@linux-foundation.org wrote: - drm dma-buf prime

Re: [Linaro-mm-sig] [RFCv2 PATCH 2/9] v4l: vb2-dma-contig: update and code refactoring

2012-03-23 Thread Subash Patel
Hello Thomasz, Marek, I found an issue with below patch. Please read below. On 03/13/2012 03:47 PM, Tomasz Stanislawski wrote: This patch combines updates and fixes to dma-contig allocator. Moreover the allocator code was refactored. The most important changes are: - functions were reordered -

Re: [Linaro-mm-sig] [RFCv2 PATCH 4/9] v4l: add buffer exporting via dmabuf

2012-03-23 Thread Subash Patel
Hi Thomasz, On 03/22/2012 04:46 PM, Laurent Pinchart wrote: Hi Tomasz, Thanks for the patch. On Tuesday 13 March 2012 11:17:02 Tomasz Stanislawski wrote: This patch adds extension to V4L2 api. It allow to export a mmap buffer as file descriptor. New ioctl VIDIOC_EXPBUF is added. It takes a

Re: [Linaro-mm-sig] [RFCv2 PATCH 2/9 - 4/4] v4l: vb2-dma-contig: update and code refactoring

2012-03-23 Thread Subash Patel
Hi Laurent, On 03/22/2012 08:12 PM, Laurent Pinchart wrote: Hi Tomasz, On Thursday 22 March 2012 14:36:33 Tomasz Stanislawski wrote: Hi Laurent, Thank you very much for your comments and question. They were very useful. You're welcome. Please refer to the comments below. On 03/22/2012

Re: [Linaro-mm-sig] [RFCv2 PATCH 4/9] v4l: add buffer exporting via dmabuf

2012-03-23 Thread Subash Patel
On 03/22/2012 07:37 PM, Laurent Pinchart wrote: Hi Subash, On Thursday 22 March 2012 19:27:01 Subash Patel wrote: On 03/22/2012 04:46 PM, Laurent Pinchart wrote: On Tuesday 13 March 2012 11:17:02 Tomasz Stanislawski wrote: [snip] diff --git a/include/linux/videodev2.h b/include/linux

[Linaro-mm-sig] [RFCv2 PATCH 4/9] v4l: add buffer exporting via dmabuf

2012-03-22 Thread Subash Patel
On 03/22/2012 07:37 PM, Laurent Pinchart wrote: > Hi Subash, > > On Thursday 22 March 2012 19:27:01 Subash Patel wrote: >> On 03/22/2012 04:46 PM, Laurent Pinchart wrote: >>> On Tuesday 13 March 2012 11:17:02 Tomasz Stanislawski wrote: > > [snip] > >>>

[Linaro-mm-sig] [RFCv2 PATCH 2/9 - 4/4] v4l: vb2-dma-contig: update and code refactoring

2012-03-22 Thread Subash Patel
Hi Laurent, On 03/22/2012 08:12 PM, Laurent Pinchart wrote: > Hi Tomasz, > > On Thursday 22 March 2012 14:36:33 Tomasz Stanislawski wrote: >> Hi Laurent, >> Thank you very much for your comments and question. >> They were very useful. > > You're welcome. > >> Please refer to the comments below.

[Linaro-mm-sig] [RFCv2 PATCH 4/9] v4l: add buffer exporting via dmabuf

2012-03-22 Thread Subash Patel
Hi Thomasz, On 03/22/2012 04:46 PM, Laurent Pinchart wrote: > Hi Tomasz, > > Thanks for the patch. > > On Tuesday 13 March 2012 11:17:02 Tomasz Stanislawski wrote: >> This patch adds extension to V4L2 api. It allow to export a mmap buffer as >> file descriptor. New ioctl VIDIOC_EXPBUF is added.

[Linaro-mm-sig] [RFCv2 PATCH 2/9] v4l: vb2-dma-contig: update and code refactoring

2012-03-22 Thread Subash Patel
Hello Thomasz, Marek, I found an issue with below patch. Please read below. On 03/13/2012 03:47 PM, Tomasz Stanislawski wrote: > This patch combines updates and fixes to dma-contig allocator. > Moreover the allocator code was refactored. > The most important changes are: > - functions were