Re: [PATCH 00/12] Clean up drm_pci.{c,h}
On Tue, Dec 3, 2019 at 5:04 AM Thomas Zimmermann wrote:
>
> This patchset cleans up drm_pci.{c,h}. Patch 1 removes drm_pci.c from
> non-PCI builds. Declarations of legacy functions are hidden in drm_legacy.h
> and their implementation is protected by CONFIG_PCI in patch 2. The rest
> of the patches replace unnecessary include statements for drm_pci.h. Most
> of the source files only require .
>
> The pathset was built on x86-64 and aarch64 with PCI support and arm
> without PCI support.
Series is:
Reviewed-by: Alex Deucher
>
> Thomas Zimmermann (12):
> drm/pci: Only build drm_pci.c if CONFIG_PCI is set
> drm/pci: Hide legacy PCI functions from non-legacy code
> drm/ast: Don't include
> drm/i810: Don't include
> drm/mga: Don't include
> drm/mgag200: Don't include
> drm/r128: Don't include
> drm/radeon: Don't include
> drm/savage: Don't include
> drm/sis: Don't include
> drm/tdfx: Don't include
> drm/via: Don't include
>
> drivers/gpu/drm/Makefile | 3 +-
> drivers/gpu/drm/ast/ast_drv.c | 1 -
> drivers/gpu/drm/drm_internal.h| 22 ++
> drivers/gpu/drm/drm_pci.c | 17 +++
> drivers/gpu/drm/i810/i810_dma.c | 2 +-
> drivers/gpu/drm/i810/i810_drv.c | 3 +-
> drivers/gpu/drm/mga/mga_drv.h | 2 +-
> drivers/gpu/drm/mgag200/mgag200_cursor.c | 2 +-
> drivers/gpu/drm/mgag200/mgag200_i2c.c | 3 +-
> drivers/gpu/drm/mgag200/mgag200_main.c| 3 +-
> drivers/gpu/drm/mgag200/mgag200_mode.c| 2 +-
> drivers/gpu/drm/mgag200/mgag200_ttm.c | 2 +-
> drivers/gpu/drm/r128/r128_drv.c | 2 +-
> drivers/gpu/drm/radeon/atom.h | 1 +
> drivers/gpu/drm/radeon/atombios_encoders.c| 2 +-
> drivers/gpu/drm/radeon/btc_dpm.c | 3 +-
> drivers/gpu/drm/radeon/ci_dpm.c | 3 +-
> drivers/gpu/drm/radeon/cik.c | 4 +--
> drivers/gpu/drm/radeon/cypress_dpm.c | 2 +-
> drivers/gpu/drm/radeon/evergreen.c| 2 +-
> drivers/gpu/drm/radeon/kv_dpm.c | 3 +-
> drivers/gpu/drm/radeon/ni.c | 4 +--
> drivers/gpu/drm/radeon/ni_dpm.c | 3 +-
> drivers/gpu/drm/radeon/r100.c | 6 ++--
> drivers/gpu/drm/radeon/r300.c | 2 +-
> drivers/gpu/drm/radeon/r420.c | 2 +-
> drivers/gpu/drm/radeon/r600.c | 6 ++--
> drivers/gpu/drm/radeon/radeon_agp.c | 3 +-
> drivers/gpu/drm/radeon/radeon_asic.c | 2 +-
> drivers/gpu/drm/radeon/radeon_atombios.c | 3 +-
> drivers/gpu/drm/radeon/radeon_bios.c | 4 +--
> drivers/gpu/drm/radeon/radeon_clocks.c| 3 +-
> drivers/gpu/drm/radeon/radeon_combios.c | 3 +-
> drivers/gpu/drm/radeon/radeon_cs.c| 2 +-
> drivers/gpu/drm/radeon/radeon_device.c| 2 +-
> drivers/gpu/drm/radeon/radeon_display.c | 2 +-
> drivers/gpu/drm/radeon/radeon_encoders.c | 3 +-
> drivers/gpu/drm/radeon/radeon_fb.c| 2 +-
> drivers/gpu/drm/radeon/radeon_gart.c | 2 +-
> drivers/gpu/drm/radeon/radeon_gem.c | 3 +-
> drivers/gpu/drm/radeon/radeon_i2c.c | 2 +-
> drivers/gpu/drm/radeon/radeon_irq_kms.c | 2 +-
> drivers/gpu/drm/radeon/radeon_kms.c | 2 +-
> .../gpu/drm/radeon/radeon_legacy_encoders.c | 2 +-
> drivers/gpu/drm/radeon/radeon_pm.c| 2 +-
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> drivers/gpu/drm/radeon/rs600.c| 2 +-
> drivers/gpu/drm/radeon/rs690.c| 2 +-
> drivers/gpu/drm/radeon/rs780_dpm.c| 3 +-
> drivers/gpu/drm/radeon/rv770.c| 2 +-
> drivers/gpu/drm/radeon/si.c | 4 +--
> drivers/gpu/drm/radeon/si_dpm.c | 3 +-
> drivers/gpu/drm/radeon/trinity_dpm.c | 3 +-
> drivers/gpu/drm/savage/savage_drv.c | 2 +-
> drivers/gpu/drm/sis/sis_drv.c | 2 +-
> drivers/gpu/drm/tdfx/tdfx_drv.c | 2 +-
> drivers/gpu/drm/via/via_dmablit.c | 2 +-
> drivers/gpu/drm/via/via_drv.c | 2 +-
> drivers/gpu/drm/via/via_map.c | 3 +-
> include/drm/drm_legacy.h | 29 ++-
> include/drm/drm_pci.h | 19 ++--
> 61 files changed, 144 insertions(+), 89 deletions(-)
>
> --
> 2.23.0
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 00/12] Clean up drm_pci.{c,h}
Am 03.12.19 um 13:13 schrieb Sam Ravnborg: > Hi Thomas. > >> The rest >> of the patches replace unnecessary include statements for drm_pci.h. Most >> of the source files only require . > > I guess I am to blame here. When migrating away from drmP.h I used > as preferred way when there were pci related build > errors and when it worked I moved on. > Sorry for creating extra work for you, but glad to see it cleaned up. No problem, don't worry. :) > > Sam > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer signature.asc Description: OpenPGP digital signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 00/12] Clean up drm_pci.{c,h}
Hi Thomas. > The rest > of the patches replace unnecessary include statements for drm_pci.h. Most > of the source files only require . I guess I am to blame here. When migrating away from drmP.h I used as preferred way when there were pci related build errors and when it worked I moved on. Sorry for creating extra work for you, but glad to see it cleaned up. Sam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 00/12] Clean up drm_pci.{c,h}
On Tue, 3 Dec 2019 at 10:04, Thomas Zimmermann wrote:
>
> This patchset cleans up drm_pci.{c,h}. Patch 1 removes drm_pci.c from
> non-PCI builds. Declarations of legacy functions are hidden in drm_legacy.h
> and their implementation is protected by CONFIG_PCI in patch 2. The rest
> of the patches replace unnecessary include statements for drm_pci.h. Most
> of the source files only require .
>
> The pathset was built on x86-64 and aarch64 with PCI support and arm
> without PCI support.
>
> Thomas Zimmermann (12):
> drm/pci: Only build drm_pci.c if CONFIG_PCI is set
> drm/pci: Hide legacy PCI functions from non-legacy code
> drm/ast: Don't include
> drm/i810: Don't include
> drm/mga: Don't include
> drm/mgag200: Don't include
> drm/r128: Don't include
> drm/radeon: Don't include
> drm/savage: Don't include
> drm/sis: Don't include
> drm/tdfx: Don't include
> drm/via: Don't include
>
Slightly leaning about getting 01 <> 02 swapped, but regardless the series is:
Reviewed-by: Emil Velikov
-Emil
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 00/12] Clean up drm_pci.{c,h}
This patchset cleans up drm_pci.{c,h}. Patch 1 removes drm_pci.c from
non-PCI builds. Declarations of legacy functions are hidden in drm_legacy.h
and their implementation is protected by CONFIG_PCI in patch 2. The rest
of the patches replace unnecessary include statements for drm_pci.h. Most
of the source files only require .
The pathset was built on x86-64 and aarch64 with PCI support and arm
without PCI support.
Thomas Zimmermann (12):
drm/pci: Only build drm_pci.c if CONFIG_PCI is set
drm/pci: Hide legacy PCI functions from non-legacy code
drm/ast: Don't include
drm/i810: Don't include
drm/mga: Don't include
drm/mgag200: Don't include
drm/r128: Don't include
drm/radeon: Don't include
drm/savage: Don't include
drm/sis: Don't include
drm/tdfx: Don't include
drm/via: Don't include
drivers/gpu/drm/Makefile | 3 +-
drivers/gpu/drm/ast/ast_drv.c | 1 -
drivers/gpu/drm/drm_internal.h| 22 ++
drivers/gpu/drm/drm_pci.c | 17 +++
drivers/gpu/drm/i810/i810_dma.c | 2 +-
drivers/gpu/drm/i810/i810_drv.c | 3 +-
drivers/gpu/drm/mga/mga_drv.h | 2 +-
drivers/gpu/drm/mgag200/mgag200_cursor.c | 2 +-
drivers/gpu/drm/mgag200/mgag200_i2c.c | 3 +-
drivers/gpu/drm/mgag200/mgag200_main.c| 3 +-
drivers/gpu/drm/mgag200/mgag200_mode.c| 2 +-
drivers/gpu/drm/mgag200/mgag200_ttm.c | 2 +-
drivers/gpu/drm/r128/r128_drv.c | 2 +-
drivers/gpu/drm/radeon/atom.h | 1 +
drivers/gpu/drm/radeon/atombios_encoders.c| 2 +-
drivers/gpu/drm/radeon/btc_dpm.c | 3 +-
drivers/gpu/drm/radeon/ci_dpm.c | 3 +-
drivers/gpu/drm/radeon/cik.c | 4 +--
drivers/gpu/drm/radeon/cypress_dpm.c | 2 +-
drivers/gpu/drm/radeon/evergreen.c| 2 +-
drivers/gpu/drm/radeon/kv_dpm.c | 3 +-
drivers/gpu/drm/radeon/ni.c | 4 +--
drivers/gpu/drm/radeon/ni_dpm.c | 3 +-
drivers/gpu/drm/radeon/r100.c | 6 ++--
drivers/gpu/drm/radeon/r300.c | 2 +-
drivers/gpu/drm/radeon/r420.c | 2 +-
drivers/gpu/drm/radeon/r600.c | 6 ++--
drivers/gpu/drm/radeon/radeon_agp.c | 3 +-
drivers/gpu/drm/radeon/radeon_asic.c | 2 +-
drivers/gpu/drm/radeon/radeon_atombios.c | 3 +-
drivers/gpu/drm/radeon/radeon_bios.c | 4 +--
drivers/gpu/drm/radeon/radeon_clocks.c| 3 +-
drivers/gpu/drm/radeon/radeon_combios.c | 3 +-
drivers/gpu/drm/radeon/radeon_cs.c| 2 +-
drivers/gpu/drm/radeon/radeon_device.c| 2 +-
drivers/gpu/drm/radeon/radeon_display.c | 2 +-
drivers/gpu/drm/radeon/radeon_encoders.c | 3 +-
drivers/gpu/drm/radeon/radeon_fb.c| 2 +-
drivers/gpu/drm/radeon/radeon_gart.c | 2 +-
drivers/gpu/drm/radeon/radeon_gem.c | 3 +-
drivers/gpu/drm/radeon/radeon_i2c.c | 2 +-
drivers/gpu/drm/radeon/radeon_irq_kms.c | 2 +-
drivers/gpu/drm/radeon/radeon_kms.c | 2 +-
.../gpu/drm/radeon/radeon_legacy_encoders.c | 2 +-
drivers/gpu/drm/radeon/radeon_pm.c| 2 +-
drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
drivers/gpu/drm/radeon/rs600.c| 2 +-
drivers/gpu/drm/radeon/rs690.c| 2 +-
drivers/gpu/drm/radeon/rs780_dpm.c| 3 +-
drivers/gpu/drm/radeon/rv770.c| 2 +-
drivers/gpu/drm/radeon/si.c | 4 +--
drivers/gpu/drm/radeon/si_dpm.c | 3 +-
drivers/gpu/drm/radeon/trinity_dpm.c | 3 +-
drivers/gpu/drm/savage/savage_drv.c | 2 +-
drivers/gpu/drm/sis/sis_drv.c | 2 +-
drivers/gpu/drm/tdfx/tdfx_drv.c | 2 +-
drivers/gpu/drm/via/via_dmablit.c | 2 +-
drivers/gpu/drm/via/via_drv.c | 2 +-
drivers/gpu/drm/via/via_map.c | 3 +-
include/drm/drm_legacy.h | 29 ++-
include/drm/drm_pci.h | 19 ++--
61 files changed, 144 insertions(+), 89 deletions(-)
--
2.23.0
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
