Re: [PATCH 1/2] drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active

2020-10-02 Thread Maxime Ripard
On Thu, Sep 24, 2020 at 05:08:56PM +0900, Hoegeun Kwon wrote: > Hi Maxime, > > On 9/18/20 11:59 PM, Maxime Ripard wrote: > > The HVS has three FIFOs that can be assigned to a number of PixelValves > > through a mux. > > > > However, changing that FIFO requires that we disable and then enable the

Re: [PATCH 1/2] drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active

2020-10-01 Thread Maxime Ripard
On Thu, Sep 24, 2020 at 05:08:56PM +0900, Hoegeun Kwon wrote: > Hi Maxime, > > On 9/18/20 11:59 PM, Maxime Ripard wrote: > > The HVS has three FIFOs that can be assigned to a number of PixelValves > > through a mux. > > > > However, changing that FIFO requires that we disable and then enable the

Re: [PATCH 1/2] drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active

2020-09-24 Thread Hoegeun Kwon
Hi Maxime, On 9/18/20 11:59 PM, Maxime Ripard wrote: > The HVS has three FIFOs that can be assigned to a number of PixelValves > through a mux. > > However, changing that FIFO requires that we disable and then enable the > pixelvalve, so we want to assign FIFOs to all the enabled CRTCs, and not >

Re: [PATCH 1/2] drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active

2020-09-24 Thread Maxime Ripard
On Fri, Sep 18, 2020 at 04:43:20PM +0100, Dave Stevenson wrote: > Hi Maxime > > Thanks for the patch. > > On Fri, 18 Sep 2020 at 15:59, Maxime Ripard wrote: > > > > The HVS has three FIFOs that can be assigned to a number of PixelValves > > through a mux. > > > > However, changing that FIFO

[PATCH 1/2] drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active

2020-09-19 Thread Maxime Ripard
The HVS has three FIFOs that can be assigned to a number of PixelValves through a mux. However, changing that FIFO requires that we disable and then enable the pixelvalve, so we want to assign FIFOs to all the enabled CRTCs, and not just the active ones. Fixes: 87ebcd42fb7b ("drm/vc4: crtc:

Re: [PATCH 1/2] drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active

2020-09-18 Thread Dave Stevenson
Hi Maxime Thanks for the patch. On Fri, 18 Sep 2020 at 15:59, Maxime Ripard wrote: > > The HVS has three FIFOs that can be assigned to a number of PixelValves > through a mux. > > However, changing that FIFO requires that we disable and then enable the > pixelvalve, so we want to assign FIFOs