[Bug 109561] [regression, bisected] code re-factor causing games to stutter or lock-up system
https://bugs.freedesktop.org/show_bug.cgi?id=109561 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #8 from Timothy Arceri --- Updated fix pushed. No Mans Sky no longer hangs. Closing. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 109561] [regression, bisected] code re-factor causing games to stutter or lock-up system
https://bugs.freedesktop.org/show_bug.cgi?id=109561 --- Comment #7 from Marek Olšák --- The fix doesn't apply to master. Also, it would be nice to get it into 19.0 before it's released. (originally it should have been released today) -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 109561] [regression, bisected] code re-factor causing games to stutter or lock-up system
https://bugs.freedesktop.org/show_bug.cgi?id=109561 --- Comment #6 from Timothy Arceri --- (In reply to Nicolai Hähnle from comment #4) > Yeah, sorry, I wrote the patch directly on top of the offending commit for > testing purposes. Any chance you can send out the second fix for review? It seems to fix my issues. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 109561] [regression, bisected] code re-factor causing games to stutter or lock-up system
https://bugs.freedesktop.org/show_bug.cgi?id=109561 --- Comment #5 from Timothy Arceri --- (In reply to Nicolai Hähnle from comment #1) > Created attachment 143321 [details] [review] > fix some issues > > I cannot reproduce the hang, unfortunately. What hardware do you get the > hang with? > > There is some flickering on Polaris, which gets worse with the commit you > bisected this to. The attached patch reduces the flicker back to the > pre-commit level. Though it's essentially Marek's patch, plus an additional > minor fix. > > I have yet to try the Batman issue. I can confirm this patch fixes the hang in No Mans Sky. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 109561] [regression, bisected] code re-factor causing games to stutter or lock-up system
https://bugs.freedesktop.org/show_bug.cgi?id=109561 --- Comment #4 from Nicolai Hähnle --- Yeah, sorry, I wrote the patch directly on top of the offending commit for testing purposes. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 109561] [regression, bisected] code re-factor causing games to stutter or lock-up system
https://bugs.freedesktop.org/show_bug.cgi?id=109561 --- Comment #3 from Timothy Arceri --- The fix doesn't apply to master. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 109561] [regression, bisected] code re-factor causing games to stutter or lock-up system
https://bugs.freedesktop.org/show_bug.cgi?id=109561 --- Comment #2 from Timothy Arceri --- (In reply to Nicolai Hähnle from comment #1) > Created attachment 143321 [details] [review] > fix some issues > > I cannot reproduce the hang, unfortunately. What hardware do you get the > hang with? Vega 64 -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 109561] [regression, bisected] code re-factor causing games to stutter or lock-up system
https://bugs.freedesktop.org/show_bug.cgi?id=109561 --- Comment #1 from Nicolai Hähnle --- Created attachment 143321 --> https://bugs.freedesktop.org/attachment.cgi?id=143321=edit fix some issues I cannot reproduce the hang, unfortunately. What hardware do you get the hang with? There is some flickering on Polaris, which gets worse with the commit you bisected this to. The attached patch reduces the flicker back to the pre-commit level. Though it's essentially Marek's patch, plus an additional minor fix. I have yet to try the Batman issue. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 109561] [regression, bisected] code re-factor causing games to stutter or lock-up system
https://bugs.freedesktop.org/show_bug.cgi?id=109561 Timothy Arceri changed: What|Removed |Added Blocks||109535 Referenced Bugs: https://bugs.freedesktop.org/show_bug.cgi?id=109535 [Bug 109535] [Tracker] Mesa 19.0 release tracker -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 109561] [regression, bisected] code re-factor causing games to stutter or lock-up system
https://bugs.freedesktop.org/show_bug.cgi?id=109561 Bug ID: 109561 Summary: [regression, bisected] code re-factor causing games to stutter or lock-up system Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: t_arc...@yahoo.com.au QA Contact: dri-devel@lists.freedesktop.org The following commit cause bad stuttering in the Batman Arkham City benchmark (note when testing this game is 32bit). It also causes No Mans Sky to freeze my system. Link to No Mans Sky api trace below. Needs the following environment variables set when running apitrace: force_glsl_extensions_warn=true allow_glsl_layout_qualifier_on_function_parameters=true https://drive.google.com/open?id=1xFl7Uzfr75aODC0ljP8hC5OYRxgtuCan commit e0f0d3675d462aad4ca30e4383a3530d46e6e85d Author: Nicolai Hähnle Date: Tue Sep 18 15:52:17 2018 +0200 radeonsi: factor si_query_buffer logic out of si_query_hw This is a move towards using composition instead of inheritance for different query types. This change weakens out-of-memory error reporting somewhat, though this should be acceptable since we didn't consistently report such errors in the first place. Reviewed-by: Marek Olšák -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
