Re: [Intel-gfx] [PATCH] drm/i915/guc/rc: Use i915_probe_error instead of drm_error

2022-05-16 Thread Jani Nikula
On Fri, 13 May 2022, "Teres Alexis, Alan Previn" wrote: > Nit: not sure why we use ERR_PTR for int when calling func was also returning > an int. > Anyway, that was how the original code was, so: %pe on an error pointer prints the symbolic error name if CONFIG_SYMBOLIC_ERRNAME=y and the errno

Re: [Intel-gfx] [PATCH] drm/i915/guc/rc: Use i915_probe_error instead of drm_error

2022-05-13 Thread Teres Alexis, Alan Previn
Nit: not sure why we use ERR_PTR for int when calling func was also returning an int. Anyway, that was how the original code was, so: Reviewed-by: Alan Previn On Thu, 2022-05-05 at 22:41 -0700, Vinay Belgaumkar wrote: > To avoid false positives in error injection cases. > > Signed-off-by: