[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-03 Thread Daniel Vetter
On Sat, Sep 01, 2012 at 07:44:17PM -0700, Arjan van de Ven wrote: > On 9/1/2012 6:36 PM, Ben Widawsky wrote: > > > It depends on what you're trying to measure. I think this patch is quite > > useful but I think I'll make you defend your patch now since you're the > > maintainer and you took > >

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-03 Thread Daniel Vetter
On Sat, Sep 01, 2012 at 06:36:32PM -0700, Ben Widawsky wrote: > On 2012-09-01 12:14, Daniel Vetter wrote: > >On Sat, Sep 1, 2012 at 8:35 PM, Ben Widawsky > >wrote: > >>On 2012-09-01 11:28, Arjan van de Ven wrote: > >>> > >>>On 9/1/2012 11:26 AM, Ben Widawsky wrote: > > On 2012-08-30

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-03 Thread Daniel Vetter
On Sat, Sep 01, 2012 at 06:36:32PM -0700, Ben Widawsky wrote: On 2012-09-01 12:14, Daniel Vetter wrote: On Sat, Sep 1, 2012 at 8:35 PM, Ben Widawsky b...@bwidawsk.net wrote: On 2012-09-01 11:28, Arjan van de Ven wrote: On 9/1/2012 11:26 AM, Ben Widawsky wrote: On 2012-08-30 04:26, Daniel

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-03 Thread Daniel Vetter
On Sat, Sep 01, 2012 at 07:44:17PM -0700, Arjan van de Ven wrote: On 9/1/2012 6:36 PM, Ben Widawsky wrote: It depends on what you're trying to measure. I think this patch is quite useful but I think I'll make you defend your patch now since you're the maintainer and you took your own

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-02 Thread Chris Wilson
On Sat, 01 Sep 2012 18:16:52 -0700, Ben Widawsky wrote: > On 2012-09-01 12:22, Chris Wilson wrote: > > On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky > > wrote: > >> I have no problem with Daniel's patch. It's just a matter of cutting > >> through some scheduler BS of "when the GPU wants to

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-02 Thread Ben Widawsky
On 2012-09-01 20:06, Arjan van de Ven wrote: On 9/1/2012 8:05 PM, Ben Widawsky wrote: , from a single trace event you should know the current frequency and the previous frequency. but if you're doing a heavy game or whatever... you may stay at the highest all the time, and I get no

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-02 Thread Chris Wilson
On Sat, 01 Sep 2012 18:16:52 -0700, Ben Widawsky b...@bwidawsk.net wrote: On 2012-09-01 12:22, Chris Wilson wrote: On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky b...@bwidawsk.net wrote: I have no problem with Daniel's patch. It's just a matter of cutting through some scheduler BS of

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-02 Thread Arjan van de Ven
On 9/1/2012 6:36 PM, Ben Widawsky wrote: It depends on what you're trying to measure. I think this patch is quite useful but I think I'll make you defend your patch now since you're the maintainer and you took your own patch and you're shooting down my idea. So please tell me what

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-02 Thread Arjan van de Ven
On 9/1/2012 8:05 PM, Ben Widawsky wrote: , from a single trace event you should know the current frequency and the previous frequency. but if you're doing a heavy game or whatever... you may stay at the highest all the time, and I get no information... same for getting stuck or being always

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Daniel Vetter
On Sat, Sep 1, 2012 at 8:35 PM, Ben Widawsky wrote: > On 2012-09-01 11:28, Arjan van de Ven wrote: >> >> On 9/1/2012 11:26 AM, Ben Widawsky wrote: >>> >>> On 2012-08-30 04:26, Daniel Vetter wrote: We've had and still have too many issues where the gpu turbot doesn't quite to what

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Chris Wilson
On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky wrote: > I have no problem with Daniel's patch. It's just a matter of cutting > through some scheduler BS of "when the GPU wants to change frequency" > vs. "when we actually change the GPU frequency." I think *both* are > interesting. We

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 20:06, Arjan van de Ven wrote: > On 9/1/2012 8:05 PM, Ben Widawsky wrote: >> , from a single trace event you should know the current frequency >> and the previous frequency. > but if you're doing a heavy game or whatever... you may stay at the > highest all the time, > and I get no

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Arjan van de Ven
On 9/1/2012 8:05 PM, Ben Widawsky wrote: > , from a single trace event you should know the current frequency and the > previous frequency. but if you're doing a heavy game or whatever... you may stay at the highest all the time, and I get no information... same for getting stuck or being always

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 19:44, Arjan van de Ven wrote: > On 9/1/2012 6:36 PM, Ben Widawsky wrote: > >> It depends on what you're trying to measure. I think this patch is >> quite useful but I think I'll make you defend your patch now since >> you're the maintainer and you took >> your own patch and you're

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Arjan van de Ven
On 9/1/2012 6:36 PM, Ben Widawsky wrote: > It depends on what you're trying to measure. I think this patch is quite > useful but I think I'll make you defend your patch now since you're the > maintainer and you took > your own patch and you're shooting down my idea. So please tell me what >

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 12:14, Daniel Vetter wrote: > On Sat, Sep 1, 2012 at 8:35 PM, Ben Widawsky > wrote: >> On 2012-09-01 11:28, Arjan van de Ven wrote: >>> >>> On 9/1/2012 11:26 AM, Ben Widawsky wrote: On 2012-08-30 04:26, Daniel Vetter wrote: > > We've had and still have too many

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 12:22, Chris Wilson wrote: > On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky > wrote: >> I have no problem with Daniel's patch. It's just a matter of cutting >> through some scheduler BS of "when the GPU wants to change >> frequency" >> vs. "when we actually change the GPU

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 11:28, Arjan van de Ven wrote: > On 9/1/2012 11:26 AM, Ben Widawsky wrote: >> On 2012-08-30 04:26, Daniel Vetter wrote: >>> We've had and still have too many issues where the gpu turbot >>> doesn't >>> quite to what it's supposed to do (or what we want it to do). >>> >>> Adding a

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Arjan van de Ven
On 9/1/2012 11:26 AM, Ben Widawsky wrote: > On 2012-08-30 04:26, Daniel Vetter wrote: >> We've had and still have too many issues where the gpu turbot doesn't >> quite to what it's supposed to do (or what we want it to do). >> >> Adding a tracepoint to track when the desired gpu frequence changes

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-08-30 04:26, Daniel Vetter wrote: > We've had and still have too many issues where the gpu turbot doesn't > quite to what it's supposed to do (or what we want it to do). > > Adding a tracepoint to track when the desired gpu frequence changes > should help a lot in characterizing and

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Daniel Vetter
On Sat, Sep 1, 2012 at 8:35 PM, Ben Widawsky b...@bwidawsk.net wrote: On 2012-09-01 11:28, Arjan van de Ven wrote: On 9/1/2012 11:26 AM, Ben Widawsky wrote: On 2012-08-30 04:26, Daniel Vetter wrote: We've had and still have too many issues where the gpu turbot doesn't quite to what it's

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Chris Wilson
On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky b...@bwidawsk.net wrote: I have no problem with Daniel's patch. It's just a matter of cutting through some scheduler BS of when the GPU wants to change frequency vs. when we actually change the GPU frequency. I think *both* are interesting.

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Arjan van de Ven
On 9/1/2012 11:26 AM, Ben Widawsky wrote: On 2012-08-30 04:26, Daniel Vetter wrote: We've had and still have too many issues where the gpu turbot doesn't quite to what it's supposed to do (or what we want it to do). Adding a tracepoint to track when the desired gpu frequence changes should

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 12:22, Chris Wilson wrote: On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky b...@bwidawsk.net wrote: I have no problem with Daniel's patch. It's just a matter of cutting through some scheduler BS of when the GPU wants to change frequency vs. when we actually change the GPU

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 12:14, Daniel Vetter wrote: On Sat, Sep 1, 2012 at 8:35 PM, Ben Widawsky b...@bwidawsk.net wrote: On 2012-09-01 11:28, Arjan van de Ven wrote: On 9/1/2012 11:26 AM, Ben Widawsky wrote: On 2012-08-30 04:26, Daniel Vetter wrote: We've had and still have too many issues where

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-09-01 Thread Ben Widawsky
On 2012-09-01 19:44, Arjan van de Ven wrote: On 9/1/2012 6:36 PM, Ben Widawsky wrote: It depends on what you're trying to measure. I think this patch is quite useful but I think I'll make you defend your patch now since you're the maintainer and you took your own patch and you're shooting

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-08-31 Thread Daniel Vetter
On Thu, Aug 30, 2012 at 02:34:11PM +0100, Chris Wilson wrote: > On Thu, 30 Aug 2012 13:26:48 +0200, Daniel Vetter > wrote: > > We've had and still have too many issues where the gpu turbot doesn't > > quite to what it's supposed to do (or what we want it to do). > > > > Adding a tracepoint to

[Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-08-30 Thread Chris Wilson
On Thu, 30 Aug 2012 13:26:48 +0200, Daniel Vetter wrote: > We've had and still have too many issues where the gpu turbot doesn't > quite to what it's supposed to do (or what we want it to do). > > Adding a tracepoint to track when the desired gpu frequence changes > should help a lot in

Re: [Intel-gfx] [PATCH] drm/i915: add a tracepoint for gpu frequency changes

2012-08-30 Thread Chris Wilson
On Thu, 30 Aug 2012 13:26:48 +0200, Daniel Vetter daniel.vet...@ffwll.ch wrote: We've had and still have too many issues where the gpu turbot doesn't quite to what it's supposed to do (or what we want it to do). Adding a tracepoint to track when the desired gpu frequence changes should help