Re: [Intel-gfx] [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-20 Thread Chris Wilson
Quoting Dave Airlie (2017-12-21 02:42:56) > > @@ -494,12 +473,11 @@ static int drm_syncobj_fd_to_handle(struct drm_file > > *file_private, > > spin_unlock(_private->syncobj_table_lock); > > idr_preload_end(); > > > > - if (ret < 0) { > > - fput(syncobj->file);

Re: [Intel-gfx] [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-20 Thread Dave Airlie
> @@ -494,12 +473,11 @@ static int drm_syncobj_fd_to_handle(struct drm_file > *file_private, > spin_unlock(_private->syncobj_table_lock); > idr_preload_end(); > > - if (ret < 0) { > - fput(syncobj->file); > - return ret; > - } > -

Re: [Intel-gfx] [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-19 Thread Daniel Vetter
On Tue, Dec 19, 2017 at 12:07:00PM +, Chris Wilson wrote: > The vk cts test: > dEQP-VK.api.external.semaphore.opaque_fd.export_multiple_times_temporary > > triggers a lot of > VFS: Close: file count is 0 > > Dave pointed out that clearing the syncobj->file from > drm_syncobj_file_release()