Re: [Outreachy kernel] [PATCH v2 3/3] drm: Remove assignment in if condition

2017-09-14 Thread Jani Nikula
On Wed, 13 Sep 2017, Julia Lawall wrote: > On Wed, 13 Sep 2017, Meghana Madhyastha wrote: > >> Move the assignment so that it happens before the if >> condition. This results in syntax which is easier to read. > > It would be nice to mention the merged conditionals in the

Re: [Outreachy kernel] [PATCH v2 3/3] drm: Remove assignment in if condition

2017-09-13 Thread Julia Lawall
On Wed, 13 Sep 2017, Meghana Madhyastha wrote: > Move the assignment so that it happens before the if > condition. This results in syntax which is easier to read. It would be nice to mention the merged conditionals in the log message. julia > Found by checkpath.pl > > Signed-off-by: Meghana