Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-06-23 Thread Chih-Wei Huang
Sorry for the late reply since I didn't notice it. (I rarely read the ML) The patch of Jiyong Park is the one he submitted to the ML before. https://patchwork.kernel.org/patch/9864539/ https://patchwork.kernel.org/patch/10109599/ I'm not sure why it's not merged. Maybe just forgotten. The 2nd an

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-04-26 Thread Mauro Rossi
Here is patch using include which should suffice for the purpose. Cheers Mauro On Mon, Apr 22, 2019 at 11:46 AM Mauro Rossi wrote: > > Hi Emil, Chih-Wei, > > what about the series of latest three patches we have in oreo-x86 branch? > > [oreo-x86 branch] > http://git.osdn.net/view?p=android-x86/

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-04-22 Thread Mauro Rossi
Hi Emil, Chih-Wei, what about the series of latest three patches we have in oreo-x86 branch? [oreo-x86 branch] http://git.osdn.net/view?p=android-x86/external-libdrm.git;a=history;f=Android.mk;h=f832b24e99007c75ce3a8d9a3ece34d4e475e957;hb=refs/heads/oreo-x86 My doubt is about the one "android: m

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-04-22 Thread Mauro Rossi
Hi, I can try replacing with , but I would like to get confirmation from Chih-Wei, the original author of [1] Mauro [1] http://git.osdn.net/view?p=android-x86/external-libdrm.git;a=commit;h=9d2a4cc3a16b5b464fda0a0c321dd1f5acadaa33 On Mon, Mar 18, 2019 at 2:32 PM Tapani Pälli wrote: > > > >

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-04-17 Thread Emil Velikov
On Mon, 18 Mar 2019 at 13:32, Tapani Pälli wrote: > On 3/18/19 3:25 PM, Robert Foss wrote: > > Hey, > > > > On 3/18/19 2:11 PM, Mauro Rossi wrote: > >> Hi, > >> > >> On Mon, Mar 18, 2019 at 10:58 AM Robert Foss > >> wrote: > >>> > >>> Hey Mauro, > >>> > >>> On 3/18/19 9:38 AM, Mauro Rossi wrote:

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Tapani Pälli
On 3/18/19 3:25 PM, Robert Foss wrote: Hey, On 3/18/19 2:11 PM, Mauro Rossi wrote: Hi, On Mon, Mar 18, 2019 at 10:58 AM Robert Foss wrote: Hey Mauro, On 3/18/19 9:38 AM, Mauro Rossi wrote: Hi Robert, On Mon, Mar 18, 2019 at 9:21 AM Robert Foss wrote: On a second note, this does no

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Robert Foss
Hey, On 3/18/19 2:11 PM, Mauro Rossi wrote: Hi, On Mon, Mar 18, 2019 at 10:58 AM Robert Foss wrote: Hey Mauro, On 3/18/19 9:38 AM, Mauro Rossi wrote: Hi Robert, On Mon, Mar 18, 2019 at 9:21 AM Robert Foss wrote: On a second note, this does not apply on libdrm/master due to: LOCAL_SHAR

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Mauro Rossi
Hi, On Mon, Mar 18, 2019 at 10:58 AM Robert Foss wrote: > > Hey Mauro, > > On 3/18/19 9:38 AM, Mauro Rossi wrote: > > Hi Robert, > > > > On Mon, Mar 18, 2019 at 9:21 AM Robert Foss > > wrote: > >> > >> On a second note, this does not apply on libdrm/master due > >> to: > >> > >> LOCAL_SHARED_LI

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Tapani Pälli
It seems like there is no usage of __android_log_vprint in upstream libdrm. Perhaps this was against libdrm with some android specific changes on top? On 3/17/19 10:50 PM, Mauro Rossi wrote: Fixes the following building error: FAILED: $(OUT)/obj/SHARED_LIBRARIES/libdrm_platform_intermediates

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Robert Foss
Hey Mauro, On 3/18/19 9:38 AM, Mauro Rossi wrote: Hi Robert, On Mon, Mar 18, 2019 at 9:21 AM Robert Foss wrote: On a second note, this does not apply on libdrm/master due to: LOCAL_SHARED_LIBRARIES := \ libcutils Sorry, we have an additional Google patch, not present in libdrm/ma

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Mauro Rossi
Hi Robert, On Mon, Mar 18, 2019 at 9:21 AM Robert Foss wrote: > > On a second note, this does not apply on libdrm/master due > to: > > LOCAL_SHARED_LIBRARIES := \ > libcutils Sorry, we have an additional Google patch, not present in libdrm/master that adds libdrm_platform module, but it

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Robert Foss
On a second note, this does not apply on libdrm/master due to: LOCAL_SHARED_LIBRARIES := \ libcutils My thinking is that libcutils probably can be replaced with liblog, but I'm not 100% sure. Rob. On 3/18/19 9:09 AM, Robert Foss wrote: This is probably a good idea! Reviewed-by: Rob

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Robert Foss
This is probably a good idea! Reviewed-by: Robert Foss On 3/17/19 9:54 PM, Mauro Rossi wrote: Hi, I used the option --subject-prefix="PATCH libdrm" but it did not go as expected. Anyway, the patch is for Android build of mesa/drm Mauro On Sun, Mar 17, 2019 at 9:50 PM Mauro Rossi wrote: F

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-17 Thread Mauro Rossi
Hi, I used the option --subject-prefix="PATCH libdrm" but it did not go as expected. Anyway, the patch is for Android build of mesa/drm Mauro On Sun, Mar 17, 2019 at 9:50 PM Mauro Rossi wrote: > > Fixes the following building error: > > FAILED: > $(OUT)/obj/SHARED_LIBRARIES/libdrm_platform_inte

[PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-17 Thread Mauro Rossi
Fixes the following building error: FAILED: $(OUT)/obj/SHARED_LIBRARIES/libdrm_platform_intermediates/LINKED/libdrm_platform.so ... external/libdrm/xf86drm.c:146: error: undefined reference to '__android_log_vprint' clang.real: error: linker command failed with exit code 1 (use -v to see invoca