Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-08-09 Thread Thomas Gleixner
On Fri, 9 Aug 2019, Sedat Dilek wrote: > On Fri, Aug 9, 2019 at 1:03 AM Nick Desaulniers > wrote: > > > > On Thu, Aug 8, 2019 at 1:22 PM Thomas Gleixner wrote: > > > > tglx just picked up 2 other patches of mine, bumping just in case he's > > > > not picking up patches while on vacation. ;) > >

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-08-09 Thread Sedat Dilek
On Fri, Aug 9, 2019 at 1:03 AM Nick Desaulniers wrote: > > On Thu, Aug 8, 2019 at 1:22 PM Thomas Gleixner wrote: > > > tglx just picked up 2 other patches of mine, bumping just in case he's > > > not picking up patches while on vacation. ;) > > > > I'm only half on vacation :) > > > > So I can

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-08-09 Thread Nick Desaulniers
On Tue, Aug 6, 2019 at 5:59 AM Josh Poimboeuf wrote: > > On Mon, Aug 05, 2019 at 09:29:53PM +0200, Sedat Dilek wrote: > > On Wed, Jul 31, 2019 at 2:25 PM Sedat Dilek wrote: > > > > > > On Fri, Jul 26, 2019 at 9:30 PM Chris Wilson > > > wrote: > > > > > > > > Quoting Thomas Gleixner (2019-07-26

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-08-08 Thread Nick Desaulniers
On Thu, Aug 8, 2019 at 1:22 PM Thomas Gleixner wrote: > > tglx just picked up 2 other patches of mine, bumping just in case he's > > not picking up patches while on vacation. ;) > > I'm only half on vacation :) > > So I can pick it up. Thanks, will send half margaritas. -- Thanks, ~Nick

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-08-08 Thread Thomas Gleixner
On Thu, 8 Aug 2019, Nick Desaulniers wrote: > On Tue, Aug 6, 2019 at 5:59 AM Josh Poimboeuf wrote: > > > Gentle ping... > > > Thomas and Chris: Will someone of you pick this up? > > > As "objtool: Improve UACCESS coverage" [1] went trough tip tree I > > > highly appreciate to do so with this one.

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-08-06 Thread Josh Poimboeuf
On Mon, Aug 05, 2019 at 09:29:53PM +0200, Sedat Dilek wrote: > On Wed, Jul 31, 2019 at 2:25 PM Sedat Dilek wrote: > > > > On Fri, Jul 26, 2019 at 9:30 PM Chris Wilson > > wrote: > > > > > > Quoting Thomas Gleixner (2019-07-26 20:18:32) > > > > On Fri, 26 Jul 2019, Chris Wilson wrote: > > > > >

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-08-05 Thread Sedat Dilek
On Wed, Jul 31, 2019 at 2:25 PM Sedat Dilek wrote: > > On Fri, Jul 26, 2019 at 9:30 PM Chris Wilson wrote: > > > > Quoting Thomas Gleixner (2019-07-26 20:18:32) > > > On Fri, 26 Jul 2019, Chris Wilson wrote: > > > > Quoting Thomas Gleixner (2019-07-25 22:55:45) > > > > > On Thu, 25 Jul 2019,

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-31 Thread Sedat Dilek
On Fri, Jul 26, 2019 at 9:30 PM Chris Wilson wrote: > > Quoting Thomas Gleixner (2019-07-26 20:18:32) > > On Fri, 26 Jul 2019, Chris Wilson wrote: > > > Quoting Thomas Gleixner (2019-07-25 22:55:45) > > > > On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > > > > > > > > > Objtool reports: > > > > > >

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-26 Thread Chris Wilson
Quoting Thomas Gleixner (2019-07-26 20:18:32) > On Fri, 26 Jul 2019, Chris Wilson wrote: > > Quoting Thomas Gleixner (2019-07-25 22:55:45) > > > On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > > > > > > > Objtool reports: > > > > > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning:

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-26 Thread Thomas Gleixner
On Fri, 26 Jul 2019, Chris Wilson wrote: > Quoting Thomas Gleixner (2019-07-25 22:55:45) > > On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > > > > > Objtool reports: > > > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > > .altinstr_replacement+0x36: redundant UACCESS

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-26 Thread Chris Wilson
Quoting Thomas Gleixner (2019-07-25 22:55:45) > On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > > > Objtool reports: > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > .altinstr_replacement+0x36: redundant UACCESS disable > > > > __copy_from_user() already does both

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-25 Thread Thomas Gleixner
On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > Objtool reports: > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > .altinstr_replacement+0x36: redundant UACCESS disable > > __copy_from_user() already does both STAC and CLAC, so the > user_access_end() in its error path

[PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-25 Thread Josh Poimboeuf
Objtool reports: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: .altinstr_replacement+0x36: redundant UACCESS disable __copy_from_user() already does both STAC and CLAC, so the user_access_end() in its error path adds an extra unnecessary CLAC. Fixes: 0b2c8f8b6b0c ("i915: