Re: [PATCH] drm/i915: Use drm_dev_unplug()

2019-04-15 Thread Daniel Vetter
On Fri, Apr 05, 2019 at 08:41:16AM +0100, Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-04-05 08:26:57) > > From: Janusz Krzysztofik > > > > The driver does not currently support unbinding from a device which is > > in use. Since open file descriptors may still be pointing into kernel >

Re: [PATCH] drm/i915: Use drm_dev_unplug()

2019-04-05 Thread Janusz Krzysztofik
On Fri, 2019-04-05 at 09:24 +0100, Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-04-05 09:11:54) > > On Fri, 2019-04-05 at 08:41 +0100, Chris Wilson wrote: > > > Quoting Janusz Krzysztofik (2019-04-05 08:26:57) > > > > From: Janusz Krzysztofik > > > > > > > > The driver does not currentl

Re: [PATCH] drm/i915: Use drm_dev_unplug()

2019-04-05 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-05 09:11:54) > On Fri, 2019-04-05 at 08:41 +0100, Chris Wilson wrote: > > Quoting Janusz Krzysztofik (2019-04-05 08:26:57) > > > From: Janusz Krzysztofik > > > > > > The driver does not currently support unbinding from a device which > > > is > > > in use. Sin

Re: [PATCH] drm/i915: Use drm_dev_unplug()

2019-04-05 Thread Janusz Krzysztofik
On Fri, 2019-04-05 at 08:41 +0100, Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-04-05 08:26:57) > > From: Janusz Krzysztofik > > > > The driver does not currently support unbinding from a device which > > is > > in use. Since open file descriptors may still be pointing into > > kernel

Re: [PATCH] drm/i915: Use drm_dev_unplug()

2019-04-05 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-05 08:26:57) > From: Janusz Krzysztofik > > The driver does not currently support unbinding from a device which is > in use. Since open file descriptors may still be pointing into kernel > memory where the device structures used to be, entirely correct kernel

[PATCH] drm/i915: Use drm_dev_unplug()

2019-04-05 Thread Janusz Krzysztofik
From: Janusz Krzysztofik The driver does not currently support unbinding from a device which is in use. Since open file descriptors may still be pointing into kernel memory where the device structures used to be, entirely correct kernel panics protect the driver from being unbound as we should n