Re: [PATCH] drm/msm/a6xx: Remove unneeded GBIF unhalt

2020-02-05 Thread Rob Clark
On Tue, Feb 4, 2020 at 9:42 AM Jordan Crouse wrote: > > Commit e812744c5f95 ("drm: msm: a6xx: Add support for A618") added a > universal GBIF un-halt into a6xx_start(). This can cause problems for > a630 targets which do not use GBIF and might have access protection > enabled on the region now

Re: [PATCH] drm/msm/a6xx: Remove unneeded GBIF unhalt

2020-02-05 Thread John Stultz
On Tue, Feb 4, 2020 at 9:42 AM Jordan Crouse wrote: > > Commit e812744c5f95 ("drm: msm: a6xx: Add support for A618") added a > universal GBIF un-halt into a6xx_start(). This can cause problems for > a630 targets which do not use GBIF and might have access protection > enabled on the region now

Re: [PATCH] drm/msm/a6xx: Remove unneeded GBIF unhalt

2020-02-04 Thread Rob Clark
+jstultz On Tue, Feb 4, 2020 at 9:42 AM Jordan Crouse wrote: > > Commit e812744c5f95 ("drm: msm: a6xx: Add support for A618") added a > universal GBIF un-halt into a6xx_start(). This can cause problems for > a630 targets which do not use GBIF and might have access protection > enabled on the

[PATCH] drm/msm/a6xx: Remove unneeded GBIF unhalt

2020-02-04 Thread Jordan Crouse
Commit e812744c5f95 ("drm: msm: a6xx: Add support for A618") added a universal GBIF un-halt into a6xx_start(). This can cause problems for a630 targets which do not use GBIF and might have access protection enabled on the region now occupied by the GBIF registers. But it turns out that we didn't