Re: [PATCH] drm/msm/adreno/a5xx_debugfs: fix potential NULL pointer dereference

2018-02-04 Thread Gustavo A. R. Silva
Quoting Rob Clark : On Fri, Feb 2, 2018 at 11:30 AM, Jordan Crouse wrote: On Fri, Feb 02, 2018 at 06:32:23AM -0600, Gustavo A. R. Silva wrote: _minor_ is being dereferenced before it is null checked, hence there is a potential null pointer

Re: [PATCH] drm/msm/adreno/a5xx_debugfs: fix potential NULL pointer dereference

2018-02-02 Thread Rob Clark
On Fri, Feb 2, 2018 at 11:30 AM, Jordan Crouse wrote: > On Fri, Feb 02, 2018 at 06:32:23AM -0600, Gustavo A. R. Silva wrote: >> _minor_ is being dereferenced before it is null checked, hence there >> is a potential null pointer dereference. Fix this by moving the pointer

Re: [PATCH] drm/msm/adreno/a5xx_debugfs: fix potential NULL pointer dereference

2018-02-02 Thread Jordan Crouse
On Fri, Feb 02, 2018 at 06:32:23AM -0600, Gustavo A. R. Silva wrote: > _minor_ is being dereferenced before it is null checked, hence there > is a potential null pointer dereference. Fix this by moving the pointer > dereference after _minor_ has been null checked. > > Fixes: 024ad8df763f

[PATCH] drm/msm/adreno/a5xx_debugfs: fix potential NULL pointer dereference

2018-02-02 Thread Gustavo A. R. Silva
_minor_ is being dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer dereference after _minor_ has been null checked. Fixes: 024ad8df763f ("drm/msm: add a5xx specific debugfs") Signed-off-by: Gustavo A. R. Silva