Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-30 Thread Masahiro Yamada
On Wed, Mar 27, 2024 at 6:23 PM Arnd Bergmann wrote: > > On Wed, Mar 27, 2024, at 08:50, Jani Nikula wrote: > > On Tue, 26 Mar 2024, "Arnd Bergmann" wrote: > >> On Tue, Mar 26, 2024, at 21:24, Jani Nikula wrote: > >>> On Tue, 26 Mar 2024, Arnd Bergmann wrote: > >> > >> It works now. > >> > >>

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-28 Thread Linus Walleij
On Tue, Mar 26, 2024 at 3:49 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The -Woverride-init warn about code that may be intentional or not, > but the inintentional ones tend to be real bugs, so there is a bit of > disagreement on whether this warning option should be enabled by default >

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-27 Thread Arnd Bergmann
On Wed, Mar 27, 2024, at 08:50, Jani Nikula wrote: > On Tue, 26 Mar 2024, "Arnd Bergmann" wrote: >> On Tue, Mar 26, 2024, at 21:24, Jani Nikula wrote: >>> On Tue, 26 Mar 2024, Arnd Bergmann wrote: >> >> It works now. >> >> The original __diag_ignore_all() only did it for gcc-8 and above >>

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-27 Thread Jani Nikula
On Tue, 26 Mar 2024, "Arnd Bergmann" wrote: > On Tue, Mar 26, 2024, at 21:24, Jani Nikula wrote: >> On Tue, 26 Mar 2024, Arnd Bergmann wrote: >>> From: Arnd Bergmann >>> index 475e1e8c1d35..0786eb0da391 100644 >>> --- a/drivers/net/ethernet/renesas/sh_eth.c >>> +++

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-26 Thread Andrew Jeffery
On Tue, 2024-03-26 at 15:47 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The -Woverride-init warn about code that may be intentional or not, > but the inintentional ones tend to be real bugs, so there is a bit of > disagreement on whether this warning option should be enabled by default

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-26 Thread Arnd Bergmann
On Tue, Mar 26, 2024, at 21:24, Jani Nikula wrote: > On Tue, 26 Mar 2024, Arnd Bergmann wrote: >> From: Arnd Bergmann >> index 475e1e8c1d35..0786eb0da391 100644 >> --- a/drivers/net/ethernet/renesas/sh_eth.c >> +++ b/drivers/net/ethernet/renesas/sh_eth.c >> @@ -50,7 +50,7 @@ >> * the macros

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-26 Thread Jani Nikula
On Tue, 26 Mar 2024, Arnd Bergmann wrote: > From: Arnd Bergmann > > The -Woverride-init warn about code that may be intentional or not, > but the inintentional ones tend to be real bugs, so there is a bit of > disagreement on whether this warning option should be enabled by default > and we have

Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-26 Thread Hamza Mahfooz
Cc: amd-...@lists.freedesktop.org On 3/26/24 10:47, Arnd Bergmann wrote: From: Arnd Bergmann The -Woverride-init warn about code that may be intentional or not, but the inintentional ones tend to be real bugs, so there is a bit of disagreement on whether this warning option should be enabled

[PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-26 Thread Arnd Bergmann
From: Arnd Bergmann The -Woverride-init warn about code that may be intentional or not, but the inintentional ones tend to be real bugs, so there is a bit of disagreement on whether this warning option should be enabled by default and we have multiple settings in scripts/Makefile.extrawarn as