[PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.

2016-02-08 Thread Vlastimil Babka
On 02/08/2016 02:58 AM, Mario Kleiner wrote: Now i just need to actually code and test it first. >>> >>> Ping, any news? :) >>> > > Ok, so that series "drm vblank regression fixes for Linux 4.4+" i just > sent out should hopefully fix this bug and related bugs. Thanks, I'll test on Wed

[PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.

2016-02-08 Thread Mario Kleiner
On 02/07/2016 12:59 PM, Mario Kleiner wrote: > I have a few simple patches which after testing seem to work well > enough and fix additional similar problems with nouveau. Got > distracted with other stuff last week. I'll try to send them out later > today when i'm at the machine. > > -mario > > >

[PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.

2016-02-07 Thread Mario Kleiner
I have a few simple patches which after testing seem to work well enough and fix additional similar problems with nouveau. Got distracted with other stuff last week. I'll try to send them out later today when i'm at the machine. -mario On Sun, Feb 7, 2016 at 12:05 PM, Vlastimil Babka wrote: >

[PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.

2016-02-07 Thread Vlastimil Babka
On 01/22/2016 06:08 PM, Mario Kleiner wrote: > Anyway, some more hours of thinking and code browsing later, now i think > i have a simple and safe solution which should hopefully restore the > drm_vblank_pre/post_modeset behaviour with only a few lines of core > code. At the same time it should

[PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.

2016-01-22 Thread Mario Kleiner
On 01/22/2016 04:17 AM, Michel Dänzer wrote: > On 21.01.2016 18:16, Mario Kleiner wrote: >> On 01/21/2016 09:25 AM, Michel Dänzer wrote: >>> On 21.01.2016 17:16, Mario Kleiner wrote: This patch replaces calls to drm_vblank_pre/post_modeset in the drivers dpms code with calls to

[PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.

2016-01-22 Thread Michel Dänzer
On 21.01.2016 18:16, Mario Kleiner wrote: > On 01/21/2016 09:25 AM, Michel Dänzer wrote: >> On 21.01.2016 17:16, Mario Kleiner wrote: >>> >>> This patch replaces calls to drm_vblank_pre/post_modeset in the >>> drivers dpms code with calls to drm_vblank_off/on, as recommended >>> for drivers with

[PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.

2016-01-21 Thread Ville Syrjälä
On Thu, Jan 21, 2016 at 10:16:01AM +0100, Mario Kleiner wrote: > On 01/21/2016 09:25 AM, Michel Dänzer wrote: > > On 21.01.2016 17:16, Mario Kleiner wrote: > >> > >> This patch replaces calls to drm_vblank_pre/post_modeset in the > >> drivers dpms code with calls to drm_vblank_off/on, as

[PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.

2016-01-21 Thread Michel Dänzer
On 21.01.2016 17:16, Mario Kleiner wrote: > > This patch replaces calls to drm_vblank_pre/post_modeset in the > drivers dpms code with calls to drm_vblank_off/on, as recommended > for drivers with hw counters that reset to zero during modeset. Sounds like you fell for the drm_vblank_on/off

[PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.

2016-01-21 Thread Vlastimil Babka
Is there a PATCH 2/2 which I can't find, or is the subject wrong? On 01/21/2016 09:16 AM, Mario Kleiner wrote: > The hardware vblank counter of AMD gpu's resets to zero during a > modeset. The new implementation of drm_update_vblank_count() from > commit 4dfd6486 "drm: Use vblank timestamps to

[PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.

2016-01-21 Thread Mario Kleiner
On 01/21/2016 09:25 AM, Michel Dänzer wrote: > On 21.01.2016 17:16, Mario Kleiner wrote: >> >> This patch replaces calls to drm_vblank_pre/post_modeset in the >> drivers dpms code with calls to drm_vblank_off/on, as recommended >> for drivers with hw counters that reset to zero during modeset. >

[PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.

2016-01-21 Thread Mario Kleiner
The hardware vblank counter of AMD gpu's resets to zero during a modeset. The new implementation of drm_update_vblank_count() from commit 4dfd6486 "drm: Use vblank timestamps to guesstimate how many vblanks were missed", introduced in Linux 4.4, treats that as a counter wraparound and causes the