Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-14 Thread Michel Dänzer
On 2023-12-14 11:31, Christian König wrote: > Am 13.12.23 um 16:46 schrieb Michel Dänzer: >> From a security PoV, the kernel should never return uncleared memory to (at >> least unprivileged) user space. This series seems like a big step in that >> direction. > > Well please take a look at the

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-14 Thread Christian König
Am 13.12.23 um 16:46 schrieb Michel Dänzer: From a security PoV, the kernel should never return uncleared memory to (at least unprivileged) user space. This series seems like a big step in that direction. Well please take a look at the MAP_UNINITIALIZED flag for mmap(). We even have the

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-13 Thread Michel Dänzer
On 2023-12-13 16:39, Felix Kuehling wrote: > On 2023-12-13 9:20, Christian König wrote: >> Am 12.12.23 um 00:32 schrieb Felix Kuehling: >>> On 2023-12-11 04:50, Christian König wrote: Am 08.12.23 um 20:53 schrieb Alex Deucher: > [SNIP] >> You also need a functionality which resets all

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-13 Thread Christian König
Am 13.12.23 um 16:39 schrieb Felix Kuehling: On 2023-12-13 9:20, Christian König wrote: Am 12.12.23 um 00:32 schrieb Felix Kuehling: On 2023-12-11 04:50, Christian König wrote: Am 08.12.23 um 20:53 schrieb Alex Deucher: [SNIP] You also need a functionality which resets all cleared blocks

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-13 Thread Felix Kuehling
On 2023-12-13 9:20, Christian König wrote: Am 12.12.23 um 00:32 schrieb Felix Kuehling: On 2023-12-11 04:50, Christian König wrote: Am 08.12.23 um 20:53 schrieb Alex Deucher: [SNIP] You also need a functionality which resets all cleared blocks to uncleared after suspend/resume. No idea how

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-13 Thread Christian König
Am 12.12.23 um 00:32 schrieb Felix Kuehling: On 2023-12-11 04:50, Christian König wrote: Am 08.12.23 um 20:53 schrieb Alex Deucher: [SNIP] You also need a functionality which resets all cleared blocks to uncleared after suspend/resume. No idea how to do this, maybe Alex knows of hand. Since

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-11 Thread Felix Kuehling
On 2023-12-11 04:50, Christian König wrote: Am 08.12.23 um 20:53 schrieb Alex Deucher: [SNIP] You also need a functionality which resets all cleared blocks to uncleared after suspend/resume. No idea how to do this, maybe Alex knows of hand. Since the buffers are cleared on creation, is

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-11 Thread Alex Deucher
On Mon, Dec 11, 2023 at 4:50 AM Christian König wrote: > > Am 08.12.23 um 20:53 schrieb Alex Deucher: > > [SNIP] > > You also need a functionality which resets all cleared blocks to > uncleared after suspend/resume. > > No idea how to do this, maybe Alex knows of hand. > > Since the buffers are

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-11 Thread Christian König
Am 08.12.23 um 20:53 schrieb Alex Deucher: [SNIP] You also need a functionality which resets all cleared blocks to uncleared after suspend/resume. No idea how to do this, maybe Alex knows of hand. Since the buffers are cleared on creation, is there actually anything to do? Well exactly

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-08 Thread Alex Deucher
On Fri, Dec 8, 2023 at 5:07 AM Christian König wrote: > > Am 07.12.23 um 16:11 schrieb Arunpravin Paneer Selvam: > > Add clear page support in vram memory region. > > The first patch looks good, but this here needs quite some work. > > > > > Signed-off-by: Arunpravin Paneer Selvam > > --- > >

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-08 Thread Christian König
Am 07.12.23 um 16:11 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. The first patch looks good, but this here needs quite some work. Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c| 13 +++--

Re: [PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-07 Thread Alex Deucher
On Thu, Dec 7, 2023 at 10:12 AM Arunpravin Paneer Selvam wrote: > > Add clear page support in vram memory region. > > Signed-off-by: Arunpravin Paneer Selvam > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c| 13 +++-- > .../gpu/drm/amd/amdgpu/amdgpu_res_cursor.h| 25 ++ >

[PATCH 2/2] drm/amdgpu: Enable clear page functionality

2023-12-07 Thread Arunpravin Paneer Selvam
Add clear page support in vram memory region. Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c| 13 +++-- .../gpu/drm/amd/amdgpu/amdgpu_res_cursor.h| 25 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 50 +++