[PATCH 3/3] drm: Use vblank_disable_and_save in drm_vblank_cleanup()

2014-08-07 Thread Mario Kleiner
On 08/07/2014 08:50 AM, Daniel Vetter wrote: > On Thu, Aug 7, 2014 at 2:50 AM, Mario Kleiner > wrote: >> I'm not sure about all the new embedded drivers, if they have hw vblank >> counters? > Quick grep says a lot don't have it or at least not implemented - they > use drm_vblank_count. Thinking

[PATCH 3/3] drm: Use vblank_disable_and_save in drm_vblank_cleanup()

2014-08-07 Thread Daniel Vetter
On Thu, Aug 7, 2014 at 2:50 AM, Mario Kleiner wrote: > Ok, good with me, thanks. Ville, thanks for the review. I'll review and test > your vblank series next week when i have access to suitable machines and > enough time. I need to go through this in single-step mode, vblank on/off > changes

[PATCH 3/3] drm: Use vblank_disable_and_save in drm_vblank_cleanup()

2014-08-07 Thread Daniel Vetter
On Thu, Aug 7, 2014 at 2:50 AM, Mario Kleiner wrote: > I'm not sure about all the new embedded drivers, if they have hw vblank > counters? Quick grep says a lot don't have it or at least not implemented - they use drm_vblank_count. Thinking about this, should we use that as a signal to also set

[PATCH 3/3] drm: Use vblank_disable_and_save in drm_vblank_cleanup()

2014-08-07 Thread Mario Kleiner
On 08/06/2014 03:57 PM, Daniel Vetter wrote: > On Wed, Aug 06, 2014 at 01:51:41PM +0300, Ville Syrj?l? wrote: >> On Wed, Aug 06, 2014 at 03:22:46AM +0200, Mario Kleiner wrote: >>> Calling vblank_disable_fn() will cause that function to no-op >>> if !dev->vblank_disable_allowed for some kms

[PATCH 3/3] drm: Use vblank_disable_and_save in drm_vblank_cleanup()

2014-08-06 Thread Daniel Vetter
On Wed, Aug 06, 2014 at 01:51:41PM +0300, Ville Syrj?l? wrote: > On Wed, Aug 06, 2014 at 03:22:46AM +0200, Mario Kleiner wrote: > > Calling vblank_disable_fn() will cause that function to no-op > > if !dev->vblank_disable_allowed for some kms drivers, e.g., > > on nouveau-kms. This can cause the

[PATCH 3/3] drm: Use vblank_disable_and_save in drm_vblank_cleanup()

2014-08-06 Thread Ville Syrjälä
On Wed, Aug 06, 2014 at 03:22:46AM +0200, Mario Kleiner wrote: > Calling vblank_disable_fn() will cause that function to no-op > if !dev->vblank_disable_allowed for some kms drivers, e.g., > on nouveau-kms. This can cause the gpu vblank irq's to not get > disabled before freeing the dev->vblank

[PATCH 3/3] drm: Use vblank_disable_and_save in drm_vblank_cleanup()

2014-08-06 Thread Mario Kleiner
Calling vblank_disable_fn() will cause that function to no-op if !dev->vblank_disable_allowed for some kms drivers, e.g., on nouveau-kms. This can cause the gpu vblank irq's to not get disabled before freeing the dev->vblank array, so if a vblank irq fires and calls into drm_handle_vblank() after