[PATCH v2] drm/edid: use true and false for boolean values

2018-01-31 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Use true for boolean value in add_detailed_mode as suggested by Daniel Vetter. -

Re: [PATCH v2] drm/edid: use true and false for boolean values

2018-01-30 Thread Daniel Vetter
On Tue, Jan 30, 2018 at 11:02:44AM -0500, Sean Paul wrote: > On Tue, Jan 30, 2018 at 05:19:46PM +0200, Ville Syrjälä wrote: > > On Tue, Jan 30, 2018 at 10:09:27AM -0500, Sean Paul wrote: > > > On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: > > > > Assign true or false to

Re: [PATCH v2] drm/edid: use true and false for boolean values

2018-01-30 Thread Sean Paul
On Tue, Jan 30, 2018 at 05:19:46PM +0200, Ville Syrjälä wrote: > On Tue, Jan 30, 2018 at 10:09:27AM -0500, Sean Paul wrote: > > On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: > > > Assign true or false to boolean variables instead of an integer value. > > > > > > This issue

Re: [PATCH v2] drm/edid: use true and false for boolean values

2018-01-30 Thread Jani Nikula
On Tue, 30 Jan 2018, Ville Syrjälä wrote: > On Tue, Jan 30, 2018 at 10:09:27AM -0500, Sean Paul wrote: >> On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: >> > Assign true or false to boolean variables instead of an integer value. >> > >> > This

Re: [PATCH v2] drm/edid: use true and false for boolean values

2018-01-30 Thread Ville Syrjälä
On Tue, Jan 30, 2018 at 10:09:27AM -0500, Sean Paul wrote: > On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: > > Assign true or false to boolean variables instead of an integer value. > > > > This issue was detected with the help of Coccinelle. > > I suppose you could also

Re: [PATCH v2] drm/edid: use true and false for boolean values

2018-01-30 Thread Sean Paul
On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. I suppose you could also fix up the other preferred assignment by adding !! to the bitwise &