Re: [PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-08-23 Thread Harry Wentland
On 2018-07-31 05:07 PM, Manasi Navare wrote: > According to Display Stream compression spec 1.2, the picture > parameter set metadata is sent from source to sink device > using the DP Secondary data packet. An infoframe is formed > for the PPS SDP header and PPS SDP payload bytes. > This patch

Re: [PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-08-03 Thread Manasi Navare
On Fri, Aug 03, 2018 at 08:43:51PM +0100, Chris Wilson wrote: > Quoting Manasi Navare (2018-08-03 20:18:42) > > On Tue, Jul 31, 2018 at 10:16:45PM +0100, Chris Wilson wrote: > > > Quoting Manasi Navare (2018-07-31 22:07:06) > > > > + /* PPS 4 */ > > > > + pps_sdp->pps_payload.pps_4 =

Re: [PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-08-03 Thread Chris Wilson
Quoting Manasi Navare (2018-08-03 20:18:42) > On Tue, Jul 31, 2018 at 10:16:45PM +0100, Chris Wilson wrote: > > Quoting Manasi Navare (2018-07-31 22:07:06) > > > + /* PPS 4 */ > > > + pps_sdp->pps_payload.pps_4 = (u8)((dsc_cfg->bits_per_pixel & > > > +

Re: [PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-08-03 Thread Manasi Navare
On Tue, Jul 31, 2018 at 10:16:45PM +0100, Chris Wilson wrote: > Quoting Manasi Navare (2018-07-31 22:07:06) > > + /* PPS 4 */ > > + pps_sdp->pps_payload.pps_4 = (u8)((dsc_cfg->bits_per_pixel & > > + DSC_PPS_BPP_HIGH_MASK) >> > > +

Re: [PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-07-31 Thread Chris Wilson
Quoting Manasi Navare (2018-07-31 22:07:06) > + /* PPS 4 */ > + pps_sdp->pps_payload.pps_4 = (u8)((dsc_cfg->bits_per_pixel & > + DSC_PPS_BPP_HIGH_MASK) >> > + DSC_PPS_MSB_SHIFT) | To avoid overhanging

[PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-07-31 Thread Manasi Navare
According to Display Stream compression spec 1.2, the picture parameter set metadata is sent from source to sink device using the DP Secondary data packet. An infoframe is formed for the PPS SDP header and PPS SDP payload bytes. This patch adds helpers to fill the PPS SDP header and PPS SDP