Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-06 Thread Jani Nikula
On Tue, 05 Mar 2024, Hsin-Yi Wang wrote: > On Tue, Mar 5, 2024 at 11:25 AM Doug Anderson wrote: >> Hmm. As Hsin-Yi pointed out to me offline. Somehow we'll need to get >> the actual panel ID out. Right now in panel-edp.c we have: >> >> dev_warn(dev, >> "Unknown panel %s %#06x, using

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-05 Thread Hsin-Yi Wang
On Tue, Mar 5, 2024 at 11:25 AM Doug Anderson wrote: > > Hi, > > On Tue, Mar 5, 2024 at 12:17 AM Jani Nikula > wrote: > > > > On Mon, 04 Mar 2024, Doug Anderson wrote: > > > Hi, > > > > > > On Mon, Mar 4, 2024 at 4:19 PM Hsin-Yi Wang wrote: > > >> > > >> > > Probably change to u32

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-05 Thread Doug Anderson
Hi, On Tue, Mar 5, 2024 at 12:17 AM Jani Nikula wrote: > > On Mon, 04 Mar 2024, Doug Anderson wrote: > > Hi, > > > > On Mon, Mar 4, 2024 at 4:19 PM Hsin-Yi Wang wrote: > >> > >> > > Probably change to u32 drm_edid_get_panel_id(const struct drm_edid > >> > > *);? Given that we still need to

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-05 Thread Jani Nikula
On Mon, 04 Mar 2024, Doug Anderson wrote: > Hi, > > On Mon, Mar 4, 2024 at 4:19 PM Hsin-Yi Wang wrote: >> >> > > Probably change to u32 drm_edid_get_panel_id(const struct drm_edid >> > > *);? Given that we still need to parse id from >> > > drm_edid_read_base_block(). >> > >> > No, we no longer

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-05 Thread Jani Nikula
On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > On Mon, Mar 4, 2024 at 4:09 PM Jani Nikula > wrote: >> >> On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: >> > To clarify: >> > struct drm_edid currently is only internal to drm_edid.c. So with >> > change we will have to move it to the header drm_edid.h >>

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-04 Thread Hsin-Yi Wang
On Mon, Mar 4, 2024 at 4:09 PM Jani Nikula wrote: > > On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > > On Mon, Mar 4, 2024 at 12:38 PM Jani Nikula > > wrote: > >> > >> On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > >> > Add a function to check if the EDID base block contains a given string. > >> > >

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-04 Thread Doug Anderson
Hi, On Mon, Mar 4, 2024 at 4:19 PM Hsin-Yi Wang wrote: > > > > Probably change to u32 drm_edid_get_panel_id(const struct drm_edid > > > *);? Given that we still need to parse id from > > > drm_edid_read_base_block(). > > > > No, we no longer need to parse the id outside of drm_edid.c. You'll

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-04 Thread Hsin-Yi Wang
On Mon, Mar 4, 2024 at 4:09 PM Jani Nikula wrote: > > On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > > On Mon, Mar 4, 2024 at 12:38 PM Jani Nikula > > wrote: > >> > >> On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > >> > Add a function to check if the EDID base block contains a given string. > >> > >

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-04 Thread Jani Nikula
On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > On Mon, Mar 4, 2024 at 12:38 PM Jani Nikula > wrote: >> >> On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: >> > Add a function to check if the EDID base block contains a given string. >> > >> > One of the use cases is fetching panel from a list of panel

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-04 Thread Dmitry Baryshkov
On Mon, 4 Mar 2024 at 22:38, Jani Nikula wrote: > > On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > > Add a function to check if the EDID base block contains a given string. > > > > One of the use cases is fetching panel from a list of panel names, since > > some panel vendors put the monitor name

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-04 Thread Hsin-Yi Wang
On Mon, Mar 4, 2024 at 12:38 PM Jani Nikula wrote: > > On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > > Add a function to check if the EDID base block contains a given string. > > > > One of the use cases is fetching panel from a list of panel names, since > > some panel vendors put the monitor name

Re: [PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-04 Thread Jani Nikula
On Mon, 04 Mar 2024, Hsin-Yi Wang wrote: > Add a function to check if the EDID base block contains a given string. > > One of the use cases is fetching panel from a list of panel names, since > some panel vendors put the monitor name after EDID_DETAIL_MONITOR_STRING > instead of

[PATCH v3 2/4] drm/edid: Add a function to check monitor string

2024-03-04 Thread Hsin-Yi Wang
Add a function to check if the EDID base block contains a given string. One of the use cases is fetching panel from a list of panel names, since some panel vendors put the monitor name after EDID_DETAIL_MONITOR_STRING instead of EDID_DETAIL_MONITOR_NAME. Signed-off-by: Hsin-Yi Wang --- v2->v3: