Re: Re: [PATCH v3 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2024-02-08 Thread Lucas De Marchi
On Thu, Feb 08, 2024 at 09:07:32PM +0100, Andi Shyti wrote: Hi Lucas, ... +#define REG_GENMASK(__high, __low) GENMASK_U32(__high, __low) +#define REG_GENMASK64(__high, __low) GENMASK_U64(__high, __low) +#define REG_GENMASK16(__high, __low) GENMASK_U16(__high, __low) +#define

Re: [PATCH v3 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2024-02-08 Thread Andi Shyti
Hi Lucas, ... > +#define REG_GENMASK(__high, __low) GENMASK_U32(__high, __low) > +#define REG_GENMASK64(__high, __low) GENMASK_U64(__high, __low) > +#define REG_GENMASK16(__high, __low) GENMASK_U16(__high, __low) > +#define REG_GENMASK8(__high, __low) GENMASK_U8(__high, __low) I was hoping

Re: [PATCH v3 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2024-02-08 Thread Jani Nikula
On Wed, 07 Feb 2024, Lucas De Marchi wrote: > Now that include/linux/bits.h implements fixed-width GENMASK_*, use them > to implement the i915/xe specific macros. Converting each driver to use > the generic macros are left for later, when/if other driver-specific > macros are also generalized. >

[PATCH v3 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2024-02-07 Thread Lucas De Marchi
Now that include/linux/bits.h implements fixed-width GENMASK_*, use them to implement the i915/xe specific macros. Converting each driver to use the generic macros are left for later, when/if other driver-specific macros are also generalized. Signed-off-by: Lucas De Marchi Acked-by: Jani Nikula