Re: [PATCH v4 02/12] drm/client: Restrict the plane_state scope

On Fri, 14 Jun 2019, Maxime Ripard wrote: > Hi Jani, > > On Fri, Jun 14, 2019 at 03:28:59PM +0300, Jani Nikula wrote: >> On Fri, 14 Jun 2019, Maxime Ripard wrote: >> > The drm_client_modeset_commit_atomic function uses two times the >> > plane_state variable in inner blocks of code, but the

Re: [PATCH v4 02/12] drm/client: Restrict the plane_state scope

Den 14.06.2019 14.13, skrev Maxime Ripard: > The drm_client_modeset_commit_atomic function uses two times the > plane_state variable in inner blocks of code, but the variable has a scope > global to this function. > > This will lead to inadvertent devs to reuse the variable in the second >

Re: [PATCH v4 02/12] drm/client: Restrict the plane_state scope

Hi Jani, On Fri, Jun 14, 2019 at 03:28:59PM +0300, Jani Nikula wrote: > On Fri, 14 Jun 2019, Maxime Ripard wrote: > > The drm_client_modeset_commit_atomic function uses two times the > > plane_state variable in inner blocks of code, but the variable has a scope > > global to this function. > > >

Re: [PATCH v4 02/12] drm/client: Restrict the plane_state scope

On Fri, 14 Jun 2019, Maxime Ripard wrote: > The drm_client_modeset_commit_atomic function uses two times the > plane_state variable in inner blocks of code, but the variable has a scope > global to this function. > > This will lead to inadvertent devs to reuse the variable in the second > block

[PATCH v4 02/12] drm/client: Restrict the plane_state scope

The drm_client_modeset_commit_atomic function uses two times the plane_state variable in inner blocks of code, but the variable has a scope global to this function. This will lead to inadvertent devs to reuse the variable in the second block with the value left by the first, without any warning