Re: [PATCH v4 1/1] drm/syncobj: add sideband payload

2019-08-09 Thread Lionel Landwerlin
On 09/08/2019 15:27, Koenig, Christian wrote: Am 09.08.19 um 14:26 schrieb Lionel Landwerlin: On 09/08/2019 14:44, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-08-09 12:30:30) diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 8a5b2f8f8eb9..1ce83853f997 100644 ---

Re: [PATCH v4 1/1] drm/syncobj: add sideband payload

2019-08-09 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-08-09 13:38:57) > On 09/08/2019 14:58, Chris Wilson wrote: > > Not atomic (the u64 write should really be to avoid total corruption) > > and nothing prevents userspace from racing. How safe is that in the > > overall design? > > > Atomic would prevent issue

Re: [PATCH v4 1/1] drm/syncobj: add sideband payload

2019-08-09 Thread Chris Wilson
Quoting Chris Wilson (2019-08-09 12:58:51) > Quoting Lionel Landwerlin (2019-08-09 12:30:30) > > + if (flags & I915_DRM_SYNCOBJ_BINARY_ITEM_VALUE_READ) { > > + copy_to_user([i], > > [i]->binary_payload, sizeof(values[i])); > > + ret = ret

Re: [PATCH v4 1/1] drm/syncobj: add sideband payload

2019-08-09 Thread Lionel Landwerlin
On 09/08/2019 14:58, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-08-09 12:30:30) +int drm_syncobj_binary_ioctl(struct drm_device *dev, void *data, +struct drm_file *file_private) +{ + struct drm_syncobj_binary_array *args = data; + struct

Re: [PATCH v4 1/1] drm/syncobj: add sideband payload

2019-08-09 Thread Koenig, Christian
Am 09.08.19 um 14:26 schrieb Lionel Landwerlin: > On 09/08/2019 14:44, Chris Wilson wrote: >> Quoting Lionel Landwerlin (2019-08-09 12:30:30) >>> diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h >>> index 8a5b2f8f8eb9..1ce83853f997 100644 >>> --- a/include/uapi/drm/drm.h >>> +++

Re: [PATCH v4 1/1] drm/syncobj: add sideband payload

2019-08-09 Thread Lionel Landwerlin
On 09/08/2019 14:44, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-08-09 12:30:30) diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 8a5b2f8f8eb9..1ce83853f997 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -785,6 +785,22 @@ struct

Re: [PATCH v4 1/1] drm/syncobj: add sideband payload

2019-08-09 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-08-09 12:30:30) > +int drm_syncobj_binary_ioctl(struct drm_device *dev, void *data, > +struct drm_file *file_private) > +{ > + struct drm_syncobj_binary_array *args = data; > + struct drm_syncobj **syncobjs; > + u32

Re: [PATCH v4 1/1] drm/syncobj: add sideband payload

2019-08-09 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-08-09 12:30:30) > diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h > index 8a5b2f8f8eb9..1ce83853f997 100644 > --- a/include/uapi/drm/drm.h > +++ b/include/uapi/drm/drm.h > @@ -785,6 +785,22 @@ struct drm_syncobj_timeline_array { > __u32 pad; >

[PATCH v4 1/1] drm/syncobj: add sideband payload

2019-08-09 Thread Lionel Landwerlin
The Vulkan timeline semaphores allow signaling to happen on the point of the timeline without all of the its dependencies to be created. The current 2 implementations (AMD/Intel) of the Vulkan spec on top of the Linux kernel are using a thread to wait on the dependencies of a given point to