Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Gerd Hoffmann
Hi, > > > I had a look into this and how other drivers are doing it. > > > msm[1] and etnaviv[2] seem to use the same dual-use variable. > > > > Ok, lets do it the same way then. > > What is the status of the userspace side of this? > > The patch is hosted here[1], but is as of yet unmerged.

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Robert Foss
On 2018-11-12 12:11, Gerd Hoffmann wrote: On Mon, Nov 12, 2018 at 11:30:57AM +0100, Robert Foss wrote: Hey Gerd On 2018-11-12 10:10, Gerd Hoffmann wrote: On Fri, Nov 09, 2018 at 06:13:52PM +0100, Robert Foss wrote: Hey Gerd, On 2018-11-09 11:13, Gerd Hoffmann wrote: On Mon, Nov 05, 2018

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Gerd Hoffmann
On Mon, Nov 12, 2018 at 11:30:57AM +0100, Robert Foss wrote: > Hey Gerd > > On 2018-11-12 10:10, Gerd Hoffmann wrote: > > On Fri, Nov 09, 2018 at 06:13:52PM +0100, Robert Foss wrote: > > > Hey Gerd, > > > > > > On 2018-11-09 11:13, Gerd Hoffmann wrote: > > > > On Mon, Nov 05, 2018 at 05:25:05PM

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Robert Foss
Hey Gerd On 2018-11-12 10:10, Gerd Hoffmann wrote: On Fri, Nov 09, 2018 at 06:13:52PM +0100, Robert Foss wrote: Hey Gerd, On 2018-11-09 11:13, Gerd Hoffmann wrote: On Mon, Nov 05, 2018 at 05:25:05PM +, Emil Velikov wrote: On Mon, 5 Nov 2018 at 11:42, Robert Foss wrote: When the

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Gerd Hoffmann
On Fri, Nov 09, 2018 at 06:13:52PM +0100, Robert Foss wrote: > Hey Gerd, > > On 2018-11-09 11:13, Gerd Hoffmann wrote: > > On Mon, Nov 05, 2018 at 05:25:05PM +, Emil Velikov wrote: > > > On Mon, 5 Nov 2018 at 11:42, Robert Foss > > > wrote: > > > > > > > > When the execbuf call receives an

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-09 Thread Robert Foss
Hey Gerd, On 2018-11-09 11:13, Gerd Hoffmann wrote: On Mon, Nov 05, 2018 at 05:25:05PM +, Emil Velikov wrote: On Mon, 5 Nov 2018 at 11:42, Robert Foss wrote: When the execbuf call receives an in-fence it will get the dma_fence related to that fence fd and wait on it before submitting

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-09 Thread Gerd Hoffmann
On Mon, Nov 05, 2018 at 05:25:05PM +, Emil Velikov wrote: > On Mon, 5 Nov 2018 at 11:42, Robert Foss wrote: > > > > When the execbuf call receives an in-fence it will get the dma_fence > > related to that fence fd and wait on it before submitting the draw call. > > > > On the out-fence side

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-05 Thread Robert Foss
Heya, On 2018-11-05 18:25, Emil Velikov wrote: On Mon, 5 Nov 2018 at 11:42, Robert Foss wrote: When the execbuf call receives an in-fence it will get the dma_fence related to that fence fd and wait on it before submitting the draw call. On the out-fence side we get fence returned by the

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-05 Thread Emil Velikov
On Mon, 5 Nov 2018 at 11:42, Robert Foss wrote: > > When the execbuf call receives an in-fence it will get the dma_fence > related to that fence fd and wait on it before submitting the draw call. > > On the out-fence side we get fence returned by the submitted draw call > and attach it to a

[PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-05 Thread Robert Foss
When the execbuf call receives an in-fence it will get the dma_fence related to that fence fd and wait on it before submitting the draw call. On the out-fence side we get fence returned by the submitted draw call and attach it to a sync_file and send the sync_file fd to userspace. On error -1 is