Re: [PATCH v6 08/11] drm/i915/pxp: Use to_gt() helper

2021-12-09 Thread Matt Roper
On Fri, Dec 10, 2021 at 02:21:53AM +0200, Andi Shyti wrote: > Hi Matt, > > > > -static inline struct intel_pxp *i915_dev_to_pxp(struct device *i915_kdev) > > > +static struct intel_pxp *i915_dev_to_pxp(struct device *i915_kdev) > > > > Was dropping the inline here intentional? It doesn't seem

Re: [PATCH v6 08/11] drm/i915/pxp: Use to_gt() helper

2021-12-09 Thread Andi Shyti
Hi Matt, > > -static inline struct intel_pxp *i915_dev_to_pxp(struct device *i915_kdev) > > +static struct intel_pxp *i915_dev_to_pxp(struct device *i915_kdev) > > Was dropping the inline here intentional? It doesn't seem like there's > any reason to drop it, and if it was intentional the

Re: [PATCH v6 08/11] drm/i915/pxp: Use to_gt() helper

2021-12-09 Thread Matt Roper
On Thu, Dec 09, 2021 at 03:25:09PM +0200, Andi Shyti wrote: > Use to_gt() helper consistently throughout the codebase. > Pure mechanical s/i915->gt/to_gt(i915). No functional changes. > > Signed-off-by: Andi Shyti > --- > drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 6 -- > 1 file changed, 4

[PATCH v6 08/11] drm/i915/pxp: Use to_gt() helper

2021-12-09 Thread Andi Shyti
Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git