Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-07 Thread Emil Velikov
On 7 August 2018 at 13:28, Daniel Vetter wrote: > On Tue, Aug 07, 2018 at 12:01:50PM +0100, Emil Velikov wrote: >> On 3 August 2018 at 20:50, Sean Paul wrote: >> > On Fri, Aug 03, 2018 at 06:03:50PM +0100, Emil Velikov wrote: >> >> On 3 August 2018 at 16:06, Martin Fuzzey >> >> wrote: >> >> > H

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-07 Thread Martin Fuzzey
On 06/08/18 21:05, Rob Herring wrote: On Fri, Aug 3, 2018 at 1:50 PM Sean Paul wrote: Fwiw, I'd lean towards allowing DUMB allocation from the render nodes. I understand it limits use cases that are undesirable, but it is also limiting usecases that are desirable. So, given that people are goin

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-07 Thread Daniel Vetter
On Tue, Aug 07, 2018 at 12:01:50PM +0100, Emil Velikov wrote: > On 3 August 2018 at 20:50, Sean Paul wrote: > > On Fri, Aug 03, 2018 at 06:03:50PM +0100, Emil Velikov wrote: > >> On 3 August 2018 at 16:06, Martin Fuzzey > >> wrote: > >> > Hi Emil, > >> > > >> > On 03/08/18 14:35, Emil Velikov wr

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-07 Thread Emil Velikov
On 3 August 2018 at 20:50, Sean Paul wrote: > On Fri, Aug 03, 2018 at 06:03:50PM +0100, Emil Velikov wrote: >> On 3 August 2018 at 16:06, Martin Fuzzey >> wrote: >> > Hi Emil, >> > >> > On 03/08/18 14:35, Emil Velikov wrote: >> >> >> >> Hi Martin, >> >> >> >> On 1 August 2018 at 15:24, Martin Fu

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-06 Thread Rob Herring
On Fri, Aug 3, 2018 at 1:50 PM Sean Paul wrote: > > On Fri, Aug 03, 2018 at 06:03:50PM +0100, Emil Velikov wrote: > > On 3 August 2018 at 16:06, Martin Fuzzey > > wrote: > > > Hi Emil, > > > > > > On 03/08/18 14:35, Emil Velikov wrote: > > >> > > >> Hi Martin, > > >> > > >> On 1 August 2018 at 1

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-06 Thread Martin Fuzzey
Hi Emil, On 03/08/18 14:35, Emil Velikov wrote: Hi Martin, On 1 August 2018 at 15:24, Martin Fuzzey wrote: Let's start with the not-so obvious question: Why does one open the imx as render node? Of the top of my head: There is nothing in egl/android that should require an authenticated devic

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-03 Thread Sean Paul
On Fri, Aug 03, 2018 at 06:03:50PM +0100, Emil Velikov wrote: > On 3 August 2018 at 16:06, Martin Fuzzey wrote: > > Hi Emil, > > > > On 03/08/18 14:35, Emil Velikov wrote: > >> > >> Hi Martin, > >> > >> On 1 August 2018 at 15:24, Martin Fuzzey > >> wrote: > >> > >> Let's start with the not-so obv

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-03 Thread Emil Velikov
On 3 August 2018 at 16:06, Martin Fuzzey wrote: > Hi Emil, > > On 03/08/18 14:35, Emil Velikov wrote: >> >> Hi Martin, >> >> On 1 August 2018 at 15:24, Martin Fuzzey >> wrote: >> >> Let's start with the not-so obvious question: >> Why does one open the imx as render node? >> >> Of the top of my h

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-03 Thread Emil Velikov
Hi Martin, On 1 August 2018 at 15:24, Martin Fuzzey wrote: > Hi, > > I am running into the same problem using etnaviv on i.MX6 under Android 8.1 > > The mesa etnaviv code uses CREATE_DUMB / MAP_DUMB for the scanout buffers > and is called from the surfaceflinger process. > > But, under Android 8.

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-03 Thread Emil Velikov
Hi all, Sharing some ideas on the topic. Personally I'm neither for, nor against this patch. On 24 July 2018 at 09:22, Robert Foss wrote: > From: Tomasz Figa > > There is no particular reason to prevent userspace for using this IOCTL, > considering that it already has access to other, platform-

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-02 Thread Martin Fuzzey
Hi, I am running into the same problem using etnaviv on i.MX6 under Android 8.1 The mesa etnaviv code uses CREATE_DUMB / MAP_DUMB for the scanout buffers and is called from the surfaceflinger process. But, under Android 8.1 drm_hwcomposer runs in a seperate process to surfaceflinger. Since drm

[RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-07-24 Thread Robert Foss
From: Tomasz Figa There is no particular reason to prevent userspace for using this IOCTL, considering that it already has access to other, platform-specific IOCTLs. This patch makes is possible to have the same userspace code work regardless on the underlying platform, which significantly simpli