[Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

> + > +#define fourcc_mod_code(vendor, val) \ > + u64)DRM_FORMAT_MOD_VENDOR_## vendor) << 56) | (val & > 0x00ffL)) eh, yeah no, /home/airlied/kernel/drm-2.6/drivers/gpu/drm/i915/intel_pm.c: In function ‘skl_wm_method2’:

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Jan 30, 2015 at 05:08:23PM +0100, Daniel Vetter wrote: > From: Rob Clark > > In DRM/KMS we are lacking a good way to deal with tiled/compressed > formats. Especially in the case of dmabuf/prime buffer sharing, where > we cannot always rely on under-the-hood flags passed to driver

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

From: Rob Clark In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffer sharing, where we cannot always rely on under-the-hood flags passed to driver specific gem-create ioctl to pass around these extra

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Jan 30, 2015 at 09:51:48AM -0500, Rob Clark wrote: > On Fri, Jan 30, 2015 at 9:35 AM, Tvrtko Ursulin > wrote: > > > > On 01/30/2015 01:43 PM, Rob Clark wrote: > >> > >> On Fri, Jan 30, 2015 at 5:51 AM, Tvrtko Ursulin > >> wrote: > > +/* > + * Format Modifier tokens: >

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

On 01/29/2015 05:01 PM, Daniel Vetter wrote: > +#define fourcc_mod_code(vendor, val) \ > + u64)DRM_FORMAT_MOD_VENDOR_## vendor) << 56) | (val & > 0x00ffL) Unbalanced parentheses. Finding them as I go along, sorry! :) Regards, Tvrtko

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

On 01/30/2015 01:43 PM, Rob Clark wrote: > On Fri, Jan 30, 2015 at 5:51 AM, Tvrtko Ursulin > wrote: >>> +/* >>> + * Format Modifier tokens: >>> + * >>> + * When adding a new token please document the layout with a code >>> comment, >>> + * similar to the fourcc codes above. drm_fourcc.h is

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

On 01/29/2015 05:01 PM, Daniel Vetter wrote: [snip] > + > +/* > + * Format Modifiers: > + * > + * Format modifiers describe, typically, a re-ordering or modification > + * of the data in a plane of an FB. This can be used to express tiled/ > + * swizzled formats, or compression, or a

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Jan 30, 2015 at 9:35 AM, Tvrtko Ursulin wrote: > > On 01/30/2015 01:43 PM, Rob Clark wrote: >> >> On Fri, Jan 30, 2015 at 5:51 AM, Tvrtko Ursulin >> wrote: +/* + * Format Modifier tokens: + * + * When adding a new token please document the layout with a code

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Jan 30, 2015 at 5:51 AM, Tvrtko Ursulin wrote: >> +/* >> + * Format Modifier tokens: >> + * >> + * When adding a new token please document the layout with a code >> comment, >> + * similar to the fourcc codes above. drm_fourcc.h is considered the >> + * authoritative source for all of

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

From: Rob Clark In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffer sharing, where we cannot always rely on under-the-hood flags passed to driver specific gem-create ioctl to pass around these extra

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

On Thu, Jan 29, 2015 at 12:55:48PM +, Tvrtko Ursulin wrote: > > On 01/29/2015 11:57 AM, Daniel Vetter wrote: > >On Thu, Jan 29, 2015 at 11:43:07AM +, Tvrtko Ursulin wrote: > >> > >>On 01/29/2015 11:30 AM, Daniel Vetter wrote: > >>>On Wed, Jan 28, 2015 at 05:57:56PM +, Tvrtko Ursulin

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

On Thu, Jan 29, 2015 at 11:43:07AM +, Tvrtko Ursulin wrote: > > On 01/29/2015 11:30 AM, Daniel Vetter wrote: > >On Wed, Jan 28, 2015 at 05:57:56PM +, Tvrtko Ursulin wrote: > >> > >>On 01/28/2015 05:37 PM, Daniel Vetter wrote: > >>>From: Rob Clark > >>> > >>>In DRM/KMS we are lacking a

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

On 01/29/2015 11:57 AM, Daniel Vetter wrote: > On Thu, Jan 29, 2015 at 11:43:07AM +, Tvrtko Ursulin wrote: >> >> On 01/29/2015 11:30 AM, Daniel Vetter wrote: >>> On Wed, Jan 28, 2015 at 05:57:56PM +, Tvrtko Ursulin wrote: On 01/28/2015 05:37 PM, Daniel Vetter wrote: > From:

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

On Wed, Jan 28, 2015 at 05:57:56PM +, Tvrtko Ursulin wrote: > > On 01/28/2015 05:37 PM, Daniel Vetter wrote: > >From: Rob Clark > > > >In DRM/KMS we are lacking a good way to deal with tiled/compressed > >formats. Especially in the case of dmabuf/prime buffer sharing, where > >we cannot

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

On Wed, Jan 28, 2015 at 01:46:53PM -0500, Rob Clark wrote: > On Wed, Jan 28, 2015 at 12:37 PM, Daniel Vetter > wrote: > > From: Rob Clark > > > > In DRM/KMS we are lacking a good way to deal with tiled/compressed > > formats. Especially in the case of dmabuf/prime buffer sharing, where > > we

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

On 01/29/2015 11:30 AM, Daniel Vetter wrote: > On Wed, Jan 28, 2015 at 05:57:56PM +, Tvrtko Ursulin wrote: >> >> On 01/28/2015 05:37 PM, Daniel Vetter wrote: >>> From: Rob Clark >>> >>> In DRM/KMS we are lacking a good way to deal with tiled/compressed >>> formats. Especially in the case of

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

On Thu, Jan 29, 2015 at 7:55 AM, Tvrtko Ursulin wrote: > > On 01/29/2015 11:57 AM, Daniel Vetter wrote: >> >> On Thu, Jan 29, 2015 at 11:43:07AM +, Tvrtko Ursulin wrote: >>> >>> >>> On 01/29/2015 11:30 AM, Daniel Vetter wrote: On Wed, Jan 28, 2015 at 05:57:56PM +, Tvrtko Ursulin

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

From: Rob Clark In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffer sharing, where we cannot always rely on under-the-hood flags passed to driver specific gem-create ioctl to pass around these extra

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

On 01/28/2015 05:37 PM, Daniel Vetter wrote: > From: Rob Clark > > In DRM/KMS we are lacking a good way to deal with tiled/compressed > formats. Especially in the case of dmabuf/prime buffer sharing, where > we cannot always rely on under-the-hood flags passed to driver specific > gem-create

[PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

On Wed, Jan 28, 2015 at 12:37 PM, Daniel Vetter wrote: > From: Rob Clark > > In DRM/KMS we are lacking a good way to deal with tiled/compressed > formats. Especially in the case of dmabuf/prime buffer sharing, where > we cannot always rely on under-the-hood flags passed to driver specific >

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

Hi Rob, On Thursday 18 December 2014 19:55:24 Rob Clark wrote: > On Thu, Dec 18, 2014 at 4:22 PM, Daniel Vetter wrote: > >> TODO move definition of tokens to drm_fourcc.h? > > > > Seems orthogonal imo. Another todo is to add checking to all > > drivers to reject it if it's not 0

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

Hi Daniel, On Monday 15 December 2014 08:33:10 Daniel Vetter wrote: > On Fri, Dec 12, 2014 at 10:56:53PM +0200, Laurent Pinchart wrote: > > On Wednesday 10 December 2014 18:30:10 Daniel Vetter wrote: > > > On Wed, Dec 10, 2014 at 12:17:51PM -0500, Rob Clark wrote: > > > > In DRM/KMS we are

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Thu, Dec 18, 2014 at 10:54:14PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Monday 15 December 2014 08:33:10 Daniel Vetter wrote: > > On Fri, Dec 12, 2014 at 10:56:53PM +0200, Laurent Pinchart wrote: > > > On Wednesday 10 December 2014 18:30:10 Daniel Vetter wrote: > > > > On Wed, Dec

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Thu, Dec 18, 2014 at 4:22 PM, Daniel Vetter wrote: >> > > > > TODO move definition of tokens to drm_fourcc.h? >> > > > >> > > > Seems orthogonal imo. Another todo is to add checking to all drivers to >> > > > reject it if it's not 0 with -EINVAL. Otherwise we have yet another >> > > > case >>

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Mon, Dec 15, 2014 at 10:19:47PM +, Daniel Stone wrote: > Hi, > > On 12 December 2014 at 18:22, Ville Syrjälä linux.intel.com> > wrote: > > > > On Fri, Dec 12, 2014 at 06:05:49PM +, Daniel Stone wrote: > > > On 12 December 2014 at 18:00, Ville Syrjälä < > > ville.syrjala at

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On 12.12.2014 20:27, Daniel Stone wrote: > On 10 December 2014 at 17:17, Rob Clark > wrote: > > In DRM/KMS we are lacking a good way to deal with tiled/compressed > formats. Especially in the case of dmabuf/prime buffer sharing, where > we cannot

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Tue, Dec 16, 2014 at 3:01 AM, Daniel Stone wrote: > Hi, > > On 16 December 2014 at 03:56, Michel Dänzer wrote: >> >> On 12.12.2014 20:27, Daniel Stone wrote: >> > It might be useful to make the interpretation modifiers bitmaskable, so >> > they can be combined (e.g. wide-range/unclamped YUV

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

Hi, On 16 December 2014 at 03:56, Michel Dänzer wrote: > > On 12.12.2014 20:27, Daniel Stone wrote: > > It might be useful to make the interpretation modifiers bitmaskable, so > > they can be combined (e.g. wide-range/unclamped YUV | whatever chroma > > siting), but I can't think of a usecase

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

Hi, On 12 December 2014 at 18:22, Ville Syrjälä wrote: > > On Fri, Dec 12, 2014 at 06:05:49PM +, Daniel Stone wrote: > > On 12 December 2014 at 18:00, Ville Syrjälä < > ville.syrjala at linux.intel.com> > > wrote: > > > Well anyone who is serious about quality ought to handle that stuff.

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 12:05:41PM -0500, Rob Clark wrote: > On Fri, Dec 12, 2014 at 11:14 AM, Ville Syrjälä > wrote: > > On Fri, Dec 12, 2014 at 11:00:29AM -0500, Rob Clark wrote: > >> On Fri, Dec 12, 2014 at 10:30 AM, Ville Syrjälä > >> wrote: > >> >> > >> >> Having them separated is still

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 10:56:21AM -0500, Rob Clark wrote: > On Fri, Dec 12, 2014 at 10:11 AM, Daniel Stone > wrote: > > Hi, > > > > On 12 December 2014 at 14:56, Ville Syrjälä > linux.intel.com> > > wrote: > >> > >> On Fri, Dec 12, 2014 at 08:50:18AM -0500, Rob Clark wrote: > >> > >> > It

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 10:56:53PM +0200, Laurent Pinchart wrote: > On Wednesday 10 December 2014 18:30:10 Daniel Vetter wrote: > > On Wed, Dec 10, 2014 at 12:17:51PM -0500, Rob Clark wrote: > > > In DRM/KMS we are lacking a good way to deal with tiled/compressed > > > formats. Especially in the

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 04:33:38PM -0500, Rob Clark wrote: > On Fri, Dec 12, 2014 at 3:57 PM, Laurent Pinchart > wrote: > > Hi Rob, > > > > On Wednesday 10 December 2014 12:17:51 Rob Clark wrote: > >> In DRM/KMS we are lacking a good way to deal with tiled/compressed > >> formats. Especially in

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

Hi Rob, On Wednesday 10 December 2014 12:17:51 Rob Clark wrote: > In DRM/KMS we are lacking a good way to deal with tiled/compressed > formats. Especially in the case of dmabuf/prime buffer sharing, where > we cannot always rely on under-the-hood flags passed to driver specific > gem-create

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Wednesday 10 December 2014 18:30:10 Daniel Vetter wrote: > On Wed, Dec 10, 2014 at 12:17:51PM -0500, Rob Clark wrote: > > In DRM/KMS we are lacking a good way to deal with tiled/compressed > > formats. Especially in the case of dmabuf/prime buffer sharing, where > > we cannot always rely on

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 06:05:49PM +, Daniel Stone wrote: > Hi, > > On 12 December 2014 at 18:00, Ville Syrjälä linux.intel.com> > wrote: > > > > On Fri, Dec 12, 2014 at 05:11:50PM +, Daniel Stone wrote: > > > If you're doing it through GL, you've already lost. Either you're doing > >

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 05:11:50PM +, Daniel Stone wrote: > Hi, > > On 12 December 2014 at 15:30, Ville Syrjälä linux.intel.com> > wrote: > > > > On Fri, Dec 12, 2014 at 03:11:02PM +, Daniel Stone wrote: > > > On 12 December 2014 at 14:56, Ville Syrjälä < > > ville.syrjala at

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 11:00:29AM -0500, Rob Clark wrote: > On Fri, Dec 12, 2014 at 10:30 AM, Ville Syrjälä > wrote: > >> > >> Having them separated is still kinda nice though, for the same rationale as > >> the EGLImage import extension having them as hints. If your hardware > >> doesn't

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

Hi, On 12 December 2014 at 18:00, Ville Syrjälä wrote: > > On Fri, Dec 12, 2014 at 05:11:50PM +, Daniel Stone wrote: > > If you're doing it through GL, you've already lost. Either you're doing > > some magic behind the user's back to bind multi-planar dmabuf-EGLImages > to > > TEXTURE_2D

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 03:11:02PM +, Daniel Stone wrote: > Hi, > > On 12 December 2014 at 14:56, Ville Syrjälä linux.intel.com> > wrote: > > > > On Fri, Dec 12, 2014 at 08:50:18AM -0500, Rob Clark wrote: > > > > It does make me briefly think of just letting us set properties on fb > > > >

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

Hi, On 12 December 2014 at 15:30, Ville Syrjälä wrote: > > On Fri, Dec 12, 2014 at 03:11:02PM +, Daniel Stone wrote: > > On 12 December 2014 at 14:56, Ville Syrjälä < > ville.syrjala at linux.intel.com> > > wrote: > > Having them separated is still kinda nice though, for the same

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 08:50:18AM -0500, Rob Clark wrote: > On Fri, Dec 12, 2014 at 6:27 AM, Daniel Stone wrote: > > Hey, > > > > On 10 December 2014 at 17:17, Rob Clark wrote: > >> > >> In DRM/KMS we are lacking a good way to deal with tiled/compressed > >> formats. Especially in the case of

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 3:57 PM, Laurent Pinchart wrote: > Hi Rob, > > On Wednesday 10 December 2014 12:17:51 Rob Clark wrote: >> In DRM/KMS we are lacking a good way to deal with tiled/compressed >> formats. Especially in the case of dmabuf/prime buffer sharing, where >> we cannot always rely

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

Hi, On 12 December 2014 at 14:56, Ville Syrjälä wrote: > > On Fri, Dec 12, 2014 at 08:50:18AM -0500, Rob Clark wrote: > > It does make me briefly think of just letting us set properties on fb > > objects :-P (but maybe that is a bit overkill) > > Yeah I had the same idea at some point. But

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 11:14 AM, Ville Syrjälä wrote: > On Fri, Dec 12, 2014 at 11:00:29AM -0500, Rob Clark wrote: >> On Fri, Dec 12, 2014 at 10:30 AM, Ville Syrjälä >> wrote: >> >> >> >> Having them separated is still kinda nice though, for the same rationale >> >> as >> >> the EGLImage

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

Hey, On 10 December 2014 at 17:17, Rob Clark wrote: > > In DRM/KMS we are lacking a good way to deal with tiled/compressed > formats. Especially in the case of dmabuf/prime buffer sharing, where > we cannot always rely on under-the-hood flags passed to driver specific > gem-create ioctl to pass

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 10:30 AM, Ville Syrjälä wrote: >> >> Having them separated is still kinda nice though, for the same rationale as >> the EGLImage import extension having them as hints. If your hardware >> doesn't support the tiling/compression format you use, then you're going to >> be

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 10:11 AM, Daniel Stone wrote: > Hi, > > On 12 December 2014 at 14:56, Ville Syrjälä linux.intel.com> > wrote: >> >> On Fri, Dec 12, 2014 at 08:50:18AM -0500, Rob Clark wrote: >> >> > It does make me briefly think of just letting us set properties on fb >> >> > objects

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Fri, Dec 12, 2014 at 6:27 AM, Daniel Stone wrote: > Hey, > > On 10 December 2014 at 17:17, Rob Clark wrote: >> >> In DRM/KMS we are lacking a good way to deal with tiled/compressed >> formats. Especially in the case of dmabuf/prime buffer sharing, where >> we cannot always rely on

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

On Wed, Dec 10, 2014 at 12:17:51PM -0500, Rob Clark wrote: > In DRM/KMS we are lacking a good way to deal with tiled/compressed > formats. Especially in the case of dmabuf/prime buffer sharing, where > we cannot always rely on under-the-hood flags passed to driver specific > gem-create ioctl to

[RFC] drm: add support for tiled/compressed/etc modifier in addfb2

In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffer sharing, where we cannot always rely on under-the-hood flags passed to driver specific gem-create ioctl to pass around these extra flags. The proposal is to add a per-plane