Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Sui Jingfeng
Hi, On 2024/3/22 20:31, Maxime Ripard wrote: On Fri, Mar 22, 2024 at 07:13:54PM +0800, Sui Jingfeng wrote: Hi, On 2024/3/22 18:31, Maxime Ripard wrote: Which default config are you talking about? This compiles fine with all drm-misc defconfig, x86 defconfig and allmodconfig. The

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Maxime Ripard
On Fri, Mar 22, 2024 at 07:13:54PM +0800, Sui Jingfeng wrote: > Hi, > > > On 2024/3/22 18:31, Maxime Ripard wrote: > > Which default config are you talking about? This compiles fine with all > > drm-misc defconfig, x86 defconfig and allmodconfig. > > The drm_hdmi_avi_infoframe_colorimetry()

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Jani Nikula
On Fri, 22 Mar 2024, Maxime Ripard wrote: > On Fri, Mar 22, 2024 at 11:22:14AM +0200, Jani Nikula wrote: >> On Fri, 22 Mar 2024, Sui Jingfeng wrote: >> > Hi, >> > >> > >> > On 2024/3/21 23:29, Maxime Ripard wrote: >> >> Infoframes in KMS is usually handled by a bunch of low-level helpers >> >>

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Sui Jingfeng
Hi, On 2024/3/22 17:22, Jani Nikula wrote: On Fri, 22 Mar 2024, Sui Jingfeng wrote: Hi, On 2024/3/21 23:29, Maxime Ripard wrote: Infoframes in KMS is usually handled by a bunch of low-level helpers that require quite some boilerplate for drivers. This leads to discrepancies with how

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Sui Jingfeng
Hi, On 2024/3/22 18:31, Maxime Ripard wrote: Which default config are you talking about? This compiles fine with all drm-misc defconfig, x86 defconfig and allmodconfig. The drm_hdmi_avi_infoframe_colorimetry() function is belong to the drm_display_helper.ko kernel module, it get called from

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Maxime Ripard
On Fri, Mar 22, 2024 at 11:22:14AM +0200, Jani Nikula wrote: > On Fri, 22 Mar 2024, Sui Jingfeng wrote: > > Hi, > > > > > > On 2024/3/21 23:29, Maxime Ripard wrote: > >> Infoframes in KMS is usually handled by a bunch of low-level helpers > >> that require quite some boilerplate for drivers. This

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Maxime Ripard
Hi, On Fri, Mar 22, 2024 at 05:53:07AM +0800, Sui Jingfeng wrote: > Hi, > > > On 2024/3/21 23:29, Maxime Ripard wrote: > > Infoframes in KMS is usually handled by a bunch of low-level helpers > > that require quite some boilerplate for drivers. This leads to > > discrepancies with how drivers

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-22 Thread Jani Nikula
On Fri, 22 Mar 2024, Sui Jingfeng wrote: > Hi, > > > On 2024/3/21 23:29, Maxime Ripard wrote: >> Infoframes in KMS is usually handled by a bunch of low-level helpers >> that require quite some boilerplate for drivers. This leads to >> discrepancies with how drivers generate them, and which are

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-21 Thread Sui Jingfeng
Hi, On 2024/3/21 23:29, Maxime Ripard wrote: Infoframes in KMS is usually handled by a bunch of low-level helpers that require quite some boilerplate for drivers. This leads to discrepancies with how drivers generate them, and which are actually sent. Now that we have everything needed to