Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-27 Thread Ville Syrjälä
On Wed, Nov 25, 2015 at 02:38:04PM -0500, Alex Deucher wrote: > On Wed, Nov 25, 2015 at 1:21 PM, Mario Kleiner > wrote: > > On 11/25/2015 06:58 PM, Ville Syrjälä wrote: > >> > >> On Wed, Nov 25, 2015 at 06:24:13PM +0100, Mario Kleiner wrote: > >>> > >>> On 11/23/2015 09:24 PM, Ville Syrjälä

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-27 Thread Mario Kleiner
On 11/25/2015 08:38 PM, Alex Deucher wrote: > On Wed, Nov 25, 2015 at 1:21 PM, Mario Kleiner > wrote: >> On 11/25/2015 06:58 PM, Ville Syrjälä wrote: >>> >>> On Wed, Nov 25, 2015 at 06:24:13PM +0100, Mario Kleiner wrote: On 11/23/2015 09:24 PM, Ville Syrjälä wrote: > > On

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-27 Thread Mario Kleiner
On 11/25/2015 08:36 PM, Ville Syrjälä wrote: > On Wed, Nov 25, 2015 at 08:04:26PM +0100, Mario Kleiner wrote: >> On 11/25/2015 06:46 PM, Ville Syrjälä wrote: ... >> Attached is my current patch i wanted to submit for the drm core's >> drm_update_vblank_count(). I think it's good to make the

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-25 Thread Ville Syrjälä
On Wed, Nov 25, 2015 at 08:04:26PM +0100, Mario Kleiner wrote: > On 11/25/2015 06:46 PM, Ville Syrjälä wrote: > > On Wed, Nov 25, 2015 at 06:24:13PM +0100, Mario Kleiner wrote: > >> On 11/23/2015 09:24 PM, Ville Syrjälä wrote: > >>> On Mon, Nov 23, 2015 at 06:58:34PM +0100, Mario Kleiner

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-25 Thread Mario Kleiner
On 11/25/2015 06:46 PM, Ville Syrjälä wrote: > On Wed, Nov 25, 2015 at 06:24:13PM +0100, Mario Kleiner wrote: >> On 11/23/2015 09:24 PM, Ville Syrjälä wrote: >>> On Mon, Nov 23, 2015 at 06:58:34PM +0100, Mario Kleiner wrote: On 11/23/2015 04:51 PM, Ville Syrjälä wrote: >

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-25 Thread Ville Syrjälä
On Wed, Nov 25, 2015 at 06:24:13PM +0100, Mario Kleiner wrote: > On 11/23/2015 09:24 PM, Ville Syrjälä wrote: > > On Mon, Nov 23, 2015 at 06:58:34PM +0100, Mario Kleiner wrote: > >> > >> > >> On 11/23/2015 04:51 PM, Ville Syrjälä wrote: > >>> On Mon, Nov 23, 2015 at 04:23:21PM +0100, Mario

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-25 Thread Ville Syrjälä
On Wed, Nov 25, 2015 at 06:24:13PM +0100, Mario Kleiner wrote: > On 11/23/2015 09:24 PM, Ville Syrjälä wrote: > > On Mon, Nov 23, 2015 at 06:58:34PM +0100, Mario Kleiner wrote: > >> > >> > >> On 11/23/2015 04:51 PM, Ville Syrjälä wrote: > >>> On Mon, Nov 23, 2015 at 04:23:21PM +0100, Mario

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-25 Thread Mario Kleiner
On 11/25/2015 06:58 PM, Ville Syrjälä wrote: > On Wed, Nov 25, 2015 at 06:24:13PM +0100, Mario Kleiner wrote: >> On 11/23/2015 09:24 PM, Ville Syrjälä wrote: >>> On Mon, Nov 23, 2015 at 06:58:34PM +0100, Mario Kleiner wrote: On 11/23/2015 04:51 PM, Ville Syrjälä wrote: >

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-25 Thread Mario Kleiner
On 11/23/2015 09:24 PM, Ville Syrjälä wrote: > On Mon, Nov 23, 2015 at 06:58:34PM +0100, Mario Kleiner wrote: >> >> >> On 11/23/2015 04:51 PM, Ville Syrjälä wrote: >>> On Mon, Nov 23, 2015 at 04:23:21PM +0100, Mario Kleiner wrote: On 11/20/2015 04:34 PM, Ville Syrjälä wrote: > On

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-25 Thread Alex Deucher
On Wed, Nov 25, 2015 at 1:21 PM, Mario Kleiner wrote: > On 11/25/2015 06:58 PM, Ville Syrjälä wrote: >> >> On Wed, Nov 25, 2015 at 06:24:13PM +0100, Mario Kleiner wrote: >>> >>> On 11/23/2015 09:24 PM, Ville Syrjälä wrote: On Mon, Nov 23, 2015 at 06:58:34PM +0100, Mario Kleiner

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-23 Thread Ville Syrjälä
On Mon, Nov 23, 2015 at 06:58:34PM +0100, Mario Kleiner wrote: > > > On 11/23/2015 04:51 PM, Ville Syrjälä wrote: > > On Mon, Nov 23, 2015 at 04:23:21PM +0100, Mario Kleiner wrote: > >> On 11/20/2015 04:34 PM, Ville Syrjälä wrote: > >>> On Fri, Nov 20, 2015 at 04:24:50PM +0100, Mario Kleiner

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-23 Thread Mario Kleiner
On 11/23/2015 09:04 PM, Harry Wentland wrote: > Hi Mario, > > when we've had issues with this on amdgpu Christian fixed it by enabling > page flip irq all the time, rather than turning it on when usermode > request a flip and turning it back off after we handled it. I believe > that fix exists on

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-23 Thread Mario Kleiner
On 11/23/2015 04:51 PM, Ville Syrjälä wrote: > On Mon, Nov 23, 2015 at 04:23:21PM +0100, Mario Kleiner wrote: >> On 11/20/2015 04:34 PM, Ville Syrjälä wrote: >>> On Fri, Nov 20, 2015 at 04:24:50PM +0100, Mario Kleiner wrote: >> >> ... >> Ok, but why would that be a bad thing? I think we want

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-23 Thread Ville Syrjälä
On Mon, Nov 23, 2015 at 04:23:21PM +0100, Mario Kleiner wrote: > On 11/20/2015 04:34 PM, Ville Syrjälä wrote: > > On Fri, Nov 20, 2015 at 04:24:50PM +0100, Mario Kleiner wrote: > > ... > > >> What we do in radeon-kms is similar. If DRM_CALLED_FROM_VBLIRQ and we > >> are no more than 1% of the

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-23 Thread Mario Kleiner
On 11/20/2015 04:42 AM, Alex Deucher wrote: > On Thu, Nov 19, 2015 at 12:46 PM, Mario Kleiner > wrote: >> Hi Alex and Michel and Ville, >> >> it's "fix vblank stuff" time again ;-) > > Adding Harry from our display team. He might be able to fill in the > blanks of on some of this better than I

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-23 Thread Mario Kleiner
On 11/20/2015 04:34 PM, Ville Syrjälä wrote: > On Fri, Nov 20, 2015 at 04:24:50PM +0100, Mario Kleiner wrote: ... >> What we do in radeon-kms is similar. If DRM_CALLED_FROM_VBLIRQ and we >> are no more than 1% of the display height away from start of vblank we >> fudge scanout position in a

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-23 Thread Harry Wentland
Hi Mario, when we've had issues with this on amdgpu Christian fixed it by enabling page flip irq all the time, rather than turning it on when usermode request a flip and turning it back off after we handled it. I believe that fix exists on radeon already. Michel should have more info on that.

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-20 Thread Ville Syrjälä
On Fri, Nov 20, 2015 at 04:24:50PM +0100, Mario Kleiner wrote: > > > On 11/19/2015 08:45 PM, Ville Syrjälä wrote: > > On Thu, Nov 19, 2015 at 08:12:24PM +0100, Mario Kleiner wrote: > >> On 11/19/2015 07:20 PM, Ville Syrjälä wrote: > >>> On Thu, Nov 19, 2015 at 06:46:28PM +0100, Mario Kleiner

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-20 Thread Mario Kleiner
On 11/19/2015 08:45 PM, Ville Syrjälä wrote: > On Thu, Nov 19, 2015 at 08:12:24PM +0100, Mario Kleiner wrote: >> On 11/19/2015 07:20 PM, Ville Syrjälä wrote: >>> On Thu, Nov 19, 2015 at 06:46:28PM +0100, Mario Kleiner wrote: Hi Alex and Michel and Ville, it's "fix vblank

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-19 Thread Alex Deucher
On Thu, Nov 19, 2015 at 12:46 PM, Mario Kleiner wrote: > Hi Alex and Michel and Ville, > > it's "fix vblank stuff" time again ;-) Adding Harry from our display team. He might be able to fill in the blanks of on some of this better than I can. It might also be worth checking to see how our DAL

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-19 Thread Ville Syrjälä
On Thu, Nov 19, 2015 at 08:12:24PM +0100, Mario Kleiner wrote: > On 11/19/2015 07:20 PM, Ville Syrjälä wrote: > > On Thu, Nov 19, 2015 at 06:46:28PM +0100, Mario Kleiner wrote: > >> Hi Alex and Michel and Ville, > >> > >> it's "fix vblank stuff" time again ;-) > >> > >> Ville's changes to the

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-19 Thread Ville Syrjälä
On Thu, Nov 19, 2015 at 06:46:28PM +0100, Mario Kleiner wrote: > Hi Alex and Michel and Ville, > > it's "fix vblank stuff" time again ;-) > > Ville's changes to the DRM's drm_handle_vblank() / > drm_update_vblank_count() code in Linux 4.4 not only made that code more > elegant, but also

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-19 Thread Mario Kleiner
On 11/19/2015 07:20 PM, Ville Syrjälä wrote: > On Thu, Nov 19, 2015 at 06:46:28PM +0100, Mario Kleiner wrote: >> Hi Alex and Michel and Ville, >> >> it's "fix vblank stuff" time again ;-) >> >> Ville's changes to the DRM's drm_handle_vblank() / >> drm_update_vblank_count() code in Linux 4.4 not

Funky new vblank counter regressions in Linux 4.4-rc1

2015-11-19 Thread Mario Kleiner
Hi Alex and Michel and Ville, it's "fix vblank stuff" time again ;-) Ville's changes to the DRM's drm_handle_vblank() / drm_update_vblank_count() code in Linux 4.4 not only made that code more elegant, but also removed the robustness against the vblank irq quirks in AMD hw and similar