RE: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-16 Thread Inki Dae
@samsung.com; jy0922.s...@samsung.com Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. On Tue, May 15, 2012 at 12:33 AM, Inki Dae inki@samsung.com wrote: Hi Jerome, -Original Message- From: Jerome Glisse [mailto:j.gli...@gmail.com] Sent: Tuesday, May 15, 2012 4:27

Re: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-15 Thread KOSAKI Motohiro
; sw0312@samsung.com; jy0922.s...@samsung.com Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. + npages = buf-size PAGE_SHIFT; Why round down? usually we use round up. The size was already rounded up by exynos_drm_gem_userptr_ioctl so this is just used to get page count

Re: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-15 Thread Jerome Glisse
; kosaki.motoh...@gmail.com; kyungmin.p...@samsung.com; sw0312@samsung.com; jy0922.s...@samsung.com Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. On Mon, May 14, 2012 at 2:17 AM, Inki Dae inki@samsung.com wrote: this feature is used to import user space region allocated by malloc

Re: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-14 Thread KOSAKI Motohiro
+       npages = buf-size PAGE_SHIFT; Why round down? usually we use round up. +       down_read(current-mm-mmap_sem); + +       /* +        * Basically, all the pages from get_user_pages() can not be not only +        * migrated by CMA but also swapped out. +        * +        * The

RE: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-14 Thread Inki Dae
...@samsung.com Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. +       npages = buf-size PAGE_SHIFT; Why round down? usually we use round up. The size was already rounded up by exynos_drm_gem_userptr_ioctl so this is just used to get page count. +       down_read

RE: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-14 Thread Inki Dae
@samsung.com; jy0922.s...@samsung.com Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. (5/14/12 2:52 AM), Inki Dae wrote: -Original Message- From: KOSAKI Motohiro [mailto:kosaki.motoh...@gmail.com] Sent: Monday, May 14, 2012 3:33 PM To: Inki Dae Cc: airl...@linux.ie

RE: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-14 Thread Inki Dae
; sw0312@samsung.com; jy0922.s...@samsung.com Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. (5/14/12 2:52 AM), Inki Dae wrote: -Original Message- From: KOSAKI Motohiro [mailto:kosaki.motoh...@gmail.com] Sent: Monday, May 14, 2012 3:33 PM To: Inki Dae Cc

Re: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-14 Thread Jerome Glisse
On Mon, May 14, 2012 at 2:17 AM, Inki Dae inki@samsung.com wrote: this feature is used to import user space region allocated by malloc() or mmaped into a gem. for this, we uses get_user_pages() to get all the pages to VMAs within user address space. However we should pay attention to use

RE: [PATCH 2/2 v4] drm/exynos: added userptr feature.

2012-05-14 Thread Inki Dae
; jy0922.s...@samsung.com Subject: Re: [PATCH 2/2 v4] drm/exynos: added userptr feature. On Mon, May 14, 2012 at 2:17 AM, Inki Dae inki@samsung.com wrote: this feature is used to import user space region allocated by malloc() or mmaped into a gem. for this, we uses get_user_pages() to get