Re: [PATCH 1/2] drm/ttm: remove some bo-mutex remains

2010-03-12 Thread Maarten Maathuis
Ping? On Mon, Mar 1, 2010 at 9:55 PM, Jerome Glisse gli...@freedesktop.org wrote: On Mon, Mar 01, 2010 at 07:34:39PM +0100, Maarten Maathuis wrote: - A few comments existed here and there that referred to a bo-mutex. Signed-off-by: Maarten Maathuis madman2...@gmail.com Reviewed-by: Jerome

Re: [git pull] drm request 3

2010-03-04 Thread Maarten Maathuis
people that get to keep the pieces. Sincerely, Maarten Maathuis. -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications

Re: [git pull] drm request 3

2010-03-04 Thread Maarten Maathuis
On Thu, Mar 4, 2010 at 10:21 PM, Maarten Maathuis madman2...@gmail.com wrote: On Thu, Mar 4, 2010 at 7:18 PM, Linus Torvalds torva...@linux-foundation.org wrote: Hmm. What the hell am I supposed to do about        (II) NOUVEAU(0): [drm] nouveau interface version: 0.0.16        (EE) NOUVEAU

Re: [git pull] drm request 3

2010-03-04 Thread Maarten Maathuis
On Thu, Mar 4, 2010 at 7:18 PM, Linus Torvalds torva...@linux-foundation.org wrote: Hmm. What the hell am I supposed to do about        (II) NOUVEAU(0): [drm] nouveau interface version: 0.0.16        (EE) NOUVEAU(0): [drm] wrong version, expecting 0.0.15        (EE) NOUVEAU(0): 879: now?

[PATCH 1/2] drm/ttm: remove some bo-mutex remains

2010-03-01 Thread Maarten Maathuis
- A few comments existed here and there that referred to a bo-mutex. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/ttm/ttm_bo.c|6 +- drivers/gpu/drm/ttm/ttm_bo_vm.c |2 +- include/drm/ttm/ttm_bo_api.h|3 +-- include/drm/ttm/ttm_bo_driver.h

[PATCH 2/2] drm/ttm: don't write to bo-reserved without holding glob-lru_lock

2010-03-01 Thread Maarten Maathuis
- The headerfile says you can't write to it without holding the lock. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/ttm/ttm_bo.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

Re: [PATCH] drm/ttm: handle OOM in ttm_tt_swapout

2010-02-23 Thread Maarten Maathuis
On Tue, Feb 23, 2010 at 6:59 AM, Dave Airlie airl...@gmail.com wrote: On Sat, Feb 20, 2010 at 12:22 PM, Maarten Maathuis madman2...@gmail.com wrote: - Without this change I get a general protection fault. - Also use PTR_ERR where applicable. I just want to make sure I understand, but really

[PATCH] drm/ttm: handle OOM in ttm_tt_swapout

2010-02-19 Thread Maarten Maathuis
- Without this change I get a general protection fault. - Also use PTR_ERR where applicable. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/ttm/ttm_tt.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/ttm

Re: [git pull] drm

2010-02-15 Thread Maarten Maathuis
The channel/context switch lock related patches (to the best of knowledge) haven't even gone outside the nouveau tree, so the initial damage isn't even there. At least not for the first path. As for the 2nd patch, that one was squished into the original patch for this pull iirc. Maarten. On Mon,

Re: [PATCH 2/2] drm/radeon: Add asic hook for dma copy to r200 cards.

2010-02-10 Thread Maarten Maathuis
What happens if you have two cards, one RS200 and one RV280 (just an example). I think you shouldn't change values in a static struct. On Wed, Feb 10, 2010 at 11:10 PM, Pauli Nieminen suok...@gmail.com wrote: r200 cards have dma engine which can be used to tranfer data between vram and system

Re: [PATCH] drm: Add a generic function to change connector type/id of connector dynamically

2010-01-27 Thread Maarten Maathuis
On Wed, Jan 27, 2010 at 8:16 AM, yakui.z...@intel.com wrote: From: Zhao Yakui yakui.z...@intel.com Sometimes one connector can support more than one connector type. And it will switch the connector type/id dynamically according to the external connected device. I very much doubt it's the

Re: [Nouveau] [PATCH] drm/ttm: Fix race condition in ttm_bo_delayed_delete

2010-01-21 Thread Maarten Maathuis
On Thu, Jan 21, 2010 at 3:44 PM, Francisco Jerez curroje...@riseup.net wrote: Luca Barbieri l...@luca-barbieri.com writes: Nvidia cards have a synchronization primitive that could be used to synchronize several FIFOs in hardware (AKA semaphores, see [1] for an example). Does this operate

Re: [Nouveau] [PATCH] drm/ttm: Fix race condition in ttm_bo_delayed_delete

2010-01-21 Thread Maarten Maathuis
On Thu, Jan 21, 2010 at 4:56 PM, Luca Barbieri l...@luca-barbieri.com wrote: Doing it without software methods means you need to have a semaphore that exists in the cpu domain and therefore cannot be used again until the cpu is sure it's done. So that will probably require a rotating queue of

Re: [PATCH] drm/radeon/kms/rv100: reject modes 135 Mhz on DVI

2010-01-11 Thread Maarten Maathuis
On Mon, Jan 11, 2010 at 6:57 PM, Alex Deucher alexdeuc...@gmail.com wrote: From 6d980869ef031752dac505c1aacbbe221fb2c6e7 Mon Sep 17 00:00:00 2001 From: Alex Deucher alexdeuc...@gmail.com Date: Mon, 11 Jan 2010 12:39:35 -0500 Subject: [PATCH] drm/radeon/kms/rv100: reject modes 135 Mhz on DVI

Re: [TTM] general protection fault in ttm_tt_swapout, to_virtual looks screwed up

2010-01-10 Thread Maarten Maathuis
page_address on x86_64, since that doesn't have or need PAE or anything like that. /Thomas Maarten Maathuis wrote: I've been noticing for a while that i've been getting general protection faults in ttm_to_swapout, this time i was printk'ing the virtual addresses. In case it's not obvious

[TTM] general protection fault in ttm_tt_swapout, to_virtual looks screwed up

2010-01-09 Thread Maarten Maathuis
I've been noticing for a while that i've been getting general protection faults in ttm_to_swapout, this time i was printk'ing the virtual addresses. In case it's not obvious, the result of kmap_atomic() is wrong. This is nouveau/linux-2.6 which is somewhere after 2.6.32. I was wondering if

Re: [git pull] drm

2009-12-10 Thread Maarten Maathuis
On Thu, Dec 10, 2009 at 5:24 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Thu, 10 Dec 2009, Xavier Bestel wrote: Last time they were asked that, they wanted to be free of changing their kernel/userspace interface before upstreaming. I've heard all the excuses. If it isn't

Re: RFC: libdrm repo

2009-11-29 Thread Maarten Maathuis
the harsh reality that stems from the stalemate that the previous development model caused. No amount of complaining is going to change the fact that some people don't care about bsd. Sincerely, Maarten Maathuis. -- Let

Re: [PATCH] drm: update crtc x/y when only fb changes

2009-09-17 Thread Maarten Maathuis
On Thu, Sep 17, 2009 at 8:15 AM, skeg...@gmail.com wrote: From: Ben Skeggs bske...@redhat.com Fixes:        xrandr --output DVI-I-0 --right-of DVI-I-1        xrandr --output DVI-I-0 --left-of DVI-I-1        xrandr --output DVI-I-0 --right-of DVI-I-1 Signed-off-by: Ben Skeggs

Re: [PATCH 6/6] [drm/i915] implement drmmode overlay support v2

2009-09-02 Thread Maarten Maathuis
That said, the suggestion to use command streams for the overlay doesn't make much sense to me. If that was a good idea, why aren't we doing modesetting that way? Modesetting on nvidia g80+ is done through a command stream, so it isn't an entirely crazy idea. Maarten.

[PATCH] drm/crtc_helper: avoid NULL-pointer dereference when encoder is NULL

2009-08-31 Thread Maarten Maathuis
Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/drm_crtc_helper.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index 205349e..e3d78e6 100644 --- a/drivers/gpu/drm

[PATCH] drm/crtc_helper: avoid NULL-pointer dereference when encoder is NULL

2009-08-31 Thread Maarten Maathuis
Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/drm_crtc_helper.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index 205349e..e3d78e6 100644 --- a/drivers/gpu/drm

Re: [PATCH] drm/crtc_helper: avoid NULL-pointer dereference when encoder is NULL

2009-08-31 Thread Maarten Maathuis
This problem only exists in drm-next, sorry for not spotting this the first time. Maarten. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration

Re: [PATCH] drm/crtc_helper: avoid NULL-pointer dereference when encoder is NULL

2009-08-31 Thread Maarten Maathuis
This problem only exists in drm-next, sorry for not spotting this the first time. Maarten. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration

[PATCH 1/3] drm/crtc_helper: replace modeset fail path with something simpler

2009-08-27 Thread Maarten Maathuis
- The previous system was not very transparent, nor flexible. - This is needed to be able to fix a few bugs in the mechanism. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/drm_crtc_helper.c | 86 +++-- 1 files changed, 54 insertions

Re: [PATCH 1/3] drm/crtc_helper: replace modeset fail path with something simpler

2009-08-21 Thread Maarten Maathuis
@Dave: any word yet? On Wed, Aug 19, 2009 at 4:43 PM, Maarten Maathuismadman2...@gmail.com wrote: No complaints with this patch set? I just need plausible upstream-ability, when it happens is not a big issue for me. Maarten.

Re: [HINT] check your version of drmmode_display.c if kms + xrandr + gamma isn't working

2009-08-20 Thread Maarten Maathuis
A minor addition: http://cgit.freedesktop.org/nouveau/xf86-video-nouveau/commit/?id=569a17a98d03d965f9500c37c0cb14e0fb462311 Maarten. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial.

Re: [PATCH 1/3] drm/crtc_helper: replace modeset fail path with something simpler

2009-08-19 Thread Maarten Maathuis
No complaints with this patch set? I just need plausible upstream-ability, when it happens is not a big issue for me. Maarten. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial.

[HINT] check your version of drmmode_display.c if kms + xrandr + gamma isn't working

2009-08-19 Thread Maarten Maathuis
http://cgit.freedesktop.org/nouveau/xf86-video-nouveau/commit/?id=fe2b5e6c6f81f4c4a76f5e4c5816812459872af3 Maarten. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your

Re: [PATCH] drm/crtc_helper: make the helper more friendly to encoder swapping

2009-08-18 Thread Maarten Maathuis
No objections? Maarten. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application

[PATCH 2/3] drm/crtc_helper: place drm_helper_encoder_in_use() in the header file

2009-08-18 Thread Maarten Maathuis
- The symbol was already exported. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- include/drm/drm_crtc_helper.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_crtc_helper.h b/include/drm/drm_crtc_helper.h index 6769ff6..e44a4f8 100644

[PATCH 3/3] drm/crtc_helper: NULL encoder-crtc when switching encoders

2009-08-18 Thread Maarten Maathuis
- Previously the old encoder would be called during modeset and without a connector bad things happened. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/drm_crtc_helper.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 1/3] drm/crtc_helper: replace modeset fail path with something simpler

2009-08-18 Thread Maarten Maathuis
- The previous system was not very transparent, nor flexible. - This is needed to be able to fix a few bugs in the mechanism. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/drm_crtc_helper.c | 86 +++-- 1 files changed, 54 insertions

[PATCH] drm/crtc_helper: make the helper more friendly to encoder swapping

2009-08-17 Thread Maarten Maathuis
- Instead of touching the fragile recovery system when modesetting fails, the encoder is now defined as active when it has a connector. - Previously bad things happened with the same crtc, same connector, but different encoder, because encoder-crtc != NULL. - Also put a function in the header,

Re: [PATCH] drm/crtc_helper: make the helper more friendly to encoder swapping

2009-08-17 Thread Maarten Maathuis
Sorry about forgetting signoff, this will be corrected ofcource. Maarten. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment -

Re: [PATCH] ttm: obey page_alignment in ttm_bo_setup_vm

2009-08-03 Thread Maarten Maathuis
The page alignment shouldn't matter here since what's allocated is a free slot within the device file address space. It's only used for cpu map / write / read, and the GPU never sees the vm_node offset. But if this is the vram pci bar, then not aligning causes you to read/write misaligned to

Re: [PATCH] ttm: obey page_alignment in ttm_bo_setup_vm

2009-08-03 Thread Maarten Maathuis
Let me rephrase that, could you pinpoint the place where the translation from vm to real memory happens? Maarten. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your

Re: [PATCH] ttm: obey page_alignment in ttm_bo_setup_vm

2009-08-03 Thread Maarten Maathuis
It appears to have been a false positive, sorry for that. Maarten. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and

Re: [PATCH] drm: clarify scaling property names

2009-07-01 Thread Maarten Maathuis
DRM_MODE_SCALE_NON_GPU was intended to let the monitor do the scaling, in case you have a CRT or the monitors scalers are better. I think your new name choice is less than ideal. Maarten. -- --

Re: [Intel-gfx] [PATCH V1] drm: export get and put connector type id

2009-05-28 Thread Maarten Maathuis
No, you should list a connector as unknown. Connectors are physical plugs, creating duplicates is insane. At least that is my opinion. Maarten. -- Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is

Re: [Intel-gfx] [PATCH V1] drm: export get and put connector type id

2009-05-26 Thread Maarten Maathuis
Why does it pretend to (also) be dvi when it's only vga? Is this lazyness by the manufacturer of the sdvo adapter? Maarten. -- Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of

Re: [Intel-gfx] [PATCH V1] drm: export get and put connector type id

2009-05-23 Thread Maarten Maathuis
So you have a DVI-I (DVI-D + DVI-A) connector, but you're not sure about one of them? What exactly don't you know? Maarten. -- Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of

Re: [RFC] DRM developer guide

2008-07-20 Thread Maarten Maathuis
On 6/23/08, Jesse Barnes [EMAIL PROTECTED] wrote: On Sunday, June 22, 2008 6:55 am Pekka Paalanen wrote: On Thu, 19 Jun 2008 15:13:51 -0700 Jesse Barnes [EMAIL PROTECTED] wrote: In a shameless attempt to capitalize on the recent enthusiasm for documenting things, I've put

Re: [drm-modesetting] optional connector properties, share your thoughts

2008-07-05 Thread Maarten Maathuis
On 7/4/08, Maarten Maathuis [EMAIL PROTECTED] wrote: I've been reviewing the kernel modesetting interfaces while they are not yet set in stone. Since consistent properties are desirable we must standardise on several optional, but common properties. scaling_mode: - panel -- this name

[drm-modesetting] optional connector properties, share your thoughts

2008-07-03 Thread Maarten Maathuis
I've been reviewing the kernel modesetting interfaces while they are not yet set in stone. Since consistent properties are desirable we must standardise on several optional, but common properties. scaling_mode: - panel -- this name is debateble, it means native mode is ignored - fullscreen -

Re: [modesetting-101] Some misc questions about infrastructure

2008-06-23 Thread Maarten Maathuis
On 6/22/08, Maarten Maathuis [EMAIL PROTECTED] wrote: - Are there any plans (or existing support) to cleanly allow a crtc to be detached/disabled (note i'm merely saying detach, not dpms or anything like that). Answering myself, i noticed that passing a NULL mode should do the trick

Initial import of NV50/g80 kernel modesetting code.

2008-06-22 Thread Maarten Maathuis
I've been talking about it for some time, but now it actually does something, so comitted it. I always said i wouldn't use the randr-1.2 clone stuff and i didn't, so you can use this as an example how it could also be done. What doesn't work (for sure): lvds with no ddc support no fbcon yet

[modesetting-101] Some misc questions about infrastructure

2008-06-22 Thread Maarten Maathuis
- Are there any plans (or existing support) to cleanly allow a crtc to be detached/disabled (note i'm merely saying detach, not dpms or anything like that). - Are there plans for a generic entrypoint for falling back to fbcon or will that be implementation dependent? - Is it needed to protect

Re: kernel modesetting progress report....

2008-02-28 Thread Maarten Maathuis
On 2/28/08, Dave Airlie [EMAIL PROTECTED] wrote: So just to let people know where kernel modesetting is getting to and what I'm up to with it.. So I really want to ship something in Fedora 9 with kernel modesetting in it, whether this is a default or a special boot option for the user I

Re: kernel modesetting progress report....

2008-02-28 Thread Maarten Maathuis
On 2/28/08, Dave Airlie [EMAIL PROTECTED] wrote: So just to let people know where kernel modesetting is getting to and what I'm up to with it.. So I really want to ship something in Fedora 9 with kernel modesetting in it, whether this is a default or a special boot option for the user I

Re: kernel modesetting progress report....

2008-02-28 Thread Maarten Maathuis
On 2/28/08, Dave Airlie [EMAIL PROTECTED] wrote: Please don't let any api freezing depend on fedora core, at least give external parties time to play with it once it's reasonably stable, this will undoubtely reveal limitations. It should be in mainline drm well before api freezing

Re: kernel modesetting progress report....

2008-02-28 Thread Maarten Maathuis
On 2/28/08, Jesse Barnes [EMAIL PROTECTED] wrote: On Thursday, February 28, 2008 11:33 am Dave Airlie wrote: the current API abstracts connectors from outputs, so in reality it is encoders with connector properties at the moment. you define a connector type and a connector id for each

Re: [PATCH] make the drm (linux) obey device classes + nouveau detection without pci-id's

2007-10-03 Thread Maarten Maathuis
Is there anything holding this back? On 10/2/07, Maarten Maathuis [EMAIL PROTECTED] wrote: Here it is. Maarten. On 10/2/07, Maarten Maathuis [EMAIL PROTECTED] wrote: You seem to be correct, i must have added the tmp variable in attempt to solve something, that i ended up solving

Re: [PATCH] make the drm (linux) obey device classes + nouveau detection without pci-id's

2007-10-03 Thread Maarten Maathuis
It was merely an indirect of figuring out if i should commit it myself or if someone else must do it. Maarten. On 10/3/07, Daniel Stone [EMAIL PROTECTED] wrote: On Wed, Oct 03, 2007 at 09:23:38AM +0200, Maarten Maathuis wrote: Is there anything holding this back? It's been 12 hours: relax

Re: [PATCH] make the drm (linux) obey device classes + nouveau detection without pci-id's

2007-10-02 Thread Maarten Maathuis
Has anyone looked at this? On 10/1/07, Maarten Maathuis [EMAIL PROTECTED] wrote: Please check the first patch, the second is only to give you an idea why i would want this. Only implemented for linux, since i lack a bsd system. Anything wrong with this? Sincerely, Maarten Maathuis

Re: [PATCH] make the drm (linux) obey device classes + nouveau detection without pci-id's

2007-10-02 Thread Maarten Maathuis
You seem to be correct, i must have added the tmp variable in attempt to solve something, that i ended up solving differently. I will redo the patch and send again. Maarten. On 10/2/07, Ian Romanick [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Maarten Maathuis

Re: [PATCH] make the drm (linux) obey device classes + nouveau detection without pci-id's

2007-10-02 Thread Maarten Maathuis
Here it is. Maarten. On 10/2/07, Maarten Maathuis [EMAIL PROTECTED] wrote: You seem to be correct, i must have added the tmp variable in attempt to solve something, that i ended up solving differently. I will redo the patch and send again. Maarten. On 10/2/07, Ian Romanick [EMAIL

[PATCH] make the drm (linux) obey device classes + nouveau detection without pci-id's

2007-10-01 Thread Maarten Maathuis
Please check the first patch, the second is only to give you an idea why i would want this. Only implemented for linux, since i lack a bsd system. Anything wrong with this? Sincerely, Maarten Maathuis. From ebb0ed74dee41da3f9700386074c23d2e714488f Mon Sep 17 00:00:00 2001 From: Maarten Maathuis

Re: [PATCH] replace instance of SA_SHIRQ with IRQF_SHARED

2007-03-10 Thread Maarten Maathuis
. On Mon, 5 Mar 2007, Maarten Maathuis wrote: Bump. On 3/2/07, Maarten Maathuis [EMAIL PROTECTED] wrote: This is for the drm in case that's not obvious from the patch, forget to mention that. On 3/2/07, Maarten Maathuis [EMAIL PROTECTED] wrote: The use of SA_* is slowly being removed

Re: [PATCH] replace instance of SA_SHIRQ with IRQF_SHARED

2007-03-04 Thread Maarten Maathuis
Bump. On 3/2/07, Maarten Maathuis [EMAIL PROTECTED] wrote: This is for the drm in case that's not obvious from the patch, forget to mention that. On 3/2/07, Maarten Maathuis [EMAIL PROTECTED] wrote: The use of SA_* is slowly being removed, at least that's my impression. I use a realtime

[PATCH] replace instance of SA_SHIRQ with IRQF_SHARED

2007-03-02 Thread Maarten Maathuis
The use of SA_* is slowly being removed, at least that's my impression. I use a realtime kernel and it was gone, it seems a similar thing might happen for other kernels in the near future (-mm for 2.6.21). Maarten. fix.patch Description: Binary data

Re: [PATCH] replace instance of SA_SHIRQ with IRQF_SHARED

2007-03-02 Thread Maarten Maathuis
This is for the drm in case that's not obvious from the patch, forget to mention that. On 3/2/07, Maarten Maathuis [EMAIL PROTECTED] wrote: The use of SA_* is slowly being removed, at least that's my impression. I use a realtime kernel and it was gone, it seems a similar thing might happen