[Dri-devel] Re: Mach64 flatshading

2002-07-17 Thread Michel Dänzer
On Tue, 2002-07-16 at 20:17, Leif Delgass wrote: On Tue, 16 Jul 2002, Keith Whitwell wrote: Well, it's not high on my list. I don't think flat-shading is used that often, and the changes don't have any effect on smooth shading. Actually, it _eliminates_ some saves/restores

Re: [Dri-devel] Re: Mach64 flatshading

2002-07-17 Thread Leif Delgass
On 17 Jul 2002, Michel Dänzer wrote: On Tue, 2002-07-16 at 20:17, Leif Delgass wrote: On Tue, 16 Jul 2002, Keith Whitwell wrote: Well, it's not high on my list. I don't think flat-shading is used that often, and the changes don't have any effect on smooth shading. Actually,

Re: [Mesa3d-dev] Re: [Dri-devel] Re: Mach64 flatshading

2002-07-17 Thread Leif Delgass
On Wed, 17 Jul 2002, Leif Delgass wrote: On 17 Jul 2002, Michel Dänzer wrote: On Tue, 2002-07-16 at 20:17, Leif Delgass wrote: On Tue, 16 Jul 2002, Keith Whitwell wrote: Well, it's not high on my list. I don't think flat-shading is used that often, and the changes don't

Re: [Dri-devel] Re: Mach64 flatshading

2002-07-17 Thread Keith Whitwell
Michel Dänzer wrote: On Tue, 2002-07-16 at 20:17, Leif Delgass wrote: On Tue, 16 Jul 2002, Keith Whitwell wrote: Well, it's not high on my list. I don't think flat-shading is used that often, and the changes don't have any effect on smooth shading. Actually, it _eliminates_ some

Re: [Dri-devel] Re: Mach64 flatshading

2002-07-17 Thread Leif Delgass
On 17 Jul 2002, Michel Dänzer wrote: On Wed, 2002-07-17 at 20:05, Keith Whitwell wrote: I've fixed this for drivers that use t_dd_triemit.h -- currently only radeon and r200. Great job! The clipping problems I originally reported with the xscreensaver gears hack and fsv are fixed.

Re: [Dri-devel] Re: Mach64 flatshading

2002-07-17 Thread Leif Delgass
On Wed, 17 Jul 2002, Leif Delgass wrote: On 17 Jul 2002, Michel Dänzer wrote: On Wed, 2002-07-17 at 20:05, Keith Whitwell wrote: I've fixed this for drivers that use t_dd_triemit.h -- currently only radeon and r200. Great job! The clipping problems I originally reported with the

Re: [Dri-devel] Re: Mach64 flatshading

2002-07-17 Thread Keith Whitwell
Leif Delgass wrote: On Wed, 17 Jul 2002, Leif Delgass wrote: On 17 Jul 2002, Michel Dänzer wrote: On Wed, 2002-07-17 at 20:05, Keith Whitwell wrote: I've fixed this for drivers that use t_dd_triemit.h -- currently only radeon and r200. Great job! The clipping problems I originally

Re: [Dri-devel] Re: Mach64 flatshading

2002-07-17 Thread Leif Delgass
On Wed, 17 Jul 2002, Keith Whitwell wrote: I've done all the others. Lets see if testing was required... So, should I commit the fix for r128? I've tested that and it works fine. Yes, go ahead. I took a look at the other drivers concerning the read buffer fix. It looks like