Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-09 Thread Michel Dänzer
On Thu, 2007-03-08 at 19:07 +0200, Panagiotis Papadakos wrote: On Thursday 08 March 2007 17:05, Michel Dänzer wrote: Any idea what's going on? The only situation where radeonSetCliprects doesn't get called from radeonMakeCurrent is if neither the drawable nor its stamp has changed...

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-09 Thread Panagiotis Papadakos
Yep, I think it is OK! On Friday 09 March 2007 10:46, Michel Dänzer wrote: On Thu, 2007-03-08 at 19:07 +0200, Panagiotis Papadakos wrote: On Thursday 08 March 2007 17:05, Michel Dänzer wrote: Any idea what's going on? The only situation where radeonSetCliprects doesn't get called from

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-09 Thread Michel Dänzer
On Fri, 2007-03-09 at 13:49 +0200, Panagiotis Papadakos wrote: Yep, I think it is OK! Pushed, thanks. -- Earthling Michel Dänzer | http://tungstengraphics.com Libre software enthusiast | Debian, X and DRI developer

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-08 Thread Panagiotis Papadakos
On Thursday 08 March 2007 12:12, Michel Dänzer wrote: Does calling radeonSetCliprects unconditionally before _mesa_make_current help? I don't see a way for radeonMakeCurrent to be sure DoBindContext didn't update the cliprects. Yep it helps. Calling radeonSetCliprects when stamp!=lastStamp

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-08 Thread Panagiotis Papadakos
Calling radeonSetCliprects when stamp!=lastStamp also helps! Sorry meant radeon-lastStamp != driDrawPriv-lastStamp and radeon-lastStamp != driReadPriv-lastStamp. - Take Surveys. Earn Cash. Influence the Future of IT Join

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-08 Thread Michel Dänzer
On Thu, 2007-03-08 at 14:25 +0200, Panagiotis Papadakos wrote: Calling radeonSetCliprects when stamp!=lastStamp also helps! Sorry meant radeon-lastStamp != driDrawPriv-lastStamp That'll usually be fine, but in theory the stamps could be identical when a different drawable was bound

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-08 Thread Michel Dänzer
On Thu, 2007-03-08 at 14:31 +0100, Michel Dänzer wrote: On Thu, 2007-03-08 at 14:25 +0200, Panagiotis Papadakos wrote: Calling radeonSetCliprects when stamp!=lastStamp also helps! Sorry meant radeon-lastStamp != driDrawPriv-lastStamp That'll usually be fine, but in theory the stamps

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-08 Thread Panagiotis Papadakos
I still get invalid reads with your latest patch. On Thursday 08 March 2007 15:42, Michel Dänzer wrote: On Thu, 2007-03-08 at 14:31 +0100, Michel Dänzer wrote: On Thu, 2007-03-08 at 14:25 +0200, Panagiotis Papadakos wrote: Calling radeonSetCliprects when stamp!=lastStamp also helps!

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-08 Thread Michel Dänzer
On Thu, 2007-03-08 at 17:03 +0200, Panagiotis Papadakos wrote: I still get invalid reads with your latest patch. Any idea what's going on? The only situation where radeonSetCliprects doesn't get called from radeonMakeCurrent is if neither the drawable nor its stamp has changed... -- Earthling

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-08 Thread Panagiotis Papadakos
On Thursday 08 March 2007 17:05, Michel Dänzer wrote: Any idea what's going on? The only situation where radeonSetCliprects doesn't get called from radeonMakeCurrent is if neither the drawable nor its stamp has changed... We have to call radeonSetCliprects(radeon), before

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-07 Thread Panagiotis Papadakos
On Friday 02 March 2007 16:41, Michel Dänzer wrote: On Mon, 2007-02-26 at 07:09 +0200, Panagiotis Papadakos wrote: Well I think I have the correct patch for this. I'm afraid not; the test modification is incorrect. The test is an optimization to avoid doing unnecessary work when the context

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-07 Thread Panagiotis Papadakos
The problem is that I still get invalid reads when going from fullscreen mode to window mode for the first time, with my OSG application. On Wednesday 07 March 2007 19:10, Michel Dänzer wrote: On Wed, 2007-03-07 at 19:02 +0200, Panagiotis Papadakos wrote: On Friday 02 March 2007 16:41, Michel

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-03-02 Thread Michel Dänzer
On Mon, 2007-02-26 at 07:09 +0200, Panagiotis Papadakos wrote: Well I think I have the correct patch for this. I'm afraid not; the test modification is incorrect. The test is an optimization to avoid doing unnecessary work when the context is already up to date wrt the drawables passed in and

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-02-25 Thread Panagiotis Papadakos
Well I think I have the correct patch for this. We should call radeonSetCliprects inside radeonMakeCurrent to update to the new pClipRects whenever lastStamps change. Probably this should also be applied to r200. Haven't seen for other drivers. Comments? P.S. Should I try to get an account?

Re: Invalid reads from intersect_rect in radeon_state.c of r300 driver. [PATCH included]

2007-02-02 Thread Panagiotis Papadakos
Well this patch is not correct since it leads to memory leaks, probably due to succeeding calls to dri_interface-getDrawableInfo. So I created the attached patch, but again valgrind warns for invalid reads. Anyone understands why? Thanks P.S. Sorry but I am new to the code! On Thursday 01