Re: root priv and DRM

2005-06-20 Thread Jon Smirl
On 6/20/05, Alan Cox <[EMAIL PROTECTED]> wrote: > On Sad, 2005-06-18 at 16:54, Jon Smirl wrote: > > How about this as a safe first step: > > 1) Remove the general root capability check > > 2) Change the semantics of the root_only field on these calls to mean > > master only. > > 3) Push the root ca

Re: root priv and DRM

2005-06-20 Thread Alan Cox
> I very strongly believe that the right model moving forward is for > user-mode to say to the kernel, "I beg of thee. Initialize thyne self." Much of the initialization of chips is complex and messy and not neccessarily good kernel material. SAREA setup I agree seems an obvious kernel thing to d

Re: root priv and DRM

2005-06-20 Thread Alan Cox
On Sad, 2005-06-18 at 16:54, Jon Smirl wrote: > How about this as a safe first step: > 1) Remove the general root capability check > 2) Change the semantics of the root_only field on these calls to mean > master only. > 3) Push the root capability check into each of these IOCTL individually. > 4) L

Re: root priv and DRM

2005-06-20 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Adam Jackson wrote: > On Friday 17 June 2005 23:18, Ian Romanick wrote: > >>Basically, user-mode should say to the kernel, "Please initialize >>yourself with these tunable parameters." The kernel should then do >>whatever it wants and let user-mode k

Re: root priv and DRM

2005-06-18 Thread Jon Smirl
DRM has the concepts of master and authenticated. In the current code master is also equated with needing root priv. The patch splits these two concepts into three (auth, master, root) and makes them separately controllable. For example: [DRM_IOCTL_NR(DRM_IOCTL_ADD_BUFS)] = {drm_addbufs, 1

Re: root priv and DRM

2005-06-18 Thread Jon Smirl
On 6/17/05, Jon Smirl <[EMAIL PROTECTED]> wrote: > These are the ones marked root. > > [DRM_IOCTL_NR(DRM_IOCTL_IRQ_BUSID)] = {drm_irq_by_busid, 0, 1}, > [DRM_IOCTL_NR(DRM_IOCTL_SET_VERSION)] = {drm_setversion, 0, 1}, > [DRM_IOCTL_NR(DRM_IOCTL_SET_UNIQUE)] = {drm_setunique,

Re: root priv and DRM

2005-06-17 Thread Adam Jackson
On Friday 17 June 2005 23:18, Ian Romanick wrote: > Adam Jackson wrote: > > drmAddMap has to be root-only because it's mapping device memory into > > userspace (can trigger bus-master writes, blah blah, root escalation). I > > think that's the only one that _really_ needs it, and to be honest thos

Re: root priv and DRM

2005-06-17 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Adam Jackson wrote: > drmAddMap has to be root-only because it's mapping device memory into > userspace (can trigger bus-master writes, blah blah, root escalation). I > think that's the only one that _really_ needs it, and to be honest those > map

Re: root priv and DRM

2005-06-17 Thread Adam Jackson
On Friday 17 June 2005 22:39, Jon Smirl wrote: > I'm working on making EGL run non-root. Now I'm up against the IOCTLs > in DRM marked root only. DRM is a master/slave model, so this is > really a list of the master only calls. > > With EGL the first app to open the DRI device is master, and later