Re: [PATCH] libdrm support for GTT mapping

2008-10-23 Thread Steven J Newbury
On Wed, 2008-10-22 at 15:20 -0700, Jesse Barnes wrote: On Wednesday, October 22, 2008 3:08 pm Jesse Barnes wrote: Fairly straightforward aside from the aforementioned question about how to set tiling stride values for a given object. DDX driver patch? i830_memory.c: In function

Re: [PATCH] libdrm support for GTT mapping

2008-10-23 Thread Jesse Barnes
On Thursday, October 23, 2008 3:11 am Steven J Newbury wrote: On Wed, 2008-10-22 at 15:20 -0700, Jesse Barnes wrote: On Wednesday, October 22, 2008 3:08 pm Jesse Barnes wrote: Fairly straightforward aside from the aforementioned question about how to set tiling stride values for a given

Re: [git pull] drm fixes for 2.6.27-rc1

2008-10-23 Thread Michel Dänzer
On Thu, 2008-10-23 at 04:52 +0100, Dave Airlie wrote: commit 9e44af790f8bf8c3aa8a3101fd4f9bca2e932baa Author: Keith Packard [EMAIL PROTECTED] Date: Thu Oct 16 21:18:27 2008 -0700 drm/i915: hold dev-struct_mutex and DRM lock during vblank ring operations To synchronize

Re: [git pull] drm fixes for 2.6.27-rc1

2008-10-23 Thread Keith Packard
On Thu, 2008-10-23 at 10:54 +0200, Michel Dänzer wrote: Does that still provide good enough latency to prevent tearing though, e.g. with reduced blanking modes? It now depends on the scheduler and what else is running on the system. Yes, this is not ideal, but the sketch of how DRI2 would work

Re: [git pull] drm fixes for 2.6.27-rc1

2008-10-23 Thread Keith Packard
On Thu, 2008-10-23 at 18:10 +0200, Thomas Hellström wrote: I haven't looked into the code for a while, but isn't it possible to use a spinlock (_bh) for ring protection? Because we may have to wait for the hardware to drain the ring, it wouldn't be a good idea to hold a spinlock. In the worst

Re: [git pull] drm fixes for 2.6.27-rc1

2008-10-23 Thread Thomas Hellström
Keith Packard wrote: On Thu, 2008-10-23 at 18:10 +0200, Thomas Hellström wrote: I haven't looked into the code for a while, but isn't it possible to use a spinlock (_bh) for ring protection? Because we may have to wait for the hardware to drain the ring, it wouldn't be a good

[Bug 18191] Xorg segfault in _swrast_copy_teximage2d

2008-10-23 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=18191 --- Comment #1 from Chris Coulson [EMAIL PROTECTED] 2008-10-23 13:23:59 PST --- Created an attachment (id=19831) -- (http://bugs.freedesktop.org/attachment.cgi?id=19831) Output of lspci -vvnn -- Configure bugmail:

[Bug 18191] Xorg segfault in _swrast_copy_teximage2d

2008-10-23 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=18191 --- Comment #3 from Chris Coulson [EMAIL PROTECTED] 2008-10-23 13:24:43 PST --- Created an attachment (id=19833) -- (http://bugs.freedesktop.org/attachment.cgi?id=19833) Xorg.0.log.old -- Configure bugmail:

Re: Adding kmap_atomic_prot_pfn (was: [git pull] drm patches for 2.6.27-rc1)

2008-10-23 Thread Keith Packard
On Thu, 2008-10-23 at 13:38 -0700, Andrew Morton wrote: I guess one could reimplemenet kmap_atomic_pfn() to call this. Sometime. The goal is to stop needing this function fairly soon and replace it with a 'real' io-mapping implementation for 32-bit processors. Given that all

Re: Adding kmap_atomic_prot_pfn (was: [git pull] drm patches for 2.6.27-rc1)

2008-10-23 Thread Linus Torvalds
On Thu, 23 Oct 2008, Andrew Morton wrote: Given that all highmem-implementing archtiectures must use the same declaration here, we might as well put it into include/linux/highmem.h. Although that goes against current mistakes^Wcode. Does powerpc32 still implement highmem? It seems that

Re: [PATCH] GTT mapping support for GEM

2008-10-23 Thread Jesse Barnes
On Wednesday, October 22, 2008 2:42 pm Jesse Barnes wrote: Ok, this one actually works w/o corrupting your display. However, after running for awhile I end up hitting the BUG_ON at i915_gem.c:1061, so I'm hoping someone can tell me where I messed up the list handling (the change in

Re: [PATCH] GTT mapping support for GEM

2008-10-23 Thread Jesse Barnes
On Thursday, October 23, 2008 5:09 pm Jesse Barnes wrote: On Thursday, October 23, 2008 3:51 pm Jesse Barnes wrote: On Wednesday, October 22, 2008 2:42 pm Jesse Barnes wrote: Ok, this one actually works w/o corrupting your display. However, after running for awhile I end up hitting the

Re: [PATCH] GTT mapping support for GEM

2008-10-23 Thread Jesse Barnes
On Thursday, October 23, 2008 3:51 pm Jesse Barnes wrote: On Wednesday, October 22, 2008 2:42 pm Jesse Barnes wrote: Ok, this one actually works w/o corrupting your display. However, after running for awhile I end up hitting the BUG_ON at i915_gem.c:1061, so I'm hoping someone can tell me

Re: Adding kmap_atomic_prot_pfn (was: [git pull] drm patches for 2.6.27-rc1)

2008-10-23 Thread Keith Packard
On Thu, 2008-10-23 at 14:24 -0700, Linus Torvalds wrote: The whole point of that function has absolutely nothing to do with highmem, and it *must* be useful on non-highmem configurations to be appropriate. Right, I'd just like my io_mapping_map_atomic_wc to be able to rapidly map random

ATI XV Output Patch

2008-10-23 Thread Esben Stien
I've pulled GIT xf86-video-ati for some months now and I always have to apply this patch: diff --git a/src/radeon_video.c b/src/radeon_video.c index ac60166..c400468 100644 --- a/src/radeon_video.c +++ b/src/radeon_video.c @@ -1597,5 +1597,8 @@ skip_theatre: static XF86VideoAdaptorPtr

Re: Adding kmap_atomic_prot_pfn (was: [git pull] drm patches for 2.6.27-rc1)

2008-10-23 Thread Linus Torvalds
On Thu, 23 Oct 2008, Keith Packard wrote: So I'd much rather create a new linux/kmap.h or something. Or just expose this from to asm/fixmap.h or something. Let's not confuse this with highmem, even if the implementation _historically_ was due to that. Sure, we readily admit that

Re: Adding kmap_atomic_prot_pfn (was: [git pull] drm patches for 2.6.27-rc1)

2008-10-23 Thread Benjamin Herrenschmidt
On Thu, 2008-10-23 at 14:24 -0700, Linus Torvalds wrote: The whole point of that function has absolutely nothing to do with highmem, and it *must* be useful on non-highmem configurations to be appropriate. So I'd much rather create a new linux/kmap.h or something. Or just expose this

Re: Adding kmap_atomic_prot_pfn (was: [git pull] drm patches for 2.6.27-rc1)

2008-10-23 Thread Benjamin Herrenschmidt
On Thu, 2008-10-23 at 19:48 -0700, Linus Torvalds wrote: Then, there's the issue of 64-bit, and just mapping everything there, and the interface to that. I liked the trivial extension to struct resource to have a cached mapping pointer. So if we can just make it pass resources around and

Re: Adding kmap_atomic_prot_pfn (was: [git pull] drm patches for 2.6.27-rc1)

2008-10-23 Thread Keith Packard
On Thu, 2008-10-23 at 19:48 -0700, Linus Torvalds wrote: I'm not entirely sure who wants to own up to owning that particular part of code, and is willing to make kmap_atomic_prot_pfn() also work in the absense of CONFIG_HIGHMEM. All of the kmap_atomic functions *do* work without

Re: Adding kmap_atomic_prot_pfn (was: [git pull] drm patches for 2.6.27-rc1)

2008-10-23 Thread Keith Packard
On Fri, 2008-10-24 at 14:24 +1100, Benjamin Herrenschmidt wrote: I'm not that fan of carrying a mapping with a struct resource because if we do that we should probably also refcount the mapping, and then there is the whole question of mappings with different attributes, etc etc... I'm fine