On Fri, 2007-03-09 at 13:49 +0200, Panagiotis Papadakos wrote:
> Yep, I think it is OK!
Pushed, thanks.
--
Earthling Michel Dänzer | http://tungstengraphics.com
Libre software enthusiast | Debian, X and DRI developer
Yep, I think it is OK!
On Friday 09 March 2007 10:46, Michel Dänzer wrote:
> On Thu, 2007-03-08 at 19:07 +0200, Panagiotis Papadakos wrote:
> > On Thursday 08 March 2007 17:05, Michel Dänzer wrote:
> > > Any idea what's going on? The only situation where radeonSetCliprects
> > > doesn't get called
On Thu, 2007-03-08 at 19:07 +0200, Panagiotis Papadakos wrote:
> On Thursday 08 March 2007 17:05, Michel Dänzer wrote:
> >
> > Any idea what's going on? The only situation where radeonSetCliprects
> > doesn't get called from radeonMakeCurrent is if neither the drawable nor
> > its stamp has changed
On Thursday 08 March 2007 17:05, Michel Dänzer wrote:
>
> Any idea what's going on? The only situation where radeonSetCliprects
> doesn't get called from radeonMakeCurrent is if neither the drawable nor
> its stamp has changed...
We have to call radeonSetCliprects(radeon), before
r300UpdateViewp
On Thu, 2007-03-08 at 17:03 +0200, Panagiotis Papadakos wrote:
> I still get invalid reads with your latest patch.
Any idea what's going on? The only situation where radeonSetCliprects
doesn't get called from radeonMakeCurrent is if neither the drawable nor
its stamp has changed...
--
Earthling
I still get invalid reads with your latest patch.
On Thursday 08 March 2007 15:42, Michel Dänzer wrote:
> On Thu, 2007-03-08 at 14:31 +0100, Michel Dänzer wrote:
> > On Thu, 2007-03-08 at 14:25 +0200, Panagiotis Papadakos wrote:
> > > > Calling radeonSetCliprects when stamp!=lastStamp also helps!
On Thu, 2007-03-08 at 14:31 +0100, Michel Dänzer wrote:
> On Thu, 2007-03-08 at 14:25 +0200, Panagiotis Papadakos wrote:
> > > Calling radeonSetCliprects when stamp!=lastStamp also helps!
> > Sorry meant radeon->lastStamp != driDrawPriv->lastStamp
>
> That'll usually be fine, but in theory the st
On Thu, 2007-03-08 at 14:25 +0200, Panagiotis Papadakos wrote:
> > Calling radeonSetCliprects when stamp!=lastStamp also helps!
> Sorry meant radeon->lastStamp != driDrawPriv->lastStamp
That'll usually be fine, but in theory the stamps could be identical
when a different drawable was bound previo
> Calling radeonSetCliprects when stamp!=lastStamp also helps!
Sorry meant radeon->lastStamp != driDrawPriv->lastStamp and
radeon->lastStamp != driReadPriv->lastStamp.
-
Take Surveys. Earn Cash. Influence the Future of IT
J
On Thursday 08 March 2007 12:12, Michel Dänzer wrote:
> Does calling radeonSetCliprects unconditionally before
> _mesa_make_current help? I don't see a way for radeonMakeCurrent to be
> sure DoBindContext didn't update the cliprects.
Yep it helps. Calling radeonSetCliprects when stamp!=lastStamp
On Wed, 2007-03-07 at 23:19 +0200, Panagiotis Papadakos wrote:
> The problem is that I still get invalid reads when going from fullscreen mode
> to window mode for the first time, with my OSG application.
Hmm, then I guess it re-binds the context in the process of switching
between fullscreen and
The problem is that I still get invalid reads when going from fullscreen mode
to window mode for the first time, with my OSG application.
On Wednesday 07 March 2007 19:10, Michel Dänzer wrote:
> On Wed, 2007-03-07 at 19:02 +0200, Panagiotis Papadakos wrote:
> > On Friday 02 March 2007 16:41, Mich
On Wed, 2007-03-07 at 19:02 +0200, Panagiotis Papadakos wrote:
> On Friday 02 March 2007 16:41, Michel Dänzer wrote:
> > On Mon, 2007-02-26 at 07:09 +0200, Panagiotis Papadakos wrote:
> > > Well I think I have the correct patch for this.
> >
> > I'm afraid not; the test modification is incorrect. T
On Friday 02 March 2007 16:41, Michel Dänzer wrote:
> On Mon, 2007-02-26 at 07:09 +0200, Panagiotis Papadakos wrote:
> > Well I think I have the correct patch for this.
>
> I'm afraid not; the test modification is incorrect. The test is an
> optimization to avoid doing unnecessary work when the con
On Mon, 2007-02-26 at 07:09 +0200, Panagiotis Papadakos wrote:
> Well I think I have the correct patch for this.
I'm afraid not; the test modification is incorrect. The test is an
optimization to avoid doing unnecessary work when the context is already
up to date wrt the drawables passed in and
Well I think I have the correct patch for this. We should call
radeonSetCliprects inside radeonMakeCurrent to update to
the new pClipRects whenever lastStamps change.
Probably this should also be applied to r200. Haven't seen for other drivers.
Comments?
P.S.
Should I try to get an account?
O
Well this patch is not correct since it leads to memory leaks, probably due to
succeeding calls to dri_interface->getDrawableInfo. So I created the attached
patch, but again valgrind warns for invalid reads.
Anyone understands why?
Thanks
P.S. Sorry but I am new to the code!
On Thursday 01 Fe
Checking with valgrind I got some invalid reads. The message was like the
following:
==6988== Invalid read of size 4
==6988==at 0x4B3C7FD: intersect_rect (radeon_state.c:61)
==6988==by 0x4B3C9DA: radeonRecalcScissorRects (radeon_state.c:108)
==6988==by 0x4B3CAEC: radeonUpdateScissor (
18 matches
Mail list logo