https://bugs.freedesktop.org/show_bug.cgi?id=37696
--- Comment #5 from Joshua Roys roysj...@gmail.com ---
(In reply to comment #4)
Created attachment 76913 [details] [review]
possible fix
Does the attached patch help?
Yes, that patch fixes the lines. Double-checking with avivotool shows
This looks a bit like a hack and it doesn't look right, conceptually. If
the call fails, it should restore things as if nothing has ever happened
and overwriting old_mapping is not going to do the trick.
I think the right way to fix it would be to separately store the
original mapping for
https://bugs.freedesktop.org/show_bug.cgi?id=43655
--- Comment #24 from Alexandre Demers alexandre.f.dem...@gmail.com ---
62444b7462a2b98bc78d68736c03a7c4e66ba7e2 is the first bad commit
commit 62444b7462a2b98bc78d68736c03a7c4e66ba7e2
Author: Alex Deucher alexander.deuc...@amd.com
Date: Wed Aug
https://bugs.freedesktop.org/show_bug.cgi?id=62959
Priority: medium
Bug ID: 62959
Assignee: dri-devel@lists.freedesktop.org
Summary: r600g (HD 6950 Cayman) fails piglit tests and hangs
system
Severity: normal
https://bugs.freedesktop.org/show_bug.cgi?id=62959
Alexandre Demers alexandre.f.dem...@gmail.com changed:
What|Removed |Added
Hardware|Other |All
--
https://bugs.freedesktop.org/show_bug.cgi?id=62959
--- Comment #1 from Alexandre Demers alexandre.f.dem...@gmail.com ---
I'd appreciate if someone could tell me how to test a single glsl test (or
batch or version) at a time.
--
You are receiving this mail because:
You are the assignee for the
https://bugs.freedesktop.org/show_bug.cgi?id=61182
--- Comment #20 from Chris Fong mutek...@hotmail.com ---
(In reply to comment #16)
No gnome-shell crashes since I've upgraded to Mesa 9.1.1. Will post an
update in a few days whether it remains stable or I was just lucky today.
Observed the
https://bugs.freedesktop.org/show_bug.cgi?id=62959
--- Comment #2 from Alexandre Demers alexandre.f.dem...@gmail.com ---
Nevermind, I've found out how to run a single glsl test.
Running /home/dema1701/projects/display/piglit/framework/../bin/shader_runner
ttp://lists.freedesktop.org/archives/dri-devel/attachments/20130330/c8099788/attachment.html>
.
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20130330/5b9e17f6/attachment.html>
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20130330/a24a62d2/attachment-0001.html>
t; - dev->dev_mapping = >i_data;
> + dev->dev_mapping = old_mapping = >i_data;
> /* ihold ensures nobody can remove inode with our i_data */
> ihold(container_of(dev->dev_mapping, struct inode, i_data));
> inode->i_mapping = dev->dev_mapping;
> --
> 1.7.10.4
>
> --
> Michal Hocko
> SUSE Labs
-- next part --
A non-text attachment was scrubbed...
Name: 0001-drm-correctly-restore-mappings-if-drm_open-fails.patch
Type: application/octet-stream
Size: 2097 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20130330/33ae1302/attachment.obj>
If first drm_open fails, the error-handling path will
incorrectly restore inode's mapping to NULL. This can
cause the crash later on. Fix by separately storing
away mapping pointers that drm_open can touch and
restore each from its own respective variable if the
call fails.
Reference:
13 matches
Mail list logo
