[PATCH v2] drm/tilcdc: Precalculate total frametime in tilcdc_crtc_set_mode()

2017-10-13 Thread Jyri Sarha
We need the total frame refresh time to check if we are too close to vertical sync when updating the two framebuffer DMA registers and risk a collision. This new method is more accurate that the previous that based on mode's vrefresh value, which itself is inaccurate or may not even be

[pull] drm/msm: fixes for 4.14

2017-10-13 Thread Rob Clark
Hi Dave, A few fixes for 4.14.. The following changes since commit 545036a9944e9d6e50fed4ca03117147c880ff71: Merge tag 'drm-misc-fixes-2017-10-11' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000) are available in the git repository at:

Re: [PATCH] drm/tilcdc: Remove redundant OF_DETACHED flag setting

2017-10-13 Thread Jyri Sarha
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 10/13/17 10:47, Stephen Boyd wrote: > of_fdt_unflatten_tree() already sets the flag on this node to > OF_DETACHED, because of_fdt_unflatten_tree() calls >

Re: [PATCH] drm/ttm: fix the fix for huge compound pages

2017-10-13 Thread Christian König
Michel, gentle ping to you. With that patch applied piglit seems to be stable on my Tonga (with a bit older Mesa). Christian. Am 12.10.2017 um 19:30 schrieb Christian König: From: Christian König We don't use compound pages at the moment. Take this into account

Re: [PATCH 2/4] drm: Add missing __user annotation to drm_syncobj_array_find()

2017-10-13 Thread Ville Syrjälä
On Fri, Sep 01, 2017 at 07:44:46PM +0200, Thierry Reding wrote: > On Fri, Sep 01, 2017 at 07:53:26PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > 'user_handles' needs a __user annotation for fix the following sparse > > warning: > >

Re: [PATCH v2] drm/tilcdc: Precalculate total frametime in tilcdc_crtc_set_mode()

2017-10-13 Thread Jyri Sarha
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 10/13/17 14:04, Tomi Valkeinen wrote: >> +uint tilcdc_mode_hvtotal(const struct drm_display_mode *mode) >> +{ >> +uint ret; >> + >> +ret = (uint)

[PATCH v13 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

2017-10-13 Thread Meghana Madhyastha
Rename tinydrm_of_find_backlight to backlight_get and move it to linux/backlight.c so that it can be used by other drivers. Signed-off-by: Meghana Madhyastha --- Changes in v13: -Add backlight_put to backlight.h in this patch

[GIT PULL] etnaviv-next for 4.15

2017-10-13 Thread Lucas Stach
Hi Dave, this time around we have a bunch more patches, compared to the last cycles. Most notable addition this time is the support for the GPU performance counters by Christian. This has been in the making for some time and it has matured a lot. Since this is adding UAPI, the corresponding WIP

[Bug 100443] DMESG: [powerplay] Can't find requested voltage id in vdd_dep_on_sclk table!

2017-10-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100443 --- Comment #35 from Devin Prince --- Upon further investigation, I would like to ammend my previous comment. Setting amdgpu.dpm=0 will allow you to bypass those errors by disabling dpm altogether, but the consequence is

[PATCH v13 3/3] drm/tinydrm: Add devres versions of backlight_get

2017-10-13 Thread Meghana Madhyastha
Add devm_backlight_get and the corresponding release function because some drivers use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha --- Changes in v13: -Add devm_backlight_put to backlight.c

Re: [PATCH] staging: vboxvideo: Fix reporting invalid suggested-offset-properties

2017-10-13 Thread Hans de Goede
Hi, On 13-10-17 08:26, Michael Thayer wrote: Hello Hans, 12.10.2017 20:10, Hans de Goede wrote: The x and y hints receives from the host are unsigned 32 bit integers and they get set to -1 (0x) when invalid. Before this commit the vboxvideo driver was storing them in an u16 causing

Re: [PATCH v2] drm/tilcdc: Precalculate total frametime in tilcdc_crtc_set_mode()

2017-10-13 Thread Tomi Valkeinen
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 13/10/17 12:35, Jyri Sarha wrote: > We need the total frame refresh time to check if we are too close to > vertical sync when updating the two framebuffer DMA

Re: [PATCH v2] drm/tilcdc: Precalculate total frametime in tilcdc_crtc_set_mode()

2017-10-13 Thread Tomi Valkeinen
This message contains a digitally signed email which can be read by opening the attachment. Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki --- Begin Message --- On 13/10/17 15:00, Jyri Sarha wrote: > On 10/13/17

Re: [PATCH v2 0/9] Exynos DRM: rewrite IPP subsystem and userspace API

2017-10-13 Thread Tobias Jakobi
Hello everyone, I have finished some first (working) version of my mpv video backend for IPPv2. You can find the tree here: https://github.com/tobiasjakobi/mpv I've also created some RFC pull request upstream, to get some input on the current patches: https://github.com/mpv-player/mpv/pull/4986

Re: [PATCH v2 1/6] drm/amd/display: Use DRM new-style object iterators.

2017-10-13 Thread Andrey Grodzovsky
On 10/13/2017 11:41 AM, Leo wrote: On 2017-10-13 11:03 AM, Andrey Grodzovsky wrote: On 10/12/2017 05:15 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" Use the correct for_each_new/old_* iterators instead of for_each_* List of affected functions:

Re: [Outreachy kernel] [PATCH] drm/amd/powerplay: Remove unnecessary cast on void pointer

2017-10-13 Thread Julia Lawall
On Fri, 13 Oct 2017, Harsha Sharma wrote: > Done with following coccinelle patch > > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > ( > *((T *)e) > | > ((T *)x)[...] > | > ((T*)x)->f > | > > - (T*) > e > ) > > Signed-off-by: Harsha Sharma >

Re: [PATCH 5/6] drm/amd/display: Fix typo

2017-10-13 Thread Alex Deucher
On Thu, Oct 12, 2017 at 5:15 PM, wrote: > From: "Leo (Sunpeng) Li" > > undersacn -> underscan > > Signed-off-by: Leo (Sunpeng) Li Reviewed-by: Alex Deucher > --- >

Re: [PATCH v2 1/6] drm/amd/display: Use DRM new-style object iterators.

2017-10-13 Thread Andrey Grodzovsky
On 10/12/2017 05:15 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" Use the correct for_each_new/old_* iterators instead of for_each_* List of affected functions: amdgpu_dm_find_first_crtc_matching_connector: use for_each_new - Old from_state_var flag was

Re: [PATCH v13 1/3] drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h

2017-10-13 Thread Daniel Thompson
On 13/10/17 11:40, Meghana Madhyastha wrote: Move the helper functions enable_backlight and disable_backlight from tinydrm-helpers.c to backlight.h as static inline functions so that they can be used by other drivers. Signed-off-by: Meghana Madhyastha --- diff

[PATCH 41/48] drm: omapdrm: dss: Pass omap_dss_device pointer to dss_mgr_*() functions

2017-10-13 Thread Laurent Pinchart
The dss_mgr_*() functions take a channel argument to identify the channel they operate on. This prevents the functions from accessing driver data structures without resorting to global variables. In an effort to remove global variables, pass the omap_dss_device pointer associated with the channel

[PATCH 36/48] drm: omapdrm: dsi: Pass the dsi_data pointer to internal functions

2017-10-13 Thread Laurent Pinchart
Internal dsi functions take a pointer to the DSI platform_device and then cast it to a dsi_data pointer. That's pointless as the caller already has the dsi_data pointer. Pass it directly instead of the platform_device pointer. Signed-off-by: Laurent Pinchart

[PATCH 27/48] drm: omapdrm: dss: Pass DSS pointer to dss clock functions

2017-10-13 Thread Laurent Pinchart
This removes the need to access the global DSS private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DSS device dynamically). Signed-off-by: Laurent Pinchart ---

[PATCH 30/48] drm: omapdrm: dss: Allocate the DSS private data structure dynamically

2017-10-13 Thread Laurent Pinchart
The DSS private data structure is currently stored as a global variable. While no platform with multiple DSS devices currently exists nor is planned, this doesn't comply with the kernel device model and should thus be fixed. As a first step to the fix, allocate the DSS private data structure

[PATCH 32/48] drm: omapdrm: hdmi5: Allocate the omap_hdmi data structure dynamically

2017-10-13 Thread Laurent Pinchart
The omap_hdmi private data structure is currently stored as a global variable. While no platform with multiple HDMI5 encoders currently exists nor is planned, this doesn't comply with the kernel device model and should thus be fixed. Signed-off-by: Laurent Pinchart

[PATCH 34/48] drm: omapdrm: sdi: Allocate the sdi private data structure dynamically

2017-10-13 Thread Laurent Pinchart
The sdi private data structure is currently stored as a global variable. While no platform with multiple SDI encoders currently exists nor is planned, this doesn't comply with the kernel device model and should thus be fixed. Signed-off-by: Laurent Pinchart ---

[PATCH 35/48] drm: omapdrm: dsi: Make wait_for_bit_change() return a status

2017-10-13 Thread Laurent Pinchart
The wait_for_bit_change() function returns the value of the bit it polls. This requires the caller to compare the return value to the expected bit value. As all the existing callers need is to check whether the bit has reached the expected value, it's easier to return a boolean status from the

[PATCH 31/48] drm: omapdrm: hdmi4: Allocate the omap_hdmi data structure dynamically

2017-10-13 Thread Laurent Pinchart
The omap_hdmi private data structure is currently stored as a global variable. While no platform with multiple HDMI4 encoders currently exists nor is planned, this doesn't comply with the kernel device model and should thus be fixed. Signed-off-by: Laurent Pinchart

[PATCH 26/48] drm: omapdrm: dss: Pass DSS pointer to dss_get_*_clk_source()

2017-10-13 Thread Laurent Pinchart
This removes the need to access the global DSS private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DSS device dynamically). Signed-off-by: Laurent Pinchart ---

[PATCH 23/48] drm: omapdrm: dss: Pass PLL pointer to dss_ctrl_pll_enable()

2017-10-13 Thread Laurent Pinchart
This will allow accessing the PLL data to get the DSS device pointer, removing the need to access the global DSS private data. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dss.c | 13 +++-- drivers/gpu/drm/omapdrm/dss/dss.h

[PATCH 28/48] drm: omapdrm: dss: Pass DSS pointer to remaining dss functions

2017-10-13 Thread Laurent Pinchart
This removes the need to access the global DSS private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DSS device dynamically). Signed-off-by: Laurent Pinchart ---

[PATCH 20/48] drm: omapdrm: Merge the omapdrm and omapdss drivers

2017-10-13 Thread Laurent Pinchart
The split between the omapdss and omapdrm driver is historic and was due to other userspace APIs (FBDEV and V4L2) being supported in addition to DRM/KMS. Now that the drivers only supports the DRM/KMS API, there is no need to keep them separate anymore. Merge the two drivers and remove the now

[PATCH 37/48] drm: omapdrm: dsi: Combine two commonly used inline functions

2017-10-13 Thread Laurent Pinchart
The dsi_get_dsidrv_data() and dsi_get_dsidev_from_dssdev() inline functions convert a struct omap_dss_device pointer to the corresponding struct platform_device, and a struct platform_device pointer to the corresponding struct dsi_data. They are nearly always called together without any use of the

Re: [PATCH 2/6] drm/amd/display: Use new DRM API where possible

2017-10-13 Thread Harry Wentland
On 2017-10-12 05:15 PM, sunpeng...@amd.com wrote: > From: "Leo (Sunpeng) Li" > > To conform to DRM's new API, we should not be accessing a DRM object's > internal state directly. Rather, the DRM for_each_old/new_* iterators, > and drm_atomic_get_old/new_* interface should be

Re: [PATCH 0/6] Use new DRM API where possible, and cleanups.

2017-10-13 Thread Harry Wentland
Patches 3-6 are Reviewed-by: Harry Wentland Harry On 2017-10-12 05:15 PM, sunpeng...@amd.com wrote: > From: "Leo (Sunpeng) Li" > > Hi Dave, > > This series reworks the previous patch. Patch 1 is a v2 of the previous, > and additional patches are

Re: [PATCH v2 1/6] drm/amd/display: Use DRM new-style object iterators.

2017-10-13 Thread Leo
On 2017-10-13 11:56 AM, Andrey Grodzovsky wrote: On 10/13/2017 11:41 AM, Leo wrote: On 2017-10-13 11:03 AM, Andrey Grodzovsky wrote: On 10/12/2017 05:15 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" Use the correct for_each_new/old_* iterators instead of

[PATCH] drm: panel: simple: add Toshiba LT089AC19000

2017-10-13 Thread Lucas Stach
Only exposes a single mode and not a complete display timing, as the datasheet is rather vague about the minimum/maximum values. Signed-off-by: Lucas Stach --- .../display/panel/toshiba,lt089ac29000.txt | 8 +++ drivers/gpu/drm/panel/panel-simple.c

Re: [PATCH 6/6] drm/amd/display: Remove useless pcrtc pointer

2017-10-13 Thread Alex Deucher
On Thu, Oct 12, 2017 at 5:15 PM, wrote: > From: "Leo (Sunpeng) Li" > > in amdgpu_dm_atomic_commit_tail. Just use crtc instead. > > Signed-off-by: Leo (Sunpeng) Li Reviewed-by: Alex Deucher > --- >

Re: [Outreachy kernel] [PATCH v3] drm/amd/powerplay: Remove unnecessary cast on void pointer

2017-10-13 Thread Julia Lawall
On Sat, 14 Oct 2017, Harsha Sharma wrote: > Done with following coccinelle patch > > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > ( > *((T *)e) > | > ((T *)x)[...] > | > ((T*)x)->f > | > > - (T*) > e > ) > > Signed-off-by: Harsha Sharma >

[Bug 102809] Rust shadows(?) flash random colours

2017-10-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102809 --- Comment #12 from bugzilla.i...@spamgourmet.com --- Using the patch I now no longer have the flashes occurring in game. (In reply to Nicolai Hähnle from comment #11) > Created attachment 134808 [details] [review] > possible fix > > Please

[PATCH v2] drm/vc4: Fix sleeps during the IRQ handler for DSI transactions.

2017-10-13 Thread Eric Anholt
VC4's DSI1 has a bug where the AXI connection is broken for 32-bit writes from the CPU, so we use the DMA engine to DMA 32-bit values into registers instead. That sleeps, so we can't do it from the top half. As a solution, use an interrupt thread so that all our writes happen when sleeping is is

[PATCH 6/7] drm/sun4i: hdmi: Document PAD_CTRL1 output invert bits

2017-10-13 Thread Chen-Yu Tsai
While debugging inverted color from the HDMI output on the A10, I found that the lowest 3 bits were set. These were cleared on A20 boards that had normal display output. By manually toggling these bits the mapping of the color components to these bits was found. While these are not used anywhere,

[PATCH 7/7] drm/sun4i: hdmi: Move PAD_CTRL1 setting to mode_set function

2017-10-13 Thread Chen-Yu Tsai
Initially we configured the PAD_CTRL1 register at probe/bind time. However it seems the HDMI controller will modify some of the bits in this register by itself. On the A10 it is particularly annoying as it toggles the output invert bits, which inverts the colors on the display output. The U-boot

[PATCH 0/7] drm/sun4i: More cleanups

2017-10-13 Thread Chen-Yu Tsai
Hi, Here's another bunch of cleanups for sun4i-drm. Most of these were found while working on A10/A20 DRM and HDMI support. To be clear, nothing was broken before these patches. Patch 1 trims the sun4i-drm probe sequence by not adding repeating components. The component can deal with duplicates,

[PATCH 5/7] drm/sun4i: backend: Offset layer buffer address by DRAM starting address

2017-10-13 Thread Chen-Yu Tsai
The display backend, as well as other peripherals that have a DRAM clock gate and access DRAM directly, bypassing the system bus, address the DRAM starting from 0x0, while physical addresses the system uses starts from 0x4000 (or 0x2000 in A80's case). Correct the address configured into

[PATCH 4/7] drm/sun4i: backend: Add comment explaining why registers are cleared

2017-10-13 Thread Chen-Yu Tsai
Many of the backend's layer configuration registers have undefined default values. This poses a risk as we use regmap_update_bits in some places, and don't overwrite the whole register. At probe/bind time we explicitly clear all the control registers by writing 0 to them. This patch adds a more

[PATCH 3/7] drm/sun4i: backend: Use drm_fb_cma_get_gem_addr() to get display memory

2017-10-13 Thread Chen-Yu Tsai
Commit 4636ce93d5b2 ("drm/fb-cma-helper: Add drm_fb_cma_get_gem_addr()") adds a new helper, which covers fetching a drm_framebuffer's GEM object and calculating the buffer address for a given plane. This patch uses this helper to replace our own open coded version of the same function.

[PATCH 2/7] drm/sun4i: backend: Create regmap after access is possible

2017-10-13 Thread Chen-Yu Tsai
The backend has various clocks and reset controls that need to be enabled and deasserted before register access is possible. Move the creation of the regmap to after the clocks and reset controls have been configured where it makes more sense. Signed-off-by: Chen-Yu Tsai ---

[PATCH 1/7] drm/sun4i: don't add components that are already in the queue

2017-10-13 Thread Chen-Yu Tsai
Even though the components framework can handle duplicate entries, the extra entries cause a lot more debug messages to be generated, which would be confusing to developers not familiar with our driver and the framework in general. Instead, we can scan the relatively small queue and check if the

tracing, dma-buf: Remove unused trace event dma_fence_annotate_wait_on

2017-10-13 Thread Steven Rostedt
From: Steven Rostedt (VMware) Commit e941759c74 ("fence: dma-buf cross-device synchronization") added trace event fence_annotate_wait_on, but never used it. It was renamed to dma_fence_annotate_wait_on by commit f54d186700 ("dma-buf: Rename struct fence to dma_fence") but

Re: [PATCH v13 3/3] drm/tinydrm: Add devres versions of backlight_get

2017-10-13 Thread Daniel Thompson
On 13/10/17 11:42, Meghana Madhyastha wrote: Add devm_backlight_get and the corresponding release function because some drivers use devres versions of functions for requiring device resources. s/requiring/acquiring/ Signed-off-by: Meghana Madhyastha With the

[PATCH 11/48] drm: omapdrm: Use unsigned int type

2017-10-13 Thread Laurent Pinchart
The kernel favours 'unsigned int' over plain 'unsigned'. Replace all occurences of the latter by the former. This avoid lots of checkpatch complaints in patches that touch lines where a plain 'unsigned' is used. Signed-off-by: Laurent Pinchart ---

[PATCH 13/48] drm: omapdrm: connector-analog-tv: Remove tvc_of_match forward declaration

2017-10-13 Thread Laurent Pinchart
The tvc_of_match variable is never referenced before its definition. Remove the forward declaration. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 12/48] drm: omapdrm: Split init and cleanup from probe and remove functions

2017-10-13 Thread Laurent Pinchart
When merging the omapdrm and omapdss drivers there will be not omapdrm platform device anymore, and thus no associated probe and remove functions. To prepare for that, split all the initialization code from the probe function to make it usable without a platform device. Similarly, split the

[PATCH 09/48] drm: omapdrm: Deconstruct the omap_drv.h header.

2017-10-13 Thread Laurent Pinchart
The number of function declarations in the omap_drv.h degrades readability. To fix it, create new header files for each part of the driver and move the related functions. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_connector.h | 37

[PATCH 10/48] drm: omapdrm: Use kernel integer types

2017-10-13 Thread Laurent Pinchart
The standard kernel integer types are [us]{8,16,32}. Use them instead of the u?int{8,16,32}_t types. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_crtc.c | 12 - drivers/gpu/drm/omapdrm/omap_crtc.h | 2 +-

[PATCH 17/48] drm: omapdrm: displays: Get connector source at connect time

2017-10-13 Thread Laurent Pinchart
The connector drivers need a handle to the source they are connected to in order to control the source. All drivers get that handle at probe time, resulting in probe deferral when the source hasn't been probed yet. However they don't need the handle until their connect handler is called. Move

[PATCH 18/48] drm: omapdrm: displays: Get panel source at connect time

2017-10-13 Thread Laurent Pinchart
The connector drivers need a handle to the source they are connected to in order to control the source. All drivers get that handle at probe time, resulting in probe deferral when the source hasn't been probed yet. However they don't need the handle until their connect handler is called. Move

[PATCH 07/48] drm: omapdrm: dpi: Remove dpi_data port_initialized field

2017-10-13 Thread Laurent Pinchart
The dpi_data structure port_initialized field is used to check in the cleanup path whether the DPI has been initialized. This can be performed through the associated device_node data field instead. Remove the port_initialized field. Signed-off-by: Laurent Pinchart

[PATCH 04/48] drm: omapdrm: Merge the omapdss and omapdss-base modules

2017-10-13 Thread Laurent Pinchart
There's no need for the omapdss-base code to be part of a separate module. Merge it with the omapdss module. This allows removing the exports for internal symbols. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/Kconfig | 4

[PATCH 08/48] drm: omapdrm: venc: Return error code on OF parsing failure

2017-10-13 Thread Laurent Pinchart
The venc_probe_of() function has an error cleanup path that returns success instead of an error code. Fix it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/venc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 06/48] drm: omapdrm: dss: Make dss_dump_clocks() function static

2017-10-13 Thread Laurent Pinchart
The function isn't used outside of its compilation unit, make it static. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dss.c | 4 +++- drivers/gpu/drm/omapdrm/dss/dss.h | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 05/48] drm: omapdrm: dss: Set the DMA coherent mask

2017-10-13 Thread Laurent Pinchart
When merging the omapdrm and omapdss drivers the omapdrm virtual platform device will disappear, and the omapdss platform device will be used for DMA memory allocation. To prepare for that, set the DMA coherent mask for the device. Signed-off-by: Laurent Pinchart

Re: [PATCH 1/2] drm/udl: Fixed problem with UDL adpater reconnection

2017-10-13 Thread Alex Deucher
On Thu, Oct 12, 2017 at 8:13 PM, Robert Tarasov wrote: > Fixed problem with DisplayLink and DisplayLink certified adapers in drm/udl > driver when adapter doesn't want to work if it was initialized with > disconnected DVI cable by enabling drm connectot polling and

Re: [PATCH] drm/tinydrm: Remove explicit .best_encoder assignment

2017-10-13 Thread Noralf Trønnes
Den 10.10.2017 22.58, skrev Haneen Mohammed: Since the driver is relying on the atomic helpers, remove the explicit .best_encoder assignment and let the core call drm_atomic_helper_best_encoder(). Signed-off-by: Haneen Mohammed --- Thanks, applied to drm-misc.

Re: [PATCH v3] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

2017-10-13 Thread Noralf Trønnes
Den 07.10.2017 00.17, skrev Harsha Sharma: Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma --- Thanks, applied to drm-misc. Noralf. Changes in v3: -Solve merge conflicts

Re: [PULL] drm-misc-next

2017-10-13 Thread Maarten Lankhorst
Op 12-10-17 om 14:05 schreef Daniel Vetter: > Hi Dave, > > drm-misc-next-2017-10-12: > More 4.15 drm-misc stuff: > > Cross-subsystem Changes: > - bridge cleanup refactor (Benjamin Gaignard) > > Core Changes: > - less surprising atomic iterators (Maarten), fixes an oops introduced > in drm-next >

[PATCH v3] drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl

2017-10-13 Thread Boris Brezillon
This ioctl will allow us to purge inactive userspace buffers when the system is running out of contiguous memory. For now, the purge logic is rather dumb in that it does not try to release only the amount of BO needed to meet the last CMA alloc request but instead purges all objects placed in the

[PATCH 24/48] drm: omapdrm: sdi: Pass DSS pointer to dss_sdi_*() functions

2017-10-13 Thread Laurent Pinchart
This removes the need to access the global DSS private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DSS device dynamically). Signed-off-by: Laurent Pinchart ---

[PATCH 25/48] drm: omapdrm: dss: Pass DSS pointer to dss_ops operations

2017-10-13 Thread Laurent Pinchart
This removes the need to access the global DSS private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DSS device dynamically). Signed-off-by: Laurent Pinchart ---

[PATCH 19/48] drm: omapdrm: displays: Get encoder source at connect time

2017-10-13 Thread Laurent Pinchart
The encoder drivers need a handle to the source they are connected to in order to control the source. All drivers get that handle at probe time, resulting in probe deferral when the source hasn't been probed yet. However they don't need the handle until their connect handler is called. Move

[PATCH 21/48] drm: omapdrm: dss: Support passing private data to debugfs show handlers

2017-10-13 Thread Laurent Pinchart
To simplify implementation of debugfs seq_file show handlers, the driver passes the pointer to the show function through the debugfs_create_file data pointer. This prevents using the pointer to pass driver private data to the show handler, and requires all handlers to use global variables to

[PATCH 22/48] drm: omapdrm: dss: Pass DSS private structure to runtime PM functions

2017-10-13 Thread Laurent Pinchart
To prepare for the removal of the global variable storing DSS private data, pass its pointer to the dss_runtime_{get,put}() functions. As this requires getting hold of the DSS private structure in the callers, we expose the structure through an opaque pointer that can be retrieved through a new

[PATCH 15/48] drm: omapdrm: displays: Remove OF node check in encoder drivers

2017-10-13 Thread Laurent Pinchart
No encoder is instantiated through platform data anymore, there is no need to check for OF node presence. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/displays/encoder-opa362.c| 5 - drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c|

[PATCH 14/48] drm: omapdrm: displays: Remove OF node check in connector drivers

2017-10-13 Thread Laurent Pinchart
No connector is instantiated through platform data anymore, there is no need to check for OF node presence. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c | 3 --- drivers/gpu/drm/omapdrm/displays/connector-dvi.c

[PATCH 16/48] drm: omapdrm: displays: Remove OF node check in panel drivers

2017-10-13 Thread Laurent Pinchart
No panel is instantiated through platform data anymore, there is no need to check for OF node presence. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/displays/panel-dpi.c| 3 --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c

Re: [PATCH v13 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

2017-10-13 Thread Daniel Vetter
Hi Meghana, On Fri, Oct 13, 2017 at 04:09:27PM +0530, Meghana Madhyastha wrote: > Move drm helper functions from tinydrm-helpers to linux/backlight for > ease of use by callers in other drivers. I've been a bit overloaded past few days, so didn't get around to looking at any of your patches yet,

Re: [Outreachy kernel] Re: [PATCH v4] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-13 Thread Daniel Vetter
On Fri, Oct 13, 2017 at 04:51:38PM +0200, Daniel Vetter wrote: > On Fri, Oct 13, 2017 at 08:03:59PM +0530, Harsha Sharma wrote: > > On Mon, Oct 9, 2017 at 5:36 PM, Harsha Sharma > > wrote: > > > Replace instances of drm_framebuffer_reference/unreference() with > > >

[PATCH 48/48] drm: omapdrm: dss: Store the registered plls array in struct dss_device

2017-10-13 Thread Laurent Pinchart
As part of an effort to remove the usage of global variables in the driver, store the registered plls array in the dss_device structure instead of a global variable. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dispc.c | 4 ++--

Re: [PATCH 2/2] drm/udl: Reading all edid blocks in DRM/UDL driver

2017-10-13 Thread Alex Deucher
On Thu, Oct 12, 2017 at 8:13 PM, Robert Tarasov wrote: > Now DRM/UDL driver retreives all edid data blocks instead of only base one. > Previous approch could lead to improper initialization of video mode with > certain monitors. > > Signed-off-by: Robert Tarasov

Re: tracing, dma-buf: Remove unused trace event dma_fence_annotate_wait_on

2017-10-13 Thread Christian König
Am 13.10.2017 um 16:06 schrieb Steven Rostedt: From: Steven Rostedt (VMware) Commit e941759c74 ("fence: dma-buf cross-device synchronization") added trace event fence_annotate_wait_on, but never used it. It was renamed to dma_fence_annotate_wait_on by commit f54d186700

Re: [PULL] drm-misc-next

2017-10-13 Thread Benjamin Gaignard
2017-10-13 16:08 GMT+02:00 Maarten Lankhorst : > Op 12-10-17 om 14:05 schreef Daniel Vetter: >> Hi Dave, >> >> drm-misc-next-2017-10-12: >> More 4.15 drm-misc stuff: >> >> Cross-subsystem Changes: >> - bridge cleanup refactor (Benjamin Gaignard) >> >> Core

Re: [PATCH v13 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

2017-10-13 Thread Daniel Thompson
On 13/10/17 11:41, Meghana Madhyastha wrote: Rename tinydrm_of_find_backlight to backlight_get and move it to linux/backlight.c so that it can be used by other drivers. Signed-off-by: Meghana Madhyastha Acked-by: Daniel Thompson

[PATCH 43/48] drm: omapdrm: dss: Pass omap_drm_private pointer to dss_mgr_ops

2017-10-13 Thread Laurent Pinchart
The dss_mgr_ops operations implemented by the omapdrm side have to look up the omap_crtc objects from global variables as they are only passed a channel number. In order to remove global variables pass the omap_drm_private pointer to the dss_mgr_ops. This requires storing a pointer to the

[PATCH 40/48] drm: omapdrm: dsi: Don't pass channel to dispc init/uninit functions

2017-10-13 Thread Laurent Pinchart
The dsi_display_init_dispc() and dsi_display_uninit_dispc() functions take a channel argument that is reduntant as it is always identical to the dsi->output.dispc_channel. Remove the argument and use the field directly in the functions to avoid misuse. Signed-off-by: Laurent Pinchart

[PATCH 45/48] drm: omapdrm: dispc: Pass DISPC pointer to remaining dispc API functions

2017-10-13 Thread Laurent Pinchart
This removes the need to access the global DISPC private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DISPC private data dynamically). Signed-off-by: Laurent Pinchart ---

[PATCH 47/48] drm: omapdrm: dss: Store the debugfs root directory in struct dss_device

2017-10-13 Thread Laurent Pinchart
As part of an effort to remove the usage of global variables in the driver, store the debugfs root directory in the dss_device structure instead of a global variable. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dispc.c | 2 +-

[PATCH 39/48] drm: omapdrm: dsi: Store the struct device pointer in struct dsi_data

2017-10-13 Thread Laurent Pinchart
The dsi_data structure stores a pointer to a struct platform_device. The driver only uses the dev member of the platform device structure. Store the struct device pointer instead and use it directly. Signed-off-by: Laurent Pinchart ---

[PATCH 38/48] drm: omapdrm: dsi: Use dev pointer directly in dsi_bind() function

2017-10-13 Thread Laurent Pinchart
The dsi_bind() function receives a pointer to a struct device that it casts to a struct platform_device, only to use the platform device's dev field through the code. Use the dev pointer directly. While at it rename the struct platform_device pointer dsidev to pdev to make it more explicit.

[PATCH 33/48] drm: omapdrm: venc: Allocate the venc private data structure dynamically

2017-10-13 Thread Laurent Pinchart
The venc private data structure is currently stored as a global variable. While no platform with multiple VENC encoders currently exists nor is planned, this doesn't comply with the kernel device model and should thus be fixed. Signed-off-by: Laurent Pinchart

[PATCH 42/48] drm: omapdrm: dss: Remove unused functions prototypes

2017-10-13 Thread Laurent Pinchart
The omap_dss_register_driver(), omap_dss_unregister_driver() and dispc_enable_gamma_table() functions don't exist anymore, remove their prototypes. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dss.h | 1 -

[PATCH 44/48] drm: omapdrm: dispc: Pass DISPC pointer to dispc_ops operations

2017-10-13 Thread Laurent Pinchart
This removes the need to access the global DISPC private data in those functions (both for the current accesses and the future ones that will be introduced when allocating the DISPC private data dynamically). In order to allow the omapdrm side to call the dispc_ops with a DISPC pointer, we also

[PATCH 29/48] drm: omapdrm: dss: Remove dss_get_hdmi_venc_clk_source() function

2017-10-13 Thread Laurent Pinchart
The function is unused, remove it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dss.c | 14 -- drivers/gpu/drm/omapdrm/dss/dss.h | 1 - 2 files changed, 15 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c

Re: [PATCH] drm/ttm: fix the fix for huge compound pages

2017-10-13 Thread Michel Dänzer
On 12/10/17 07:30 PM, Christian König wrote: > From: Christian König > > We don't use compound pages at the moment. Take this into account when > freeing them. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/ttm/ttm_page_alloc.c

Re: [Outreachy kernel] Re: [PATCH v4] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-13 Thread Daniel Vetter
On Fri, Oct 13, 2017 at 08:03:59PM +0530, Harsha Sharma wrote: > On Mon, Oct 9, 2017 at 5:36 PM, Harsha Sharma > wrote: > > Replace instances of drm_framebuffer_reference/unreference() with > > *_get/put() suffixes and drm_dev_unref with *_put() suffix > > because

[PATCH 02/48] drm: omapdrm: Pass drm_device to omap_gem_resume()

2017-10-13 Thread Laurent Pinchart
The omap_gem_resume() function is internal to the driver. Pass it a drm_device pointer that the caller already has instead of looking it up from device data. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-

[PATCH 00/48] omapdrm: Merge omapdrm and omapdss

2017-10-13 Thread Laurent Pinchart
Hello, This patch series merges the omapdrm and omapdss drivers into a single driver called omapdrm. The split in two drivers was historical, in order to support the FBDEV, V4L2 and DRM/KMS APIs. Now that the driver supports DRM/KMS only there's no need to keep two seperate drivers. The series

[PATCH 01/48] drm: omapdrm: dpi: Don't treat GPIO probe deferral as an error

2017-10-13 Thread Laurent Pinchart
There's no need to print an error message on probe deferral, that's a normal situation. Probe deferral debugging can be performed by enabling the related debug messages in the drivers core. Signed-off-by: Laurent Pinchart ---

[PATCH 03/48] drm: omapdrm: Remove unused omap_dss_find_device() function

2017-10-13 Thread Laurent Pinchart
The omap_dss_find_device() function is unused. Remove it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/display.c | 14 -- drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 --- 2 files changed, 17 deletions(-) diff --git

Re: [PATCH v2 1/6] drm/amd/display: Use DRM new-style object iterators.

2017-10-13 Thread Leo
On 2017-10-13 11:03 AM, Andrey Grodzovsky wrote: On 10/12/2017 05:15 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" Use the correct for_each_new/old_* iterators instead of for_each_* List of affected functions: amdgpu_dm_find_first_crtc_matching_connector: use

Re: [Outreachy kernel] [PATCH v13 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

2017-10-13 Thread Rob Clark
On Fri, Oct 13, 2017 at 4:25 PM, Sean Paul wrote: > On Fri, Oct 13, 2017 at 04:11:43PM +0530, Meghana Madhyastha wrote: >> Rename tinydrm_of_find_backlight to backlight_get and move it >> to linux/backlight.c so that it can be used by other drivers. > > [apologies if this

  1   2   >