Re: [PATCH 27/89] clk: bcm: Add BCM2711 DVP driver

2020-03-24 Thread Stephen Boyd
Quoting Maxime Ripard (2020-03-23 03:56:16) > Hi Stephen, > > On Thu, Mar 12, 2020 at 06:00:59PM -0700, Stephen Boyd wrote: > > > + dvp->clks[1] = clk_register_gate(>dev, "hdmi1-108MHz", > > > +parent, CLK_IS_CRITICAL, > > > +

Re: [PATCH 00/16] x86, crypto: remove always-defined CONFIG_AS_* and cosolidate Kconfig/Makefiles

2020-03-24 Thread Ingo Molnar
* Masahiro Yamada wrote: > This series of cleanups was prompted by Linus: > https://lkml.org/lkml/2020/3/12/726 > > First, this series drop always-on CONFIG_AS_* options. > Some of those options were introduced in old days. > For example, the check for CONFIG_AS_CFI dates back to 2006. > >

Re: [PATCH 00/16] x86, crypto: remove always-defined CONFIG_AS_* and cosolidate Kconfig/Makefiles

2020-03-24 Thread Masahiro Yamada
Hi Ingo, On Wed, Mar 25, 2020 at 1:59 PM Ingo Molnar wrote: > > > * Masahiro Yamada wrote: > > > This series of cleanups was prompted by Linus: > > https://lkml.org/lkml/2020/3/12/726 > > > > First, this series drop always-on CONFIG_AS_* options. > > Some of those options were introduced in old

Re: [PATCH v2 00/11] new cgroup controller for gpu/drm subsystem

2020-03-24 Thread Kenny Ho
Hi Tejun, Can you elaborate more on what are the missing pieces? Regards, Kenny On Tue, Mar 24, 2020 at 2:46 PM Tejun Heo wrote: > > On Tue, Mar 17, 2020 at 12:03:20PM -0400, Kenny Ho wrote: > > What's your thoughts on this latest series? > > My overall impression is that the feedbacks aren't

Re: [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementation)

2020-03-24 Thread Thomas Zimmermann
Hi Am 14.03.20 um 11:59 schrieb Krzysztof Kozlowski: > On Thu, Mar 12, 2020 at 11:49:05AM +0100, Thomas Zimmermann wrote: >> Hi Krzysztof, >> >> I just received a resend email from 3 weeks ago :/ >> >> Do you want me to merge the mgag200 patch into drm-misc-next? > > Thanks but it depends on the

[PATCH v2 hmm 8/9] mm/hmm: do not set pfns when returning an error code

2020-03-24 Thread Jason Gunthorpe
From: Jason Gunthorpe Most places that return an error code, like -EFAULT, do not set HMM_PFN_ERROR, only two places do this. Resolve this inconsistency by never setting the pfns on an error exit. This doesn't seem like a worthwhile thing to do anyhow. If for some reason it becomes important,

[PATCH v2 hmm 5/9] mm/hmm: remove the CONFIG_TRANSPARENT_HUGEPAGE #ifdef

2020-03-24 Thread Jason Gunthorpe
From: Jason Gunthorpe This code can be compiled when CONFIG_TRANSPARENT_HUGEPAGE is off, so remove the ifdef. The function is only ever called under if (pmd_devmap(pmd) || pmd_trans_huge(pmd)) Which is statically false if !CONFIG_TRANSPARENT_HUGEPAGE, so the compiler reliably eliminates

Re: [PATCH hmm 2/6] mm/hmm: return the fault type from hmm_pte_need_fault()

2020-03-24 Thread Jason Gunthorpe
On Sat, Mar 21, 2020 at 09:37:26AM +0100, Christoph Hellwig wrote: > On Fri, Mar 20, 2020 at 01:49:01PM -0300, Jason Gunthorpe wrote: > > +enum { > > + NEED_FAULT = 1 << 0, > > + NEED_WRITE_FAULT = 1 << 1, > > +}; > > Maybe add a HMM_ prefix? Yes, OK, the existing names are pretty generic

[PATCH v2 hmm 7/9] mm/hmm: do not unconditionally set pfns when returning EBUSY

2020-03-24 Thread Jason Gunthorpe
From: Jason Gunthorpe In hmm_vma_handle_pte() and hmm_vma_walk_hugetlb_entry() if fault happens then -EBUSY will be returned and the pfns input flags will have been destroyed. For hmm_vma_handle_pte() set HMM_PFN_NONE only on the success returns that don't otherwise store to pfns. For

Re: [PATCH v5 5/5] drm/panfrost: Register devfreq cooling and attempt to add Energy Model

2020-03-24 Thread Lukasz Luba
On 3/18/20 1:11 PM, Alyssa Rosenzweig wrote: Reviewed-by: Alyssa Rosenzweig Thank you Alyssa for the review. Regards, Lukasz ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH V4 3/4] backlight: qcom-wled: Add WLED5 bindings

2020-03-24 Thread Kiran Gunda
Add WLED5 specific bindings. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy --- .../bindings/leds/backlight/qcom-wled.yaml | 39 ++ 1 file changed, 39 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml

RE: [PATCH] drm/vkms: use bitfield op to get xrgb on compute crc

2020-03-24 Thread David Laight
From: Melissa Wen > Sent: 21 March 2020 20:37 > The previous memset operation was not correctly setting zero on the > alpha channel to compute the crc, and as a result, the > pipe-A-cursor-alpha-transparent subtest of the IGT test kms_cursor_crc > was crashing. To avoid errors of misinterpretation

[PATCH v2 hmm 4/9] mm/hmm: remove HMM_FAULT_SNAPSHOT

2020-03-24 Thread Jason Gunthorpe
From: Jason Gunthorpe Now that flags are handled on a fine-grained per-page basis this global flag is redundant and has a confusing overlap with the pfn_flags_mask and default_flags. Normalize the HMM_FAULT_SNAPSHOT behavior into one place. Callers needing the SNAPSHOT behavior should set a

[PATCH V4 2/4] backlight: qcom-wled: Add callback functions

2020-03-24 Thread Kiran Gunda
Add wled_cabc_config, wled_sync_toggle, wled_ovp_fault_status and wled_ovp_delay callback functions to prepare the driver for adding WLED5 support. wled_cabc_config() ===> Used to configure the cabc register. It is applicable for wled4 and wled5. wled_sync_toggle() ===>

[PATCH V4 0/4] Add support for WLED5

2020-03-24 Thread Kiran Gunda
Currently, WLED driver supports only WLED4 peripherals that is present on pmi8998 and pm660L. This patch series converts the existing WLED4 bindings from .txt to .yaml format and adds the support for WLED5 peripheral that is present on PM8150L. PM8150L WLED supports the following. - Two

[PATCH 1/2] drm/prime: correct logic for mapping sg to arrays

2020-03-24 Thread Shane Francis
Previously drm_prime_sg_to_page_addr_arrays did not allow for scatter-gather tables where the length had been reduced in a dma_map. This commit enables this via drm_prime_dma_sg_to_page_addr_arrays while still keeping the original logic in place for tables that that have not been through dma

[PATCH v2 hmm 2/9] mm/hmm: return the fault type from hmm_pte_need_fault()

2020-03-24 Thread Jason Gunthorpe
From: Jason Gunthorpe Using two bools instead of flags return is not necessary and leads to bugs. Returning a value is easier for the compiler to check and easier to pass around the code flow. Convert the two bools into flags and push the change to all callers. Signed-off-by: Jason Gunthorpe

[PATCH v2 hmm 3/9] mm/hmm: remove unused code and tidy comments

2020-03-24 Thread Jason Gunthorpe
From: Jason Gunthorpe Delete several functions that are never called, fix some desync between comments and structure content, toss the now out of date top of file header, and move one function only used by hmm.c into hmm.c Signed-off-by: Jason Gunthorpe --- include/linux/hmm.h | 104

[PATCH v2 hmm 6/9] mm/hmm: use device_private_entry_to_pfn()

2020-03-24 Thread Jason Gunthorpe
From: Jason Gunthorpe swp_offset() should not be called directly, the wrappers are supposed to abstract away the encoding of the device_private specific information in the swap entry. Reviewed-by: Ralph Campbell Signed-off-by: Jason Gunthorpe --- mm/hmm.c | 2 +- 1 file changed, 1

[PATCH 00/16] x86, crypto: remove always-defined CONFIG_AS_* and cosolidate Kconfig/Makefiles

2020-03-24 Thread Masahiro Yamada
This series of cleanups was prompted by Linus: https://lkml.org/lkml/2020/3/12/726 First, this series drop always-on CONFIG_AS_* options. Some of those options were introduced in old days. For example, the check for CONFIG_AS_CFI dates back to 2006. We raise the minimal tool versions from time

Re: [PATCH 22/51] drm: manage drm_minor cleanup with drmm_

2020-03-24 Thread Thomas Zimmermann
Hi Am 23.03.20 um 15:49 schrieb Daniel Vetter: > The cleanup here is somewhat tricky, since we can't tell apart the > allocated minor index from 0. So register a cleanup action first, and > if the index allocation fails, unregister that cleanup action again to > avoid bad mistakes. > > The kdev

[PATCH V4 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format

2020-03-24 Thread Kiran Gunda
Convert the qcom-wled bindings from .txt to .yaml format. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy Acked-by: Daniel Thompson --- .../bindings/leds/backlight/qcom-wled.txt | 154 - .../bindings/leds/backlight/qcom-wled.yaml | 184

Re: [PATCH hmm 3/6] mm/hmm: remove unused code and tidy comments

2020-03-24 Thread Jason Gunthorpe
On Fri, Mar 20, 2020 at 02:46:09PM -0700, Ralph Campbell wrote: > > On 3/20/20 9:49 AM, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > Delete several functions that are never called, fix some desync between > > comments and structure content, remove an unused ret, and move one > >

[PATCH v2 hmm 1/9] mm/hmm: remove pgmap checking for devmap pages

2020-03-24 Thread Jason Gunthorpe
From: Jason Gunthorpe The checking boils down to some racy check if the pagemap is still available or not. Instead of checking this, rely entirely on the notifiers, if a pagemap is destroyed then all pages that belong to it must be removed from the tables and the notifiers triggered.

Re: [PATCH 07/89] clk: bcm: rpi: Allow the driver to be probed by DT

2020-03-24 Thread Maxime Ripard
Hi Stefan, On Sun, Mar 01, 2020 at 01:16:28PM +0100, Stefan Wahren wrote: > Hi Maxime, > > Am 24.02.20 um 10:06 schrieb Maxime Ripard: > > The current firmware clock driver for the RaspberryPi can only be probed by > > manually registering an associated platform_device. > > > > While this works

Re: [PATCH hmm 6/6] mm/hmm: use device_private_entry_to_pfn()

2020-03-24 Thread Jason Gunthorpe
On Sat, Mar 21, 2020 at 09:43:47AM +0100, Christoph Hellwig wrote: > On Fri, Mar 20, 2020 at 01:49:05PM -0300, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > swp_offset() should not be called directly, the wrappers are supposed to > > abstract away the encoding of the device_private

[PATCH V4 4/4] backlight: qcom-wled: Add support for WLED5 peripheral in PM8150L

2020-03-24 Thread Kiran Gunda
From: Subbaraman Narayanamurthy Add support for WLED5 peripheral that is present on PM8150L PMICs. PM8150L WLED supports the following: - Two modulators and each sink can use any of the modulator - Multiple CABC selection options from which one can be selected/enabled - Multiple

[PATCH] drm/vram-helper: remove unneeded #if defined/endif guards.

2020-03-24 Thread Wambui Karuga
Remove unneeded #if/#endif guards for checking whether the CONFIG_DEBUG_FS option is set or not. If the option is not set, the compiler optimizes the functions making the guards unnecessary. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/drm_gem_vram_helper.c | 4 1 file changed, 4

Re: [PATCH hmm 5/6] mm/hmm: remove the CONFIG_TRANSPARENT_HUGEPAGE #ifdef

2020-03-24 Thread Jason Gunthorpe
On Sat, Mar 21, 2020 at 09:43:17AM +0100, Christoph Hellwig wrote: > On Fri, Mar 20, 2020 at 01:49:04PM -0300, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > This code can be compiled when CONFIG_TRANSPARENT_HUGEPAGE is off, so > > remove the ifdef. > > It can compile, but will the

Re: [PATCH 27/89] clk: bcm: Add BCM2711 DVP driver

2020-03-24 Thread Maxime Ripard
Hi Stephen, On Thu, Mar 12, 2020 at 06:00:59PM -0700, Stephen Boyd wrote: > > + dvp->clks[1] = clk_register_gate(>dev, "hdmi1-108MHz", > > +parent, CLK_IS_CRITICAL, > > +base + DVP_HT_RPI_MISC_CONFIG, 4, > > +

Re: [PATCH V3 2/4] backlight: qcom-wled: Add callback functions

2020-03-24 Thread kgunda
On 2020-03-11 16:00, Daniel Thompson wrote: On Wed, Mar 11, 2020 at 12:11:00PM +0530, kgu...@codeaurora.org wrote: On 2020-03-10 20:57, Daniel Thompson wrote: > On Mon, Mar 09, 2020 at 06:56:00PM +0530, Kiran Gunda wrote: > > Add cabc_config, sync_toggle, wled_ovp_fault_status and

[PATCH v2 hmm 9/9] mm/hmm: return error for non-vma snapshots

2020-03-24 Thread Jason Gunthorpe
From: Jason Gunthorpe The pagewalker does not call most ops with NULL vma, those are all routed to pte_hole instead. Thus hmm_vma_fault() is only called with a NULL vma from hmm_vma_walk_hole(), so hoist the check to there. Now it is clear that snapshotting with no vma is a HMM_PFN_ERROR as

[PATCH 2/2] drm/amdgpu: fix scatter-gather mapping with user pages

2020-03-24 Thread Shane Francis
Calls to dma_map_sg may return segments / entries than requested if they fall on page bounderies. The old implementation did not support this use case. Signed-off-by: Shane Francis --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[PATCH v2 hmm 0/9] Small hmm_range_fault() cleanups

2020-03-24 Thread Jason Gunthorpe
From: Jason Gunthorpe This is v2 of the first simple series with a few additional patches of little adjustments. This needs an additional patch to the hmm tester: diff --git a/tools/testing/selftests/vm/hmm-tests.c b/tools/testing/selftests/vm/hmm-tests.c index 033a12c7ab5b6d..da15471a2bbf9a

Re: [PATCH hmm 3/6] mm/hmm: remove unused code and tidy comments

2020-03-24 Thread Jason Gunthorpe
On Sat, Mar 21, 2020 at 09:39:02AM +0100, Christoph Hellwig wrote: > On Fri, Mar 20, 2020 at 01:49:02PM -0300, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > Delete several functions that are never called, fix some desync between > > comments and structure content, remove an unused

[PATCH 10/16] drm/i915: remove always-defined CONFIG_AS_MOVNTDQA

2020-03-24 Thread Masahiro Yamada
CONFIG_AS_MOVNTDQA was introduced by commit 0b1de5d58e19 ("drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory"). We raise the minimal supported binutils version from time to time. The last bump was commit 1fb12b35e5ff ("kbuild: Raise the minimum required binutils version to 2.21").

Re: [PATCH v1 0/3] drm: drm_encoder_init() => drm_encoder_init_funcs()

2020-03-24 Thread Thomas Zimmermann
Hi Sam Am 13.03.20 um 21:17 schrieb Sam Ravnborg: > Thomas Zimmermann had made a nice patch-set that introduced > drm_simple_encoder_init() which is already present in drm-misc-next. > > While looking at this it was suddenly obvious to me that > this was functionalty that really should be

Re: [PATCH 49/51] drm/udl: Drop explicit drm_mode_config_cleanup call

2020-03-24 Thread Thomas Zimmermann
Am 23.03.20 um 15:49 schrieb Daniel Vetter: > It's right above the drm_dev_put(). > > This allows us to delete a bit of onion unwinding in > udl_modeset_init(). > > This is made possible by a preceeding patch which added a drmm_ > cleanup action to drm_mode_config_init(), hence all we need to

Separate pull request? WAS: [PATCH v6 0/9] Huge page-table entries for TTM

2020-03-24 Thread VMware
On 3/4/20 11:28 AM, Thomas Hellström (VMware) wrote: In order to reduce CPU usage [1] and in theory TLB misses this patchset enables huge- and giant page-table entries for TTM and TTM-enabled graphics drivers. Patch 1 and 2 introduce a vma_is_special_huge() function to make the mm code take

Re: Separate pull request? WAS: [PATCH v6 0/9] Huge page-table entries for TTM

2020-03-24 Thread Koenig, Christian
Yeah, sure go ahead. It's just that I am out of office because of COVID-19 and won't be able to help if it goes up in flames :) Cheers, Christian Am 24.03.2020 11:03 schrieb "Thomas Hellström (VMware)" : On 3/4/20 11:28 AM, Thomas Hellström (VMware) wrote: > In order to reduce CPU usage [1]

Re: [PATCH v11 10/12] backlight: pwm_bl: Use 64-bit division function

2020-03-24 Thread Lee Jones
On Fri, 20 Mar 2020, Lee Jones wrote: > On Thu, 19 Mar 2020, Guru Das Srinagesh wrote: > > > Since the PWM framework is switching struct pwm_state.period's datatype > > to u64, prepare for this transition by using div_u64 to handle a 64-bit > > dividend instead of a straight division operation.

Re: [PATCH v3] drm: Align a comment block

2020-03-24 Thread Rodrigo Siqueira
Hi, Reviewed-by: Rodrigo Siqueira On 03/19, Igor Matheus Andrade Torrente wrote: > Fix a checkpatch warning caused by a misaligned comment block. > > Signed-off-by: Igor Matheus Andrade Torrente > > --- > Changes in v2: > - Change subject text > > Changes in V3 > - Fix a typo in the commit

Re: [PATCH] drm/i915: remove always-defined CONFIG_AS_MOVNTDQA

2020-03-24 Thread Masahiro Yamada
Hi i915 maintainers, On Mon, Mar 23, 2020 at 11:12 AM Masahiro Yamada wrote: > > CONFIG_AS_MOVNTDQA was introduced by commit 0b1de5d58e19 ("drm/i915: > Use SSE4.1 movntdqa to accelerate reads from WC memory"). > > We raise the minimal supported binutils version from time to time. > The last

Re: [PATCH 14/21] drm: mxsfb: Enable vblank handling

2020-03-24 Thread Stefan Agner
On 2020-03-24 00:08, Stefan Agner wrote: > On 2020-03-09 20:52, Laurent Pinchart wrote: >> Enable vblank handling when the CRTC is turned on and disable it when it >> is turned off. This requires moving vblank init after the KMS pipeline >> initialisation, otherwise drm_vblank_init() gets called

Re: [PATCH 20/22] drm/vkms: Use simple encoder

2020-03-24 Thread Rodrigo Siqueira
Hi Thomas, First of all, thanks for your patch! I applied all your series, compiled it, and when I tried `make INSTALL_MOD_PATH=/PATH/ modules_instal` I got the following message: depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper depmod: ERROR: Found 2 modules in

Re: [PATCH] drm/vkms: enable cursor by default

2020-03-24 Thread Rodrigo Siqueira
Hi Melissa, First of all, thanks for your patch. I agree with you, it makes more sense to me if we enable cursors by default. I don't remember why we decided to add it as a disabled by default. Reviewed-by: Rodrigo Siqueira On 03/21, Melissa Wen wrote: > This patch proposes a change in the

Re: [PATCH] dma-buf: Improve CONFIG_DMABUF_MOVE_NOTIFY help text

2020-03-24 Thread Koenig, Christian
Am 24.03.2020 13:54 schrieb Geert Uytterhoeven : Improve the help text for the CONFIG_DMABUF_MOVE_NOTIFY symbol by: 1. Removing duplicated single quotes, 2. Adding a missing subject, 3. Fixing a misspelling of "yet", 4. Wrapping long lines. Fixes: bb42df4662a44765 ("dma-buf: add dynamic

Re: [PATCH v11 10/12] backlight: pwm_bl: Use 64-bit division function

2020-03-24 Thread Daniel Thompson
On Tue, Mar 24, 2020 at 01:57:35PM +0100, Uwe Kleine-König wrote: > Hello Lee, > > On Tue, Mar 24, 2020 at 11:07:10AM +, Lee Jones wrote: > > On Fri, 20 Mar 2020, Lee Jones wrote: > > > > > On Thu, 19 Mar 2020, Guru Das Srinagesh wrote: > > > > > > > Since the PWM framework is switching

Re: [PATCH v11 10/12] backlight: pwm_bl: Use 64-bit division function

2020-03-24 Thread Uwe Kleine-König
Hello Lee, On Tue, Mar 24, 2020 at 11:07:10AM +, Lee Jones wrote: > On Fri, 20 Mar 2020, Lee Jones wrote: > > > On Thu, 19 Mar 2020, Guru Das Srinagesh wrote: > > > > > Since the PWM framework is switching struct pwm_state.period's datatype > > > to u64, prepare for this transition by using

[PATCH] drm: add managed resources tied to drm_device

2020-03-24 Thread Daniel Vetter
We have lots of these. And the cleanup code tends to be of dubious quality. The biggest wrong pattern is that developers use devm_, which ties the release action to the underlying struct device, whereas all the userspace visible stuff attached to a drm_device can long outlive that one (e.g. after

Re: [PATCH v3] video: fbdev: vesafb: add missed release_region

2020-03-24 Thread Bartlomiej Zolnierkiewicz
On 3/24/20 2:35 PM, Chuhong Yuan wrote: > On Fri, Mar 20, 2020 at 8:01 PM Bartlomiej Zolnierkiewicz > wrote: >> >> >> On 3/10/20 3:35 AM, Chuhong Yuan wrote: >>> The driver forgets to free the I/O region in remove and probe >>> failure. >>> Add the missed calls to fix it. >>> >>> Signed-off-by:

Re: 2020 X.Org Board of Directors Elections Nomination period is NOW

2020-03-24 Thread Daniel Vetter
Another reminder that we're in the election process, and the next deadline is approaching: - Send board nominations to elections AT x DOT org - Got to https://members.x.org/ to renew your membership (or become one to begin with!) On Tue, Mar 17, 2020 at 7:21 AM Daniel Vetter wrote: > > Just a

[PATCH] dma-buf: Improve CONFIG_DMABUF_MOVE_NOTIFY help text

2020-03-24 Thread Geert Uytterhoeven
Improve the help text for the CONFIG_DMABUF_MOVE_NOTIFY symbol by: 1. Removing duplicated single quotes, 2. Adding a missing subject, 3. Fixing a misspelling of "yet", 4. Wrapping long lines. Fixes: bb42df4662a44765 ("dma-buf: add dynamic DMA-buf handling v15") Signed-off-by: Geert

[PATCH v2 4/6] video: fbdev: controlfb: remove function prototypes part #1

2020-03-24 Thread Bartlomiej Zolnierkiewicz
Reorder code a bit and then remove no longer needed function prototypes. Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 41 +++-- 1 file changed, 13 insertions(+), 28 deletions(-) diff --git

[PATCH v2 1/6] video: fbdev: controlfb: fix sparse warning about using incorrect type

2020-03-24 Thread Bartlomiej Zolnierkiewicz
Use in_le32() instead of le32_to_cpup() to fix sparse warning about improper type of the argument. Also add missing inline keyword to control_par_to_var() definition (to match function prototype). Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz ---

[PATCH v2 0/6] video: fbdev: controlfb: small cleanup

2020-03-24 Thread Bartlomiej Zolnierkiewicz
Hi, Small cleanup for controlfb driver: - fix sparse warnings - remove not working module support - add COMPILE_TEST support - remove redundant function prototypes Changes since v1 (https://lore.kernel.org/lkml/20200116140900.26363-1-b.zolnier...@samsung.com/): - use in_le32() instead of

[PATCH v2 3/6] video: fbdev: controlfb: remove obsolete module support

2020-03-24 Thread Bartlomiej Zolnierkiewicz
CONFIG_FB_CONTROL is bool, hence the Apple "control" frame buffer driver cannot be built as a module. Replace module_init() by device_initcall(). Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 25 + 1 file changed,

[PATCH v2 6/6] video: fbdev: controlfb: remove function prototypes part #3

2020-03-24 Thread Bartlomiej Zolnierkiewicz
Reorder code a bit and then remove no longer needed function prototypes. Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 302 +++- 1 file changed, 145 insertions(+), 157 deletions(-) diff --git

[PATCH v2 5/6] video: fbdev: controlfb: remove function prototypes part #2

2020-03-24 Thread Bartlomiej Zolnierkiewicz
Reorder code a bit and then remove no longer needed function prototypes. Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 410 +++- 1 file changed, 198 insertions(+), 212 deletions(-) diff --git

[PATCH v2 2/6] video: fbdev: controlfb: add COMPILE_TEST support

2020-03-24 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to controlfb driver for better compile testing coverage. While at it: - convert driver to use eieio() and dcbf() helpers instead of open-coding them - add invalid_vram_cache() helper to avoid code duplication Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej

RE: [PATCH v2 1/5] drm: Introduce plane and CRTC scaling filter properties

2020-03-24 Thread Laxminarayan Bharadiya, Pankaj
> -Original Message- > From: Ville Syrjälä > Sent: 23 March 2020 19:52 > To: Laxminarayan Bharadiya, Pankaj > > Cc: Lattannavar, Sameer ; > jani.nik...@linux.intel.com; dan...@ffwll.ch; intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org; dani...@collabora.com; Maarten

Re: [PATCH v11 10/12] backlight: pwm_bl: Use 64-bit division function

2020-03-24 Thread Uwe Kleine-König
On Tue, Mar 24, 2020 at 02:24:41PM +, Lee Jones wrote: > On Tue, 24 Mar 2020, Daniel Thompson wrote: > > > On Tue, Mar 24, 2020 at 01:57:35PM +0100, Uwe Kleine-König wrote: > > > Hello Lee, > > > > > > On Tue, Mar 24, 2020 at 11:07:10AM +, Lee Jones wrote: > > > > On Fri, 20 Mar 2020,

RE: [PATCH v2 5/5] drm/i915: Enable scaling filter for plane and CRTC

2020-03-24 Thread Laxminarayan Bharadiya, Pankaj
> -Original Message- > From: Ville Syrjälä > Sent: 23 March 2020 20:18 > To: Laxminarayan Bharadiya, Pankaj > > Cc: Lattannavar, Sameer ; > jani.nik...@linux.intel.com; dan...@ffwll.ch; intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org; dani...@collabora.com; Joonas

[PATCH v3 5/7] drm/fourcc: amlogic: Add modifier definitions for Memory Saving option

2020-03-24 Thread Neil Armstrong
Amlogic uses a proprietary lossless image compression protocol and format for their hardware video codec accelerators, either video decoders or video input encoders. An option exist changing the layout superblock size to save memory when using 8bit components pixels size. The layout options

[PATCH v3 3/7] drm/meson: overlay: setup overlay for Amlogic FBC

2020-03-24 Thread Neil Armstrong
Setup the Amlogic FBC decoder for the VD1 video overlay plane. The VD1 Amlogic FBC decoder is integrated in the pipeline like the YUV pixel reading/formatter but used a direct memory address instead. This adds support for the basic layout, and needs to calculate the content body size since the

Re: [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-03-24 Thread Doug Anderson
Hi, On Sun, Mar 22, 2020 at 11:14 PM Kalyan Thota wrote: > > "The PM core always increments the runtime usage counter > before calling the ->suspend() callback and decrements it > after calling the ->resume() callback" > > DPU and DSI are managed as runtime devices. When > suspend is triggered,

RE: [PATCH v2 3/5] drm/i915: Introduce scaling filter related registers and bit fields.

2020-03-24 Thread Laxminarayan Bharadiya, Pankaj
> -Original Message- > From: Ville Syrjälä > Sent: 23 March 2020 20:09 > To: Laxminarayan Bharadiya, Pankaj > > Cc: Lattannavar, Sameer ; > jani.nik...@linux.intel.com; dan...@ffwll.ch; intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org; dani...@collabora.com; Joonas

[PATCH v3 7/7] drm/meson: overlay: setup overlay for Amlogic FBC Scatter Memory layout

2020-03-24 Thread Neil Armstrong
Setup the Amlogic FBC decoder for the VD1 video overlay plane to use read the FBC header as Scatter Memory layout reference. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_overlay.c | 48 +-- 1 file changed, 31 insertions(+), 17 deletions(-) diff --git

[PATCH v3 1/7] drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression

2020-03-24 Thread Neil Armstrong
Amlogic uses a proprietary lossless image compression protocol and format for their hardware video codec accelerators, either video decoders or video input encoders. It considerably reduces memory bandwidth while writing and reading frames in memory. The underlying storage is considered to be 3

[PATCH v3 4/7] drm/meson: crtc: handle commit of Amlogic FBC frames

2020-03-24 Thread Neil Armstrong
Since the VD1 Amlogic FBC decoder is now configured by the overlay driver, commit the right registers to decode the Amlogic FBC frame. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_crtc.c | 118 + 1 file changed, 88 insertions(+), 30 deletions(-)

[PATCH v3 0/7] drm/meson: add support for Amlogic Video FBC

2020-03-24 Thread Neil Armstrong
Amlogic uses a proprietary lossless image compression protocol and format for their hardware video codec accelerators, either video decoders or video input encoders. It considerably reduces memory bandwidth while writing and reading frames in memory. The underlying storage is considered to be 3

[PATCH v3 2/7] drm/meson: add Amlogic Video FBC registers

2020-03-24 Thread Neil Armstrong
Add the registers of the VPU VD1 Amlogic FBC decoder module, and routing register. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_registers.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/meson/meson_registers.h

[PATCH v3 6/7] drm/meson: overlay: setup overlay for Amlogic FBC Memory Saving mode

2020-03-24 Thread Neil Armstrong
Setup the Amlogic FBC decoder for the VD1 video overlay plane to use a different superblock size for the Memory Saving mode. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_overlay.c | 14 -- include/uapi/drm/drm_fourcc.h | 16 +++- 2 files changed,

Re: [PATCH v3 6/7] drm/meson: overlay: setup overlay for Amlogic FBC Memory Saving mode

2020-03-24 Thread Neil Armstrong
On 24/03/2020 15:20, Neil Armstrong wrote: > Setup the Amlogic FBC decoder for the VD1 video overlay plane to use > a different superblock size for the Memory Saving mode. > > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/meson/meson_overlay.c | 14 -- >

Re: [PATCH v11 10/12] backlight: pwm_bl: Use 64-bit division function

2020-03-24 Thread Lee Jones
On Tue, 24 Mar 2020, Daniel Thompson wrote: > On Tue, Mar 24, 2020 at 01:57:35PM +0100, Uwe Kleine-König wrote: > > Hello Lee, > > > > On Tue, Mar 24, 2020 at 11:07:10AM +, Lee Jones wrote: > > > On Fri, 20 Mar 2020, Lee Jones wrote: > > > > > > > On Thu, 19 Mar 2020, Guru Das Srinagesh

[PATCH 1/3] drm/virtio: random virtgpu_drv.h cleanups

2020-03-24 Thread Gurchetan Singh
- Static-ify virtio_gpu_gem_create - Delete unused prototypes - Point to current implementation files Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h | 26 +- drivers/gpu/drm/virtio/virtgpu_gem.c | 10 +- 2 files changed, 14 insertions(+),

[PATCH 3/3] drm/virtio: delete notify in virtio_gpu_object_create

2020-03-24 Thread Gurchetan Singh
- For dumb buffers, virtio_gpu_gem_create can notify. - For 3D buffers, virtio_gpu_gem_object_open can notify. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_gem.c| 1 + drivers/gpu/drm/virtio/virtgpu_object.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v2 3/5] drm/i915: Introduce scaling filter related registers and bit fields.

2020-03-24 Thread Ville Syrjälä
On Tue, Mar 24, 2020 at 02:36:10PM +, Laxminarayan Bharadiya, Pankaj wrote: > > > > -Original Message- > > From: Ville Syrjälä > > Sent: 23 March 2020 20:09 > > To: Laxminarayan Bharadiya, Pankaj > > > > Cc: Lattannavar, Sameer ; > > jani.nik...@linux.intel.com; dan...@ffwll.ch; >

[PATCH 2/3] drm/virtio: delete notify after virtio_gpu_cmd_context_create

2020-03-24 Thread Gurchetan Singh
The first 3D ioctl will take care of notification. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c index 336cc9143205..867c5e239d55

Re: [PATCH v2 5/5] drm/i915: Enable scaling filter for plane and CRTC

2020-03-24 Thread Ville Syrjälä
On Tue, Mar 24, 2020 at 03:32:09PM +, Laxminarayan Bharadiya, Pankaj wrote: > > > > -Original Message- > > From: Ville Syrjälä > > Sent: 23 March 2020 20:18 > > To: Laxminarayan Bharadiya, Pankaj > > > > Cc: Lattannavar, Sameer ; > > jani.nik...@linux.intel.com; dan...@ffwll.ch; >

Re: [PATCH 1/4] drm/radeon: remove unneeded header include path

2020-03-24 Thread Masahiro Yamada
Hi, I think this series is a good clean-up. Could you take a look at this please? On Fri, Feb 14, 2020 at 12:40 AM Masahiro Yamada wrote: > > A header include path without $(srctree)/ is suspicious because it does > not work with O= builds. > > You can build drivers/gpu/drm/radeon/ without

Re: [PATCH 00/16] x86, crypto: remove always-defined CONFIG_AS_* and cosolidate Kconfig/Makefiles

2020-03-24 Thread Linus Torvalds
On Tue, Mar 24, 2020 at 1:49 AM Masahiro Yamada wrote: > > If it is OK to queue this up to Kbuild tree, > I will send a pull request to Linus. Looks fine to me, assuming we didn't now get some confusion due to duplicate patches (I think Jason got his tree added to -next already). And yeah, that

Re: [PATCH v7] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2020-03-24 Thread Karol Herbst
On Sat, Mar 21, 2020 at 2:02 AM Karol Herbst wrote: > > On Fri, Mar 20, 2020 at 11:19 PM Bjorn Helgaas wrote: > > > > On Tue, Mar 10, 2020 at 08:26:27PM +0100, Karol Herbst wrote: > > > Fixes the infamous 'runtime PM' bug many users are facing on Laptops with > > > Nvidia Pascal GPUs by skipping

Re: [PATCH v7] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2020-03-24 Thread Bjorn Helgaas
On Sat, Mar 21, 2020 at 02:02:22AM +0100, Karol Herbst wrote: > On Fri, Mar 20, 2020 at 11:19 PM Bjorn Helgaas wrote: > > > > On Tue, Mar 10, 2020 at 08:26:27PM +0100, Karol Herbst wrote: > > > Fixes the infamous 'runtime PM' bug many users are facing on Laptops with > > > Nvidia Pascal GPUs by

[PATCH v7 8/9] drm/vmwgfx: Introduce a huge page aligning TTM range manager

2020-03-24 Thread VMware
From: "Thomas Hellstrom (VMware)" Using huge page-table entries requires that the physical address of the start of a buffer object is huge page size aligned. Make a special version of the TTM range manager that accomplishes this, but falls back to a smaller page size alignment (PUD->PMD,

[PATCH v7 9/9] drm/vmwgfx: Hook up the helpers to align buffer objects

2020-03-24 Thread VMware
From: "Thomas Hellstrom (VMware)" Start using the helpers that align buffer object user-space addresses and buffer object vram addresses to huge page boundaries. This is to improve the chances of allowing huge page-table entries. Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox

[PATCH v7 2/9] mm: Introduce vma_is_special_huge

2020-03-24 Thread VMware
From: "Thomas Hellstrom (VMware)" For VM_PFNMAP and VM_MIXEDMAP vmas that want to support transhuge pages and -page table entries, introduce vma_is_special_huge() that takes the same codepaths as vma_is_dax(). The use of "special" follows the definition in memory.c, vm_normal_page(): "Special"

[PATCH v7 3/9] mm: Split huge pages on write-notify or COW

2020-03-24 Thread VMware
From: "Thomas Hellstrom (VMware)" The functions wp_huge_pmd() and wp_huge_pud() currently relies on the huge_fault() callback to split huge page table entries if needed. However for module users that requires export of the split_huge_xxx() functionality which may be undesired. Instead split

[PATCH v7 4/9] mm: Add vmf_insert_pfn_xxx_prot() for huge page-table entries

2020-03-24 Thread VMware
From: "Thomas Hellstrom (VMware)" For graphics drivers needing to modify the page-protection, add huge page-table entries counterparts to vmf_insert_pfn_prot(). Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Oracle)" Cc: "Kirill A. Shutemov" Cc: Ralph Campbell Cc: "Jérôme Glisse"

[Bug 206575] [amdgpu] [drm] No video signal on resume from suspend, R9 380

2020-03-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206575 --- Comment #18 from Joe Ramsey (kernel_bugzi...@joeramsey.com) --- (In reply to Alex Deucher from comment #17) > If you could verify that 5.6 works for you, you could bisect to see what > commit fixed it. OK, I'm about to reveal my ignorance.

[PATCH v7 0/9] Huge page-table entries for TTM

2020-03-24 Thread VMware
From: Thomas Hellstrom (VMware) In order to reduce CPU usage [1] and in theory TLB misses this patchset enables huge- and giant page-table entries for TTM and TTM-enabled graphics drivers. Patch 1 and 2 introduce a vma_is_special_huge() function to make the mm code take the same path as DAX

[PATCH v7 5/9] drm/ttm, drm/vmwgfx: Support huge TTM pagefaults

2020-03-24 Thread VMware
From: "Thomas Hellstrom (VMware)" Support huge (PMD-size and PUD-size) page-table entries by providing a huge_fault() callback. We still support private mappings and write-notify by splitting the huge page-table entries on write-access. Note that for huge page-faults to occur, either the kernel

[PATCH v7 7/9] drm: Add a drm_get_unmapped_area() helper

2020-03-24 Thread VMware
From: "Thomas Hellstrom (VMware)" Unaligned virtual addresses makes it unlikely that huge page-table entries can be used. So align virtual buffer object address huge page boundaries to the underlying physical address huge page boundaries taking buffer object sizes into account to determine when

[PATCH v7 6/9] drm/vmwgfx: Support huge page faults

2020-03-24 Thread VMware
From: "Thomas Hellstrom (VMware)" With vmwgfx dirty-tracking we need a specialized huge_fault callback. Implement and hook it up. Cc: Andrew Morton Cc: Michal Hocko Cc: "Matthew Wilcox (Oracle)" Cc: "Kirill A. Shutemov" Cc: Ralph Campbell Cc: "Jérôme Glisse" Cc: "Christian König" Cc: Dan

Re: [PATCH v8] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2020-03-24 Thread Karol Herbst
just noticed that the patch title should be changed.. drm/nouveau: prevent putting nvidia GPUs into lower device states on certain intel bridges or drm/nouveau: workaround runpm fail by disabling PCI power management on certain intel bridges On Tue, Mar 24, 2020 at 9:29 PM Karol Herbst wrote:

Re: [PATCH v2 1/6] video: fbdev: controlfb: fix sparse warning about using incorrect type

2020-03-24 Thread Daniel Vetter
On Tue, Mar 24, 2020 at 02:45:03PM +0100, Bartlomiej Zolnierkiewicz wrote: > Use in_le32() instead of le32_to_cpup() to fix sparse warning about > improper type of the argument. > > Also add missing inline keyword to control_par_to_var() definition > (to match function prototype). > > Acked-by:

Re: [PATCH v7] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges

2020-03-24 Thread Bjorn Helgaas
On Tue, Mar 24, 2020 at 06:31:08PM +0100, Karol Herbst wrote: > On Sat, Mar 21, 2020 at 2:02 AM Karol Herbst wrote: > > > > On Fri, Mar 20, 2020 at 11:19 PM Bjorn Helgaas wrote: > > > > > > On Tue, Mar 10, 2020 at 08:26:27PM +0100, Karol Herbst wrote: > > > > Fixes the infamous 'runtime PM' bug

Re: [PATCH v2 00/11] new cgroup controller for gpu/drm subsystem

2020-03-24 Thread Tejun Heo
On Tue, Mar 17, 2020 at 12:03:20PM -0400, Kenny Ho wrote: > What's your thoughts on this latest series? My overall impression is that the feedbacks aren't being incorporated throughly / sufficiently. Thanks. -- tejun ___ dri-devel mailing list

Re: [PATCH] Revert "drm/dp_mst: Remove VCPI while disabling topology mgr"

2020-03-24 Thread Lyude Paul
Huh? There was an alternative fix for this pushed a while ago: 8732fe46b20c ("drm/dp_mst: Fix clearing payload state on topology disable") But I'm not seeing it in master, although it is cc'd for stable :S On Sun, 2020-03-22 at 16:42 +0100, Jiri Kosina wrote: > On Fri, 17 Jan 2020, Lyude Paul

Re: [PATCH 22/51] drm: manage drm_minor cleanup with drmm_

2020-03-24 Thread Sam Ravnborg
On Mon, Mar 23, 2020 at 03:49:21PM +0100, Daniel Vetter wrote: > The cleanup here is somewhat tricky, since we can't tell apart the > allocated minor index from 0. So register a cleanup action first, and > if the index allocation fails, unregister that cleanup action again to > avoid bad mistakes.

  1   2   >