Re: [Intel-gfx] [PATCH 3/3] drm/i915: Drop the drm_atomic_helper_calc_timestamping_constants() call

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 03:00:26PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We update the timestamping constants per-crtc explicitly in > intel_crtc_update_active_timings(). Furtermore the helper will > use uapi.adjusted_mode whereas we want hw.adjusted_mode. Thus > let's drop the

Re: [PATCH 2/2] drm/msm/dpu: clean up some impossibilities

2020-09-07 Thread kernel test robot
Hi Rob, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on linus/master v5.9-rc4 next-20200903] [cannot apply to drm-intel/for-linux-next tegra-drm/drm/tegra/for-next drm/drm-next drm-exynos/exynos-drm-next] [If your patch

Re: [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 02:46:21PM +0530, Vaibhav Gupta wrote: > On Mon, Sep 07, 2020 at 09:55:59AM +0200, Daniel Vetter wrote: > > On Thu, Aug 06, 2020 at 12:52:54PM +0530, Vaibhav Gupta wrote: > > > Linux Kernel Mentee: Remove Legacy Power Management. > > > > > > The original goal of the patch

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 07:17:12PM +0300, Laurent Pinchart wrote: > Hi Stefan, > > Thank you for the patch. > > On Mon, Sep 07, 2020 at 06:03:43PM +0200, Stefan Agner wrote: > > The lcdif IP does not support a framebuffer pitch (stride) other than > > the CRTC width. Check for equality and

Re: [PATCH v2 3/3] drm: panel: add TDO tl070wsh30 panel driver

2020-09-07 Thread Sam Ravnborg
Hi Neil. On Mon, Sep 07, 2020 at 01:10:27PM +0200, Neil Armstrong wrote: > This adds support for the TDO TL070WSH30 TFT-LCD panel module. > The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. > It provides a MIPI DSI interface to the host, a built-in LED backlight > and touch

Re: [PATCH 5/9] arm64: dts: renesas: r8a77961: Add VSP device nodes

2020-09-07 Thread Kuninori Morimoto
Hi Kieran > > From: Kuninori Morimoto > > > > This patch adds VSP device nodes for R-Car M3-W+ (r8a77961) SoC. > > This patch is test on R-Car M3-W+ Salvator-XS board. > > > > Signed-off-by: Kuninori Morimoto > > --- (snip) > Do we keep the items grouped by the first occurrence? or sort the

Re: [PATCH 6/6] drm/meson: add support for MIPI-DSI transceiver

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 11:03:29AM +0200, Neil Armstrong wrote: > On 07/09/2020 10:44, Daniel Vetter wrote: > > On Mon, Sep 07, 2020 at 10:43:51AM +0200, Daniel Vetter wrote: > >> On Mon, Sep 07, 2020 at 10:18:25AM +0200, Neil Armstrong wrote: > >>> The Amlogic AXg SoCs embeds a Synopsys

Re: [PATCH 2/2] drm/ttm: merge offset and base in ttm_bus_placement

2020-09-07 Thread Dave Airlie
I'd written something similar but didn't finish it! For the series, Reviewed-by: Dave Airlie On Mon, 7 Sep 2020 at 23:29, Christian König wrote: > > This is used by TTM to communicate the physical address > which should be used with ioremap(), ioremap_wc(). We don't > need to separate the

Re: [Nouveau] [PATCH v5 1/2] drm/nouveau/kms/nv50-: Program notifier offset before requesting disp caps

2020-09-07 Thread Ben Skeggs
On Sat, 5 Sep 2020 at 06:28, Lyude Paul wrote: > > Not entirely sure why this never came up when I originally tested this > (maybe some BIOSes already have this setup?) but the ->caps_init vfunc > appears to cause the display engine to throw an exception on driver > init, at least on my ThinkPad

[PATCH v2 08/10] arm64: dts: renesas: r8a77961: Add HDMI device nodes

2020-09-07 Thread Kuninori Morimoto
From: Kuninori Morimoto This patch adds HDMI device nodes for R-Car M3-W+ (r8a77961) SoC. This patch was tested on R-Car M3-W+ Salvator-XS board. Signed-off-by: Kuninori Morimoto --- arch/arm64/boot/dts/renesas/r8a77961.dtsi | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-)

[PATCH v2 10/10] arm64: dts: renesas: r8a77961-salvator-xs: add HDMI Sound support

2020-09-07 Thread Kuninori Morimoto
From: Kuninori Morimoto This patch enables HDMI Sound on R-Car M3-W+ Salvator-XS board. This reverts commit b997613fad58a03588f0f64a3d86db6c5bd76dd2. Signed-off-by: Kuninori Morimoto --- .../boot/dts/renesas/r8a77961-salvator-xs.dts | 29 +++ 1 file changed, 29 insertions(+)

[PATCH v2 06/10] arm64: dts: renesas: r8a77961: Add VSP device nodes

2020-09-07 Thread Kuninori Morimoto
From: Kuninori Morimoto This patch adds VSP device nodes for R-Car M3-W+ (r8a77961) SoC. This patch was tested on R-Car M3-W+ Salvator-XS board. Signed-off-by: Kuninori Morimoto --- arch/arm64/boot/dts/renesas/r8a77961.dtsi | 55 +++ 1 file changed, 55 insertions(+)

[PATCH v2 01/10] dt-bindings: display: renesas: du: Document the r8a77961 bindings

2020-09-07 Thread Kuninori Morimoto
From: Kuninori Morimoto Document the R-Car M3-W+ (R8A77961) SoC in the R-Car DU bindings. Signed-off-by: Kuninori Morimoto --- Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v2 03/10] dt-bindings: display: renesas: dw-hdmi: Add R8A77961 support

2020-09-07 Thread Kuninori Morimoto
From: Kuninori Morimoto This patch adds R-Car M3-W+ (R8A77961) SoC bindings. Signed-off-by: Kuninori Morimoto Reviewed-by: Geert Uytterhoeven --- .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 02/10] dt-bindings: display: renesas: dw-hdmi: tidyup example compatible.

2020-09-07 Thread Kuninori Morimoto
From: Kuninori Morimoto required is "renesas,r8a7795-hdmi", instead of "renesas,r8a7795-dw-hdmi" Signed-off-by: Kuninori Morimoto --- .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 09/10] arm64: dts: renesas: r8a77961-salvator-xs: add HDMI Display support

2020-09-07 Thread Kuninori Morimoto
From: Kuninori Morimoto This patch enables HDMI Display on R-Car M3-W+ Salvator-XS board. Signed-off-by: Kuninori Morimoto --- .../boot/dts/renesas/r8a77961-salvator-xs.dts | 28 +++ 1 file changed, 28 insertions(+) diff --git

[PATCH v2 07/10] arm64: dts: renesas: r8a77961: Add DU device nodes

2020-09-07 Thread Kuninori Morimoto
From: Kuninori Morimoto This patch adds DU device nodes for R-Car M3-W+ (r8a77961) SoC. This patch was tested on R-Car M3-W+ Salvator-XS board. Signed-off-by: Kuninori Morimoto --- arch/arm64/boot/dts/renesas/r8a77961.dtsi | 13 - 1 file changed, 12 insertions(+), 1 deletion(-)

Re: [Intel-gfx] [PATCH 2/3] drm/atomic-helper: Remove the timestamping constant update from drm_atomic_helper_update_legacy_modeset_state()

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 03:00:25PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The timestamping constants have nothing to do with any legacy state > so should not be updated from > drm_atomic_helper_update_legacy_modeset_state(). > > Let's make everyone call

[PATCH 07/13] drm/vmwgfx: move to driver binding functions

2020-09-07 Thread Dave Airlie
From: Dave Airlie Acked-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c index

[PATCH 08/13] drm/amdgpu/ttm: move to driver backend binding funcs

2020-09-07 Thread Dave Airlie
From: Dave Airlie Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index

Re: [PATCH 1/9] dt-bindings: display: renesas: du: Document the r8a77961 bindings

2020-09-07 Thread Kuninori Morimoto
Hi Geert > > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > > @@ -18,6 +18,7 @@ Required Properties: > > - "renesas,du-r8a7794" for R8A7794 (R-Car E2) compatible DU > > - "renesas,du-r8a7795" for

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-07 Thread Daniel Abrecht
Am 2020-09-07 16:03, schrieb Stefan Agner: The lcdif IP does not support a framebuffer pitch (stride) other than the CRTC width. This may be true for some SOCs, but not for all of them. I used to have this working flawlessly on the imx8mq like so:

[PATCH v2 00/10] arm64: renesas: enable HDMI Display/Sound on R-Car M3-W+ Salvator-XS

2020-09-07 Thread Kuninori Morimoto
Hi Geert, Laurent These are v2 of HDMI Display/Sound support for R8A77961. These are tested on R-Car M3-W+ Salvator-XS board. v1 -> v2 - "is test" to "was tested" at git-log - add M3-W+ port entry to DU table (= [01/10]) - add dw-hdmi tidyup new patch (= [02/10])

[PATCH v2 05/10] arm64: dts: renesas: r8a77961: Add FCP device nodes

2020-09-07 Thread Kuninori Morimoto
From: Kuninori Morimoto This patch adds FCP device nodes for R-Car M3-W+ (r8a77961) SoC. This patch was tested on R-Car M3-W+ Salvator-XS board. Signed-off-by: Kuninori Morimoto --- arch/arm64/boot/dts/renesas/r8a77961.dtsi | 52 +++ 1 file changed, 52 insertions(+)

[PATCH v2 04/10] drm: rcar-du: Add r8a77961 support

2020-09-07 Thread Kuninori Morimoto
From: Kuninori Morimoto This patch adds R-Car M3-W+ (R8A77961) support which has compatible to R-Car M3-W (R8A77960). Signed-off-by: Kuninori Morimoto --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c

[Bug 203905] amdgpu:actual_brightness has unreal/wrong value

2020-09-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203905 --- Comment #17 from John Shand (jshand2...@gmail.com) --- Created attachment 292419 --> https://bugzilla.kernel.org/attachment.cgi?id=292419=edit Journalctl 8-9-2020 -- You are receiving this mail because: You are watching the assignee of

Re: [PATCH] drm/bridge: dw-mipi-dsi: fix dw_mipi_dsi_debugfs_show/write warnings

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 12:27:11PM +0200, Neil Armstrong wrote: > This fixes the following warnings while building in W=1 : > dw-mipi-dsi.c:1002:5: warning: no previous prototype for > 'dw_mipi_dsi_debugfs_write' [-Wmissing-prototypes] > dw-mipi-dsi.c:1027:5: warning: no previous prototype for >

Re: [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings

2020-09-07 Thread Sam Ravnborg
Hi Neil. On Mon, Sep 07, 2020 at 03:24:47PM +0200, Neil Armstrong wrote: > Hi, > > On 07/09/2020 13:45, Sam Ravnborg wrote: > > Hi Neil. > > > > On Mon, Sep 07, 2020 at 01:10:26PM +0200, Neil Armstrong wrote: > >> This add the bindings for the 1024*600 tl070wsh30 DSI panel. > > > > The binding

Re: [PATCH 00/13] ttm tt refactor repost of part 1

2020-09-07 Thread Ben Skeggs
On Tue, 8 Sep 2020 at 06:46, Dave Airlie wrote: > > Most of these have r-b or acks already, patch 1 I may have > posted before but found in my tree, so reposting it, and patch > 5 for radeon I think were what needed re-review. R-b for ttm and nouveau changes, A-b for the other drivers. Ben. > >

Re: [Intel-gfx] [PATCH 1/3] drm/atomic-helper: Extract drm_atomic_helper_calc_timestamping_constants()

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 03:00:24PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Put the vblank timestamping constants update loop into its own > function. It has no business living inside > drm_atomic_helper_update_legacy_modeset_state() so we'll be wanting > to move it out entirely. As

[Bug 203905] amdgpu:actual_brightness has unreal/wrong value

2020-09-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203905 John Shand (jshand2...@gmail.com) changed: What|Removed |Added CC||jshand2...@gmail.com

[Bug 203905] amdgpu:actual_brightness has unreal/wrong value

2020-09-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203905 --- Comment #16 from John Shand (jshand2...@gmail.com) --- Created attachment 292417 --> https://bugzilla.kernel.org/attachment.cgi?id=292417=edit Dmesg 8-9-2020 -- You are receiving this mail because: You are watching the assignee of the

Re: [PATCH] gpu/drm: cleanup coding style a bit

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 05:31:29AM -0700, Bernard Zhao wrote: > Remove first assignment to info which is meaningless. > Put the width and higth check first. > This change is to make the code a bit readable. > > Signed-off-by: Bernard Zhao Looks reasonable, thanks for your patch. Applied to

[PATCH 03/13] drm/qxl: move bind/unbind/destroy to the driver function table.

2020-09-07 Thread Dave Airlie
From: Dave Airlie Acked-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/qxl/qxl_ttm.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index c3530c6e46bd..4970c3450e88 100644 ---

[PATCH 05/13] drm/radeon/ttm: move to driver binding/destroy functions. (v2)

2020-09-07 Thread Dave Airlie
From: Dave Airlie Do agp decision in the driver, instead of special binding funcs v2: use container_of, drop some {}. Signed-off-by: Dave Airlie --- drivers/gpu/drm/radeon/radeon.h| 7 +- drivers/gpu/drm/radeon/radeon_cs.c | 2 +- drivers/gpu/drm/radeon/radeon_gem.c| 6 +-

[PATCH 01/13] drm/ttm: introduce ttm_bo_move_null

2020-09-07 Thread Dave Airlie
From: Dave Airlie This pattern is cut-n-pasted across 4 drivers, switch it to a WARN_ON instead, as BUG_ON is considered a bad idea usually. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 24 +++- drivers/gpu/drm/nouveau/nouveau_bo.c| 4 +---

[PATCH 00/13] ttm tt refactor repost of part 1

2020-09-07 Thread Dave Airlie
Most of these have r-b or acks already, patch 1 I may have posted before but found in my tree, so reposting it, and patch 5 for radeon I think were what needed re-review. I'd like to land these, and I'll revisit the remainder of this series. Dave. ___

[PATCH 02/13] drm/ttm: add optional bind/unbind via driver.

2020-09-07 Thread Dave Airlie
From: Dave Airlie I want to remove the backend funcs Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_tt.c| 15 +++--- include/drm/ttm/ttm_bo_driver.h | 36 + 2 files changed, 48 insertions(+), 3 deletions(-)

[PATCH 04/13] drm/ttm/agp: export bind/unbind/destroy for drivers to use.

2020-09-07 Thread Dave Airlie
From: Dave Airlie Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_agp_backend.c | 15 +-- include/drm/ttm/ttm_tt.h | 6 ++ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_agp_backend.c

[PATCH 11/13] drm/ttm: get rid of agp specific populate/unpopulate paths.

2020-09-07 Thread Dave Airlie
From: Dave Airlie Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ++-- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- drivers/gpu/drm/ttm/ttm_agp_backend.c | 17 - include/drm/ttm/ttm_tt.h | 2 -- 4 files

[PATCH 10/13] drm/ttm/agp: drop back end bindings from agp

2020-09-07 Thread Dave Airlie
From: Dave Airlie These aren't used anymore. Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_agp_backend.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_agp_backend.c b/drivers/gpu/drm/ttm/ttm_agp_backend.c index

[PATCH 09/13] drm/gem_vram/ttm: move to driver backend destroy function.

2020-09-07 Thread Dave Airlie
From: Dave Airlie Acked-by: Thomas Zimmermann Acked-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/drm_gem_vram_helper.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c

[PATCH 06/13] drm/nouveau/ttm: use driver bind/unbind/destroy functions.

2020-09-07 Thread Dave Airlie
From: Dave Airlie Acked-by: Christian König Reviewed-by: Ben Skeggs Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_bo.c| 44 drivers/gpu/drm/nouveau/nouveau_sgdma.c | 54 ++--- drivers/gpu/drm/nouveau/nouveau_ttm.h | 3 ++ 3

[PATCH 12/13] drm/ttm/agp: remove bdev from agp helpers

2020-09-07 Thread Dave Airlie
From: Dave Airlie Since the agp bind/unbind/destroy are now getting called from drivers rather than via the func table, drop the bdev parameter. Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_bo.c | 6 +++--- drivers/gpu/drm/radeon/radeon_ttm.c

[PATCH 13/13] drm/ttm: drop the tt backend function paths.

2020-09-07 Thread Dave Airlie
From: Dave Airlie These are now driver side. Reviewed-by: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_tt.c | 15 +++--- include/drm/ttm/ttm_tt.h | 39 2 files changed, 3 insertions(+), 51 deletions(-) diff --git

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_ddp_comp_init()

2020-09-07 Thread Chun-Kuang Hu
Hi Yu Kuai: Yu Kuai 於 2020年9月5日 週六 下午4:31寫道: > > if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have > a corresponding put_device(). Thus add put_device() to fix the exception > handling for this function implementation. > This patch looks good to me, but I find another thing

Re: [PATCH 03/13] drm/qxl: move bind/unbind/destroy to the driver function table.

2020-09-07 Thread Gerd Hoffmann
On Tue, Sep 08, 2020 at 06:46:20AM +1000, Dave Airlie wrote: > From: Dave Airlie > > Acked-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Gerd Hoffmann ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH v4 1/1] drm: allow limiting the scatter list size.

2020-09-07 Thread Gerd Hoffmann
On Mon, Sep 07, 2020 at 03:53:02PM +0200, Daniel Vetter wrote: > On Mon, Sep 7, 2020 at 1:24 PM Gerd Hoffmann wrote: > > > > Add drm_device argument to drm_prime_pages_to_sg(), so we can > > call dma_max_mapping_size() to figure the segment size limit > > and call into

Re: [PATCH v2 01/10] dt-bindings: display: renesas: du: Document the r8a77961 bindings

2020-09-07 Thread Laurent Pinchart
Hi Morimoto-san, Thank you for the patch. On Tue, Sep 08, 2020 at 09:34:04AM +0900, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Document the R-Car M3-W+ (R8A77961) SoC in the R-Car DU bindings. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart > --- >

Re: [RFC] Experimental DMA-BUF Device Heaps

2020-09-07 Thread Laurent Pinchart
Hi Daniel, On Tue, Sep 01, 2020 at 09:32:22AM +0200, Daniel Vetter wrote: > On Sun, Aug 16, 2020 at 02:22:46PM -0300, Ezequiel Garcia wrote: > > This heap is basically a wrapper around DMA-API dma_alloc_attrs, > > which will allocate memory suitable for the given device. > > > > The

linux-next: manual merge of the drm-intel tree with Linus' tree

2020-09-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/display/intel_panel.c between commit: f8bd54d21904 ("drm/i915: panel: Use atomic PWM API for devs with an external PWM controller") from Linus' tree and commit: 6b51e7d23aa8 ("drm/i915:

linux-next: build warning after merge of the drm-misc tree

2020-09-07 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: modpost: missing MODULE_LICENSE() in drivers/gpu/drm/panel/panel-samsung-s6e63m0.o Introduced by commit b7b23e447687 ("drm/panel: s6e63m0: Break out SPI transport") --

Re: [PATCH v2 02/10] dt-bindings: display: renesas: dw-hdmi: tidyup example compatible.

2020-09-07 Thread Laurent Pinchart
Hi Morimoto-san, Thank you for the patch. On Tue, Sep 08, 2020 at 09:34:11AM +0900, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > required is "renesas,r8a7795-hdmi", instead of "renesas,r8a7795-dw-hdmi" > > Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart > --- >

Re: [PATCH v2 03/10] dt-bindings: display: renesas: dw-hdmi: Add R8A77961 support

2020-09-07 Thread Laurent Pinchart
Hi Morimoto-san, Thank you for the patch. On Tue, Sep 08, 2020 at 09:34:17AM +0900, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch adds R-Car M3-W+ (R8A77961) SoC bindings. > > Signed-off-by: Kuninori Morimoto > Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent

Re: [PATCH 1/2] drm/radeon: Add sclk frequency as hwmon sensor

2020-09-07 Thread Sandeep Raghuraman
On 9/1/20 2:03 AM, Alex Deucher wrote: > On Sun, Aug 30, 2020 at 3:25 AM Sandeep Raghuraman > wrote: >> >> This patch series adds support for reporting sclk and vddc values for Radeon >> GPUs, where supported. > > This commit message should be specific to this particular patch rather > than

Re: [PATCH v2 04/10] drm: rcar-du: Add r8a77961 support

2020-09-07 Thread Laurent Pinchart
Hi Morimoto-san, Thank you for the patch. On Tue, Sep 08, 2020 at 09:34:32AM +0900, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch adds R-Car M3-W+ (R8A77961) support which has > compatible to R-Car M3-W (R8A77960). Maybe "... is compatible with the ..." ? >

Re: [PATCH v2 05/10] arm64: dts: renesas: r8a77961: Add FCP device nodes

2020-09-07 Thread Laurent Pinchart
Hi Morimoto-san, Thank you for the patch. On Tue, Sep 08, 2020 at 09:34:50AM +0900, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch adds FCP device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori

Re: [PATCH v2 1/2] drm: allow limiting the scatter list size.

2020-09-07 Thread Gerd Hoffmann
> > + /** > > +* @max_segment: > > +* > > +* Max size for scatter list segments. When unset the default > > +* (SCATTERLIST_MAX_SEGMENT) is used. > > +*/ > > + size_t max_segment; > > Is there no better place for this then "at the bottom"? drm_device is a > huge

[PATCH] drm/mediatek: add missing put_device() call in mtk_ddp_comp_init()

2020-09-07 Thread Yu Kuai
if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have a corresponding put_device(). Thus add put_device() to fix the exception handling for this function implementation. Fixes: d0afe37f5209 ("drm/mediatek: support CMDQ interface in ddp component") Signed-off-by: Yu Kuai ---

[PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction

2020-09-07 Thread Martin Cerveny
The secondary video layer (VI) on "Allwinner V3s" displays decoded video (YUV) in wrong colors. The secondary CSC should be programmed. Let's correct CSC register offset and extend regmap size. Regards. Martin Cerveny (2): drm/sun4i: sun8i-csc: Secondary CSC register correction drm/sun4i:

[PATCH 1/2] drm/sun4i: sun8i-csc: Secondary CSC register correction

2020-09-07 Thread Martin Cerveny
"Allwinner V3s" has secondary video layer (VI). Decoded video is displayed in wrong colors until secondary CSC registers are programmed correctly. Signed-off-by: Martin Cerveny --- drivers/gpu/drm/sun4i/sun8i_csc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC PATCH v2 06/17] gpu: host1x: Cleanup and refcounting for syncpoints

2020-09-07 Thread Dmitry Osipenko
05.09.2020 13:34, Mikko Perttunen пишет: ... > + > +/** > + * host1x_syncpt_put() - free a requested syncpoint > + * @sp: host1x syncpoint > + * > + * Release a syncpoint previously allocated using host1x_syncpt_request(). A > + * host1x client driver should call this when the syncpoint is no

Re: [PATCH v1 1/2] video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container

2020-09-07 Thread Vaibhav Gupta
___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v1 2/2] fbdev: radeonfb:use generic power management

2020-09-07 Thread Vaibhav Gupta
Drivers using legacy PCI power management .suspend()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a "struct dev_pm_ops" variable to take the

[PATCH 2/2] drm/sun4i: mixer: Extend regmap max_register

2020-09-07 Thread Martin Cerveny
Better guess. Secondary CSC registers are from 0xF. Signed-off-by: Martin Cerveny --- drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c index

[PATCH v1 1/2] video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container

2020-09-07 Thread Vaibhav Gupta
Fixes commit 42ddb453a0cd ("radeon: Conditionally compile PM code") Before the above mentioned patch, codes between the line number 547 and 2803 were already inside "#ifdef CONFIG_PM" container. Thus, addition of "#if defined(CONFIG_PM)" was not required in the patch. It also affected the "#ifdef

Re: [Linux-kernel-mentees] [PATCH v1 1/2] video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container

2020-09-07 Thread Vaibhav Gupta
On Mon, Sep 07, 2020 at 08:48:10AM +0200, Greg KH wrote: > On Mon, Sep 07, 2020 at 12:03:47PM +0530, Vaibhav Gupta wrote: > > > > Why did you send empty emails out? > > greg k-h I was trying to re-ping the patches. Guess it went empty. I will send patches again. Vaibhav

Re: [PATCH v1 2/2] fbdev: radeonfb:use generic power management

2020-09-07 Thread Vaibhav Gupta
___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

2020-09-07 Thread Vaibhav Gupta
Linux Kernel Mentee: Remove Legacy Power Management. The original goal of the patch series is to upgrade the power management framework of radeonfb fbdev driver. This has been done by upgrading .suspend() and .resume() callbacks. The upgrade makes sure that the involvement of PCI Core does not

Re: [PATCH 2/3] backlight: pwm_bl: Artificially add 0% during interpolation

2020-09-07 Thread Daniel Vetter
On Fri, Sep 04, 2020 at 12:38:22PM +0100, Daniel Thompson wrote: > On Mon, Jul 20, 2020 at 09:25:21PM -0700, Alexandru Stan wrote: > > Some displays need the low end of the curve cropped in order to make > > them happy. In that case we still want to have the 0% point, even though > > anything

Re: [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

2020-09-07 Thread Daniel Vetter
On Thu, Aug 06, 2020 at 12:52:54PM +0530, Vaibhav Gupta wrote: > Linux Kernel Mentee: Remove Legacy Power Management. > > The original goal of the patch series is to upgrade the power management > framework of radeonfb fbdev driver. This has been done by upgrading .suspend() > and .resume()

Re: [PATCH v2] drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs

2020-09-07 Thread Neil Armstrong
Hi, On 06/04/2020 15:49, Angelo Ribeiro wrote: > Add support for the video pattern generator (VPG) BER pattern mode and > configuration in runtime. > > This enables using the debugfs interface to manipulate the VPG after > the pipeline is set. > Also, enables the usage of the VPG BER pattern. >

[PATCH v3 2/2] drm/virtio: set max_segment

2020-09-07 Thread Gerd Hoffmann
When initializing call virtio_max_dma_size() to figure the scatter list limit. Needed to make virtio-gpu work properly with SEV. v2: place max_segment in drm driver not gem object. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_kms.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v3 1/2] drm: allow limiting the scatter list size.

2020-09-07 Thread Gerd Hoffmann
Add max_segment argument to drm_prime_pages_to_sg(). When set pass it through to the __sg_alloc_table_from_pages() call, otherwise use SCATTERLIST_MAX_SEGMENT. Also add max_segment field to drm driver and pass it to drm_prime_pages_to_sg() calls in drivers and helpers. v2: place max_segment in

[PATCH v3 0/2] drm: fix virtio-gpu + sev

2020-09-07 Thread Gerd Hoffmann
virtio-gpu must make sure scatter list segments are not too big. Gerd Hoffmann (2): drm: allow limiting the scatter list size. drm/virtio: set max_segment include/drm/drm_device.h| 8 include/drm/drm_prime.h | 3 ++-

Re: [Linux-kernel-mentees] [PATCH v1 1/2] video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container

2020-09-07 Thread Greg KH
On Mon, Sep 07, 2020 at 12:03:47PM +0530, Vaibhav Gupta wrote: > Why did you send empty emails out? greg k-h ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/1] drm/amdgpu: Convert to using devm_drm_dev_alloc()

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 10:06:08AM +0200, Daniel Vetter wrote: > On Sat, Sep 05, 2020 at 11:50:05AM -0400, Alex Deucher wrote: > > On Thu, Sep 3, 2020 at 9:22 PM Luben Tuikov wrote: > > > > > > Convert to using devm_drm_dev_alloc(), > > > as drm_dev_init() is going away. > > > > > >

[PATCH] drm/xlnx: Use devm_drm_dev_alloc

2020-09-07 Thread Daniel Vetter
Gets rid of drmm_add_final_kfree, which I want to unexport so that it stops confusion people about this transitional state of rolling drm managed memory out. This also fixes the missing drm_dev_put in the error path of the probe code. v2: Drop the misplaced drm_dev_put from zynqmp_dpsub_drm_init

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-07 Thread Simon Ser
On Monday, September 7, 2020 10:31 AM, Daniel Vetter wrote: > On Wed, Sep 02, 2020 at 02:59:49PM +, Simon Ser wrote: > > > On Wednesday, September 2, 2020 4:29 PM, Daniel Vetter > > daniel.vet...@ffwll.ch wrote: > > > > > On Wed, Sep 2, 2020 at 2:49 PM Simon Ser cont...@emersion.fr wrote: >

Re: [PATCH 6/6] drm/meson: add support for MIPI-DSI transceiver

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 10:43:51AM +0200, Daniel Vetter wrote: > On Mon, Sep 07, 2020 at 10:18:25AM +0200, Neil Armstrong wrote: > > The Amlogic AXg SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), > > with a custom > > glue managing the IP resets, clock and data input similar to the

Re: [PATCH v2 04/11] drm/fourcc: Add AMD DRM modifiers.

2020-09-07 Thread Pierre-Eric Pelloux-Prayer
Hi Bas, 2 small typos you may want to fix: On 04/09/2020 18:07, Bas Nieuwenhuizen wrote: > This adds modifiers for GFX9+ AMD GPUs. > > As the modifiers need a lot of parameters I split things out in > getters and setters. > - Advantage: simplifies the code a lot > - Disadvantage: Makes it

Re: [PATCH v2 00/11] amd/display: Add GFX9+ modifier support.

2020-09-07 Thread Ernst Sjöstrand
Den fre 4 sep. 2020 kl 18:07 skrev Bas Nieuwenhuizen < b...@basnieuwenhuizen.nl>: > This adds modifier support to radeonsi. > Wouldn't it be more correct to say that this adds modifier support to amdgpu (and enables it to work with radeonsi OpenGL) or something like that? //E > It has been

Re: [PATCH 6/6] drm/meson: add support for MIPI-DSI transceiver

2020-09-07 Thread Neil Armstrong
On 07/09/2020 10:44, Daniel Vetter wrote: > On Mon, Sep 07, 2020 at 10:43:51AM +0200, Daniel Vetter wrote: >> On Mon, Sep 07, 2020 at 10:18:25AM +0200, Neil Armstrong wrote: >>> The Amlogic AXg SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), >>> with a custom >>> glue managing the IP

Re: [Linux-kernel-mentees] [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

2020-09-07 Thread Greg KH
On Mon, Sep 07, 2020 at 12:01:53PM +0530, Vaibhav Gupta wrote: > Please review this patch-series. I see no patch here :( ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 00/11] amd/display: Add GFX9+ modifier support.

2020-09-07 Thread Daniel Vetter
On Fri, Sep 04, 2020 at 06:06:58PM +0200, Bas Nieuwenhuizen wrote: > This adds modifier support to radeonsi. > It has been tested on > > - VEGA10, RAVEN, NAVI14 > - weston, sway, X with xf86-video-amdgpu (i.e. legacy path still works) > > and includes some basic testing of the layout code. > >

Re: [PATCH v3 0/2] drm: fix virtio-gpu + sev

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 08:33:41AM +0200, Gerd Hoffmann wrote: > virtio-gpu must make sure scatter list segments are not too big. > > Gerd Hoffmann (2): > drm: allow limiting the scatter list size. > drm/virtio: set max_segment So this all feels a bit irky and mid-layer, and why can't the

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 08:37:31AM +, Simon Ser wrote: > On Monday, September 7, 2020 10:31 AM, Daniel Vetter wrote: > > > On Wed, Sep 02, 2020 at 02:59:49PM +, Simon Ser wrote: > > > > > On Wednesday, September 2, 2020 4:29 PM, Daniel Vetter > > > daniel.vet...@ffwll.ch wrote: > > > >

Re: [PATCH v3 6/7] drm: Validate encoder->possible_crtcs

2020-09-07 Thread Jan Kiszka
On 11.02.20 18:04, Daniel Vetter wrote: > On Tue, Feb 11, 2020 at 06:22:07PM +0200, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> WARN if the encoder possible_crtcs is effectively empty or contains >> bits for non-existing crtcs. >> >> v2: Move to drm_mode_config_validate() (Daniel) >>

Re: [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

2020-09-07 Thread Vaibhav Gupta
Please review this patch-series. Thank you Vaibhav Gupta ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-07 Thread Daniel Vetter
On Fri, Sep 04, 2020 at 12:43:04PM +0200, Michel Dänzer wrote: > From: Michel Dänzer > > Don't check drm_crtc_state::active for this either, per its > documentation in include/drm/drm_crtc.h: > > * Hence drivers must not consult @active in their various > * _mode_config_funcs.atomic_check

Re: [PATCH 1/1] drm/amdgpu: Convert to using devm_drm_dev_alloc()

2020-09-07 Thread Daniel Vetter
On Sat, Sep 05, 2020 at 11:50:05AM -0400, Alex Deucher wrote: > On Thu, Sep 3, 2020 at 9:22 PM Luben Tuikov wrote: > > > > Convert to using devm_drm_dev_alloc(), > > as drm_dev_init() is going away. > > > > Signed-off-by: Luben Tuikov > > I think we can drop the final drm_put in the error case?

[PATCH 0/6] drm/meson: add support for AXG & MIPI-DSI

2020-09-07 Thread Neil Armstrong
The Amlogic AXG SoC family has a downgraded VPU with the following changes : - Only a single OSD plane, no overlay video plane - The primary plane doesn't support HW scaling - The pixels are read directly from DDR without any Canvas module - Doesn't support HDMI or CVBS - Ouputs only with ENCL

[PATCH 5/6] drm/meson: remove useless recursive components matching

2020-09-07 Thread Neil Armstrong
The initial design was recursive to cover all port/endpoints, but only the first layer of endpoints should be covered by the components list. This also breaks the MIPI-DSI init/bridge attach sequence, thus only parse the first endpoints instead of recursing. Signed-off-by: Neil Armstrong ---

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-07 Thread Daniel Vetter
On Wed, Sep 02, 2020 at 02:59:49PM +, Simon Ser wrote: > On Wednesday, September 2, 2020 4:29 PM, Daniel Vetter > wrote: > > > On Wed, Sep 2, 2020 at 2:49 PM Simon Ser cont...@emersion.fr wrote: > > > > > On Wednesday, September 2, 2020 2:44 PM, Daniel Vetter > > > daniel.vet...@ffwll.ch

Re: [PATCH v3 6/7] drm: Validate encoder->possible_crtcs

2020-09-07 Thread Daniel Vetter
On Sun, Sep 6, 2020 at 1:19 PM Jan Kiszka wrote: > > On 11.02.20 18:04, Daniel Vetter wrote: > > On Tue, Feb 11, 2020 at 06:22:07PM +0200, Ville Syrjala wrote: > >> From: Ville Syrjälä > >> > >> WARN if the encoder possible_crtcs is effectively empty or contains > >> bits for non-existing crtcs.

Re: [PATCH v2 1/2] drm: allow limiting the scatter list size.

2020-09-07 Thread Daniel Vetter
On Mon, Sep 7, 2020 at 8:39 AM Gerd Hoffmann wrote: > > > > + /** > > > +* @max_segment: > > > +* > > > +* Max size for scatter list segments. When unset the default > > > +* (SCATTERLIST_MAX_SEGMENT) is used. > > > +*/ > > > + size_t max_segment; > > > > Is there no

Re: [PATCH] drm/bridge/synopsys: dsi: allow sending longer LP commands

2020-09-07 Thread Neil Armstrong
On 01/07/2020 16:31, Yannick Fertre wrote: > From: Antonio Borneo > > Current code does not properly computes the max length of LP > commands that can be send during H or V sync, and rely on static > values. > Limiting the max LP length to 4 byte during the V-sync is overly > conservative. > >

Re: [PATCH] drm/bridge/synopsys: dsi: add support for non-continuous HS clock

2020-09-07 Thread Neil Armstrong
On 01/07/2020 21:42, Yannick Fertre wrote: > From: Antonio Borneo > > Current code enables the HS clock when video mode is started or to > send out a HS command, and disables the HS clock to send out a LP > command. This is not what DSI spec specify. > > Enable HS clock either in command and in

Re: [PATCH v2] drm/bridge/synopsys: dsi: allow LP commands in video mode

2020-09-07 Thread Neil Armstrong
On 08/07/2020 16:08, Yannick Fertre wrote: > From: Antonio Borneo > > Current code only sends LP commands in command mode. > > Allows sending LP commands also in video mode by setting the > proper flag in DSI_VID_MODE_CFG. > > Signed-off-by: Antonio Borneo > --- >

[PATCH 1/6] dt-bindings: display: amlogic, meson-vpu: add bindings for VPU found in AXG SoCs

2020-09-07 Thread Neil Armstrong
The Amlogic AXG SoC family has a downgraded VPU supporting only MIPI-DSI output after it's ENCL DPI encoder output. Signed-off-by: Neil Armstrong --- .../bindings/display/amlogic,meson-vpu.yaml | 36 +-- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git

  1   2   >