[PATCH 1/2] drm/ttm: drop special pipeline accel cleanup function.

2020-09-17 Thread Dave Airlie
From: Dave Airlie The two accel cleanup paths were mostly the same once refactored. Just pass a bool to say if the evictions are to be pipelined. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 +- drivers/gpu/drm/nouveau/nouveau_bo.c| 2 +-

[PATCH 2/2] drm/ttm: drop evicted from ttm_bo.

2020-09-17 Thread Dave Airlie
From: Dave Airlie This was unused. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 4 include/drm/ttm/ttm_bo_api.h | 1 - 2 files changed, 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 279a0e44a5ed..7562b0844c75 100644 ---

[PATCH 0/2] ttm follow-on cleanups

2020-09-17 Thread Dave Airlie
These two also just fell out and seemed like good cleanups. (based on previous series) Dave. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/7] drm/ttm: move unbind into the tt destroy.

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie This moves unbind into the driver side on destroy paths. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 1 + drivers/gpu/drm/nouveau/nouveau_bo.c | 1 +

Re: [PATCH 1/2] drm/ttm: drop special pipeline accel cleanup function.

2020-09-17 Thread Christian König
Am 17.09.20 um 08:41 schrieb Dave Airlie: From: Dave Airlie The two accel cleanup paths were mostly the same once refactored. Just pass a bool to say if the evictions are to be pipelined. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 +-

Re: [PATCH 6/6] drm/meson: add support for MIPI-DSI transceiver

2020-09-17 Thread Neil Armstrong
On 08/09/2020 10:46, Daniel Vetter wrote: > On Tue, Sep 08, 2020 at 10:06:03AM +0200, Neil Armstrong wrote: >> Hi, >> >> On 07/09/2020 20:03, Daniel Vetter wrote: >>> On Mon, Sep 07, 2020 at 11:03:29AM +0200, Neil Armstrong wrote: On 07/09/2020 10:44, Daniel Vetter wrote: > On Mon, Sep

Re: [PATCH 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-17 Thread Thomas Zimmermann
Hi Christian and Thomas Am 16.09.20 um 15:37 schrieb Thomas Hellström (Intel): > > On 9/16/20 2:59 PM, Christian König wrote: >> Am 16.09.20 um 14:24 schrieb Daniel Vetter: >>> On Wed, Sep 16, 2020 at 12:48:20PM +0200, Thomas Zimmermann wrote: Hi Am 16.09.20 um 11:37 schrieb

[v2 PATCH] dt-bindings: display: mediatek: convert the dpi bindings to yaml

2020-09-17 Thread Jitao Shi
Convert display/mediatek/mediatek,dpi.txt to display/mediatek/mediatek,dpi.yaml and remove the old text bindings. Signed-off-by: Jitao Shi --- .../bindings/display/mediatek/mediatek,dpi.txt | 42 -- .../bindings/display/mediatek/mediatek,dpi.yaml| 97 ++ 2

Re: [PATCH 4/7] drm/ttm/drivers: call the bind function directly.

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie Now the bind functions have all the protection explicitly the drivers can just call them directly, and the api can be unexported Signed-off-by: Dave Airlie Reviewed-by: Christian König ---

Re: [PATCH 5/7] drm/ttm: add a simple assign mem to bo wrapper

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie This pattern is called in a few places, just clean it up. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 18 ++ include/drm/ttm/ttm_bo_driver.h | 10

[PATCH v1] powerplay:hwmgr - modify the return value

2020-09-17 Thread Xiaoliang Pang
modify the return value is -EINVAL Fixes: f83a9991648bb("drm/amd/powerplay: add Vega10 powerplay support (v5)") Fixes: 2cac05dee6e30("drm/amd/powerplay: add the hw manager for vega12 (v4)") Cc: Eric Huang Cc: Evan Quan Signed-off-by: Xiaoliang Pang ---

Re: [PATCH] drm/aspeed: Add sysfs for output settings

2020-09-17 Thread Andrew Jeffery
On Wed, 16 Sep 2020, at 18:04, Joel Stanley wrote: > These settings are used by an ASPEED BMC to determine when the host is > trying to drive the display over PCIe (vga_pw) and to switch the > output between PCIe and the internal graphics device (dac_mux). > > The valid values for the dac mux

Re: [oss-drivers] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-17 Thread Simon Horman
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > fallthrough to a separate case/default label break; isn't very readable. > > Convert pseudo-keyword fallthrough; statements to a simple break; when > the next label is case or default and the only statement in the next > label block

Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-17 Thread Maxime Ripard
On Mon, Sep 14, 2020 at 07:14:11PM +0900, Hoegeun Kwon wrote: > Hi Maxime, > > On 9/8/20 9:00 PM, Maxime Ripard wrote: > > Hi Hoegeun, > > > > On Mon, Sep 07, 2020 at 08:49:12PM +0900, Hoegeun Kwon wrote: > >> On 9/3/20 5:00 PM, Maxime Ripard wrote: > >>> Hi everyone, > >>> > >>> Here's a (pretty

[PATCH] drm: fix spelling error in comments

2020-09-17 Thread Wang Qing
Change the comment typo: "manger" -> "manager". Signed-off-by: Wang Qing --- include/drm/drm_mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h index a01bc6f..9b4292f --- a/include/drm/drm_mm.h +++ b/include/drm/drm_mm.h @@

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-17 Thread Matthew Wilcox
On Mon, Sep 14, 2020 at 11:55:24PM +0200, Thomas Gleixner wrote: > But just look at any check which uses preemptible(), especially those > which check !preemptible(): hmm. +++ b/include/linux/preempt.h @@ -180,7 +180,9 @@ do { \ #define preempt_enable_no_resched()

Re: [PATCH 0/3] drm: panfrost: Coherency support

2020-09-17 Thread Alyssa Rosenzweig
> So I get a performance regression with the dma-coherent approach, even if it's > clearly the cleaner. That's bizarre -- this should really be the faster of the two. signature.asc Description: PGP signature ___ dri-devel mailing list

Re: [RFC PATCH v2 13/17] gpu: host1x: Reset max value when freeing a syncpoint

2020-09-17 Thread Dmitry Osipenko
05.09.2020 13:34, Mikko Perttunen пишет: > With job recovery becoming optional, syncpoints may have a mismatch > between their value and max value when freed. As such, when freeing, > set the max value to the current value of the syncpoint so that it > is in a sane state for the next user. > >

Re: [RFC PATCH v2 13/17] gpu: host1x: Reset max value when freeing a syncpoint

2020-09-17 Thread Dmitry Osipenko
16.09.2020 23:43, Mikko Perttunen пишет: ... >> Please note that the sync point state actually needs to be completely >> reset at the sync point request-time because both downstream fastboot >> and upstream u-boot [1] are needlessly enabling display VBLANK interrupt >> that continuously increments

[PATCH -next] drm/tidss: use devm_platform_ioremap_resource_byname

2020-09-17 Thread Wang Xiaojun
Use the devm_platform_ioremap_resource_byname() helper instead of calling platform_get_resource_byname() and devm_ioremap_resource() separately. Signed-off-by: Wang Xiaojun --- drivers/gpu/drm/tidss/tidss_dispc.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git

Re: [PATCH v2 00/21] Convert all remaining drivers to GEM object functions

2020-09-17 Thread Thomas Zimmermann
Hi Am 15.09.20 um 17:25 schrieb Christian König: > Added my rb to the amdgpu and radeon patches. > > Should we pick those up through the amd branches or do you want to push > everything to drm-misc-next? > > I think the later since this should result in much merge clash. Yes, preferable, I'd

Re: [PATCH 0/3] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-17 Thread Christian König
Am 17.09.20 um 09:16 schrieb Thomas Zimmermann: Hi Christian and Thomas Am 16.09.20 um 15:37 schrieb Thomas Hellström (Intel): On 9/16/20 2:59 PM, Christian König wrote: Am 16.09.20 um 14:24 schrieb Daniel Vetter: On Wed, Sep 16, 2020 at 12:48:20PM +0200, Thomas Zimmermann wrote: Hi Am

Re: [PATCH 2/2] drm/ttm: drop evicted from ttm_bo.

2020-09-17 Thread Christian König
Am 17.09.20 um 08:41 schrieb Dave Airlie: From: Dave Airlie This was unused. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 4 include/drm/ttm/ttm_bo_api.h | 1 - 2 files changed, 5 deletions(-) diff --git

Re: [PATCH v1] powerplay:hwmgr - modify the return value

2020-09-17 Thread Christian König
Am 17.09.20 um 05:46 schrieb Xiaoliang Pang: modify the return value is -EINVAL Maybe better write something like "The correct return value should be -EINVAL." With that done feel free to add my acked-by. Christian. Fixes: f83a9991648bb("drm/amd/powerplay: add Vega10 powerplay support

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Christian König
Am 17.09.20 um 08:23 schrieb Daniel Vetter: On Wed, Sep 16, 2020 at 5:31 PM Christian König wrote: Am 16.09.20 um 17:24 schrieb Daniel Vetter: On Wed, Sep 16, 2020 at 4:14 PM Christian König wrote: Am 16.09.20 um 16:07 schrieb Jason Gunthorpe: On Wed, Sep 16, 2020 at 11:53:59AM +0200,

Re: [PATCH 1/7] drm/ttm: protect against reentrant bind in the drivers

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie This moves the generic tracking into the drivers and protects against reentrancy in the drivers. It fixes up radeon and agp to be able to query the bound status as that is required. Signed-off-by: Dave Airlie If would prefer

Re: [PATCH 2/7] drm/ttm: flip tt destroy ordering.

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie Call the driver first and have it call the common code cleanup. This is useful later to fix unbind. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 1 +

Re: [PATCH 7/7] drm/ttm: make common function for wait/free node path.

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie The pipeline and accel cleansups has similiar paths here. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 38 --- 1 file changed, 20 insertions(+),

Re: [PATCH 6/7] drm/ttm: move ghost object creation to a common function

2020-09-17 Thread Christian König
Am 17.09.20 um 06:30 schrieb Dave Airlie: From: Dave Airlie Both accel cleanup and pipeline move had the same code, make a single function for it. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo_util.c | 105 -- 1 file changed, 43 insertions(+), 62

Re: [PATCH] drm/ttm: some cleanups

2020-09-17 Thread Dave Airlie
Reviewed-by: Dave Airlie On Wed, 16 Sep 2020 at 00:31, Christian König wrote: > > Unexport ttm_check_under_lowerlimit. > Make ttm_bo_acc_size static and unexport it. > Remove ttm_get_kernel_zone_memory_size. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/ttm/ttm_bo.c | 7

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Daniel Vetter
On Wed, Sep 16, 2020 at 5:31 PM Christian König wrote: > > Am 16.09.20 um 17:24 schrieb Daniel Vetter: > > On Wed, Sep 16, 2020 at 4:14 PM Christian König > > wrote: > >> Am 16.09.20 um 16:07 schrieb Jason Gunthorpe: > >>> On Wed, Sep 16, 2020 at 11:53:59AM +0200, Daniel Vetter wrote: > >>> >

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-17 Thread Ard Biesheuvel
On Wed, 16 Sep 2020 at 21:32, Linus Torvalds wrote: > > But something like a driver list walking thing should not be doing > different things behind peoples back depending on whether they hold > spinlocks or not. It should either just work regardless, or there > should be a flag (or special

Re: [RFC PATCH v2 13/17] gpu: host1x: Reset max value when freeing a syncpoint

2020-09-17 Thread Mikko Perttunen
On 9/17/20 12:37 AM, Dmitry Osipenko wrote: 16.09.2020 23:43, Mikko Perttunen пишет: ... Please note that the sync point state actually needs to be completely reset at the sync point request-time because both downstream fastboot and upstream u-boot [1] are needlessly enabling display VBLANK

Re: [PATCH v2 01/21] drm/amdgpu: Introduce GEM object functions

2020-09-17 Thread Thomas Zimmermann
Hi Am 15.09.20 um 17:05 schrieb Christian König: > Am 15.09.20 um 16:59 schrieb Thomas Zimmermann: >> GEM object functions deprecate several similar callback interfaces in >> struct drm_driver. This patch replaces the per-driver callbacks with >> per-instance callbacks in amdgpu. The only

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-17 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 12:39 AM Paul E. McKenney wrote: > > On Wed, Sep 16, 2020 at 11:43:02PM +0200, Daniel Vetter wrote: > > On Wed, Sep 16, 2020 at 10:58 PM Paul E. McKenney > > wrote: > > > > > > On Wed, Sep 16, 2020 at 10:29:06PM +0200, Daniel Vetter wrote: > > > > On Wed, Sep 16, 2020 at

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 9:11 AM Christian König wrote: > > Am 17.09.20 um 08:23 schrieb Daniel Vetter: > > On Wed, Sep 16, 2020 at 5:31 PM Christian König > > wrote: > >> Am 16.09.20 um 17:24 schrieb Daniel Vetter: > >>> On Wed, Sep 16, 2020 at 4:14 PM Christian König > >>> wrote: > Am

Re: [PATCH v2 0/3] drm/panfrost: add Amlogic integration quirks

2020-09-17 Thread Alyssa Rosenzweig
series r-b, nice! On Wed, Sep 16, 2020 at 05:01:44PM +0200, Neil Armstrong wrote: > The T820, G31 & G52 GPUs integrated by Amlogic in the respective GXM, > G12A/SM1 & G12B > SoCs needs a quirk in the PWR registers at the GPU reset time. > > This serie adds the necessary quirks for the Amlogic

Re: [PATCH] drm/ttm: fix incorrect TT->SYSTEM move handling

2020-09-17 Thread Christian König
Am 16.09.20 um 21:27 schrieb Dave Airlie: On Thu, 17 Sep 2020 at 00:24, Christian König wrote: When we move from the SYSTEM domain to the TT domain we still need to potentially change the caching state. This is most likely the source of a bunch of problems with AGP and USWC together with

[PULL] drm-intel-fixes

2020-09-17 Thread Jani Nikula
Hi Dave & Daniel - Due to the separate feature pull we haven't picked up gem fixes until now. Here's the first batch; there's potentially a few more to come [1]. I also just received a gvt fixes pull that didn't make it this week, so there are still more fixes coming. BR, Jani. [1]

Re: [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Ville Syrjälä
On Thu, Sep 17, 2020 at 11:14:43AM -0700, Puthikorn Voravootivat wrote: > The Lyude fde7266fb2f6 change is actually based on Chromium change > (https://crrev.com/c/1650325) that fixes the brightness for Samsung > Galaxy Chromebook. So currently we have 2 examples that use LSB > interpretation and

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-17 Thread Jacob Keller
On 9/9/2020 1:55 PM, Keith Busch wrote: > On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: >> diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c >> index eea0f453cfb6..8aac5bc60f4c 100644 >> --- a/crypto/tcrypt.c >> +++ b/crypto/tcrypt.c >> @@ -2464,7 +2464,7 @@ static int do_test(const

Re: [Intel-gfx] [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Ville Syrjälä
On Thu, Sep 17, 2020 at 09:25:35PM +0300, Ville Syrjälä wrote: > On Thu, Sep 17, 2020 at 11:14:43AM -0700, Puthikorn Voravootivat wrote: > > The Lyude fde7266fb2f6 change is actually based on Chromium change > > (https://crrev.com/c/1650325) that fixes the brightness for Samsung > > Galaxy

Re: [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Lyude Paul
On Thu, 2020-09-17 at 21:25 +0300, Ville Syrjälä wrote: > On Thu, Sep 17, 2020 at 11:14:43AM -0700, Puthikorn Voravootivat wrote: > > The Lyude fde7266fb2f6 change is actually based on Chromium change > > (https://crrev.com/c/1650325) that fixes the brightness for Samsung > > Galaxy Chromebook. So

Re: drm/ast something ate high-res modes (5.3->5.6 regression)

2020-09-17 Thread Ilpo Järvinen
Hi, Yes, I can build custom kernels and test but I won't have time for that before the end of September so I'll do it only then. And thanks a lot :-). -- i. On Thu, 17 Sep 2020, Thomas Zimmermann wrote: > Hi > > Am 08.07.20 um 12:05 schrieb Ilpo Järvinen: > > Hi, > > > > After upgrading

Re: [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Lyude Paul
On Thu, 2020-09-17 at 11:31 -0600, Kevin Chowski wrote: > Thanks very much for the quick reply, Lyude! > > I'm happy to make the requested changes, but I wanted to clarify before > falling down the wrong hole: are you suggesting that I move > the

Re: [PATCH] fbcon: Remove the superfluous break

2020-09-17 Thread Gustavo A. R. Silva
On 9/17/20 08:15, Jing Xiangfeng wrote: > Remove the superfuous break, as there is a 'return' before it. > > Signed-off-by: Jing Xiangfeng Reviewed-by: Gustavo A. R. Silva Also, the following Fixes tag should be included in the changelog text: Fixes: bad07ff74c32 ("fbcon: smart blitter

Re: [PATCHv2] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-09-17 Thread Ville Syrjälä
On Thu, Sep 17, 2020 at 03:39:38PM +0300, Tomi Valkeinen wrote: > On 17/09/2020 14:22, Ville Syrjälä wrote: > > On Thu, Sep 17, 2020 at 08:52:10AM +0300, Tomi Valkeinen wrote: > >> Add binding for DisplayPort connector. A few notes: > >> > >> * Similar to hdmi-connector, it has hpd-gpios as an

Re: [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Kevin Chowski
(resending as plain-text, my last mail was rejected by lots of addresses for some reason) Thanks very much for the quick reply, Lyude! I'm happy to make the requested changes, but I wanted to clarify before falling down the wrong hole: are you suggesting that I move the

[PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Kevin Chowski
We have observed that Google Pixelbook's backlight hardware is interpretting these backlight bits from the most-significant side of the 16 bit word (if DP_EDP_PWMGEN_BIT_COUNT < 16), whereas the driver code assumes the peripheral cares about the least-significant bits. Testing was done from

[PATCH] dma-fence: add get_signaled_timestamp to fence ops

2020-09-17 Thread Veera Sundaram Sankaran
Add an optional fence ops to allow drivers to be able to set the timestamp for a fence. Some drivers have hardware capability to get the precise timestamp of certain events based on which the fences are triggered. This allows it to set accurate timestamp factoring out any software and IRQ

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Jason Gunthorpe
On Thu, Sep 17, 2020 at 06:06:14PM +0200, Christian König wrote: > > > If it is already taking a page fault I'm not sure the extra function > > > call indirection is going to be a big deal. Having a uniform VMA > > > sounds saner than every driver custom rolling something. > > > > > > When I

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Jason Gunthorpe
On Thu, Sep 17, 2020 at 04:54:44PM +0200, Christian König wrote: > Am 17.09.20 um 16:35 schrieb Jason Gunthorpe: > > On Thu, Sep 17, 2020 at 02:24:29PM +0200, Christian König wrote: > > > Am 17.09.20 um 14:18 schrieb Jason Gunthorpe: > > > > On Thu, Sep 17, 2020 at 02:03:48PM +0200, Christian

[git pull] drm fixes for 5.9-rc6

2020-09-17 Thread Dave Airlie
Hi Linus, A bunch of small fixes, some of the i915 ones have been out for a while and got better commit msg explaining some better reasoning behind them. (hopefully this trend continues). Otherwise there a few AMD related ones mostly small, one radeon PLL regression fix and a bunch of small

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Jason Gunthorpe
On Thu, Sep 17, 2020 at 02:24:29PM +0200, Christian König wrote: > Am 17.09.20 um 14:18 schrieb Jason Gunthorpe: > > On Thu, Sep 17, 2020 at 02:03:48PM +0200, Christian König wrote: > > > Am 17.09.20 um 13:31 schrieb Jason Gunthorpe: > > > > On Thu, Sep 17, 2020 at 10:09:12AM +0200, Daniel Vetter

Re: [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Puthikorn Voravootivat
The Lyude fde7266fb2f6 change is actually based on Chromium change (https://crrev.com/c/1650325) that fixes the brightness for Samsung Galaxy Chromebook. So currently we have 2 examples that use LSB interpretation and 1 that use MSB. On Thu, Sep 17, 2020 at 10:55 AM Kevin Chowski wrote: > >

Re: [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Kevin Chowski
Thanks very much for the quick reply, Lyude! I'm happy to make the requested changes, but I wanted to clarify before falling down the wrong hole: are you suggesting that I move the intel_dp_aux_set_backlight/intel_dp_aux_get_backlight routines to the drm_dp_helper.c file? On Thu, Sep 17, 2020 at

Re: [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Kevin Chowski
Apologies for being too vague. To be as precise I can be, here is the specific code delta I tested: https://crrev.com/c/2406616 . To answer your other question, the code I tested against is indeed including the fde7266fb2f6 (despite ostensibly being called 5.4 in my commit message): our current

[PATCH v4 09/19] drm/virtio: implement blob resources: probe for host visible region

2020-09-17 Thread Gurchetan Singh
From: Gerd Hoffmann The availability of the host visible region means host 3D allocations can be directly mapped in the guest. Signed-off-by: Gerd Hoffmann Co-developed-by: Gurchetan Singh Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_debugfs.c |

Re: [PATCH v3 09/19] drm/virtio: implement blob resources: probe for host visible region

2020-09-17 Thread Gurchetan Singh
On Thu, Sep 17, 2020 at 2:40 AM Gerd Hoffmann wrote: > Hi, > > > + if (!devm_request_mem_region(>vdev->dev, > > + > vgdev->host_visible_region.addr, > > + > vgdev->host_visible_region.len, > > + dev_name(>vdev->dev))) > { > > +

Re: [PATCH v3 12/19] drm/virtio: implement blob resources: implement vram object

2020-09-17 Thread Gerd Hoffmann
Hi, > + if (resp_type == VIRTIO_GPU_RESP_OK_MAP_INFO) { > + vram->map_info = resp->map_info; > + vram->map_state = STATE_OK; > + } else { > + vram->map_state = STATE_ERR; > + } Ah, found it, here. ok. take care, Gerd

[PATCH 2/2] drm/dp: add a number of DP 2.0 DPCD definitions

2020-09-17 Thread Jani Nikula
Prepare for future with DP 2.0 DPCD definitions, with a couple of related drive-by cleanups. No functional changes. Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 52 - 1 file changed, 45 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 0/3] drm: panfrost: Coherency support

2020-09-17 Thread Tomeu Vizoso
On 9/17/20 12:38 PM, Steven Price wrote: On 16/09/2020 18:46, Rob Herring wrote: On Wed, Sep 16, 2020 at 11:04 AM Alyssa Rosenzweig wrote: So I get a performance regression with the dma-coherent approach, even if it's clearly the cleaner. That's bizarre -- this should really be the

[PATCH 1/2] drm/dp: add subheadings to DPCD address definitions

2020-09-17 Thread Jani Nikula
Add the subheadings from the DP spec. No functional changes. Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index

Re: [PATCH v2 18/21] drm/vkms: Introduce GEM object functions

2020-09-17 Thread Melissa Wen
Hi Thomas, On 09/15, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in vkms. > > Signed-off-by: Thomas Zimmermann Thanks! Looks fine. Reviewed-by:

Re: [Linaro-mm-sig] Changing vma->vm_file in dma_buf_mmap()

2020-09-17 Thread Christian König
Am 17.09.20 um 13:31 schrieb Jason Gunthorpe: On Thu, Sep 17, 2020 at 10:09:12AM +0200, Daniel Vetter wrote: Yeah, but it doesn't work when forwarding from the drm chardev to the dma-buf on the importer side, since you'd need a ton of different address spaces. And you still rely on the core

[PATCH] drm/ttm: remove superflous extern attribute from funcs

2020-09-17 Thread Christian König
Extern is the default attribute for functions anyway. Signed-off-by: Christian König --- include/drm/ttm/ttm_execbuf_util.h | 19 --- include/drm/ttm/ttm_memory.h | 25 - 2 files changed, 20 insertions(+), 24 deletions(-) diff --git

Why is nouveau using a separate swap storage?

2020-09-17 Thread Christian König
Hi guys, just another TTM feature which is only used by nouveau. We have this bo->bo.persistent_swap_storage pointer which is only set by nouveau to the GEM filp and used when a BO is swapped to a shmem file. As far as I can see this doesn't make any sense at all? What is the background

Re: [PATCH v2 0/4] Enlarge tracepoints in the display component

2020-09-17 Thread Daniel Vetter
On Wed, Sep 16, 2020 at 11:27:27AM -0400, Kazlauskas, Nicholas wrote: > On 2020-09-16 5:12 a.m., Daniel Vetter wrote: > > On Fri, Sep 11, 2020 at 10:59:23AM -0400, Rodrigo Siqueira wrote: > > > Debug issues related to display can be a challenge due to the complexity > > > around this topic and

Re: [PATCH v3 02/19] drm/virtio: blob prep: make CPU responses more generic

2020-09-17 Thread Gerd Hoffmann
On Wed, Sep 16, 2020 at 05:08:21PM -0700, Gurchetan Singh wrote: > RESOURCE_MAP_BLOB / RESOURCE_UNMAP_BLOB can use this. > -#define UUID_INITIALIZING 0 > -#define UUID_INITIALIZED 1 > -#define UUID_INITIALIZATION_FAILED 2 > +#define STATE_INITIALIZING 0 > +#define STATE_OK 1 > +#define STATE_ERR

Re: [PATCH v2 14/21] drm/tegra: Introduce GEM object functions

2020-09-17 Thread Thierry Reding
On Tue, Sep 15, 2020 at 04:59:51PM +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in tegra. > > Signed-off-by: Thomas Zimmermann > --- >

Re: [PATCH 6/8] drm/vram-helper: don't use ttm bo->offset v4

2020-09-17 Thread Christian König
Hi Thomas, Am 17.09.20 um 12:51 schrieb Thomas Zimmermann: Hi Am 24.06.20 um 20:26 schrieb Nirmoy Das: Calculate GEM VRAM bo's offset within vram-helper without depending on bo->offset. Signed-off-by: Nirmoy Das Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_gem_vram_helper.c | 11

Re: [PATCH] drm: fix spelling error in comments

2020-09-17 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 10:04:32AM +0800, Wang Qing wrote: > Change the comment typo: "manger" -> "manager". > > Signed-off-by: Wang Qing Pushed to drm-misc-next, thanks for your patch. -Daniel > --- > include/drm/drm_mm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH RESEND v10 0/4] Support DRM bridges on NVIDIA Tegra

2020-09-17 Thread Thierry Reding
On Fri, Aug 14, 2020 at 01:06:52AM +0300, Dmitry Osipenko wrote: > Hello, > > This series adds initial support for the DRM bridges to NVIDIA Tegra DRM > driver. This is required by newer device-trees where we model the LVDS > encoder bridge properly. In particular this series is needed in order

Re: [PATCH 6/8] drm/vram-helper: don't use ttm bo->offset v4

2020-09-17 Thread Thomas Zimmermann
Hi Am 24.06.20 um 20:26 schrieb Nirmoy Das: > Calculate GEM VRAM bo's offset within vram-helper without depending on > bo->offset. > > Signed-off-by: Nirmoy Das > Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_gem_vram_helper.c | 11 ++- > 1 file changed, 10 insertions(+), 1

Re: Why is nouveau using a separate swap storage?

2020-09-17 Thread Ben Skeggs
On Thu, 17 Sep 2020 at 20:06, Christian König wrote: > > Hi guys, > > just another TTM feature which is only used by nouveau. > > We have this bo->bo.persistent_swap_storage pointer which is only set by > nouveau to the GEM filp and used when a BO is swapped to a shmem file. > > As far as I can

Re: drm/ast something ate high-res modes (5.3->5.6 regression)

2020-09-17 Thread Thomas Zimmermann
Hi Am 08.07.20 um 12:05 schrieb Ilpo Järvinen: > Hi, > > After upgrading kernel from 5.3 series to 5.6.16 something seems to > prevent me from achieving high resolutions with the ast driver. Are you able to build and run a test kernel? I'm seriously considering moving ast to the SHMEM memory

Re: [PATCH 0/3] drm: panfrost: Coherency support

2020-09-17 Thread Steven Price
On 17/09/2020 11:51, Tomeu Vizoso wrote: On 9/17/20 12:38 PM, Steven Price wrote: On 16/09/2020 18:46, Rob Herring wrote: On Wed, Sep 16, 2020 at 11:04 AM Alyssa Rosenzweig wrote: So I get a performance regression with the dma-coherent approach, even if it's clearly the cleaner. That's

Re: [PATCH 6/6] drm/meson: add support for MIPI-DSI transceiver

2020-09-17 Thread Daniel Vetter
On Thu, Sep 17, 2020 at 09:14:33AM +0200, Neil Armstrong wrote: > On 08/09/2020 10:46, Daniel Vetter wrote: > > On Tue, Sep 08, 2020 at 10:06:03AM +0200, Neil Armstrong wrote: > >> Hi, > >> > >> On 07/09/2020 20:03, Daniel Vetter wrote: > >>> On Mon, Sep 07, 2020 at 11:03:29AM +0200, Neil

[PATCH AUTOSEL 5.4 182/330] drm/msm/a5xx: Always set an OPP supported hardware value

2020-09-17 Thread Sasha Levin
From: Jordan Crouse [ Upstream commit 0478b4fc5f37f4d494245fe7bcce3f531cf380e9 ] If the opp table specifies opp-supported-hw as a property but the driver has not set a supported hardware value the OPP subsystem will reject all the table entries. Set a "default" value that will match the

[PATCH AUTOSEL 5.4 216/330] PCI: Use ioremap(), not phys_to_virt() for platform ROM

2020-09-17 Thread Sasha Levin
From: Mikel Rychliski [ Upstream commit 72e0ef0e5f067fd991f702f0b2635d911d0cf208 ] On some EFI systems, the video BIOS is provided by the EFI firmware. The boot stub code stores the physical address of the ROM image in pdev->rom. Currently we attempt to access this pointer using

[PATCH AUTOSEL 5.4 265/330] drm/amd/powerplay: try to do a graceful shutdown on SW CTF

2020-09-17 Thread Sasha Levin
From: Evan Quan [ Upstream commit 9495220577416632675959caf122e968469ffd16 ] Normally this(SW CTF) should not happen. And by doing graceful shutdown we can prevent further damage. Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

Re: [PATCH AUTOSEL 5.4 001/330] drm/v3d: don't leak bin job if v3d_job_init fails.

2020-09-17 Thread Eric Anholt
On Thu, Sep 17, 2020 at 7:01 PM Sasha Levin wrote: > > From: Iago Toral Quiroga > > [ Upstream commit 0d352a3a8a1f26168d09f7073e61bb4b328e3bb9 ] > > If the initialization of the job fails we need to kfree() it > before returning. > > Signed-off-by: Iago Toral Quiroga > Signed-off-by: Eric

[PATCH AUTOSEL 5.4 232/330] drm/amdgpu/sriov add amdgpu_amdkfd_pre_reset in gpu reset

2020-09-17 Thread Sasha Levin
From: Jack Zhang [ Upstream commit 04bef61e5da18c2b301c629a209ccdba4d4c6fbb ] kfd_pre_reset will free mem_objs allocated by kfd_gtt_sa_allocate Without this change, sriov tdr code path will never free those allocated memories and get memory leak. v2:add a bugfix for kiq ring test fail

[PATCH AUTOSEL 5.4 223/330] drm/amdgpu/vcn2.0: stall DPG when WPTR/RPTR reset

2020-09-17 Thread Sasha Levin
From: James Zhu [ Upstream commit ef563ff403404ef2f234abe79bdd9f04ab6481c9 ] Add vcn dpg harware synchronization to fix race condition issue between vcn driver and hardware. Signed-off-by: James Zhu Reviewed-by: Leo Liu Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 4.19 132/206] PCI: Use ioremap(), not phys_to_virt() for platform ROM

2020-09-17 Thread Sasha Levin
From: Mikel Rychliski [ Upstream commit 72e0ef0e5f067fd991f702f0b2635d911d0cf208 ] On some EFI systems, the video BIOS is provided by the EFI firmware. The boot stub code stores the physical address of the ROM image in pdev->rom. Currently we attempt to access this pointer using

[PATCH AUTOSEL 4.19 116/206] drm/msm/a5xx: Always set an OPP supported hardware value

2020-09-17 Thread Sasha Levin
From: Jordan Crouse [ Upstream commit 0478b4fc5f37f4d494245fe7bcce3f531cf380e9 ] If the opp table specifies opp-supported-hw as a property but the driver has not set a supported hardware value the OPP subsystem will reject all the table entries. Set a "default" value that will match the

[PATCH AUTOSEL 4.19 100/206] drm/amdgpu: increase atombios cmd timeout

2020-09-17 Thread Sasha Levin
From: John Clements [ Upstream commit 1b3460a8b19688ad3033b75237d40fa580a5a953 ] mitigates race condition on BACO reset between GPU bootcode and driver reload Reviewed-by: Hawking Zhang Signed-off-by: John Clements Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 4.19 115/206] drm/msm: fix leaks if initialization fails

2020-09-17 Thread Sasha Levin
From: Pavel Machek [ Upstream commit 66be340f827554cb1c8a1ed7dea97920b4085af2 ] We should free resources in unlikely case of allocation failure. Signed-off-by: Pavel Machek Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_drv.c | 6 -- 1 file changed, 4

[PATCH AUTOSEL 4.9 47/90] drm/amdgpu: increase atombios cmd timeout

2020-09-17 Thread Sasha Levin
From: John Clements [ Upstream commit 1b3460a8b19688ad3033b75237d40fa580a5a953 ] mitigates race condition on BACO reset between GPU bootcode and driver reload Reviewed-by: Hawking Zhang Signed-off-by: John Clements Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 4.4 03/64] gma/gma500: fix a memory disclosure bug due to uninitialized bytes

2020-09-17 Thread Sasha Levin
From: Kangjie Lu [ Upstream commit 57a25a5f754ce27da2cfa6f413cfd366f878db76 ] `best_clock` is an object that may be sent out. Object `clock` contains uninitialized bytes that are copied to `best_clock`, which leads to memory disclosure and information leak. Signed-off-by: Kangjie Lu

[PATCH AUTOSEL 4.9 38/90] drm/omap: fix possible object reference leak

2020-09-17 Thread Sasha Levin
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings:

[PATCH AUTOSEL 4.9 03/90] gma/gma500: fix a memory disclosure bug due to uninitialized bytes

2020-09-17 Thread Sasha Levin
From: Kangjie Lu [ Upstream commit 57a25a5f754ce27da2cfa6f413cfd366f878db76 ] `best_clock` is an object that may be sent out. Object `clock` contains uninitialized bytes that are copied to `best_clock`, which leads to memory disclosure and information leak. Signed-off-by: Kangjie Lu

[PATCH AUTOSEL 4.4 27/64] drm/omap: fix possible object reference leak

2020-09-17 Thread Sasha Levin
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings:

[PATCH AUTOSEL 5.4 181/330] drm/msm: fix leaks if initialization fails

2020-09-17 Thread Sasha Levin
From: Pavel Machek [ Upstream commit 66be340f827554cb1c8a1ed7dea97920b4085af2 ] We should free resources in unlikely case of allocation failure. Signed-off-by: Pavel Machek Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_drv.c | 6 -- 1 file changed, 4

[PATCH AUTOSEL 5.4 160/330] drm/amd/display: Stop if retimer is not available

2020-09-17 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit a0e40018dcc3f59a10ca21d58f8ea8ceb1b035ac ] Raven provides retimer feature support that requires i2c interaction in order to make it work well, all settings required for this configuration are loaded from the Atom bios which include the i2c address. If

[PATCH AUTOSEL 5.4 154/330] drm/amd/display: fix image corruption with ODM 2:1 DSC 2 slice

2020-09-17 Thread Sasha Levin
From: Wenjing Liu [ Upstream commit df8e34ac27e8a0d8dce364628226c5619693c3fd ] [why] When combining two or more pipes in DSC mode, there will always be more than 1 slice per line. In this case, as per DSC rules, the sink device is expecting that the ICH is reset at the end of each slice line

[PATCH AUTOSEL 5.4 144/330] drm/omap: dss: Cleanup DSS ports on initialisation failure

2020-09-17 Thread Sasha Levin
From: Laurent Pinchart [ Upstream commit 2a0a3ae17d36fa86dcf7c8e8d7b7f056ebd6c064 ] When the DSS initialises its output DPI and SDI ports, failures don't clean up previous successfully initialised ports. This can lead to resource leak or memory corruption. Fix it. Reported-by: Hans Verkuil

[PATCH AUTOSEL 5.4 143/330] drm/amd/display: dal_ddc_i2c_payloads_create can fail causing panic

2020-09-17 Thread Sasha Levin
From: Aric Cyr [ Upstream commit 6a6c4a4d459ecacc9013c45dcbf2bc9747fdbdbd ] [Why] Since the i2c payload allocation can fail need to check return codes [How] Clean up i2c payload allocations and check for errors Signed-off-by: Aric Cyr Reviewed-by: Joshua Aberback Acked-by: Rodrigo Siqueira

[PATCH AUTOSEL 5.4 158/330] drm/amdgpu: increase atombios cmd timeout

2020-09-17 Thread Sasha Levin
From: John Clements [ Upstream commit 1b3460a8b19688ad3033b75237d40fa580a5a953 ] mitigates race condition on BACO reset between GPU bootcode and driver reload Reviewed-by: Hawking Zhang Signed-off-by: John Clements Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 4.19 090/206] drm/amd/display: dal_ddc_i2c_payloads_create can fail causing panic

2020-09-17 Thread Sasha Levin
From: Aric Cyr [ Upstream commit 6a6c4a4d459ecacc9013c45dcbf2bc9747fdbdbd ] [Why] Since the i2c payload allocation can fail need to check return codes [How] Clean up i2c payload allocations and check for errors Signed-off-by: Aric Cyr Reviewed-by: Joshua Aberback Acked-by: Rodrigo Siqueira

  1   2   3   >