[PATCH 0/4] Add support for atomic async page-flips

2022-08-24 Thread Simon Ser
This series adds support for DRM_MODE_PAGE_FLIP_ASYNC for atomic commits, aka. "immediate flip" (which might result in tearing). The feature was only available via the legacy uAPI, however for gaming use-cases it may be desirable to enable it via the atomic uAPI too. User-space patch:

[PATCH 3/4] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP

2022-08-24 Thread Simon Ser
This new kernel capability indicates whether async page-flips are supported via the atomic uAPI. DRM clients can use it to check for support before feeding DRM_MODE_PAGE_FLIP_ASYNC to the kernel. Make it clear that DRM_CAP_ASYNC_PAGE_FLIP is for legacy uAPI only. Signed-off-by: Simon Ser Cc:

Re: [PATCH v3 6/9] dma-buf: Move dma-buf attachment to dynamic locking specification

2022-08-24 Thread Dmitry Osipenko
On 8/24/22 18:14, Christian König wrote: > Am 24.08.22 um 17:03 schrieb Dmitry Osipenko: >> On 8/24/22 17:08, Christian König wrote: >>> Am 24.08.22 um 12:22 schrieb Dmitry Osipenko: Move dma-buf attachment API functions to the dynamic locking specification. The strict locking

Re: [Linaro-mm-sig] [PATCH v3 6/9] dma-buf: Move dma-buf attachment to dynamic locking specification

2022-08-24 Thread Dmitry Osipenko
On 8/24/22 18:24, Christian König wrote: > Am 24.08.22 um 12:22 schrieb Dmitry Osipenko: >> Move dma-buf attachment API functions to the dynamic locking >> specification. >> The strict locking convention prevents deadlock situations for dma-buf >> importers and exporters. >> >> Previously, the

[RESEND PATCH v8 07/12] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

2022-08-24 Thread ChiaEn Wu
From: ChiYuan Huang The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display

[RESNED PATCH v8 03/12] dt-bindings: leds: mt6370: Add MediaTek MT6370 current sink type LED indicator

2022-08-24 Thread ChiaEn Wu
From: ChiYuan Huang Add MediaTek MT6370 current sink type LED indicator binding documentation. Reviewed-by: Krzysztof Kozlowski Signed-off-by: ChiYuan Huang Signed-off-by: ChiaEn Wu --- .../leds/mediatek,mt6370-indicator.yaml | 81 +++ 1 file changed, 81 insertions(+)

[PATCH v2 1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name

2022-08-24 Thread Jani Nikula
Add a helper for getting the DP PHY name. In the interest of caller simplicity and to avoid allocations and passing in of buffers, duplicate the const strings to return. It's a minor penalty to pay for simplicity in all the call sites. v2: Rebase, add kernel-doc, ensure non-NULL always Cc: Ville

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-24 Thread Maxime Ripard
On Wed, Aug 10, 2022 at 10:33:48PM +0200, Stefan Wahren wrote: > Hi Florian, > > Am 09.08.22 um 21:02 schrieb Florian Fainelli: > > On 8/4/22 16:11, Florian Fainelli wrote: > > > On 6/13/22 07:47, Maxime Ripard wrote: > > > > From: Dave Stevenson > > > > > > > > The BCM2835-37 found in the

[PATCH 04/10] drm/amdgpu: cleanup and reorder amdgpu_cs.c

2022-08-24 Thread Christian König
Sort the functions in the order they are called and cleanup the coding style and function names to represent the data they process. Check the size of the IB chunk, initialize resulting entity and scheduler job much earlier as well. Signed-off-by: Christian König ---

[PATCH 03/10] drm/amdgpu: use DMA_RESV_USAGE_BOOKKEEP

2022-08-24 Thread Christian König
Use DMA_RESV_USAGE_BOOKKEEP for VM page table updates and KFD preemption fence. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-24 Thread Noralf Trønnes
Den 16.08.2022 10.26, skrev Maxime Ripard: > Hi, > > On Mon, Aug 08, 2022 at 02:44:56PM +0200, Noralf Trønnes wrote: >> Den 29.07.2022 18.34, skrev Maxime Ripard: >>> The TV mode property has been around for a while now to select and get the >>> current TV mode output on an analog TV

Re: [RFC PATCH 01/14] drm/qaic: Add documentation for AIC100 accelerator driver

2022-08-24 Thread Krzysztof Kozlowski
On 15/08/2022 21:42, Jeffrey Hugo wrote: > Add documentation covering both the QAIC driver, and the device that it > drives. Thank you for your patch. There is something to discuss/improve. > > Change-Id: Iee519cc0a276249c4e8684507d27ae2c33e29aeb You need to drop all such non-standard tags.

[PATCH 3/3] drm: rcar-du: fix DSI enable & disable sequence

2022-08-24 Thread Tomi Valkeinen
From: Tomi Valkeinen The rcar crtc depends on the clock provided from the rcar DSI bridge. When the DSI bridge is disabled, the clock is stopped, which causes the crtc disable to timeout. Also, while I have no issue with the enable, the documentation suggests to enable the DSI before the crtc

Re: [PATCH] drm/bridge: sii902x: add support for DRM_BRIDGE_ATTACH_NO_CONNECTOR

2022-08-24 Thread Neil Armstrong
On 15/08/2022 02:15, Dmitry Osipenko wrote: 08.08.2022 12:51, Neil Armstrong пишет: On 08/08/2022 11:15, Neil Armstrong wrote: Hi Dmitry, On 31/07/2022 22:07, Dmitry Osipenko wrote: 13.01.2022 17:43, Neil Armstrong пишет: This adds support for DRM_BRIDGE_ATTACH_NO_CONNECTOR by adding the

Re: [PATCH -next] drm/bridge: Add missing clk_disable_unprepare() in analogix_dp_resume()

2022-08-24 Thread Doug Anderson
Hi, On Mon, Aug 15, 2022 at 11:45 PM Zhang Zekun wrote: > > Add the missing clk_disable_unprepare() before return from > analogix_dp_resume() in the error handling case. > > Fixes: 211f276ed3d9 ("drm: bridge: analogix/dp: add panel prepare/unprepare > in suspend/resume time") > Signed-off-by:

Re: [PATCH v5 3/4] drm/lcdif: Clean up debug prints and comments

2022-08-24 Thread Alexander Stein
Hello Marek, Am Freitag, 19. August 2022, 16:08:51 CEST schrieb Marek Vasut: > Update debug print to report bridge timings over connector ones. > Drop missed comment commit from mxsfb. > > Acked-by: Sam Ravnborg > Reviewed-by: Liu Ying > Reported-by: Liu Ying > Tested-by: Martyn Welch >

RE: [PATCH v1 2/4] drm/hyperv: Don't forget to put PCI device when removing conflicting FB fails

2022-08-24 Thread Vitaly Kuznetsov
"Michael Kelley (LINUX)" writes: > From: Vitaly Kuznetsov Sent: Thursday, August 18, 2022 > 7:25 AM >> >> When drm_aperture_remove_conflicting_pci_framebuffers() fails, 'pdev' >> needs to be released with pci_dev_put(). >> >> Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv

Re: [PATCH] disp/dpu1: fix repeated words in comments

2022-08-24 Thread Abhinav Kumar
Please fix the subject line . It should be drm/msm/dpu: fix repeated words in comments Also, you can add Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") On 8/23/2022 4:51 AM, Jilin Yuan wrote: Delete the redundant word 'is'. Signed-off-by: Jilin Yuan ---

[PATCH 1/4] drm: introduce drm_mode_config.atomic_async_page_flip_not_supported

2022-08-24 Thread Simon Ser
This new field indicates whether the driver has the necessary logic to support async page-flips via the atomic uAPI. This is leveraged by the next commit to allow user-space to use this functionality. All drivers setting drm_mode_config.async_page_flip are updated to also set

Re: [PATCH v3 6/9] dma-buf: Move dma-buf attachment to dynamic locking specification

2022-08-24 Thread Christian König
Am 24.08.22 um 17:03 schrieb Dmitry Osipenko: On 8/24/22 17:08, Christian König wrote: Am 24.08.22 um 12:22 schrieb Dmitry Osipenko: Move dma-buf attachment API functions to the dynamic locking specification. The strict locking convention prevents deadlock situations for dma-buf importers and

[PATCH] drm/vc4: fix repeated words in comments

2022-08-24 Thread Jilin Yuan
Delete the redundant word 'the'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/vc4/vc4_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers/gpu/drm/vc4/vc4_regs.h index a2b5cbbbc1b0..f0290fad991d 100644 ---

Re: [PATCH drm-misc-next v2 2/4] drm/vc4: plane: protect device resources after removal

2022-08-24 Thread Danilo Krummrich
Hi Maxime, On 8/24/22 17:48, Maxime Ripard wrote: @@ -1252,12 +1261,17 @@ void vc4_plane_async_set_fb(struct drm_plane *plane, struct drm_framebuffer *fb) WARN_ON_ONCE(plane->state->crtc_x < 0 || plane->state->crtc_y < 0); addr = bo->dma_addr + fb->offsets[0]; + if

Re: [PATCH] dt-bindings: display: sun4i: Add D1 TCONs to conditionals

2022-08-24 Thread Maxime Ripard
On Fri, 12 Aug 2022 02:37:02 -0500, Samuel Holland wrote: > When adding the D1 TCON bindings, I missed the conditional blocks that > restrict the binding for TCON LCD vs TCON TV hardware. Add the D1 TCON > variants to the appropriate blocks for DE2 TCON LCDs and TCON TVs. > > Applied to

Re: [PATCH v1 24/35] drm/vc4: vec: Add support for more analog TV standards

2022-08-24 Thread Mateusz Kwiatkowski
Hi Maxime, W dniu 15.08.2022 o 10:37, Maxime Ripard pisze: > Hi, > > On Fri, Jul 29, 2022 at 07:55:30PM +0200, Mateusz Kwiatkowski wrote: >> Hi Maxime, >> >> I think that declaring PAL-B and SECAM-B as the only supported 576i >> norms is a bit random. > > Starting with this patch, PAL-N should be

Re: [PATCH v2] drm/msm/dp: correct 1.62G link rate at dp_catalog_ctrl_config_msa()

2022-08-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-24 10:22:31) > At current implementation there is an extra 0 at 1.62G link rate which cause > no correct pixel_div selected for 1.62G link rate to calculate mvid and nvid. > This patch delete the extra 0 to have mvid and nvid be calculated correctly. > > Changes in

[PATCH 3/3] iommu/dma: Make header private

2022-08-24 Thread Robin Murphy
Now that dma-iommu.h only contains internal interfaces, make it private to the IOMMU subsytem. Signed-off-by: Robin Murphy --- drivers/acpi/viot.c | 1 - drivers/gpu/drm/exynos/exynos_drm_dma.c | 1 - drivers/iommu/amd/iommu.c| 2 +-

Re: [PATCH] dt-bindings: display: simple: Add Multi-Inno Technology MI0800FT-9 panel

2022-08-24 Thread Rob Herring
On Fri, 12 Aug 2022 13:46:00 +0200, Christoph Niedermaier wrote: > Add Multi-Inno Technology MI0800FT-9 8" 800x600 DPI panel > compatible string. > > Signed-off-by: Christoph Niedermaier > Cc: Rob Herring > Cc: Sam Ravnborg > Cc: devicet...@vger.kernel.org > To: dri-devel@lists.freedesktop.org

Re: [PATCH v2] drm/ast: add dmabuf/prime buffer sharing support

2022-08-24 Thread Christian König
Am 18.08.22 um 11:45 schrieb oushixiong: This patch adds ast specific codes for DRM prime feature, this is to allow for offloading of rending in one direction and outputs in other. v1->v2: - Fix the comment. Signed-off-by: oushixiong --- drivers/gpu/drm/ast/ast_drv.c | 22 ++

[PATCH v1 2/4] drm/hyperv: Don't forget to put PCI device when removing conflicting FB fails

2022-08-24 Thread Vitaly Kuznetsov
When drm_aperture_remove_conflicting_pci_framebuffers() fails, 'pdev' needs to be released with pci_dev_put(). Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video device") Signed-off-by: Vitaly Kuznetsov --- drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 2 +- 1 file

[PATCH v2 02/15] mei: add support to GSC extended header

2022-08-24 Thread Daniele Ceraolo Spurio
From: Tomas Winkler GSC extend header is of variable size and data is provided in a sgl list inside the header and not in the data buffers, need to enable the path. Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Cc: Vitaly Lubart --- drivers/misc/mei/client.c| 55

[PATCH v2 04/15] mei: bus: extend bus API to support command streamer API

2022-08-24 Thread Daniele Ceraolo Spurio
From: Vitaly Lubart Add mei bus API for sending gsc commands: mei_cldev_send_gsc_command() The GSC commands are originated in the graphics stack and are in form of SGL DMA buffers. The GSC commands are synchronous, the response is received in the same call on the out sg list buffers. The

[PATCH v2 08/21] drm/i915/mtl: Add VBT port and AUX_CH mapping

2022-08-24 Thread Radhakrishna Sripada
From: Imre Deak Add the proper VBT port,AUX_CH -> i915 port,AUX_CH mapping which just follows the ADL_P one. Reviewed-by: Matt Roper Signed-off-by: Imre Deak Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_bios.c | 14 +++--- 1 file changed, 7

[PATCH v2 09/21] drm/i915/mtl: Add support for MTL in Display Init sequences

2022-08-24 Thread Radhakrishna Sripada
The initialization sequence for Meteorlake reuses the sequence for icelake for most parts. Some changes viz. reset PICA handshake are added. Bspec: 49189 Reviewed-by: Matt Roper Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++

[PATCH v2 05/15] mei: pxp: add command streamer API to the PXP driver

2022-08-24 Thread Daniele Ceraolo Spurio
From: Vitaly Lubart The discrete graphics card with GSC firmware using command streamer API hence it requires to enhance pxp module with the new gsc_command() handler. The handler is implemented via mei_pxp_gsc_command() which is just just a thin wrapper around mei_cldev_send_gsc_command() V2:

Re: [PATCH v4 5/6] dt-bindings: drm/msm/gpu: Add optional resets

2022-08-24 Thread Krzysztof Kozlowski
On 19/08/2022 19:40, Akhil P Oommen wrote: > Documentation/devicetree/bindings/display/msm/gpu.yaml | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml > b/Documentation/devicetree/bindings/display/msm/gpu.yaml > index

[PATCH v2 4/4] drm/tests: Set also mock plane src_x, src_y, src_w and src_h

2022-08-24 Thread Jouni Högander
We need to set also src_x, src_y, src_w and src_h for the mock plane. After fix for drm_atomic_helper_damage_iter_init we are using these when iterating damage_clips. Signed-off-by: Jouni Högander --- drivers/gpu/drm/tests/drm_damage_helper_test.c | 5 + 1 file changed, 5 insertions(+)

[PATCH] drm/i915: fix repeated words in comments

2022-08-24 Thread Jilin Yuan
Delete the redundant word 'other'. Delete the redundant word 'the'. Delete the redundant word 'will'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/i915/i915_gem_evict.c | 2 +- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- drivers/gpu/drm/i915/i915_memcpy.h| 2 +- 3 files changed, 4

[PATCH] gpu/drm: fix repeated words in comments

2022-08-24 Thread Jilin Yuan
Delete the redundant word 'old'. Delete the redundant word 'new'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/drm_context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_context.c b/drivers/gpu/drm/drm_context.c index

[PATCH 4/6] drm/amdgpu: Refactor amdgpu_vm_get_pd_bo.

2022-08-24 Thread Bas Nieuwenhuizen
We want to take only a BOOKKEEP usage for contexts that are not implicitly synced. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 9 + drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c | 2

Re: Rust in our code base

2022-08-24 Thread Karol Herbst
On Wed, Aug 24, 2022 at 5:18 PM Jason Ekstrand wrote: > > +mesa-dev and my jlekstrand.net e-mail > > On Sun, 2022-08-21 at 20:44 +0200, Karol Herbst wrote: > > On Sun, Aug 21, 2022 at 8:34 PM Rob Clark > > wrote: > > > > > > On Sun, Aug 21, 2022 at 10:45 AM Karol Herbst > > > wrote: > > > > > >

[PATCH drm-misc-next v3 3/4] drm/vc4: crtc: protect device resources after removal

2022-08-24 Thread Danilo Krummrich
(Hardware) resources which are bound to the driver and device lifecycle must not be accessed after the device and driver are unbound. However, the DRM device isn't freed as long as the last user closed it, hence userspace can still call into the driver. Therefore protect the critical sections

[PATCH drm-misc-next v3 2/4] drm/vc4: plane: protect device resources after removal

2022-08-24 Thread Danilo Krummrich
(Hardware) resources which are bound to the driver and device lifecycle must not be accessed after the device and driver are unbound. However, the DRM device isn't freed as long as the last user closed it, hence userspace can still call into the driver. Therefore protect the critical sections

Re: [PATCH v1 04/35] drm/modes: Introduce 480i and 576i modes

2022-08-24 Thread Mateusz Kwiatkowski
Hi Maxime, W dniu 18.08.2022 o 17:56, Geert Uytterhoeven pisze: > Hi Maxime, > > On Thu, Aug 18, 2022 at 5:46 PM Maxime Ripard wrote: >> On Thu, Aug 18, 2022 at 05:34:30PM +0200, Geert Uytterhoeven wrote: >>> On Thu, Aug 18, 2022 at 3:42 PM Maxime Ripard wrote: I started adding more sanity

Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop

2022-08-24 Thread James Zhu
ThispatchisReviewed-by:JamesZhu On 2022-08-15 3:00 a.m., Khalid Masum wrote: The value assigned from vcn_v4_0_stop_dbg_mode to r is overwritten before it can be used. Remove this assignment. Addresses-Coverity: 1504988 ("Unused value") Fixes: 8da1170a16e4 ("drm/amdgpu: add VCN4 ip block

Re: [PATCH linux-next] drm/amdgpu/vcn: Return void from the stop_dbg_mode

2022-08-24 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Aug 15, 2022 at 2:40 PM Dong, Ruijing wrote: > > [AMD Official Use Only - General] > > This patch is > > Reviewed-by: Ruijing Dong > > Thanks, > Ruijing > > -Original Message- > From: Khalid Masum > Sent: Monday, August 15, 2022 2:34 PM > To: Dong,

Re: [PATCH 0/4] Allow MMIO regions to be exported through dma-buf

2022-08-24 Thread Jason Gunthorpe
On Thu, Aug 18, 2022 at 01:07:16PM +0200, Christian König wrote: > Am 17.08.22 um 18:11 schrieb Jason Gunthorpe: > > dma-buf has become a way to safely acquire a handle to non-struct page > > memory that can still have lifetime controlled by the exporter. Notably > > RDMA can now import dma-buf

Re: [PATCH 5/5] drm/msm: Skip tlbinv on unmap from non-current pgtables

2022-08-24 Thread Rob Clark
On Wed, Aug 24, 2022 at 10:46 AM Akhil P Oommen wrote: > > On 8/21/2022 11:49 PM, Rob Clark wrote: > > From: Rob Clark > > > > We can rely on the tlbinv done by CP_SMMU_TABLE_UPDATE in this case. > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 ++ >

[PATCH] Revert "drm: bridge: analogix/dp: add panel prepare/unprepare in suspend/resume time"

2022-08-24 Thread Brian Norris
This reverts commit 211f276ed3d96e964d2d1106a198c7f4a4b3f4c0. For quite some time, core DRM helpers already ensure that any relevant connectors/CRTCs/etc. are disabled, as well as their associated components (e.g., bridges) when suspending the system. Thus, analogix_dp_bridge_{enable,disable}()

[PATCH 3/4] dt-bindings: display: Document Jadard JD9365DA-H3 DSI panel

2022-08-24 Thread Jagan Teki
Jadard JD9365DA-H3 is WUXGA MIPI DSI panel and it support TFT dot matrix LCD with 800RGBx1280 dots at maximum. Document it. Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jagan Teki --- .../display/panel/jadard,jd9365da-h3.yaml | 70 +++ MAINTAINERS

Re: [PATCH v1 34/35] drm/modes: Introduce the tv_mode property as a command-line option

2022-08-24 Thread Maxime Ripard
Hi Noralf, On Sat, Aug 20, 2022 at 10:18:47PM +0200, Noralf Trønnes wrote: > Den 29.07.2022 18.35, skrev Maxime Ripard: > > Our new tv mode option allows to specify the TV mode from a property. > > However, it can still be useful, for example to avoid any boot time > > artifact, to set that

Re: vm binding interfaces and parallel with mmap

2022-08-24 Thread Jason Ekstrand
On Mon, Aug 22, 2022 at 8:27 AM Christian König wrote: > Am 22.08.22 um 10:34 schrieb Bas Nieuwenhuizen: > > On Mon, Aug 22, 2022 at 9:28 AM Dave Airlie wrote: > >> On Mon, 22 Aug 2022 at 17:05, Dave Airlie wrote: > >>> Hey, > >>> > >>> I've just been looking at the vm bind type interfaces and

[PATCH drm-misc-next v3 1/4] drm/vc4: hdmi: unlock mutex when device is unplugged

2022-08-24 Thread Danilo Krummrich
In vc4_hdmi_encoder_{pre,post}_crtc_enable() commit cd00ed5187bf ("drm/vc4: hdmi: Protect device resources after removal") missed to unlock the mutex before returning due to drm_dev_enter() indicating the device being unplugged. Fixes: cd00ed5187bf ("drm/vc4: hdmi: Protect device resources after

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-24 Thread Mark Brown
On Mon, Aug 15, 2022 at 06:54:45PM +0300, Laurent Pinchart wrote: > - With devres, you don't have full control over the order in which > resources will be released, which means that you can't control the > power off sequence, in particular if it needs to be sequenced with > GPIOs and

Re: [PATCH v1 34/35] drm/modes: Introduce the tv_mode property as a command-line option

2022-08-24 Thread Mateusz Kwiatkowski
Hi Maxime & Noralf, W dniu 24.08.2022 o 17:45, Maxime Ripard pisze: > Hi Noralf, > > On Sat, Aug 20, 2022 at 10:18:47PM +0200, Noralf Trønnes wrote: >> Den 29.07.2022 18.35, skrev Maxime Ripard: >>> Our new tv mode option allows to specify the TV mode from a property. >>> However, it can still be

Re: [RFC PATCH 01/14] drm/qaic: Add documentation for AIC100 accelerator driver

2022-08-24 Thread Jeffrey Hugo
On 8/16/2022 4:55 AM, Krzysztof Kozlowski wrote: On 15/08/2022 21:42, Jeffrey Hugo wrote: Add documentation covering both the QAIC driver, and the device that it drives. Thank you for your patch. There is something to discuss/improve. Change-Id: Iee519cc0a276249c4e8684507d27ae2c33e29aeb

Re: [PATCH -next] drm/bridge: Add missing clk_disable_unprepare() in analogix_dp_resume()

2022-08-24 Thread Brian Norris
On Mon, Aug 15, 2022 at 11:46 PM Zhang Zekun wrote: > > Add the missing clk_disable_unprepare() before return from > analogix_dp_resume() in the error handling case. > > Fixes: 211f276ed3d9 ("drm: bridge: analogix/dp: add panel prepare/unprepare > in suspend/resume time") > Signed-off-by: Zhang

Re: [PATCH] drm/bridge: ps8640: Add double reset T4 and T5 to power-on sequence

2022-08-24 Thread Doug Anderson
Hi, On Thu, Aug 18, 2022 at 8:03 AM Doug Anderson wrote: > > Hi, > > On Wed, Aug 17, 2022 at 8:22 PM Hsin-Yi Wang wrote: > > > > On Thu, Aug 18, 2022 at 11:19 AM Rock Chiu > > wrote: > > > > > > How does T4/T5 impact the real case? We talked previously the T4/T5 > > > shouldn't cause user

Re: [PATCH 3/7] drm/msm/dp: Add DP and EDP compatibles for SC8280XP

2022-08-24 Thread Dmitry Baryshkov
On 10/08/2022 06:50, Bjorn Andersson wrote: The SC8280XP platform has four DisplayPort controllers, per MDSS instance, all with widebus support. The first two are defined to be DisplayPort only, while the latter pair (of each instance) can be either DisplayPort or Embedded DisplayPort. The two

Re: [PATCH drm-misc-next v2 2/4] drm/vc4: plane: protect device resources after removal

2022-08-24 Thread Maxime Ripard
On Fri, Aug 19, 2022 at 01:08:47PM +0200, Danilo Krummrich wrote: > (Hardware) resources which are bound to the driver and device lifecycle > must not be accessed after the device and driver are unbound. > > However, the DRM device isn't freed as long as the last user closed it, > hence userspace

Re: [PATCH 1/2] drm/rockchip: dw_hdmi: relax mode_valid hook

2022-08-24 Thread Robin Murphy
On 2022-08-22 16:20, Sascha Hauer wrote: The driver checks if the pixel clock of the given mode matches an entry in the mpll config table. The frequencies in the mpll table are meant as a frequency range up to which the entry works, not as a frequency that must match the pixel clock. Return

[PATCH AUTOSEL 4.19 13/14] video: fbdev: i740fb: Check the argument of i740_calc_vclk()

2022-08-24 Thread Sasha Levin
From: Zheyu Ma [ Upstream commit 40bf722f8064f50200b8c4f8946cd625b441dda9 ] Since the user can control the arguments of the ioctl() from the user space, under special arguments that may result in a divide-by-zero bug. If the user provides an improper 'pixclock' value that makes the argumet of

[PATCH v1] drm/ttm: Refcount allocated tail pages

2022-08-24 Thread Dmitry Osipenko
Higher order pages allocated using alloc_pages() aren't refcounted and they need to be refcounted, otherwise it's impossible to map them by KVM. This patch sets the refcount of the tail pages and fixes the KVM memory mapping faults. Without this change guest virgl driver can't map host buffers

[RFC PATCH 08/14] drm/qaic: Add RAS component

2022-08-24 Thread Jeffrey Hugo
A QAIC device can report a number of different internal errors. The RAS component services these reports by logging them for the sysadmin, and collecting statistics. Change-Id: Ib2f0731daf9a4afe05724e550c72bf32313e79bc Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/qaic/qaic_ras.c | 653

[RFC PATCH 06/14] drm/qaic: Add datapath

2022-08-24 Thread Jeffrey Hugo
Add the datapath component that manages BOs and submits them to running workloads on the qaic device via the dma_bridge hardware. Change-Id: I7a94cfb2741491f5fc044ae537f53d6cc0d97fee Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/qaic/qaic_data.c | 2152 ++

[RFC PATCH 03/14] drm/qaic: Add qaic.h internal header

2022-08-24 Thread Jeffrey Hugo
qaic.h contains all of the structs and defines that get passed around to the various components of the driver. Change-Id: I8349ac831a55daad3ac67ab763c2e815bb051be0 Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/qaic/qaic.h | 396 1 file changed, 396

[PATCH 04/12] Revert "drm/udl: Kill pending URBs at suspend and disconnect"

2022-08-24 Thread Takashi Iwai
This reverts the recent fix commit e25d5954264d ("drm/udl: Kill pending URBs at suspend and disconnect") as it turned out to lead to potential hangup at a disconnection, and it doesn't help much for suspend/resume problem, either. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/udl/udl_drv.h

Re: [PATCH v1 04/35] drm/modes: Introduce 480i and 576i modes

2022-08-24 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Aug 17, 2022 at 9:54 AM Maxime Ripard wrote: > On Tue, Aug 16, 2022 at 05:00:38PM +0200, Geert Uytterhoeven wrote: > > On Tue, Aug 16, 2022 at 3:26 PM Maxime Ripard wrote: > > > On Fri, Aug 12, 2022 at 03:18:58PM +0200, Geert Uytterhoeven wrote: > > > > On Fri, Jul 29, 2022

Re: build failure of next-20220817 for amdgpu

2022-08-24 Thread Alex Deucher
On Wed, Aug 17, 2022 at 6:03 PM Sudip Mukherjee (Codethink) wrote: > > Hi All, > > Not sure if it has been reported, build of next-20220817 fails with the > error: > > ERROR: modpost: "cpu_smallcore_map" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] > undefined! > > Trying to do a git bisect to find

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-24 Thread Nicolas Dufresne
Le vendredi 19 août 2022 à 23:44 +0800, Hsia-Jun Li a écrit : > > On 8/19/22 23:28, Nicolas Dufresne wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > > > > Le vendredi 19 août 2022 à

[PATCH drm-misc-next 7/8] drm/arm/malidp: crtc: protect device resources after removal

2022-08-24 Thread Danilo Krummrich
(Hardware) resources which are bound to the driver and device lifecycle must not be accessed after the device and driver are unbound. However, the DRM device isn't freed as long as the last user didn't close it, hence userspace can still call into the driver. Therefore protect the critical

RE: [PATCH] drm/amd/display: fix i386 frame size warning

2022-08-24 Thread David Laight
From: Hamza Mahfooz > Sent: 18 August 2022 17:49 > > Addresses the following warning: > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c:3596:6: > error: stack frame > size (2092) exceeds limit (2048) in > 'dml30_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe- >

[PATCH drm-misc-next 4/8] drm/arm/malidp: plane: use drm managed resources

2022-08-24 Thread Danilo Krummrich
Use drm managed resource allocation (drmm_universal_plane_alloc()) in order to get rid of the explicit destroy hook in struct drm_plane_funcs. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/arm/malidp_planes.c | 28 +++- 1 file changed, 7 insertions(+), 21

Re: vm binding interfaces and parallel with mmap

2022-08-24 Thread Christian König
Am 22.08.22 um 10:34 schrieb Bas Nieuwenhuizen: On Mon, Aug 22, 2022 at 9:28 AM Dave Airlie wrote: On Mon, 22 Aug 2022 at 17:05, Dave Airlie wrote: Hey, I've just been looking at the vm bind type interfaces and wanted to at least document how we think the unmapping API should work. I know

Re: [PATCH 1/3] dt-bindings: mediatek: Add gamma compatible for mt8195

2022-08-24 Thread Krzysztof Kozlowski
On 22/08/2022 12:19, zheng-yan.chen wrote: > mt8195 uses 10bit-to-12bit gamma-LUT, which is different from > current 9bit-to-10bit gamma-LUT, so this patch add its own compatible > for mt8195. I am not sure if this explains the need for change. Is mt8195 still compatible with mt8183 or not? Your

Re: [PATCH v2 04/21] drm/i915/mtl: Don't mask off CCS according to DSS fusing

2022-08-24 Thread Balasubramani Vivekanandan
On 18.08.2022 16:41, Radhakrishna Sripada wrote: > From: Matt Roper > > Unlike the Xe_HP platforms, MTL only has a single CCS engine; the > quad-based engine masking logic does not apply to this platform (or > presumably any future platforms that only have 0 or 1 CCS). > > Signed-off-by: Matt

Re: [PATCH v3 6/9] dma-buf: Move dma-buf attachment to dynamic locking specification

2022-08-24 Thread Dmitry Osipenko
On 8/24/22 17:08, Christian König wrote: > Am 24.08.22 um 12:22 schrieb Dmitry Osipenko: >> Move dma-buf attachment API functions to the dynamic locking >> specification. >> The strict locking convention prevents deadlock situations for dma-buf >> importers and exporters. >> >> Previously, the

[PATCH] drm/vmwgfx: fix repeated words in comments

2022-08-24 Thread Jilin Yuan
Delete the redundant word 'to'. Delete the redundant word 'should'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] drm/tidss: fix repeated words in comments

2022-08-24 Thread Jilin Yuan
Delete the redundant word 'to'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/tidss/tidss_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c index 666e527a0acf..7de3a5ffe5bc 100644 ---

[PATCH] drm/vboxvideo: fix repeated words in comments

2022-08-24 Thread Jilin Yuan
Delete the redundant word 'the'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/vboxvideo/vboxvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vboxvideo/vboxvideo.h b/drivers/gpu/drm/vboxvideo/vboxvideo.h index a5de40fe1a76..f60d82504da0 100644 ---

Re: [PATCH] drm/msm/dp: correct 1.62G link rate at dp_catalog_ctrl_config_msa()

2022-08-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-24 09:59:16) > At current implementation there is an extra 0 at 1.62G link rate which cause > no correct pixel_div selected for 1.62G link rate to calculate mvid and nvid. > This patch delete the extra 0 to have mvid and nvid be calculated correctly. > > Fixes:

[PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-24 Thread Kuogee Hsieh
DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and crtc->active is set before pushing a new frame downstream. There is a rare case that user space display manager issue an extra screen update immediately followed by close DRM device while down

[PATCH v2 2/5] clk: qcom: Allow custom reset ops

2022-08-24 Thread Akhil P Oommen
Allow soc specific clk drivers to specify a custom reset operation. We will use this in an upcoming patch to allow gpucc driver to specify a differet reset operation for cx_gdsc. Signed-off-by: Akhil P Oommen --- Changes in v2: - Return error when a particular custom reset op is not

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-24 Thread Mark Brown
On Fri, 12 Aug 2022 13:08:17 +0300, Matti Vaittinen wrote: > Devm helpers for regulator get and enable > > First patch in the series is actually just a simple documentation fix > which could be taken in as it is now. > > A few* drivers seem to use pattern demonstrated by pseudocode: > > [...]

Re: [PATCH 1/3] drm: Use original src rect while initializing damage iterator

2022-08-24 Thread Maíra Canal
Hi Jouni, On 7/15/22 10:49, Jouni Högander wrote: > drm_plane_state->src might be modified by the driver. This is done > e.g. in i915 driver when there is bigger framebuffer than the plane > and there is some offset within framebuffer. I915 driver calculates > separate offset and adjusts src rect

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-24 Thread Nicolas Dufresne
Le jeudi 18 août 2022 à 14:33 +0800, Hsia-Jun Li a écrit : > > On 8/18/22 14:06, Tomasz Figa wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > > > > Hi Randy, > > > > On Tue, Aug 9,

Re: [PATCH 0/4] Allow MMIO regions to be exported through dma-buf

2022-08-24 Thread Jason Gunthorpe
On Thu, Aug 18, 2022 at 03:37:01PM +0200, Christian König wrote: > Am 18.08.22 um 15:16 schrieb Jason Gunthorpe: > > On Thu, Aug 18, 2022 at 02:58:10PM +0200, Christian König wrote: > > > > > > > The only thing I'm not 100% convinced of is dma_buf_try_get(), I've > > > > > seen > > > > > this

Re: [PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks

2022-08-24 Thread Chen-Yu Tsai
On Fri, Jul 22, 2022 at 1:27 AM AngeloGioacchino Del Regno wrote: > > Add callbacks for atomic_destroy_state, atomic_duplicate_state and > atomic_reset to restore functionality of the DSI driver: this solves > vblank timeouts when another bridge is present in the chain. > > Tested bridge chain:

Re: Rust in our code base

2022-08-24 Thread Karol Herbst
On Sun, Aug 21, 2022 at 7:43 PM Karol Herbst wrote: > > On Sun, Aug 21, 2022 at 5:46 PM Rob Clark wrote: > > > > On Sat, Aug 20, 2022 at 5:23 AM Karol Herbst wrote: > > > > > > Hey everybody, > > > > > > so I think it's time to have this discussion for real. > > > > > > I am working on Rusticl

[PATCH] drm/amd: remove possible condition with no effect (if == else)

2022-08-24 Thread Bernard Zhao
This patch fix cocci warning: drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c:1816:6-8: WARNING: possible condition with no effect (if == else). Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH] drm/amd: fix potential memory leak

2022-08-24 Thread Bernard Zhao
This patch fix potential memory leak (clk_src) when function run into last return NULL. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c

Re: [PATCH] dma-buf/dma-resv: check if the new fence is really later

2022-08-24 Thread Jason Ekstrand
On Wed, Aug 10, 2022 at 12:26 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Previously when we added a fence to a dma_resv object we always > assumed the the newer than all the existing fences. > > With Jason's work to add an UAPI to explicit export/import that's not > necessary

Re: [PATCH] drm/sced: Add FIFO policy for scheduler rq

2022-08-24 Thread Andrey Grodzovsky
On 2022-08-24 04:29, Michel Dänzer wrote: On 2022-08-22 22:09, Andrey Grodzovsky wrote: Poblem: Given many entities competing for same rq on same scheduler an uncceptabliy long wait time for some jobs waiting stuck in rq before being picked up are observed (seen using GPUVis). The issue is

Re: Rust in our code base

2022-08-24 Thread Jason Ekstrand
+mesa-dev and my jlekstrand.net e-mail On Sun, 2022-08-21 at 20:44 +0200, Karol Herbst wrote: > On Sun, Aug 21, 2022 at 8:34 PM Rob Clark > wrote: > > > > On Sun, Aug 21, 2022 at 10:45 AM Karol Herbst > > wrote: > > > > > > On Sun, Aug 21, 2022 at 7:43 PM Karol Herbst > > > wrote: > > > > >

Re: [Linaro-mm-sig] [PATCH v3 6/9] dma-buf: Move dma-buf attachment to dynamic locking specification

2022-08-24 Thread Christian König
Am 24.08.22 um 12:22 schrieb Dmitry Osipenko: Move dma-buf attachment API functions to the dynamic locking specification. The strict locking convention prevents deadlock situations for dma-buf importers and exporters. Previously, the "unlocked" versions of the attachment API functions weren't

Re: [PATCH v1 23/35] drm/vc4: vec: Convert to the new TV mode property

2022-08-24 Thread Maxime Ripard
Hi, On Sat, Aug 20, 2022 at 07:22:48PM +0200, Noralf Trønnes wrote: > Den 29.07.2022 18.35, skrev Maxime Ripard: > > Now that the core can deal fine with analog TV modes, let's convert the vc4 > > VEC driver to leverage those new features. > > > > We've added some backward compatibility to

[PATCH drm-misc-next v3 4/4] drm/vc4: hvs: protect drm_print_regset32()

2022-08-24 Thread Danilo Krummrich
In vc4_hvs_dump_state() potentially freed resources are protected from being accessed with drm_dev_enter()/drm_dev_exit(). Also include drm_print_regset32() in the protected section, since drm_print_regset32() does access memory that is typically mapped via devm_* calls. Fixes: 969cfae1f01d

Re: [PATCH v6 5/8] drm/i915: Check for integer truncation on the configuration of ttm place

2022-08-24 Thread Jani Nikula
On Sat, 13 Aug 2022, Gwan-gyeong Mun wrote: > There is an impedance mismatch between the first/last valid page > frame number of ttm place in unsigned and our memory/page accounting in > unsigned long. > As the object size is under the control of userspace, we have to be prudent > and catch the

[PATCH libdrm v3 2/2] tests/modetest: Add support for writeback connector

2022-08-24 Thread Jessica Zhang
From: Rohith Iyer Add writeback support to modetest with the below options: - Passing in -c will now also show the writeback connector - Test a built-in mode on writeback connector - Test a custom mode from user input on writeback connector Usage: "./modetest -M msm -x : -a -P

[PATCH libdrm v3 1/2] tests/modetest: Allocate drmModeAtomicReq before setting properties

2022-08-24 Thread Jessica Zhang
From: Rohith Iyer Fix null pointer deference caused by drmModeAtomicReq being allocated before set_property was called when modetest was run with the atomic flag. Reviewed-by: Rob Clark Signed-off-by: Rohith Iyer --- tests/modetest/modetest.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-24 Thread Maxime Ripard
On Tue, Aug 16, 2022 at 09:35:24PM +0200, Noralf Trønnes wrote: > Den 16.08.2022 11.49, skrev Maxime Ripard: > > On Tue, Aug 16, 2022 at 11:42:20AM +0200, Noralf Trønnes wrote: > >> Den 16.08.2022 10.26, skrev Maxime Ripard: > >>> Hi, > >>> > >>> On Mon, Aug 08, 2022 at 02:44:56PM +0200, Noralf

  1   2   3   4   >