Re: [PATCH v2 2/2] drm/msm/dpu: stop mapping the regdma region

2023-04-21 Thread Marijn Suijten
On 2023-04-21 01:25:58, Dmitry Baryshkov wrote: > Stop mapping the regdma region. The driver does not support regdma. > > Signed-off-by: Dmitry Baryshkov Should you add a third patch to remove this from dt-bindings? (msm8998 has it in both dpu and mdss files) Regardless, the patch itself is:

Re: [PATCH v5] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-21 Thread Thomas Zimmermann
Hi Am 20.04.23 um 05:05 schrieb Sui Jingfeng: The fbdev test of IGT may write after EOF, which lead to out-of-bound access for drm drivers hire fbdev-generic. For example, run fbdev test on a x86+ast2400 platform, with 1680x1050 resolution, will cause the linux kernel hang with the following

[PATCH -next] drm/stm: dsi: Use devm_platform_ioremap_resource()

2023-04-21 Thread Yang Li
Convert platform_get_resource(),devm_ioremap_resource() to a single call to devm_platform_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH 1/3] dt-bindings: display: synopsys, dw-hdmi: Add property for disabling CEC

2023-04-21 Thread Hans Verkuil
On 18/04/2023 23:41, Rob Herring wrote: > On Sat, Apr 15, 2023 at 12:46:11PM +0200, Jernej Skrabec wrote: >> Even though some DW-HDMI controllers have perfectly usable HDMI-CEC >> implementation, some boards might prefer not to use it or even use >> software implementation instead. >> >> Add

Re: [PATCH net-next 1/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-04-21 Thread Krzysztof Kozlowski
On 19/04/2023 02:10, Justin Chen wrote: > From: Florian Fainelli > > Add a binding document for the Broadcom ASP 2.0 Ethernet > controller. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > --- > .../devicetree/bindings/net/brcm,asp-v2.0.yaml | 146 >

Re: [PATCH v2 1/2] drm/msm/dpu: drop the regdma configuration

2023-04-21 Thread Marijn Suijten
On 2023-04-21 01:25:57, Dmitry Baryshkov wrote: > The regdma is currently not used by the current driver. We have no way > to practically verify that the regdma is described correctly. Drop it > now. > > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 1

Re: [Intel-gfx] [PATCH] drm/i915/mtl: workaround coherency issue for Media

2023-04-21 Thread Das, Nirmoy
On 4/20/2023 11:30 PM, Matt Roper wrote: On Thu, Apr 20, 2023 at 01:38:59PM +0200, Nirmoy Das wrote: From: Fei Yang This patch implements Wa_22016122933. In MTL, memory writes initiated by Media tile update the whole cache line even for partial writes. This creates a coherency problem for

Re: [PATCH v5] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-21 Thread Sui Jingfeng
Hi On 2023/4/21 16:09, Thomas Zimmermann wrote: Hi Am 20.04.23 um 05:05 schrieb Sui Jingfeng: The fbdev test of IGT may write after EOF, which lead to out-of-bound access for drm drivers hire fbdev-generic. For example, run fbdev test on a x86+ast2400 platform, with 1680x1050 resolution, will

Re: [RFC 2/3] drm/msm: Rework get_comm_cmdline() helper

2023-04-21 Thread Emil Velikov
Greeting all, Sorry for the delay - Easter Holidays, food coma and all that :-) On Tue, 18 Apr 2023 at 15:31, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 1:34 AM Daniel Vetter wrote: > > > > On Tue, Apr 18, 2023 at 09:27:49AM +0100, Tvrtko Ursulin wrote: > > > > > > On 17/04/2023 21:12, Rob

Re: [PATCH] PCI: Add ASPEED vendor ID

2023-04-21 Thread Thomas Zimmermann
Hi Am 21.04.23 um 00:04 schrieb Damien Le Moal: On 4/21/23 04:10, Bjorn Helgaas wrote: [+cc Damien, linux-ide] On Thu, Apr 20, 2023 at 09:08:48AM +0200, Thomas Zimmermann wrote: Am 19.04.23 um 20:37 schrieb Bjorn Helgaas: On Wed, Apr 19, 2023 at 09:00:15AM +0200, Thomas Zimmermann wrote:

Re: [PATCH net-next 2/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

2023-04-21 Thread Krzysztof Kozlowski
On 19/04/2023 02:10, Justin Chen wrote: > From: Justin Chen > > The ASP 2.0 Ethernet controller uses a brcm unimac. > > Signed-off-by: Justin Chen > Signed-off-by: Florian Fainelli > --- > Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [PATCH v3] drm/ast: Fix ARM compatibility

2023-04-21 Thread Thomas Zimmermann
Hi Am 21.04.23 um 02:33 schrieb Jammy Huang: ARM architecture only has 'memory', so all devices are accessed by MMIO if possible. Merged into drm-misc-fixes. Thanks for the patch. Best regards Thomas Signed-off-by: Jammy Huang Reviewed-by: Thomas Zimmermann --- v2 changes: - Use

Re: [PATCH 1/6] drm: bridge: samsung-dsim: Support multi-lane calculations

2023-04-21 Thread Lucas Stach
Am Donnerstag, dem 20.04.2023 um 16:51 -0500 schrieb Adam Ford: > On Thu, Apr 20, 2023 at 8:43 AM Lucas Stach wrote: > > > > Am Donnerstag, dem 20.04.2023 um 08:24 -0500 schrieb Adam Ford: > > > On Thu, Apr 20, 2023 at 8:06 AM Lucas Stach > > > wrote: > > > > > > > > Hi Adam, > > > > > > > >

Re: [Intel-gfx] [PATCH 7/8] drm/i915: use pat_index instead of cache_level

2023-04-21 Thread Tvrtko Ursulin
On 20/04/2023 00:00, fei.y...@intel.com wrote: From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum.

[PATCH -next] drm/arc: Use devm_platform_ioremap_resource()

2023-04-21 Thread Yang Li
Convert platform_get_resource(),devm_ioremap_resource() to a single call to devm_platform_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li --- drivers/gpu/drm/tiny/arcpgu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH -next] drm/tve200: Use devm_platform_ioremap_resource()

2023-04-21 Thread Yang Li
Convert platform_get_resource(),devm_ioremap_resource() to a single call to devm_platform_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li --- drivers/gpu/drm/tve200/tve200_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH v2 2/3] vkms: Add support for multiple pipes

2023-04-21 Thread Marius Vlad
Hi Maíra, Thanks a lot for taking a look! On Thu, Apr 20, 2023 at 01:47:59PM -0300, Maíra Canal wrote: > Hi Marius, > > Thanks for the changing the commit message! Just a few nits: > > On 4/20/23 05:41, Marius Vlad wrote: > > This adds support for creating multiple virtual pipes, in case one

Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-04-21 Thread Arnaud Vrac
Le jeu. 20 avr. 2023 à 02:20, Dmitry Baryshkov a écrit : > > On 18/04/2023 21:10, Arnaud Vrac wrote: > > Some Qualcomm SoCs that support HDMI also support CEC, including MSM8996 > > and MSM8998. The hardware block can handle a single CEC logical address > > and broadcast messages. > > > > Port

Re: [Freedreno] [PATCH 03/11] drm/msm/dpu: use hsync/vsync polarity set by the encoder

2023-04-21 Thread Jeykumar Sankaran
On 4/19/2023 7:41 AM, Arnaud Vrac wrote: Do not override the hsync/vsync polarity passed by the encoder when setting up intf timings. The same logic was used in both the encoder and intf code to set the DP and DSI polarities, so those interfaces are not impacted. However for HDMI, the

Re: [Freedreno] [PATCH 02/11] drm/msm/dpu: use the actual lm maximum width instead of a hardcoded value

2023-04-21 Thread Jeykumar Sankaran
On 4/19/2023 3:23 PM, Dmitry Baryshkov wrote: On 19/04/2023 17:41, Arnaud Vrac wrote: This avoids using two LMs instead of one when the display width is lower than the maximum supported value. For example on MSM8996/MSM8998, the actual maxwidth is 2560, so we would use two LMs for 1280x720

Re: [PATCH 04/11] drm/msm/dpu: allow using lm mixer base stage

2023-04-21 Thread Arnaud Vrac
Le jeu. 20 avr. 2023 à 00:43, Dmitry Baryshkov a écrit : > > On 19/04/2023 17:41, Arnaud Vrac wrote: > > The dpu backend already handles applying alpha to the base stage, so we > > can use it to render the bottom plane in all cases. This allows mixing > > one additional plane with the hardware

[PATCH -next] drm/rockchip: dsi: Use devm_platform_get_and_ioremap_resource()

2023-04-21 Thread Yang Li
Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li --- drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH -next] drm/tegra: dpaux: Use devm_platform_ioremap_resource()

2023-04-21 Thread Yang Li
Convert platform_get_resource(),devm_ioremap_resource() to a single call to devm_platform_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li --- drivers/gpu/drm/tegra/dpaux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH] drm/mediatek: Clarify/finish documentation for some driver structures

2023-04-21 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2023年4月19日 週三 下午2:16寫道: > > Il 21/03/23 12:14, AngeloGioacchino Del Regno ha scritto: > > The documentation for some of the driver structures in mediatek-drm > > was set to be kerneldoc but some code additions didn't actually update > > the comments

Re: [PATCH RESEND v2 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

2023-04-21 Thread Doug Anderson
Hi, On Mon, Mar 13, 2023 at 12:51 AM wrote: > > From: Richard Leitner > > Add Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel compatible > string. > > Acked-by: Krzysztof Kozlowski > Signed-off-by: Richard Leitner nit: as I understand it, ordering of tags is usually supposed to be

Re: [PATCH RESEND v2 2/2] drm/panel: simple: Add InnoLux G070ACE-L01

2023-04-21 Thread Doug Anderson
Hi, On Mon, Mar 13, 2023 at 12:51 AM wrote: > > From: Richard Leitner > > Add InnoLux G070ACE-L01 7" 800x480 TFT LCD with WLED backlight panel > support. Timing data was extracted from datasheet and vendor provided > EDID file. > > Signed-off-by: Richard Leitner > --- >

Re: [PATCH RESEND v2 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

2023-04-21 Thread Doug Anderson
Hi, On Fri, Apr 21, 2023 at 9:26 AM Krzysztof Kozlowski wrote: > > On 21/04/2023 18:15, Doug Anderson wrote: > > Hi, > > > > On Mon, Mar 13, 2023 at 12:51 AM wrote: > >> > >> From: Richard Leitner > >> > >> Add Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel compatible > >> string. > >> >

Re: [PATCH RESEND v2 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

2023-04-21 Thread Doug Anderson
Hi, On Fri, Apr 21, 2023 at 9:45 AM Krzysztof Kozlowski wrote: > > On 21/04/2023 18:37, Doug Anderson wrote: > > Hi, > > > > On Fri, Apr 21, 2023 at 9:26 AM Krzysztof Kozlowski > > wrote: > >> > >> On 21/04/2023 18:15, Doug Anderson wrote: > >>> Hi, > >>> > >>> On Mon, Mar 13, 2023 at 12:51 AM

Re: [Intel-gfx] [PATCH 3/8] drm/i915/mtl: Add PTE encode function

2023-04-21 Thread Yang, Fei
> On Wed, Apr 19, 2023 at 04:00:53PM -0700, fei.y...@intel.com wrote: >> From: Fei Yang >> >> PTE encode functions are platform dependent. This patch implements >> PTE functions for MTL, and ensures the correct PTE encode function >> is used by calling pte_encode function pointer instead of the

[PATCH v2] drm/i915/mtl: workaround coherency issue for Media

2023-04-21 Thread Nirmoy Das
From: Fei Yang This patch implements Wa_22016122933. In MTL, memory writes initiated by the Media tile update the whole cache line, even for partial writes. This creates a coherency problem for cacheable memory if both CPU and GPU are writing data to different locations within a single cache

Re: [PATCH v4 2/8] drm/i915/mtl: fix mocs selftest

2023-04-21 Thread Matt Roper
On Fri, Apr 21, 2023 at 10:37:55AM -0700, fei.y...@intel.com wrote: > From: Fei Yang > > Media GT has a different base for MOCS register, need to apply > gsi_offset to the mmio address if not using the intel_uncore_r/w > functions for register access. > > Cc: Matt Roper > Signed-off-by: Fei

[PATCH v1 0/2] Create Content Protection Property and Use it

2023-04-21 Thread Mark Yacoub
From: Mark Yacoub Hi all, Following up to my HDCP patches[1], this series introduces a new connector prop that is required to push the key from user space to a driver that requires a key from user space to enable HDCP on a connector. Patch 1 is the DRM code that creates this prop. Patch 2 is

[PATCH v1 2/2] dp_hdcp: Get the hdcp key from the connector prop

2023-04-21 Thread Mark Yacoub
From: Mark Yacoub [Why] To support protected content, the driver requires a key. Currently, it's being injected from debugfs, which is not super useful to run a user space in the wild. [How] When the key is needed, fetch the "Content Protection Property" on the connector and get the key blob.

[PATCH v1 1/2] DRM: Create new Content Protection connector property

2023-04-21 Thread Mark Yacoub
From: Mark Yacoub [Why] To enable Protected Content, some drivers require a key to be injected from user space to enable HDCP on the connector. [How] Create new "Content Protection Property" of type "Blob" Signed-off-by: Mark Yacoub --- drivers/gpu/drm/drm_atomic_uapi.c | 9 +

Re: [PATCH RESEND v2 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

2023-04-21 Thread Krzysztof Kozlowski
On 21/04/2023 18:51, Doug Anderson wrote: >>> ...and, again, it matches the order that I thought was right. In other >>> words, the patch file generated says: >>> Signed-off-by: Richard Leitner Acked-by: Krzysztof Kozlowski >> >> We talk about `b4 trailers`, because the tag is applied

Re: [PATCH v2 1/2] drm/msm/dpu: drop the regdma configuration

2023-04-21 Thread Abhinav Kumar
On 4/20/2023 3:25 PM, Dmitry Baryshkov wrote: The regdma is currently not used by the current driver. We have no way to practically verify that the regdma is described correctly. Drop it now. Signed-off-by: Dmitry Baryshkov --- As Marijn noted, perhaps we can drop even

[PATCH v2 1/2] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-21 Thread Andi Shyti
From: Madhumitha Tolakanahalli Pradeep On MTL, GT can no longer allocate on LLC - only the CPU can. This, along with programming new register bits that MTL requires calls for a MOCS/PAT table update. Also the PAT index registers are multicasted for primary GT, and there is an address jump from

[PATCH v2 2/2] drm/i915/mtl: fix mocs selftest

2023-04-21 Thread Andi Shyti
From: Fei Yang Media GT has a different base for MOCS register, need to apply gsi_offset to the mmio address if not using the intel_uncore_r/w functions for register access. Cc: Matt Roper Signed-off-by: Fei Yang Reviewed-by: Matt Roper Signed-off-by: Andi Shyti ---

[PATCH v2 0/2] Define MOCS and PAT tables for MTL

2023-04-21 Thread Andi Shyti
Hi, just extracting this patch from Fei's series. Andi Changelog: == v1 -> v2: Taken from Fei's new series: https://patchwork.freedesktop.org/series/115980/ - Removed unnecessary defines - Place the selftest patches in a different patch Fei Yang (1): drm/i915/mtl: fix mocs selftest

Re: [PATCH] drm/msm/dp: unregister audio driver during unbind

2023-04-21 Thread Abhinav Kumar
On 4/21/2023 7:56 AM, Srinivas Kandagatla wrote: while binding the code always registers a audio driver, however there is no corresponding unregistration done in unbind. This leads to multiple redundant audio platform devices if dp_display_bind and dp_display_unbind happens multiple times

[PATCH v2 3/3] dp_hdcp: Get the hdcp key from the connector prop

2023-04-21 Thread Mark Yacoub
From: Mark Yacoub [Why] To support protected content, the driver requires a key. Currently, it's being injected from debugfs, which is not super useful to run a user space in the wild. [How] When the key is needed, fetch the "Content Protection Property" on the connector and get the key blob.

Re: [PATCH v2 2/3] DRM: Create new Content Protection connector property

2023-04-21 Thread Dmitry Baryshkov
On 21/04/2023 19:27, Mark Yacoub wrote: From: Mark Yacoub Nit: is there a reason for this header? My first impression is that it matches your outgoing name & email address and as such is not necessary. Nit#2: subject should mention 'Key', as you are creating a property for the key.

Re: [Intel-gfx] [PATCH 3/8] drm/i915/mtl: Add PTE encode function

2023-04-21 Thread Matt Roper
On Fri, Apr 21, 2023 at 10:27:22AM -0700, Yang, Fei wrote: >> On Wed, Apr 19, 2023 at 04:00:53PM -0700, fei.y...@intel.com wrote: >>> From: Fei Yang >>> >>> PTE encode functions are platform dependent. This patch implements >>> PTE functions for MTL, and ensures the correct

Re: [Intel-gfx] [PATCH 1/2] drm/i915/i915_drv: Use proper parameter naming in for_each_gt()

2023-04-21 Thread Andrzej Hajda
On 21.04.2023 15:46, Andi Shyti wrote: for_each_gt() loops through engines in the GT, not in dev_priv. Because it's misleading, call it "gt__" instead of "dev_priv__". Signed-off-by: Andi Shyti With fixes mentioned by Rodrigo. Reviewed-by: Andrzej Hajda Regards Andrzej ---

[PATCH] drm/msm/dp: unregister audio driver during unbind

2023-04-21 Thread Srinivas Kandagatla
while binding the code always registers a audio driver, however there is no corresponding unregistration done in unbind. This leads to multiple redundant audio platform devices if dp_display_bind and dp_display_unbind happens multiple times during startup. On X13s platform this resulted in 6 to 9

Re: [PATCH v8 3/8] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-04-21 Thread Ceraolo Spurio, Daniele
On 4/20/2023 10:34 PM, Alan Previn wrote: Add helper functions into a new file for heci-packet-submission. The helpers will handle generating the MTL GSC-CS Memory-Header and submission of the Heci-Cmd-Packet instructions to the engine. NOTE1: These common functions for

[PATCH v2 2/3] DRM: Create new Content Protection connector property

2023-04-21 Thread Mark Yacoub
From: Mark Yacoub [Why] To enable Protected Content, some drivers require a key to be injected from user space to enable HDCP on the connector. [How] Create new "Content Protection Property" of type "Blob" Signed-off-by: Mark Yacoub --- drivers/gpu/drm/drm_atomic_uapi.c | 9 +

[PATCH v2 0/3] Create Content Protection Property and Use it

2023-04-21 Thread Mark Yacoub
From: Mark Yacoub Hi all, Following up to my HDCP patches[1], this series introduces a new connector prop that is required to push the key from user space to a driver that requires a key from user space to enable HDCP on a connector. Patch 1 is the WO blob patch to protect the key Patch 2 is

[PATCH v2 1/3] drm: Create support for Write-Only property blob

2023-04-21 Thread Mark Yacoub
From: Mark Yacoub [Why] User space might need to inject data into the kernel without allowing it to be read again by any user space. An example of where this is particularly useful is secret keys fetched by user space and injected into the kernel to enable content protection. [How] Create a

Re: [PATCH RESEND v2 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

2023-04-21 Thread Krzysztof Kozlowski
On 21/04/2023 18:15, Doug Anderson wrote: > Hi, > > On Mon, Mar 13, 2023 at 12:51 AM wrote: >> >> From: Richard Leitner >> >> Add Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel compatible >> string. >> >> Acked-by: Krzysztof Kozlowski >> Signed-off-by: Richard Leitner > > nit: as I

Re: [PATCH v2 2/2] drm/msm/dpu: stop mapping the regdma region

2023-04-21 Thread Abhinav Kumar
On 4/20/2023 3:25 PM, Dmitry Baryshkov wrote: Stop mapping the regdma region. The driver does not support regdma. Signed-off-by: Dmitry Baryshkov --- As pointed out by Marijn, the binding can be dropped too but for this change, Reviewed-by: Abhinav Kumar

Re: [PATCH v2 1/2] drm/msm/dpu: drop the regdma configuration

2023-04-21 Thread Dmitry Baryshkov
On 21/04/2023 20:46, Abhinav Kumar wrote: On 4/20/2023 3:25 PM, Dmitry Baryshkov wrote: The regdma is currently not used by the current driver. We have no way to practically verify that the regdma is described correctly. Drop it now. Signed-off-by: Dmitry Baryshkov --- As Marijn noted,

Re: [Intel-gfx] [PATCH 2/2] drm/i915/i915_drv: Use i915 instead of dev_priv insied the file_priv structure

2023-04-21 Thread Andi Shyti
On Fri, Apr 21, 2023 at 10:07:28AM -0400, Rodrigo Vivi wrote: > On Fri, Apr 21, 2023 at 03:46:54PM +0200, Andi Shyti wrote: > > In the process of renaming all instances of 'dev_priv' to 'i915', > > start using 'i915' within the 'drm_i915_file_private' structure. > > The patch looks good but the

Re: [Intel-gfx] [PATCH 2/2] drm/i915/i915_drv: Use i915 instead of dev_priv insied the file_priv structure

2023-04-21 Thread Andrzej Hajda
On 21.04.2023 15:46, Andi Shyti wrote: In the process of renaming all instances of 'dev_priv' to 'i915', start using 'i915' within the 'drm_i915_file_private' structure. Signed-off-by: Andi Shyti --- Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [PATCH RESEND v2 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

2023-04-21 Thread Krzysztof Kozlowski
On 21/04/2023 18:37, Doug Anderson wrote: > Hi, > > On Fri, Apr 21, 2023 at 9:26 AM Krzysztof Kozlowski > wrote: >> >> On 21/04/2023 18:15, Doug Anderson wrote: >>> Hi, >>> >>> On Mon, Mar 13, 2023 at 12:51 AM wrote: From: Richard Leitner Add Innolux G070ACE-L01 7" WVGA

[PATCH v4 4/8] drm/i915: preparation for using PAT index

2023-04-21 Thread fei . yang
From: Fei Yang This patch is a preparation for replacing enum i915_cache_level with PAT index. Caching policy for buffer objects is set through the PAT index in PTE, the old i915_cache_level is not sufficient to represent all caching modes supported by the hardware. Preparing the transition by

[PATCH v4 5/8] drm/i915: use pat_index instead of cache_level

2023-04-21 Thread fei . yang
From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum. In addition, the PAT index is platform dependent,

[PATCH v4 8/8] drm/i915: Allow user to set cache at BO creation

2023-04-21 Thread fei . yang
From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a

[PATCH v4 6/8] drm/i915: make sure correct pte encode is used

2023-04-21 Thread fei . yang
From: Fei Yang PTE encode is platform dependent. After replacing cache_level with pat_index, the newly introduced mtl_pte_encode is actually generic for all gen12 platforms, thus rename it to gen12_pte_encode and apply it to all gen12 platforms. Cc: Chris Wilson Cc: Matt Roper Signed-off-by:

[PATCH v4 3/8] drm/i915/mtl: Add PTE encode function

2023-04-21 Thread fei . yang
From: Fei Yang PTE encode functions are platform dependent. This patch implements PTE functions for MTL, and ensures the correct PTE encode function is used by calling pte_encode function pointer instead of the hardcoded gen8 version of PTE encode. Signed-off-by: Fei Yang Reviewed-by: Andrzej

[PATCH v4 1/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-21 Thread fei . yang
From: Madhumitha Tolakanahalli Pradeep On MTL, GT can no longer allocate on LLC - only the CPU can. This, along with programming new register bits that MTL requires calls for a MOCS/PAT table update. Also the PAT index registers are multicasted for primary GT, and there is an address jump from

[PATCH v4 2/8] drm/i915/mtl: fix mocs selftest

2023-04-21 Thread fei . yang
From: Fei Yang Media GT has a different base for MOCS register, need to apply gsi_offset to the mmio address if not using the intel_uncore_r/w functions for register access. Cc: Matt Roper Signed-off-by: Fei Yang --- drivers/gpu/drm/i915/gt/selftest_mocs.c | 3 ++- 1 file changed, 2

[PATCH v4 7/8] drm/i915/mtl: end support for set caching ioctl

2023-04-21 Thread fei . yang
From: Fei Yang The design is to keep Buffer Object's caching policy immutable through out its life cycle. This patch ends the support for set caching ioctl from MTL onward. While doing that we also set BO's to be 1-way coherent at creation time because GPU is no longer automatically snooping CPU

[PATCH v4 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-21 Thread fei . yang
From: Fei Yang The series includes patches needed to enable MTL. Also add new extension for GEM_CREATE uAPI to let user space set cache policy for buffer objects. v2: addressing review comments and checkpatch warnings v3: make mtl_ggtt_pte_encode static v4: addressing more comments from Matt

[PATCH v2 2/2] drm/i915/i915_drv: Use i915 instead of dev_priv insied the file_priv structure

2023-04-21 Thread Andi Shyti
In the process of renaming all instances of 'dev_priv' to 'i915', start using 'i915' within the i915_drv.h file. Signed-off-by: Andi Shyti Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/i915_drv.h | 458 1 file changed, 229 insertions(+), 229 deletions(-)

[PATCH v2 0/2] Use i915 instead of dev_priv

2023-04-21 Thread Andi Shyti
Hi, just another "Friday patch". While reviewing some patches from Tejas I found a bit confusing the use of dev_priv__ inside the for_each_engine(), perhaps it should be moved inside the gt/? As I was at it I made the /dev_priv/i915/ change which is still harmless. Next in queue is to change the

[PATCH v2 1/2] drm/i915/i915_drv: Use proper parameter naming in for_each_engine()

2023-04-21 Thread Andi Shyti
for_each_engine() loops through engines in the GT, not in dev_priv. Because it's misleading, call it "gt__" instead of "dev_priv__". Signed-off-by: Andi Shyti Reviewed-by: Rodrigo Vivi Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [RFC 2/3] drm/msm: Rework get_comm_cmdline() helper

2023-04-21 Thread Rob Clark
On Fri, Apr 21, 2023 at 2:33 AM Emil Velikov wrote: > > Greeting all, > > Sorry for the delay - Easter Holidays, food coma and all that :-) > > On Tue, 18 Apr 2023 at 15:31, Rob Clark wrote: > > > > On Tue, Apr 18, 2023 at 1:34 AM Daniel Vetter wrote: > > > > > > On Tue, Apr 18, 2023 at

Re: [PATCH v4 5/6] drm: Add fdinfo memory stats

2023-04-21 Thread Rob Clark
On Fri, Apr 21, 2023 at 4:59 AM Tvrtko Ursulin wrote: > > > On 21/04/2023 12:45, Emil Velikov wrote: > > On Fri, 21 Apr 2023 at 12:23, Tvrtko Ursulin > > wrote: > > > >> On 21/04/2023 11:26, Emil Velikov wrote: > >>> On Wed, 12 Apr 2023 at 23:43, Rob Clark wrote: > >>> > +/** > + *

Re: [PATCH v4 8/8] drm/i915: Allow user to set cache at BO creation

2023-04-21 Thread Matt Roper
On Fri, Apr 21, 2023 at 10:38:01AM -0700, fei.y...@intel.com wrote: > From: Fei Yang > > To comply with the design that buffer objects shall have immutable > cache setting through out their life cycle, {set, get}_caching ioctl's > are no longer supported from MTL onward. With that change caching

Re: [PATCH v2 2/2] drm/msm/dpu: stop mapping the regdma region

2023-04-21 Thread Dmitry Baryshkov
On 21/04/2023 10:35, Marijn Suijten wrote: On 2023-04-21 01:25:58, Dmitry Baryshkov wrote: Stop mapping the regdma region. The driver does not support regdma. Signed-off-by: Dmitry Baryshkov Should you add a third patch to remove this from dt-bindings? (msm8998 has it in both dpu and mdss

Re: [PATCH v1 1/5] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-21 Thread kernel test robot
-for-DSC-encoder-v1-2-engine/20230421-072925 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/1682033114-28483-2-git-send-email-quic_khsieh%40quicinc.com patch subject: [PATCH v1 1/5] drm/msm/dpu: add support for DSC encoder v1.2 engine config

[PATCH v5 1/2] drm/i915/guc/slpc: Provide sysfs for efficient freq

2023-04-21 Thread Vinay Belgaumkar
SLPC enables use of efficient freq at init by default. It is possible for GuC to request frequencies that are higher than the 'software' max if user has set it lower than the efficient level. Scenarios/tests that require strict fixing of freq below the efficient level will need to disable it

[PATCH v5 2/2] drm/i915/selftest: Update the SLPC selftest

2023-04-21 Thread Vinay Belgaumkar
Use the new efficient frequency toggling interface. Also create a helper function to restore the frequencies after the test is done. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/selftest_slpc.c | 42 ++--- 1 file changed, 37 insertions(+), 5 deletions(-) diff

Re: [PATCH v1 4/5] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-21 Thread Kuogee Hsieh
On 4/20/2023 5:27 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: During DSC preparation, add run time calculation to figure out what usage modes, split mode and merge mode, is going to be setup. Signed-off-by: Kuogee Hsieh ---  

Re: [PATCH v1 4/5] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-21 Thread Kuogee Hsieh
On 4/21/2023 2:13 PM, Dmitry Baryshkov wrote: On 22/04/2023 00:07, Kuogee Hsieh wrote: On 4/20/2023 5:27 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: During DSC preparation, add run time calculation to figure out what usage modes, split mode and merge mode, is going

Re: [PATCH v2 1/2] phy: mediatek: hdmi: mt8195: fix uninitialized variable usage in pll_calc

2023-04-21 Thread Nathan Chancellor
On Fri, Apr 14, 2023 at 06:07:46PM +0200, Guillaume Ranquet wrote: > The ret variable in mtk_hdmi_pll_calc() was used unitialized as reported > by the kernel test robot. > > Fix the issue by removing the variable altogether and testing out the > return value of mtk_hdmi_pll_set_hw() > > Fixes:

Re: [PATCH 3/9] drm/amdkfd: switch over to using drm_exec

2023-04-21 Thread Felix Kuehling
On 2023-02-28 03:34, Christian König wrote: Avoids quite a bit of logic and kmalloc overhead. Not sure what's the status of this patch series. In general I'm in favour. I think it could help with some tricky locking cases for the work we're doing for validating GEM objects in KFD contexts.

Re: [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-21 Thread Kuogee Hsieh
On 4/21/2023 4:11 PM, Dmitry Baryshkov wrote: On 22/04/2023 02:08, Kuogee Hsieh wrote: On 4/21/2023 3:16 PM, Dmitry Baryshkov wrote: On 22/04/2023 01:05, Kuogee Hsieh wrote: On 4/20/2023 5:07 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: From: Abhinav Kumar Add

Re: [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-21 Thread Kuogee Hsieh
On 4/20/2023 5:07 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information. Each display compression engine (DCE) contains dual hard slice DSC encoders so both

Re: [PATCH v1 4/5] drm/msm/dpu: calculate DSC encoder parameters dynamically

2023-04-21 Thread Dmitry Baryshkov
On 22/04/2023 00:30, Kuogee Hsieh wrote: On 4/21/2023 2:13 PM, Dmitry Baryshkov wrote: On 22/04/2023 00:07, Kuogee Hsieh wrote: On 4/20/2023 5:27 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: During DSC preparation, add run time calculation to figure out what usage

Re: [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-21 Thread Dmitry Baryshkov
On 22/04/2023 01:05, Kuogee Hsieh wrote: On 4/20/2023 5:07 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information. Each display compression engine (DCE)

Re: [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-21 Thread Dmitry Baryshkov
On 22/04/2023 01:34, Abhinav Kumar wrote: On 4/20/2023 3:52 PM, Dmitry Baryshkov wrote: On 20/04/2023 22:56, Marijn Suijten wrote: On 2023-04-20 22:51:22, Dmitry Baryshkov wrote: On 20/04/2023 22:47, Abhinav Kumar wrote: On 4/20/2023 11:01 AM, Dmitry Baryshkov wrote: On 20/04/2023

Re: [PATCH 0/2] DPU1 GC1.8 wiring-up

2023-04-21 Thread Abhinav Kumar
On 4/20/2023 3:52 PM, Dmitry Baryshkov wrote: On 20/04/2023 22:56, Marijn Suijten wrote: On 2023-04-20 22:51:22, Dmitry Baryshkov wrote: On 20/04/2023 22:47, Abhinav Kumar wrote: On 4/20/2023 11:01 AM, Dmitry Baryshkov wrote: On 20/04/2023 04:36, Konrad Dybcio wrote: On 20.04.2023

Re: [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-21 Thread Dmitry Baryshkov
On 22/04/2023 02:08, Kuogee Hsieh wrote: On 4/21/2023 3:16 PM, Dmitry Baryshkov wrote: On 22/04/2023 01:05, Kuogee Hsieh wrote: On 4/20/2023 5:07 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee Hsieh wrote: From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with

Re: [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-04-21 Thread Dmitry Baryshkov
On 22/04/2023 02:16, Kuogee Hsieh wrote: On 4/21/2023 4:11 PM, Dmitry Baryshkov wrote: On 22/04/2023 02:08, Kuogee Hsieh wrote: On 4/21/2023 3:16 PM, Dmitry Baryshkov wrote: On 22/04/2023 01:05, Kuogee Hsieh wrote: On 4/20/2023 5:07 PM, Dmitry Baryshkov wrote: On 21/04/2023 02:25, Kuogee

[PATCH 0/3] drm/msm/dpu: drop _sspp_subblk_offset()

2023-04-21 Thread Dmitry Baryshkov
Rework dpu_hw_sspp.c to access sblk base address directly rather than getting the sblk address through indirect function call. Dmitry Baryshkov (3): drm/msm/dpu: drop SSPP's SRC subblock drm/msm/dpu: access QSEED registers directly drm/msm/dpu: access CSC/CSC10 registers directly

[PATCH 3/3] drm/msm/dpu: access CSC/CSC10 registers directly

2023-04-21 Thread Dmitry Baryshkov
Stop using _sspp_subblk_offset() to get offset of the csc_blk. Inline this function and use ctx->cap->sblk->csc_blk.base directly. As this was the last user, drop _sspp_subblk_offset() too. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 43

[PATCH 1/3] drm/msm/dpu: drop SSPP's SRC subblock

2023-04-21 Thread Dmitry Baryshkov
The src_blk declares a lame copy of main SSPP register space. It's offset is always 0. It's length has been fixed to 0x150, while SSPP's length is now correct. Drop the src_blk and access SSPP registers without additional subblock lookup. Signed-off-by: Dmitry Baryshkov ---

[PATCH 2/3] drm/msm/dpu: access QSEED registers directly

2023-04-21 Thread Dmitry Baryshkov
Stop using _sspp_subblk_offset() to get offset of the scaler_blk. Inline this function and use ctx->cap->sblk->scaler_blk.base directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 27 +++-- 1 file changed, 9 insertions(+), 18 deletions(-)

Re: [PATCH v1 1/5] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-04-21 Thread Dmitry Baryshkov
On 21/04/2023 02:25, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 38 ++-

[PATCH v2 4/4] drm/i915/gsc: add support for GSC proxy interrupt

2023-04-21 Thread Daniele Ceraolo Spurio
The GSC notifies us of a proxy request via the HECI2 interrupt. The interrupt must be enabled both in the HECI layer and in our usual gt irq programming; for the latter, the interrupt is enabled via the same enable register as the GSC CS, but it does have its own mask register. When the interrupt

[PATCH v2 3/4] drm/i915/gsc: add initial support for GSC proxy

2023-04-21 Thread Daniele Ceraolo Spurio
The GSC uC needs to communicate with the CSME to perform certain operations. Since the GSC can't perform this communication directly on platforms where it is integrated in GT, i915 needs to transfer the messages from GSC to CSME and back. The proxy flow is as follow: 1 - i915 submits a request to

[PATCH v2 2/4] mei: gsc_proxy: add gsc proxy driver

2023-04-21 Thread Daniele Ceraolo Spurio
From: Alexander Usyskin Add GSC proxy driver. It to allows messaging between GSC component on Intel graphics card and CSE device. Cc: Alan Previn Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Acked-by: Greg Kroah-Hartman --- v2:

Re: [PATCH v3 1/9] drm/vc4: Switch to container_of_const

2023-04-21 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, > container_of_const() allows to preserve the pointer constness and is > thus more flexible than inline functions. > > Let's switch all our instances of container_of() to > container_of_const(). > > Signed-off-by: Maxime Ripard > --- [...] > -static inline

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Allow user to set cache at BO creation

2023-04-21 Thread Jordan Justen
On 2023-04-20 09:11:18, Yang, Fei wrote: > > On 20/04/2023 12:39, Andi Shyti wrote: > >> Hi Fei, > >> > >>> To comply with the design that buffer objects shall have immutable > >>> cache setting through out their life cycle, {set, get}_caching ioctl's > >>> are no longer supported from MTL onward.

[PATCH 1/2] drm/msm/dpu: remove DPU_DSPP_GC handling in dspp flush

2023-04-21 Thread Abhinav Kumar
Gamma correction blocks (GC) are not used today so lets remove the usage of DPU_DSPP_GC in the dspp flush to make it easier to remove GC from the catalog. We can add this back when GC is properly supported in DPU with one of the standard DRM properties. Signed-off-by: Abhinav Kumar ---

[PATCH 2/2] drm/msm/dpu: remove GC related code from dpu catalog

2023-04-21 Thread Abhinav Kumar
Since Gamma Correction (GC) block is currently unused, drop related code from the dpu hardware catalog otherwise this becomes a burden to carry across chipsets in the catalog. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 +---

[PATCH] drm/i915/guc: Actually return an error if GuC version range check fails

2023-04-21 Thread John . C . Harrison
From: John Harrison Dan Carpenter pointed out that 'err' was not being set in the case where the GuC firmware version range check fails. Fix that. Note that while this is bug fix for a previous patch (see Fixes tag below). It is an exceedingly low risk bug. The range check is asserting that the

Re: [PATCH v2 3/3] drm/msm/dpu: Pass catalog pointers directly from RM instead of IDs

2023-04-21 Thread Abhinav Kumar
On 4/21/2023 1:53 PM, Marijn Suijten wrote: The Resource Manager already iterates over all available blocks from the catalog, only to pass their ID to a dpu_hw_xxx_init() function which uses an _xxx_offset() helper to search for and find the exact same catalog pointer again to initialize the

  1   2   >