Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Christian König
Well first of all don't expose the VMID to userspace. The UMD doesn't know (and shouldn't know) which VMID is used for a submission since this is dynamically assigned and can change at any time. For debugging there is an interface to use an reserved VMID for your debugged process which

Re: [Intel-xe] [PATCH 02/14] drm/xe: Introduce the dev_coredump infrastructure.

2023-05-02 Thread Matthew Brost
On Thu, Apr 27, 2023 at 10:28:13AM +0200, Thomas Hellström wrote: > > On 4/26/23 22:57, Rodrigo Vivi wrote: > > The goal is to use devcoredump infrastructure to report error states > > captured at the crash time. > > > > The error state will contain useful information for GPU hang debug, such >

Re: [Intel-xe] [PATCH 13/14] drm/xe: Convert VM print to snapshot capture and print.

2023-05-02 Thread Matthew Brost
On Wed, Apr 26, 2023 at 04:57:12PM -0400, Rodrigo Vivi wrote: > The goal is to allow for a snapshot capture to be taken at the time > of the crash, while the print out can happen at a later time through > the exposed devcoredump virtual device. > > Signed-off-by: Rodrigo Vivi Also thinking out

[PATCH 00/11] MediaTek DDP GAMMA - 12-bit LUT support

2023-05-02 Thread AngeloGioacchino Del Regno
This series adds support for GAMMA IP requiring and/or supporting a 12-bits LUT using a slightly different register layout and programming sequence for multiple LUT banks: this IP version is currently found on a number of SoCs, not only including the Chromebook/IoT oriented Kompanio 1200/1380

[PATCH 01/11] drm/mediatek: gamma: Adjust mtk_drm_gamma_set_common parameters

2023-05-02 Thread AngeloGioacchino Del Regno
From: "Jason-JH.Lin" Adjust the parameters in mtk_drm_gamma_set_common() - add (struct device *dev) to get lut_diff from gamma's driver data - remove (bool lut_diff) and use false as default value in the function Signed-off-by: Jason-JH.Lin Signed-off-by: AngeloGioacchino Del Regno ---

Re: [PATCH V3 0/7] drm: bridge: samsung-dsim: Support variable clocking

2023-05-02 Thread Marek Szyprowski
On 02.05.2023 03:07, Adam Ford wrote: > This series fixes the blanking pack size and the PMS calculation. It then > adds support to allows the DSIM to dynamically DPHY clocks, and support > non-burst mode while allowing the removal of the hard-coded clock values > for the PLL for imx8m

Re: [PATCH v2 1/8] drm: Disable the cursor plane on atomic contexts with virtualized drivers

2023-05-02 Thread Javier Martinez Canillas
Daniel Vetter writes: > On Mon, Jul 11, 2022 at 11:32:39PM -0400, Zack Rusin wrote: >> From: Zack Rusin >> >> Cursor planes on virtualized drivers have special meaning and require >> that the clients handle them in specific ways, e.g. the cursor plane >> should react to the mouse movement the

Re: [PATCH 07/14] drm/xe: Introduce guc_submit_types.h with relevant structs.

2023-05-02 Thread Matthew Brost
On Wed, Apr 26, 2023 at 04:57:06PM -0400, Rodrigo Vivi wrote: > These structs and definitions are only used for the guc_submit > and they were added specifically for the parallel submission. > > While doing that also delete the unused struct guc_wq_item. > > Cc: Matthew Brost > Signed-off-by:

Re: [Intel-xe] [PATCH 02/14] drm/xe: Introduce the dev_coredump infrastructure.

2023-05-02 Thread Jani Nikula
On Wed, 26 Apr 2023, Rodrigo Vivi wrote: > + drm_info(>drm, "Check your > /sys/class/drm/card/device/devcoredump/data\n"); Drive-by comment, could use %d and xe->drm.primary->index instead of . BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center

Re: [PATCH V3 0/7] drm: bridge: samsung-dsim: Support variable clocking

2023-05-02 Thread Chen-Yu Tsai
On Tue, May 2, 2023 at 9:08 AM Adam Ford wrote: > > This series fixes the blanking pack size and the PMS calculation. It then > adds support to allows the DSIM to dynamically DPHY clocks, and support > non-burst mode while allowing the removal of the hard-coded clock values > for the PLL for

Re: [PATCH v6 06/15] drm/msm/a6xx: Introduce GMU wrapper support

2023-05-02 Thread Akhil P Oommen
On Sat, Apr 01, 2023 at 01:54:43PM +0200, Konrad Dybcio wrote: > Some (particularly SMD_RPM, a.k.a non-RPMh) SoCs implement A6XX GPUs > but don't implement the associated GMUs. This is due to the fact that > the GMU directly pokes at RPMh. Sadly, this means we have to take care > of enabling &

Re: [Intel-xe] [PATCH 00/14] Introduce xe_devcoredump.

2023-05-02 Thread Matthew Brost
On Wed, Apr 26, 2023 at 04:56:59PM -0400, Rodrigo Vivi wrote: > Xe needs to align with other drivers on the way that the error states are > dumped, avoiding a Xe only error_state solution. The goal is to use > devcoredump > infrastructure to report error states, since it produces a standardized

Re: [Intel-gfx] [PATCH 1/2] drm/dsc: fix drm_edp_dsc_sink_output_bpp() DPCD high byte usage

2023-05-02 Thread Jani Nikula
On Thu, 20 Apr 2023, "Nautiyal, Ankit K" wrote: > LGTM. > > Reviewed-by: Ankit Nautiyal Thanks for the reviews, pushed these a week+ ago. BR, Jani. > > On 4/6/2023 7:16 PM, Jani Nikula wrote: >> The operator precedence between << and & is wrong, leading to the high >> byte being completely

[PATCH 07/11] drm/mediatek: gamma: Support specifying number of bits per LUT component

2023-05-02 Thread AngeloGioacchino Del Regno
New SoCs, like MT8195, not only may support bigger lookup tables, but have got a different register layout to support bigger precision: support specifying the number of `lut_bits` for each SoC and use it in mtk_gamma_set_common() to perform the right calculation. Signed-off-by: AngeloGioacchino

[PATCH 10/11] drm/mediatek: gamma: Make sure relay mode is disabled

2023-05-02 Thread AngeloGioacchino Del Regno
Disable relay mode at the end of LUT programming to make sure that the processed image goes through. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c

[PATCH 09/11] drm/mediatek: gamma: Add support for 12-bit LUT and MT8195

2023-05-02 Thread AngeloGioacchino Del Regno
Add support for 12-bit gamma lookup tables and introduce the first user for it: MT8195. While at it, also reorder the variables in mtk_gamma_set_common() and rename `lut_base` to `lut0_base` to improve readability. Signed-off-by: AngeloGioacchino Del Regno ---

[PATCH 11/11] drm/mediatek: gamma: Program gamma LUT type for descending or rising

2023-05-02 Thread AngeloGioacchino Del Regno
All of the SoCs that don't have dithering control in the gamma IP have got a GAMMA_LUT_TYPE bit that tells to the IP if the LUT is "descending" (bit set) or "rising" (bit cleared): make sure to set it correctly after programming the LUT. Signed-off-by: AngeloGioacchino Del Regno ---

[PATCH 05/11] drm/mediatek: gamma: Enable the Gamma LUT table only after programming

2023-05-02 Thread AngeloGioacchino Del Regno
Move the write to DISP_GAMMA_CFG to enable the Gamma LUT to after programming the actual table to avoid potential visual glitches during table modification. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 13 - 1 file changed, 8

[PATCH 06/11] drm/mediatek: gamma: Use bitfield macros

2023-05-02 Thread AngeloGioacchino Del Regno
Make the code more robust and improve readability by using bitfield macros instead of open coding bit operations. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 40 ++- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git

[PATCH 08/11] drm/mediatek: gamma: Support multi-bank gamma LUT

2023-05-02 Thread AngeloGioacchino Del Regno
Newer Gamma IP have got multiple LUT banks: support specifying the size of the LUT banks and handle bank-switching before programming the LUT in mtk_gamma_set_common() in preparation for adding support for MT8195 and newer SoCs. Suggested-by: Jason-JH.Lin [Angelo: Refactored original commit]

[PATCH 03/11] drm/mediatek: gamma: Support SoC specific LUT size

2023-05-02 Thread AngeloGioacchino Del Regno
Newer SoCs support a bigger Gamma LUT table: wire up a callback to retrieve the correct LUT size for each different Gamma IP. Co-developed-by: Jason-JH.Lin Signed-off-by: Jason-JH.Lin [Angelo: Rewritten commit message/description + porting] Signed-off-by: AngeloGioacchino Del Regno ---

[PATCH 04/11] drm/mediatek: gamma: Improve and simplify HW LUT calculation

2023-05-02 Thread AngeloGioacchino Del Regno
Use drm_color_lut_extract() to avoid open-coding the bits reduction calculations for each color channel and use a struct drm_color_lut to temporarily store the information instead of an array of u32. Also, slightly improve the precision of the HW LUT calculation in the LUT DIFF case by performing

[PATCH 02/11] drm/mediatek: gamma: Reduce indentation in mtk_gamma_set_common()

2023-05-02 Thread AngeloGioacchino Del Regno
Invert the check for state->gamma_lut and move it at the beginning of the function to reduce indentation: this prepares the code for keeping readability on later additions. This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno ---

Re: [PATCH v6 06/15] drm/msm/a6xx: Introduce GMU wrapper support

2023-05-02 Thread Konrad Dybcio
On 2.05.2023 09:49, Akhil P Oommen wrote: > On Sat, Apr 01, 2023 at 01:54:43PM +0200, Konrad Dybcio wrote: >> Some (particularly SMD_RPM, a.k.a non-RPMh) SoCs implement A6XX GPUs >> but don't implement the associated GMUs. This is due to the fact that >> the GMU directly pokes at RPMh. Sadly,

Re: [Freedreno] [PATCH 3/9] drm/msm/dpu: fix the condition for (not) applying QoS to CURSOR SSPP

2023-05-02 Thread Jeykumar Sankaran
On 4/30/2023 1:57 PM, Dmitry Baryshkov wrote: The function dpu_plane_sspp_update_pipe() contains code to skip enabling the QoS and OT limitis for CURSOR pipes. However all DPU since sdm845 repurpose DMA SSPP for the cursor planes because they lack the real CURSOR SSPP. Fix the condition to

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Felix Richter
On 01.05.23 20:47, Alex Deucher wrote: On Mon, May 1, 2023 at 2:44 PM Felix Richter wrote: On 01.05.23 15:27, Alex Deucher wrote: On Mon, May 1, 2023 at 3:20 AM Felix Richter wrote: Hi, I am running into an issue with the integrated GPU of the Ryzen 9 7950X. It seems to be a regression

Re: [Freedreno] [PATCH 2/9] drm/msm/dpu: simplify CDP programming

2023-05-02 Thread Jeykumar Sankaran
On 4/30/2023 1:57 PM, Dmitry Baryshkov wrote: Get rid of intermediatory configuration structure and defines. Pass the format and the enablement bit directly to the new helper. The WB_CDP_CNTL register ignores BIT(2), so we can write it for both SSPP and WB CDP settings. Signed-off-by: Dmitry

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Felix Richter
On 01.05.23 15:27, Alex Deucher wrote: On Mon, May 1, 2023 at 3:20 AM Felix Richter wrote: Hi, I am running into an issue with the integrated GPU of the Ryzen 9 7950X. It seems to be a regression from kernel version 6.1 to 6.2. The bug materializes in from of my monitor blinking, meaning it

[PATCH v3] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-05-02 Thread Arseniy Krasnov
This adds support for OTP area access on MX30LFxG18AC chip series. Changelog: v1 -> v2: * Add slab.h include due to kernel test robot error. v2 -> v3: * Use 'uint64_t' as input argument for 'do_div()' instead of 'unsigned long' due to kernel test robot error. Signed-off-by: Arseniy

Re: [PATCH v4 1/3] dt-bindings: display: panel: Add Samsung S6D7AA0 LCD panel controller

2023-05-02 Thread Krzysztof Kozlowski
On 01/05/2023 20:51, Artur Weber wrote: > Add bindings for the S6D7AA0 LCD panel controller, including the > S6D7AA0-LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family > of tablets, and the S6D7AA0-LSL080AL03 and S6D7AA0-LTL101AT01 panels > used in the Samsung Galaxy Tab A 8.0 and 9.7

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Christian König
Am 02.05.23 um 03:26 schrieb André Almeida: Em 01/05/2023 16:24, Alex Deucher escreveu: On Mon, May 1, 2023 at 2:58 PM André Almeida wrote: I know that devcoredump is also used for this kind of information, but I believe that using an IOCTL is better for interfacing Mesa + Linux rather

Re: [PATCH v2 8/9] drm/fdinfo: Add comm/cmdline override fields

2023-05-02 Thread Tvrtko Ursulin
On 01/05/2023 17:58, Rob Clark wrote: On Fri, Apr 28, 2023 at 4:05 AM Tvrtko Ursulin wrote: On 27/04/2023 18:53, Rob Clark wrote: From: Rob Clark These are useful in particular for VM scenarios where the process which has opened to drm device file is just a proxy for the real user in a

Re: [Intel-xe] [PATCH 13/14] drm/xe: Convert VM print to snapshot capture and print.

2023-05-02 Thread Matthew Brost
On Wed, Apr 26, 2023 at 04:57:12PM -0400, Rodrigo Vivi wrote: > The goal is to allow for a snapshot capture to be taken at the time > of the crash, while the print out can happen at a later time through > the exposed devcoredump virtual device. > > Signed-off-by: Rodrigo Vivi This is an example

Re: [PATCH v2 5/9] drm: Add fdinfo memory stats

2023-05-02 Thread Tvrtko Ursulin
On 28/04/2023 15:45, Rob Clark wrote: On Fri, Apr 28, 2023 at 3:56 AM Tvrtko Ursulin wrote: On 27/04/2023 18:53, Rob Clark wrote: From: Rob Clark Add support to dump GEM stats to fdinfo. v2: Fix typos, change size units to match docs, use div_u64 v3: Do it in core v4: more kerneldoc

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Bas Nieuwenhuizen
On Tue, May 2, 2023 at 11:12 AM Timur Kristóf wrote: > > Hi Christian, > > Christian König ezt írta (időpont: 2023. máj. 2., > Ke 9:59): >> >> Am 02.05.23 um 03:26 schrieb André Almeida: >> > Em 01/05/2023 16:24, Alex Deucher escreveu: >> >> On Mon, May 1, 2023 at 2:58 PM André Almeida >> >>

[PATCH v9 1/5] drm: Place Renesas drivers in a separate dir

2023-05-02 Thread Biju Das
Create vendor specific renesas directory and move renesas drivers to that directory. Signed-off-by: Biju Das Acked-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- v8->v9: * Added Rb tag from Laurent and Acked-by tag from Kieran. v8: * New patch --- MAINTAINERS

[PATCH v9 2/5] dt-bindings: display: Document Renesas RZ/G2L DU bindings

2023-05-02 Thread Biju Das
The RZ/G2L LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). The DU module supports the following hardware features − Display Parallel Interface (DPI) and MIPI LINK Video Interface − Display timing master − Generates video

[PATCH v9 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2023-05-02 Thread Biju Das
RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), Video signal processor (VSPD) and Display unit(DU). The output of LCDC is connected to Display parallel interface and MIPI link video interface. The output from DSI is connected to ADV7535. Created a vendor specific directory

[PATCH v2 1/2] dt-bindings: display: novatek,nt35950: define ports

2023-05-02 Thread Krzysztof Kozlowski
The panel-common schema does not define what "ports" property is, so bring the definition to enforce the type. Panels can be single- or dual-link, thus require only one port@0. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Rework to add ports to device schema, not to

[PATCH v2 2/2] dt-bindings: display: novatek,nt36523: define ports

2023-05-02 Thread Krzysztof Kozlowski
The panel-common schema does not define what "ports" property is, so bring the definition to enforce the type. All panels described by binding are dual-link, thus require both ports. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Rework to add ports to device schema, not to

Re: drm/sched: Replacement for drm_sched_resubmit_jobs() is deprecated

2023-05-02 Thread Boris Brezillon
Hi Christian, Thanks for your quick reply. On Tue, 2 May 2023 13:36:07 +0200 Christian König wrote: > Hi Boris, > > Am 02.05.23 um 13:19 schrieb Boris Brezillon: > > Hello Christian, Alex, > > > > As part of our transition to drm_sched for the powervr GPU driver, we > > realized

Re: [PATCH] drm/udl: delete dead code

2023-05-02 Thread Thomas Zimmermann
Hi Am 02.05.23 um 14:59 schrieb Dan Carpenter: The "unode" pointer cannot be NULL here and checking for it causes Smatch warnings: drivers/gpu/drm/udl/udl_main.c:259 udl_get_urb_locked() warn: can 'unode' even be NULL? Fortunately, it's just harmless dead code which can be removed.

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Alex Deucher
On Tue, May 2, 2023 at 7:45 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > [CCing the regression list, as it should be in the loop for regressions: > https://docs.kernel.org/admin-guide/reporting-regressions.html] > > [TLDR: I'm adding this report to the list of tracked Linux kernel

[PATCH v9 3/5] dt-bindings: display: renesas, rzg2l-du: Document RZ/V2L DU bindings

2023-05-02 Thread Biju Das
Document DU found in RZ/V2L SoC. The DU block is identical to RZ/G2L SoC and therefore use RZ/G2L fallback to avoid any driver changes. Signed-off-by: Biju Das Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven --- V8->v9: * Added Rb tag from Laurent and

Re: [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example

2023-05-02 Thread Daniel Thompson
On Sat, Apr 29, 2023 at 12:02:46AM +0800, Jianhua Lu wrote: > The kinetic,ktz8866 is a I2C driver, so add the missing reg property. > And update example to make it clear. > > Signed-off-by: Jianhua Lu Reviewed-by: Daniel Thompson

[PATCH] drm/udl: delete dead code

2023-05-02 Thread Dan Carpenter
The "unode" pointer cannot be NULL here and checking for it causes Smatch warnings: drivers/gpu/drm/udl/udl_main.c:259 udl_get_urb_locked() warn: can 'unode' even be NULL? Fortunately, it's just harmless dead code which can be removed. It's left over from commit c5c354a3a472 ("drm/udl:

Re: [PATCH 06/11] drm/mediatek: gamma: Use bitfield macros

2023-05-02 Thread kernel test robot
-mediatek-gamma-Adjust-mtk_drm_gamma_set_common-parameters/20230502-161758 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20230502081650.25947-7-angelogioacchino.delregno%40collabora.com patch subject: [PATCH 06/11] drm/mediatek: gamma: Use

[PATCH v9 5/5] MAINTAINERS: Add maintainer for RZ DU drivers

2023-05-02 Thread Biju Das
Add my self as maintainer for RZ DU drivers. While at it, update the entries for common parts, rcar-du and shmobile. Signed-off-by: Biju Das Reviewed-by: Laurent Pinchart --- v8->v9: * Added Rb tag from Laurent. * Updated entries for common parts(Makefile and Kconfig). v8: * New patch ---

[PATCH v9 4/5] drm: Add RZ/G2L DU Support

2023-05-02 Thread Biju Das
The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). It has DPI/DSI interfaces and supports a maximum resolution of 1080p along with 2 RPFs to support the blending of two picture layers and raster operations (ROPs). The DU

[PATCH v9 RESEND 4/5] drm: Add RZ/G2L DU Support

2023-05-02 Thread Biju Das
The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). It has DPI/DSI interfaces and supports a maximum resolution of 1080p along with 2 RPFs to support the blending of two picture layers and raster operations (ROPs). The DU

[PATCH v9 RESEND 5/5] MAINTAINERS: Add maintainer for RZ DU drivers

2023-05-02 Thread Biju Das
Add my self as maintainer for RZ DU drivers. While at it, update the entries for common parts, rcar-du and shmobile. Signed-off-by: Biju Das Reviewed-by: Laurent Pinchart --- v8->v9: * Added Rb tag from Laurent. * Updated entries for common parts(Makefile and Kconfig). v8: * New patch ---

[PATCH v9 RESEND 1/5] drm: Place Renesas drivers in a separate dir

2023-05-02 Thread Biju Das
Create vendor specific renesas directory and move renesas drivers to that directory. Signed-off-by: Biju Das Acked-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- v8->v9: * Added Rb tag from Laurent and Acked-by tag from Kieran. v8: * New patch --- MAINTAINERS

[PATCH v9 RESEND 2/5] dt-bindings: display: Document Renesas RZ/G2L DU bindings

2023-05-02 Thread Biju Das
The RZ/G2L LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). The DU module supports the following hardware features − Display Parallel Interface (DPI) and MIPI LINK Video Interface − Display timing master − Generates video

[PATCH v9 RESEND 0/5] Add RZ/{G2L, G2LC} and RZ/V2L Display Unit support

2023-05-02 Thread Biju Das
RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), Video signal processor (VSPD) and Display unit(DU). The output of LCDC is connected to Display parallel interface and MIPI link video interface. The output from DSI is connected to ADV7535. Created a vendor specific directory

[PATCH v9 RESEND 3/5] dt-bindings: display: renesas, rzg2l-du: Document RZ/V2L DU bindings

2023-05-02 Thread Biju Das
Document DU found in RZ/V2L SoC. The DU block is identical to RZ/G2L SoC and therefore use RZ/G2L fallback to avoid any driver changes. Signed-off-by: Biju Das Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven --- V8->v9: * Added Rb tag from Laurent and

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Christian König
Hi Timur, Am 02.05.23 um 11:12 schrieb Timur Kristóf: Hi Christian, Christian König ezt írta (időpont: 2023. máj. 2., Ke 9:59): Am 02.05.23 um 03:26 schrieb André Almeida: > Em 01/05/2023 16:24, Alex Deucher escreveu: >> On Mon, May 1, 2023 at 2:58 PM André Almeida >>

drm/sched: Replacement for drm_sched_resubmit_jobs() is deprecated

2023-05-02 Thread Boris Brezillon
Hello Christian, Alex, As part of our transition to drm_sched for the powervr GPU driver, we realized drm_sched_resubmit_jobs(), which is used by all drivers relying on drm_sched right except amdgpu, has been deprecated. Unfortunately, commit 5efbe6aa7a0e ("drm/scheduler: deprecate

[PATCH v3 6/6] fbdev: Rename fb_mem*() helpers

2023-05-02 Thread Thomas Zimmermann
Update the names of the fb_mem*() helpers to be consistent with their regular counterparts. Hence, fb_memset() now becomes fb_memset_io(), fb_memcpy_fromfb() now becomes fb_memcpy_fromio() and fb_memcpy_tofb() becomes fb_memcpy_toio(). No functional changes. Signed-off-by: Thomas Zimmermann ---

[PATCH v3 3/6] fbdev: Include in various drivers

2023-05-02 Thread Thomas Zimmermann
The code uses writel() and similar I/O-memory helpers. Include the header file to get the declarations. Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg --- drivers/video/fbdev/arcfb.c | 1 + drivers/video/fbdev/aty/atyfb.h | 2 ++ drivers/video/fbdev/wmt_ge_rops.c | 2 ++ 3

[PATCH v3 4/6] fbdev: Include via

2023-05-02 Thread Thomas Zimmermann
Fbdev's main header file, , includes to get declarations for I/O helper functions. From these declarations, it later defines framebuffer I/O helpers, such as fb_{read,write}[bwlq]() or fb_memset(). The framebuffer I/O helpers depend on the system architecture and will therefore be moved into .

[PATCH v3 2/6] ipu-v3: Include

2023-05-02 Thread Thomas Zimmermann
The code uses readl() and writel(). Include the header file to get the declarations. Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg --- drivers/gpu/ipu-v3/ipu-prv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/ipu-v3/ipu-prv.h b/drivers/gpu/ipu-v3/ipu-prv.h index

[PATCH v3 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-02 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg --- drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++--- drivers/video/fbdev/matrox/matroxfb_base.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-02 Thread Thomas Zimmermann
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), in the architecture's header file or the generic one. The common case has been the use of regular I/O functions, such as __raw_readb() or memset_io(). A few architectures used plain system- memory reads and writes. Sparc used

[PATCH v3 0/6] fbdev: Move framebuffer I/O helpers to

2023-05-02 Thread Thomas Zimmermann
(was: fbdev: Use regular I/O function for framebuffers) Fbdev provides helpers for framebuffer I/O, such as fb_readl(), fb_writel() or fb_memcpy_to_fb(). The implementation of each helper depends on the architecture, but they are all equivalent to regular I/O functions of similar names. So use

RE: [PATCH v9 5/5] MAINTAINERS: Add maintainer for RZ DU drivers

2023-05-02 Thread Biju Das
> -Original Message- > From: Biju Das > Sent: Tuesday, May 2, 2023 10:56 AM > To: David Airlie ; Daniel Vetter ; Geert > Uytterhoeven ; Laurent Pinchart > ; Krzysztof Kozlowski > > Cc: Biju Das ; Fabrizio Castro > ; Prabhakar Mahadev Lad lad...@bp.renesas.com>;

Re: drm/sched: Replacement for drm_sched_resubmit_jobs() is deprecated

2023-05-02 Thread Christian König
Hi Boris, Am 02.05.23 um 13:19 schrieb Boris Brezillon: Hello Christian, Alex, As part of our transition to drm_sched for the powervr GPU driver, we realized drm_sched_resubmit_jobs(), which is used by all drivers relying on drm_sched right except amdgpu, has been deprecated. Unfortunately,

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Linux regression tracking (Thorsten Leemhuis)
[CCing the regression list, as it should be in the loop for regressions: https://docs.kernel.org/admin-guide/reporting-regressions.html] [TLDR: I'm adding this report to the list of tracked Linux kernel regressions; the text you find below is based on a few templates paragraphs you might have

Re: [PATCH] drm/amd/display: mark amdgpu_dm_connector_funcs_force static

2023-05-02 Thread Hamza Mahfooz
On 5/1/23 10:31, Arnd Bergmann wrote: From: Arnd Bergmann A global function without a header prototype has made it into linux-next during the merge window: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6339:6: error: no previous prototype for 'amdgpu_dm_connector_funcs_force'

Re: [PATCH v2 2/2] dt-bindings: display: novatek,nt36523: define ports

2023-05-02 Thread Jianhua Lu
On Tue, May 02, 2023 at 02:00:36PM +0200, Krzysztof Kozlowski wrote: > description: regulator that supplies the I/O voltage [..] > > + ports: > +$ref: /schemas/graph.yaml#/properties/ports > + > +required: > + - port@0 > + - port@1 Konrad has added a single DSI panel to

Re: [PATCH v2 2/2] dt-bindings: display: novatek,nt36523: define ports

2023-05-02 Thread Krzysztof Kozlowski
On 02/05/2023 14:44, Jianhua Lu wrote: > On Tue, May 02, 2023 at 02:00:36PM +0200, Krzysztof Kozlowski wrote: >> description: regulator that supplies the I/O voltage > [..] >> >> + ports: >> +$ref: /schemas/graph.yaml#/properties/ports >> + >> +required: >> + - port@0 >> +

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Alex Deucher
On Tue, May 2, 2023 at 9:34 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > On 02.05.23 15:13, Alex Deucher wrote: > > On Tue, May 2, 2023 at 7:45 AM Linux regression tracking (Thorsten > > Leemhuis) wrote: > > > >> On 30.04.23 13:44, Felix Richter wrote: > >>> Hi, > >>> > >>> I am

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Linux regression tracking (Thorsten Leemhuis)
On 02.05.23 15:48, Felix Richter wrote: > On 5/2/23 15:34, Linux regression tracking (Thorsten Leemhuis) wrote: >> On 02.05.23 15:13, Alex Deucher wrote: >>> On Tue, May 2, 2023 at 7:45 AM Linux regression tracking (Thorsten >>> Leemhuis) wrote: >>> On 30.04.23 13:44, Felix Richter wrote:

[PATCH 07/11] drm/i915: Split some long lines

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä Split some overly long lines. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fdi.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c b/drivers/gpu/drm/i915/display/intel_fdi.c index

[PATCH 05/11] drm/i915: Check lane count when determining FEC support

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä ICL doesn't support FEC with a x1 DP link. Make sure we don't try to enable FEC in such cases. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git

[PATCH 06/11] drm/i915: Fix FEC state dump

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä Stop dumping state while reading it out. We have a proper place for that stuff. Signed-off-by: Ville Syrjälä --- .../gpu/drm/i915/display/intel_crtc_state_dump.c| 2 ++ drivers/gpu/drm/i915/display/intel_ddi.c| 13 +++-- 2 files changed, 5

[PATCH 11/11] drm/i915: Reduce combo PHY log spam

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä We always check whether combo PHYs need to be re-initialized after disabling DC states, which leads to log spam. Switch things around so that we only log something when we actually have to re-initialized a PHY. The log spam was exacerbated by commit 41b4c7fe72b6 ("drm/i915:

[PATCH 08/11] drm/i915: Introduce crtc_state->enhanced_framing

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä Track DP enhanced framing properly in the crtc state instead of relying just on the cached DPCD everywhere, and hook it up into the state check and dump. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/g4x_dp.c | 10 --

[PATCH 04/11] drm/i915: Fix FEC pipe A vs. DDI A mixup

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä On pre-TGL FEC is a port level feature, not a transcoder level features, and it's DDI A which doesn't have it, not trancodere A. Check for the correct thing when determining whether FEC is supported or not. Signed-off-by: Ville Syrjälä ---

[PATCH 09/11] drm/i915: Stop spamming the logs with PLL state

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä encoder->get_config() is not the place where the state should be dumped. Get rid of the spam. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c

[PATCH 10/11] drm/i915: Drop some redundant eDP checks

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä There's no need to check for both eDP and fixed_mode when deciding whether to do the pfit calculations or not. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2] phy: mediatek: rework the floating point comparisons to fixed point

2023-05-02 Thread Tom Rix
gcc on aarch64 reports drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c: In function ‘mtk_hdmi_pll_set_rate’: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:240:52: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 240 | else if (tmds_clk >= 54 * MEGA && tmds_clk

[PATCH v2 4/9] drm/msm/dpu: rearrange QoS setting code

2023-05-02 Thread Dmitry Baryshkov
Slightly rearrainge code in dpu_plane_sspp_update_pipe() to group QoS/LUT related functions. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

[PATCH v2 2/9] drm/msm/dpu: simplify CDP programming

2023-05-02 Thread Dmitry Baryshkov
Get rid of intermediatory configuration structure and defines. Pass the format and the enablement bit directly to the new helper. The WB_CDP_CNTL register ignores BIT(2), so we can write it for both SSPP and WB CDP settings. Signed-off-by: Dmitry Baryshkov ---

[PATCH v2 9/9] drm/msm/dpu: use common helper for WB and SSPP QoS setup

2023-05-02 Thread Dmitry Baryshkov
Rework SSPP and WB code to use common helper for programming QoS settings. Signed-off-by: Dmitry Baryshkov --- .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 4 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 31 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 19 +

[PATCH v2 7/9] drm/msm/dpu: drop DPU_PLANE_QOS_PANIC_CTRL

2023-05-02 Thread Dmitry Baryshkov
This flag is always passed to _dpu_plane_set_qos_ctrl(), so drop it and remove corresponding conditions from the mentioned function. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 27 +++ 1 file changed, 8 insertions(+), 19 deletions(-) diff

[PATCH v2 5/9] drm/msm/dpu: drop DPU_PLANE_QOS_VBLANK_CTRL

2023-05-02 Thread Dmitry Baryshkov
Drop support for DPU_PLANE_QOS_VBLANK_CTRL flag. It is not used both in upstream driver and in vendor SDE driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c| 8

Re: [PATCH 09/14] drm/xe: Add GuC Submit Engine snapshot to xe_devcoredump.

2023-05-02 Thread Matthew Brost
On Wed, Apr 26, 2023 at 04:57:08PM -0400, Rodrigo Vivi wrote: > Let's start to move our existent logs to devcoredump one by > one. Any format change should come on follow-up work. > > Signed-off-by: Rodrigo Vivi Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/xe/xe_devcoredump.c | 7

[PATCH v2 8/9] drm/msm/dpu: remove struct dpu_hw_pipe_qos_cfg

2023-05-02 Thread Dmitry Baryshkov
Now as the struct dpu_hw_pipe_qos_cfg consists of only one bool field, drop the structure and use corresponding bool directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 10 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 13 ++---

[PATCH v2 6/9] drm/msm/dpu: simplify qos_ctrl handling

2023-05-02 Thread Dmitry Baryshkov
After removal of DPU_PLANE_QOS_VBLANK_CTRL, several fields of struct dpu_hw_pipe_qos_cfg are fixed to false/0. Drop them from the structure (and drop the corresponding code from the functions). The DPU_PLANE_QOS_VBLANK_AMORTIZE flag is also removed, since it is now a NOP. Signed-off-by: Dmitry

[PATCH v2 1/9] drm/msm/dpu: fix SSPP register definitions

2023-05-02 Thread Dmitry Baryshkov
Reorder SSPP register definitions to sort them in the ascending order. Move register bitfields after the register definitions. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 66 +++-- 1 file changed, 34 insertions(+), 32 deletions(-) diff

[PATCH v2 3/9] drm/msm/dpu: fix the condition for (not) applying QoS to CURSOR SSPP

2023-05-02 Thread Dmitry Baryshkov
The function dpu_plane_sspp_update_pipe() contains code to skip enabling the QoS and OT limitis for CURSOR pipes. However all DPU since sdm845 repurpose DMA SSPP for the cursor planes because they lack the real CURSOR SSPP. Fix the condition to actually check that the plane is CURSOR or not.

[PATCH v2 0/9] drm/msm/dpu: simplify QoS/CDP programming

2023-05-02 Thread Dmitry Baryshkov
Merge SSPP and WB code programming QoS and CDP. This allows us to drop intermediate structures and duplicate code. Changes since v1: - Fixed kerneldoc for _dpu_plane_set_qos_ctrl() - Fixed danger_safe_en programming conditions (Jeykumar) - Simplified the code surrounding setup_cdp() calls

[PATCH v2] drm/i915/huc: Parse the GSC-enabled HuC binary

2023-05-02 Thread Daniele Ceraolo Spurio
The new binaries that support the 2-step authentication have contain the legacy-style binary, which we can use for loading the HuC via DMA. To find out where this is located in the image, we need to parse the meu manifest of the GSC binary. The manifest consist of a partition header followed by

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-05-02 Thread Linux regression tracking (Thorsten Leemhuis)
On 02.05.23 15:13, Alex Deucher wrote: > On Tue, May 2, 2023 at 7:45 AM Linux regression tracking (Thorsten > Leemhuis) wrote: > >> On 30.04.23 13:44, Felix Richter wrote: >>> Hi, >>> >>> I am running into an issue with the integrated GPU of the Ryzen 9 7950X. It >>> seems to be a regression

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-02 Thread Alex Deucher
On Tue, May 2, 2023 at 9:35 AM Timur Kristóf wrote: > > Hi, > > On Tue, 2023-05-02 at 13:14 +0200, Christian König wrote: > > > > > > Christian König ezt írta (időpont: 2023. > > > máj. 2., Ke 9:59): > > > > > > > Am 02.05.23 um 03:26 schrieb André Almeida: > > > > > Em 01/05/2023 16:24, Alex

Re: [PATCH] drm/udl: delete dead code

2023-05-02 Thread Takashi Iwai
On Tue, 02 May 2023 14:59:56 +0200, Dan Carpenter wrote: > > The "unode" pointer cannot be NULL here and checking for it causes > Smatch warnings: > >drivers/gpu/drm/udl/udl_main.c:259 udl_get_urb_locked() >warn: can 'unode' even be NULL? > > Fortunately, it's just harmless dead code

Re: [PATCH 06/14] drm/xe: Add GuC CT snapshot to xe_devcoredump.

2023-05-02 Thread Matthew Brost
On Wed, Apr 26, 2023 at 04:57:05PM -0400, Rodrigo Vivi wrote: > Let's start to move our existent logs to devcoredump one by > one. Any format change should come on follow-up work. > > Signed-off-by: Rodrigo Vivi Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/xe/xe_devcoredump.c |

Re: [Freedreno] [PATCH 3/9] drm/msm/dpu: fix the condition for (not) applying QoS to CURSOR SSPP

2023-05-02 Thread Dmitry Baryshkov
On 02/05/2023 03:56, Jeykumar Sankaran wrote: On 4/30/2023 1:57 PM, Dmitry Baryshkov wrote: The function dpu_plane_sspp_update_pipe() contains code to skip enabling the QoS and OT limitis for CURSOR pipes. However all DPU since sdm845 repurpose DMA SSPP for the cursor planes because they lack

Re: [Intel-xe] [PATCH 08/14] drm/xe: Convert GuC Engine print to snapshot capture and print.

2023-05-02 Thread Matthew Brost
On Wed, Apr 26, 2023 at 04:57:07PM -0400, Rodrigo Vivi wrote: > The goal is to allow for a snapshot capture to be taken at the time > of the crash, while the print out can happen at a later time through > the exposed devcoredump virtual device. > > Signed-off-by: Rodrigo Vivi > --- >

Re: [PATCH 3/4] ARM/mmc: Convert old mmci-omap to GPIO descriptors

2023-05-02 Thread Ulf Hansson
On Sun, 30 Apr 2023 at 11:22, Linus Walleij wrote: > > A recent change to the OMAP driver making it use a dynamic GPIO > base created problems with some old OMAP1 board files, among > them Nokia 770, SX1 and also the OMAP2 Nokia n8x0. > > Fix up all instances of GPIOs being used for the MMC

  1   2   >