Re: [PATCH v4 09/30] drm/dp: Add helpers to calculate the link BW overhead

2023-11-06 Thread Imre Deak
On Mon, Nov 06, 2023 at 11:31:51PM +0200, Ville Syrjälä wrote: > On Mon, Oct 30, 2023 at 05:58:22PM +0200, Imre Deak wrote: > > Add helpers drivers can use to calculate the BW allocation overhead - > > due to SSC, FEC, DSC and data alignment on symbol cycles - and the > > channel coding efficiency

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Mina Almasry
On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev wrote: > > On 11/06, Mina Almasry wrote: > > On Mon, Nov 6, 2023 at 1:59 PM Stanislav Fomichev wrote: > > > > > > On 11/06, Mina Almasry wrote: > > > > On Mon, Nov 6, 2023 at 11:34 AM David Ahern wrote: > > > > > > > > > > On 11/6/23 11:47 AM,

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread Willem de Bruijn
On Mon, Nov 6, 2023 at 3:55 PM David Ahern wrote: > > On 11/6/23 4:32 PM, Stanislav Fomichev wrote: > >> The concise notification API returns tokens as a range for > >> compression, encoding as two 32-bit unsigned integers start + length. > >> It allows for even further batching by returning

[PATCH v5 09/30] drm/dp: Add helpers to calculate the link BW overhead

2023-11-06 Thread Imre Deak
Add helpers drivers can use to calculate the BW allocation overhead - due to SSC, FEC, DSC and data alignment on symbol cycles - and the channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On 128b/132b links the FEC overhead is part of the coding efficiency, so not accounted for in

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Stanislav Fomichev
On 11/06, Stanislav Fomichev wrote: > On 11/06, Willem de Bruijn wrote: > > On Mon, Nov 6, 2023 at 3:55 PM Stanislav Fomichev wrote: > > > > > > On Mon, Nov 6, 2023 at 3:27 PM Mina Almasry > > > wrote: > > > > > > > > On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev > > > > wrote: > > > > >

[PATCH v2] drm/panel: starry-2081101qfh032011-53g: Fine tune the panel power sequence

2023-11-06 Thread xiazhengqiao
For the "starry, 2081101qfh032011-53g" panel, it is stipulated in the panel spec that MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high. Fixes: 6069b66cd962 ("drm/panel: support for STARRY 2081101QFH032011-53G MIPI-DSI panel") Signed-off-by: xiazhengqiao Reviewed-by:

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Stanislav Fomichev
On 11/06, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 1:59 PM Stanislav Fomichev wrote: > > > > On 11/06, Mina Almasry wrote: > > > On Mon, Nov 6, 2023 at 11:34 AM David Ahern wrote: > > > > > > > > On 11/6/23 11:47 AM, Stanislav Fomichev wrote: > > > > > On 11/05, Mina Almasry wrote: > > > >

Re: [PATCH v7 0/7] incorporate pm runtime framework and eDP clean up

2023-11-06 Thread Dmitry Baryshkov
On Sat, 7 Oct 2023 at 01:55, Kuogee Hsieh wrote: > > The purpose of this patch series is to incorporate pm runtime framework > into MSM eDP/DP driver so that eDP panel can be detected by DRM eDP panel > driver during system probe time. During incorporating procedure, original > customized pm

Re: [PATCH 0/5] Some drm scheduler internal renames

2023-11-06 Thread Luben Tuikov
On 2023-11-06 07:41, Tvrtko Ursulin wrote: > > On 05/11/2023 01:51, Luben Tuikov wrote: >> On 2023-11-02 06:55, Tvrtko Ursulin wrote: >>> From: Tvrtko Ursulin >>> >>> I found some of the naming a bit incosistent and unclear so just a small >>> attempt to clarify and tidy some of them. See what

Re: [PATCH v2 1/3] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v2)

2023-11-06 Thread kernel test robot
Hi Vivek, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Vivek-Kasireddy/mm-gup-Introduce-pin_user_pages_fd-for-pinning-shmem-hugetlbfs-file-pages-v2/20231106-141954 base: https

Re: [PATCH v2] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Lazar, Lijo
On 11/7/2023 1:47 AM, Hunter Chasens wrote: Resolves Sphinx unexpected indentation warning when compiling documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds a literal block to keep vertical formatting of the example power state list. Signed-off-by: Hunter Chasens ---

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread David Ahern
On 11/6/23 3:18 PM, Mina Almasry wrote: >> @@ -991,7 +993,7 @@ struct sk_buff { >> #if IS_ENABLED(CONFIG_IP_SCTP) >> __u8csum_not_inet:1; >> #endif >> - >> +__u8devmem:1; >> #if defined(CONFIG_NET_SCHED) ||

Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing

2023-11-06 Thread Bagas Sanjaya
On 06/11/2023 17:31, Jani Nikula wrote: > On Mon, 06 Nov 2023, Bagas Sanjaya wrote: >> On Sat, Nov 04, 2023 at 09:47:08AM -0400, Hunter Chasens wrote: >>> diff --git a/Documentation/gpu/rfc/i915_scheduler.rst >>> b/Documentation/gpu/rfc/i915_scheduler.rst >>> index c237ebc024cd..23ba7006929b

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Mina Almasry
On Mon, Nov 6, 2023 at 4:16 PM David Ahern wrote: > > On 11/5/23 7:44 PM, Mina Almasry wrote: > > diff --git a/net/core/datagram.c b/net/core/datagram.c > > index 176eb5834746..cdd4fb129968 100644 > > --- a/net/core/datagram.c > > +++ b/net/core/datagram.c > > @@ -425,6 +425,9 @@ static int

[PATCH] drm/msm/dp: call dp_display_get_next_bridge() during probe

2023-11-06 Thread Dmitry Baryshkov
The funcion dp_display_get_next_bridge() can return -EPROBE_DEFER if the next bridge is not (yet) available. However returning -EPROBE_DEFER from msm_dp_modeset_init() is not ideal. This leads to -EPROBE return from component_bind, which can easily result in -EPROBE_DEFR loops. Signed-off-by:

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Stanislav Fomichev
On 11/06, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 4:08 PM Willem de Bruijn > wrote: > > > > On Mon, Nov 6, 2023 at 3:55 PM Stanislav Fomichev wrote: > > > > > > On Mon, Nov 6, 2023 at 3:27 PM Mina Almasry > > > wrote: > > > > > > > > On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev > >

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread David Ahern
On 11/6/23 5:20 PM, Mina Almasry wrote: > The user is free to modify or delete flow steering rules outside of the > lifetime of the socket. Technically it's possible for the user to > reconfigure flow steering while the socket is simultaneously receiving, > and the result will be packets switching

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Willem de Bruijn
> > > > I think my other issue with MSG_SOCK_DEVMEM being on recvmsg is that > > > > it somehow implies that I have an option of passing or not passing it > > > > for an individual system call. > > > > If we know that we're going to use dmabuf with the socket, maybe we > > > > should move this

Re: [PATCH] drm/msm/dpu: correct clk bit for WB2 block

2023-11-06 Thread Dmitry Baryshkov
On Mon, 6 Nov 2023 at 20:39, Abhinav Kumar wrote: > > Sorry for the delay in getting back on this. There was quite a bit of > history digging I had to do myself to give a certain response. > > > On 10/9/2023 10:11 AM, Dmitry Baryshkov wrote: > > On sc7280 there are two clk bits for WB2: control

Re: [PATCH v3 1/3] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-06 Thread Dmitry Baryshkov
On Mon, 6 Nov 2023 at 22:27, Hsin-Yi Wang wrote: > > Add a few generic edp panels used by mt8186 chromebooks. > Besides, modify the following panel: > - AUO 0x235c B116XTN02 renamed to B116XTN02.3. > - AUO 0x405c B116XAK01 adjust the timing of auo_b116xak01. According > to the datasheet: T3=200,

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Kaiyuan Zhang
> > But there is still always 1 dmabuf to 1 socket association (on rx), right? > In practice yes, but my understanding is that such association is only enforced by NIC features such as flow steering. So why not have a separate control channel action to say: this socket fd > is supposed to receive

Re: [syzbot] [dri?] kernel BUG in vmf_insert_pfn_prot (2)

2023-11-06 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:d2f51b3516da Merge tag 'rtc-6.7' of git://git.kernel.org/p.. git tree: upstream console+strace: https://syzkaller.appspot.com/x/log.txt?x=1422ebef68 kernel config:

Re: [RFC PATCH v3 06/12] memory-provider: dmabuf devmem memory provider

2023-11-06 Thread David Ahern
On 11/5/23 7:44 PM, Mina Almasry wrote: > diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h > index 78cbb040af94..b93243c2a640 100644 > --- a/include/net/page_pool/helpers.h > +++ b/include/net/page_pool/helpers.h > @@ -111,6 +112,45 @@ page_pool_iov_binding(const

Re: [PATCH] drm/msm/dpu: correct clk bit for WB2 block

2023-11-06 Thread Dmitry Baryshkov
On Tue, 7 Nov 2023 at 01:30, Abhinav Kumar wrote: > > > > On 11/6/2023 2:11 PM, Dmitry Baryshkov wrote: > > On Mon, 6 Nov 2023 at 20:39, Abhinav Kumar > > wrote: > >> > >> Sorry for the delay in getting back on this. There was quite a bit of > >> history digging I had to do myself to give a

Re: linux-next: manual merge of the amdgpu tree with Linus' tree

2023-11-06 Thread Stephen Rothwell
Hi all, On Mon, 6 Nov 2023 09:48:55 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the amdgpu tree got a conflict in: > > drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c > > between commit: > > 18bf400530ca ("drm/amdgpu: Use pci_get_base_class() to reduce duplicated > code") >

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Stanislav Fomichev
On Mon, Nov 6, 2023 at 3:27 PM Mina Almasry wrote: > > On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev wrote: > > > > On 11/06, Mina Almasry wrote: > > > On Mon, Nov 6, 2023 at 1:59 PM Stanislav Fomichev wrote: > > > > > > > > On 11/06, Mina Almasry wrote: > > > > > On Mon, Nov 6, 2023 at

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread David Ahern
On 11/6/23 4:32 PM, Stanislav Fomichev wrote: >> The concise notification API returns tokens as a range for >> compression, encoding as two 32-bit unsigned integers start + length. >> It allows for even further batching by returning multiple such ranges >> in a single call. > > Tangential: should

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Stanislav Fomichev
On 11/06, Willem de Bruijn wrote: > On Mon, Nov 6, 2023 at 3:55 PM Stanislav Fomichev wrote: > > > > On Mon, Nov 6, 2023 at 3:27 PM Mina Almasry wrote: > > > > > > On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev wrote: > > > > > > > > On 11/06, Mina Almasry wrote: > > > > > On Mon, Nov 6,

[git pull] drm next + fixes for 6.7-rc1

2023-11-06 Thread Dave Airlie
Hi Linus, Geert pointed out I missed the renesas reworks in my main pull, so this pull contains the renesas next work for atomic conversion and DT support. It also contains a bunch of amdgpu and some small ssd13xx fixes. I'm going to be travelling from tomorrow, I should in theory have access to

Re: [PATCH v2 1/3] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v2)

2023-11-06 Thread kernel test robot
Hi Vivek, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Vivek-Kasireddy/mm-gup-Introduce-pin_user_pages_fd-for-pinning-shmem-hugetlbfs-file-pages-v2/20231106-141954 base: https

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-06 Thread Evan Preston
Hi Huacai, On 2023-11-07 Tue 09:49am, Huacai Chen wrote: > Hi, Evan, > > On Tue, Nov 7, 2023 at 4:32 AM Evan Preston wrote: > > > > Hi Huacai, > > > > On 2023-11-06 Mon 10:22pm, Huacai Chen wrote: > > > On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja wrote: > > > > > > > > On 06.11.23 04:15,

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Willem de Bruijn
On Mon, Nov 6, 2023 at 3:55 PM Stanislav Fomichev wrote: > > On Mon, Nov 6, 2023 at 3:27 PM Mina Almasry wrote: > > > > On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev wrote: > > > > > > On 11/06, Mina Almasry wrote: > > > > On Mon, Nov 6, 2023 at 1:59 PM Stanislav Fomichev > > > > wrote: >

Re: [PATCH v5 1/4] drm/panel-edp: drm/panel-edp: Fix AUO B116XTN02, B116XAK01 name and timing

2023-11-06 Thread Hsin-Yi Wang
On Mon, Nov 6, 2023 at 4:00 PM Hsin-Yi Wang wrote: > > According to decoding edid and datahseet: > - Rename AUO 0x235c B116XTN02 to B116XTN02.3 > - Rename AUO 0x405c B116XAK01 to B116XAK01.0 and adjust the timing of > auo_b116xak01: T3=200, T12=500, T7_max = 50. > > Fixes: 3db2420422a5

RE: [PATCH v8 6/6] drm/i915/panelreplay: Debugfs support for panel replay

2023-11-06 Thread Manna, Animesh
> -Original Message- > From: Hogander, Jouni > Sent: Monday, November 6, 2023 1:33 PM > To: dri-devel@lists.freedesktop.org; Manna, Animesh > ; intel-...@lists.freedesktop.org > Cc: Murthy, Arun R ; Nikula, Jani > > Subject: Re: [PATCH v8 6/6] drm/i915/panelreplay: Debugfs support for

Re: [PATCH v4 2/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-06 Thread Dmitry Baryshkov
On Mon, 6 Nov 2023 at 23:03, Hsin-Yi Wang wrote: > > Generic edp gets mode from edid. However, some panels report incorrect > mode in this way, resulting in glitches on panel. Introduce a new quirk > additional_mode to the generic edid to pick a correct hardcoded mode. > > Signed-off-by: Hsin-Yi

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Mina Almasry
On Mon, Nov 6, 2023 at 1:59 PM Stanislav Fomichev wrote: > > On 11/06, Mina Almasry wrote: > > On Mon, Nov 6, 2023 at 11:34 AM David Ahern wrote: > > > > > > On 11/6/23 11:47 AM, Stanislav Fomichev wrote: > > > > On 11/05, Mina Almasry wrote: > > > >> For device memory TCP, we expect the skb

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread Stanislav Fomichev
On Mon, Nov 6, 2023 at 2:56 PM Willem de Bruijn wrote: > > On Mon, Nov 6, 2023 at 2:34 PM Stanislav Fomichev wrote: > > > > On 11/06, Willem de Bruijn wrote: > > > > > IMHO, we need a better UAPI to receive the tokens and give them back > > > > > to > > > > > the kernel. CMSG +

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-06 Thread David Ahern
On 11/5/23 7:44 PM, Mina Almasry wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index eeeda849115c..1c351c138a5b 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -843,6 +843,9 @@ struct netdev_dmabuf_binding { > }; > > #ifdef

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread David Ahern
On 11/5/23 7:44 PM, Mina Almasry wrote: > diff --git a/net/core/datagram.c b/net/core/datagram.c > index 176eb5834746..cdd4fb129968 100644 > --- a/net/core/datagram.c > +++ b/net/core/datagram.c > @@ -425,6 +425,9 @@ static int __skb_datagram_iter(const struct sk_buff *skb, > int offset, >

Re: [PATCH v2] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Bagas Sanjaya
On Mon, Nov 06, 2023 at 03:17:39PM -0500, Hunter Chasens wrote: > diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > b/drivers/gpu/drm/amd/pm/amdgpu_pm.c > index 517b9fb4624c..81b8ceb26890 100644 > --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c > @@ -989,12

[PATCH] drm/sched: Don't disturb the entity when in RR-mode scheduling

2023-11-06 Thread Luben Tuikov
Don't call drm_sched_select_entity() in drm_sched_run_job_queue(). In fact, rename __drm_sched_run_job_queue() to just drm_sched_run_job_queue(), and let it do just that, schedule the work item for execution. The problem is that drm_sched_run_job_queue() calls drm_sched_select_entity() to

Re: [RFC v4 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-11-06 Thread Lazar, Lijo
On 11/1/2023 1:36 PM, Aravind Iddamsetty wrote: On 30/10/23 20:41, Lazar, Lijo wrote: On 10/30/2023 11:49 AM, Aravind Iddamsetty wrote: On 26/10/23 15:34, Lazar, Lijo wrote: Hi Lijo, Thank you for your comments. On 10/23/2023 8:59 PM, Alex Deucher wrote: On Fri, Oct 20, 2023 at

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread Willem de Bruijn
On Mon, Nov 6, 2023 at 2:34 PM Stanislav Fomichev wrote: > > On 11/06, Willem de Bruijn wrote: > > > > IMHO, we need a better UAPI to receive the tokens and give them back to > > > > the kernel. CMSG + setsockopt(SO_DEVMEM_DONTNEED) get the job done, > > > > but look dated and hacky :-( > > > > >

Re: [PATCH] drm/msm/dpu: correct clk bit for WB2 block

2023-11-06 Thread Abhinav Kumar
On 11/6/2023 2:11 PM, Dmitry Baryshkov wrote: On Mon, 6 Nov 2023 at 20:39, Abhinav Kumar wrote: Sorry for the delay in getting back on this. There was quite a bit of history digging I had to do myself to give a certain response. On 10/9/2023 10:11 AM, Dmitry Baryshkov wrote: On sc7280

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Mina Almasry
On Mon, Nov 6, 2023 at 3:37 PM David Ahern wrote: > > On 11/6/23 3:18 PM, Mina Almasry wrote: > >> @@ -991,7 +993,7 @@ struct sk_buff { > >> #if IS_ENABLED(CONFIG_IP_SCTP) > >> __u8csum_not_inet:1; > >> #endif > >> - > >> +__u8

Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing

2023-11-06 Thread Bagas Sanjaya
On 07/11/2023 02:41, Jani Nikula wrote: > On Mon, 06 Nov 2023, Hunter Chasens wrote: >> When running `make htmldocs` the following warnings are given. >> >> ``` >> Documentation/gpu/rfc/i915_scheduler.rst:138: WARNING: >> Unknown directive type "c:namespace-push". >> >> .. c:namespace-push:: rfc

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-06 Thread Stanislav Fomichev
On 11/06, Willem de Bruijn wrote: > > > IMHO, we need a better UAPI to receive the tokens and give them back to > > > the kernel. CMSG + setsockopt(SO_DEVMEM_DONTNEED) get the job done, > > > but look dated and hacky :-( > > > > > > We should either do some kind of user/kernel shared memory queue

[PATCH v5 0/4] Add a few panels and use correct modes

2023-11-06 Thread Hsin-Yi Wang
This series contains 3 patches: 1. Add a few new generic edp panels. 2. Support a new quirk to override the mode read from edid 3. Only add hard-coded mode if both edid and hard-coded modes presents. v1:

[PATCH v5 2/4] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-06 Thread Hsin-Yi Wang
Add a few generic edp panels used by mt8186 chromebooks. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v4->v5: seperate fixes patch --- drivers/gpu/drm/panel/panel-edp.c | 51 +++ 1 file changed, 51 insertions(+) diff --git

[PATCH v5 3/4] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-06 Thread Hsin-Yi Wang
Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v4->v5: fix coding

[PATCH 0/2] Selftest for FAST_REQUEST feature

2023-11-06 Thread John . C . Harrison
From: John Harrison Add a selftest to verify that the FAST_REQUEST mechanism (getting errors back from fire-and-forget H2G commands) is functional. Also fix up a potential false positive in the GuC hang selftest. Signed-off-by: John Harrison John Harrison (2): drm/i915/guc: Fix for

[PATCH 2/2] drm/i915/guc: Add a selftest for FAST_REQUEST errors

2023-11-06 Thread John . C . Harrison
From: John Harrison There is a mechanism for reporting errors from fire and forget H2G messages. This is the only way to find out about almost any error in the GuC backend submission path. So it would be useful to know that it is working. Signed-off-by: John Harrison ---

[PATCH v5 4/4] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-06 Thread Hsin-Yi Wang
If a non generic edp-panel is under aux-bus, the mode read from edid would still be selected as preferred and results in multiple preferred modes, which is ambiguous. If both hard-coded mode and edid exists, only add mode from hard-coded. Signed-off-by: Hsin-Yi Wang --- v4->v5: remove

[PATCH v5 1/4] drm/panel-edp: drm/panel-edp: Fix AUO B116XTN02, B116XAK01 name and timing

2023-11-06 Thread Hsin-Yi Wang
According to decoding edid and datahseet: - Rename AUO 0x235c B116XTN02 to B116XTN02.3 - Rename AUO 0x405c B116XAK01 to B116XAK01.0 and adjust the timing of auo_b116xak01: T3=200, T12=500, T7_max = 50. Fixes: 3db2420422a5 ("drm/panel-edp: Add AUO B116XTN02, BOE NT116WHM-N21,836X2, NV116WHM-N49

[PATCH 1/2] drm/i915/guc: Fix for potential false positives in GuC hang selftest

2023-11-06 Thread John . C . Harrison
From: John Harrison Noticed that the hangcheck selftest is submitting a non-preemptoble spinner. That means that even if the GuC does not die, the heartbeat will still kick in and trigger a reset. Which is rather defeating the purpose of the test - to verify that the heartbeat will kick in if

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-06 Thread Mina Almasry
On Mon, Nov 6, 2023 at 4:08 PM Willem de Bruijn wrote: > > On Mon, Nov 6, 2023 at 3:55 PM Stanislav Fomichev wrote: > > > > On Mon, Nov 6, 2023 at 3:27 PM Mina Almasry wrote: > > > > > > On Mon, Nov 6, 2023 at 2:59 PM Stanislav Fomichev wrote: > > > > > > > > On 11/06, Mina Almasry wrote: > >

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-06 Thread Huacai Chen
Hi, Evan, On Tue, Nov 7, 2023 at 4:32 AM Evan Preston wrote: > > Hi Huacai, > > On 2023-11-06 Mon 10:22pm, Huacai Chen wrote: > > On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja wrote: > > > > > > On 06.11.23 04:15, Huacai Chen wrote: > > > > Hi, Jaak and Evan, > > > > > > > > On Mon, Nov 6, 2023

[PATCH] nouveau: use an rwlock for the event lock.

2023-11-06 Thread Dave Airlie
From: Dave Airlie This allows it to break the following circular locking dependency. Aug 10 07:01:29 dg1test kernel: == Aug 10 07:01:29 dg1test kernel: WARNING: possible circular locking dependency detected Aug 10 07:01:29 dg1test kernel:

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Abhinav Singh
On 11/7/23 03:07, Alex Deucher wrote: On Mon, Nov 6, 2023 at 4:20 PM Abhinav Singh wrote: On 11/7/23 00:25, Alex Deucher wrote: Applied. This matches what we already do in the other clear state headers. Alex On Fri, Nov 3, 2023 at 12:00 PM Abhinav Singh wrote: sparse static analysis

Re: [PATCH v8 6/6] drm/i915/panelreplay: Debugfs support for panel replay

2023-11-06 Thread Hogander, Jouni
On Tue, 2023-11-07 at 05:01 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Monday, November 6, 2023 1:33 PM > > To: dri-devel@lists.freedesktop.org; Manna, Animesh > > ; intel-...@lists.freedesktop.org > > Cc: Murthy, Arun R ; Nikula, Jani >

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Mika Westerberg
Hi, On Mon, Nov 06, 2023 at 07:56:52PM +0100, Lukas Wunner wrote: > On Mon, Nov 06, 2023 at 12:44:25PM -0600, Mario Limonciello wrote: > > Tangentially related; the link speed is currently symmetric but there are > > two sysfs files. Mika left a comment in drivers/thunderbolt/switch.c it may > >

Re: [PATCH v2 8/9] PCI: Exclude PCIe ports used for tunneling in pcie_bandwidth_available()

2023-11-06 Thread Mika Westerberg
On Tue, Nov 07, 2023 at 07:45:26AM +0200, Mika Westerberg wrote: > Hi, > > On Mon, Nov 06, 2023 at 07:56:52PM +0100, Lukas Wunner wrote: > > On Mon, Nov 06, 2023 at 12:44:25PM -0600, Mario Limonciello wrote: > > > Tangentially related; the link speed is currently symmetric but there are > > > two

Re: [PATCH 3/3] drm/panel-edp: Choose correct preferred mode

2023-11-06 Thread Maxime Ripard
On Thu, Nov 02, 2023 at 07:33:48AM -0700, Doug Anderson wrote: > Hi, > > On Wed, Nov 1, 2023 at 11:31 PM Dmitry Baryshkov > wrote: > > > > On Wed, 1 Nov 2023 at 23:26, Hsin-Yi Wang wrote: > > > > > > If a non generic edp-panel is under aux-bus, the mode read from edid would > > > still be

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Bagas Sanjaya
On Sun, Nov 05, 2023 at 09:26:26PM -0800, Randy Dunlap wrote: > > > On 11/5/23 21:15, Bagas Sanjaya wrote: > > On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote: > >> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > >> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c > >> index

[PATCH] drm/i915/display: Fix phys_base to be relative not absolute

2023-11-06 Thread Paz Zcharya
Fix the value of variable `phys_base` to be the relative offset in stolen memory, and not the absolute offset of the GSM. Currently, the value of `phys_base` is set to "Surface Base Address," which in the case of Meter Lake is 0xfc00_. This causes the function

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-06 Thread Christian König
Am 03.11.23 um 16:34 schrieb Danilo Krummrich: [SNIP] Especially we most likely don't want the VM to live longer than the application which originally used it. If you make the GPUVM an independent object you actually open up driver abuse for the lifetime of this. Right, we don't want that.

Re: [PATCH 3/3] drm/panel-edp: Choose correct preferred mode

2023-11-06 Thread Maxime Ripard
Hi, On Wed, Nov 01, 2023 at 02:20:11PM -0700, Hsin-Yi Wang wrote: > If a non generic edp-panel is under aux-bus, the mode read from edid would > still be selected as preferred and results in multiple preferred modes, > which is ambiguous. > > If a hard-coded mode is present, unset the preferred

Re: [PATCH v2 3/4] drm/modes: Add a function to clear preferred modes

2023-11-06 Thread Maxime Ripard
On Fri, Nov 03, 2023 at 09:02:33AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Nov 2, 2023 at 3:13 PM Hsin-Yi Wang wrote: > > > > Add a function to clear the preferred bit of a connector's existing modes. > > This is useful for edp panel to unset the preferred modes read from edid > > if the

Re: [PATCH v8 6/6] drm/i915/panelreplay: Debugfs support for panel replay

2023-11-06 Thread Hogander, Jouni
Hello Animesh, Thank you for the changes. Now the patch is much shorter, cleaner and easier to review. See my inline comments below. On Sat, 2023-11-04 at 02:30 +0530, Animesh Manna wrote: > Add debugfs support which will print source and sink status > per connector basis. Existing

[PATCH] drm/i915/vma: Fix potential UAF on multi-tile platforms

2023-11-06 Thread Janusz Krzysztofik
Object debugging tools were sporadically reporting illegal attempts to free a still active i915 VMA object from when parking a GPU tile believed to be idle. [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 object type: i915_active hint: __i915_vma_active+0x0/0x50 [i915]

Re: [PATCH] drm/qxl: prevent memory leak

2023-11-06 Thread Maxime Ripard
Hi, On Wed, Nov 01, 2023 at 12:58:17PM +1000, Dave Airlie wrote: > On Wed, 22 Mar 2023 at 19:04, Zongmin Zhou wrote: > > > > The allocated memory for qdev->dumb_heads should be released > > in qxl_destroy_monitors_object before qxl suspend. > > otherwise,qxl_create_monitors_object will be called

Re: [RESEND PATCH] drm/qxl: prevent memory leak

2023-11-06 Thread Maxime Ripard
On Tue, 01 Aug 2023 10:53:09 +0800, Zongmin Zhou wrote: > The allocated memory for qdev->dumb_heads should be released > in qxl_destroy_monitors_object before qxl suspend. > otherwise,qxl_create_monitors_object will be called to > reallocate memory for qdev->dumb_heads after qxl resume, > it will

Re: [PULL] drm-misc-next

2023-11-06 Thread Thomas Hellström
Hi, David. On 11/3/23 17:37, David Edelsohn wrote: Dual-license drm_gpuvm to GPL-2.0 OR MIT. diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c index 02ce6baacdad..08c088319652 100644 --- a/drivers/gpu/drm/drm_gpuvm.c

Re: [PATCH] drm/i915/vma: Fix potential UAF on multi-tile platforms

2023-11-06 Thread Janusz Krzysztofik
Hi Jani, Thanks for looking at this. On Monday, 6 November 2023 10:53:11 CET Jani Nikula wrote: > On Mon, 06 Nov 2023, Janusz Krzysztofik wrote: > > Object debugging tools were sporadically reporting illegal attempts to > > free a still active i915 VMA object from when parking a GPU tile

Re: [PULL] drm-misc-next

2023-11-06 Thread Thomas Hellström
On 11/6/23 11:37, Thomas Hellström wrote: Hi, On 11/6/23 11:20, Maxime Ripard wrote: On Mon, Nov 06, 2023 at 11:01:51AM +0100, Thomas Hellström wrote: Hi, David. On 11/3/23 17:37, David Edelsohn wrote: Dual-license drm_gpuvm to GPL-2.0 OR MIT. diff --git a/drivers/gpu/drm/drm_gpuvm.c

[PATCH 4.14 33/48] fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2023-11-06 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Arnd Bergmann [ Upstream commit c1a8d1d0edb71dec15c9649cb56866c71c1ecd9e ] ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly

Re: [PATCH v2] drm/i915: Fix potential spectre vulnerability

2023-11-06 Thread Tvrtko Ursulin
On 06/11/2023 09:57, Andi Shyti wrote: Hi Kunwu, On Fri, Nov 03, 2023 at 10:32:57AM +0800, Kunwu Chan wrote: Fix smatch warning: drivers/gpu/drm/i915/gem/i915_gem_context.c:847 set_proto_ctx_sseu() warn: potential spectre issue 'pc->user_engines' [r] (local cap) Fixes: d4433c7600f7

Re: [PATCH] drm/atomic-helper: Call stall_checks() before allocate drm_crtc_commit

2023-11-06 Thread Maxime Ripard
Hi, On Mon, Nov 06, 2023 at 03:37:42PM +0800, oushixiong wrote: > From: Shixiong Ou > > Calling stall_checks() before allocating drm_crtc_commit not after that. > > Signed-off-by: Shixiong Ou Generally speaking, we need much more context than that. What bug did you encounter that makes you

Re: [PATCH 3/3] drm/panel-edp: Choose correct preferred mode

2023-11-06 Thread Jani Nikula
On Mon, 06 Nov 2023, Maxime Ripard wrote: > On Thu, Nov 02, 2023 at 07:33:48AM -0700, Doug Anderson wrote: >> Hi, >> >> On Wed, Nov 1, 2023 at 11:31 PM Dmitry Baryshkov >> wrote: >> > >> > On Wed, 1 Nov 2023 at 23:26, Hsin-Yi Wang wrote: >> > > >> > > If a non generic edp-panel is under

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Lazar, Lijo
On 11/6/2023 2:30 AM, Hunter Chasens wrote: Resolves Sphinx unexpected indentation warning when compiling documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds a literal block to keep vertical formatting of the example power state list. Signed-off-by: Hunter Chasens

[PATCH] drm/gpuvm: Fix deprecated license identifier

2023-11-06 Thread Thomas Hellström
"GPL-2.0-only" in the license header was incorrectly changed to the now deprecated "GPL-2.0". Fix. Cc: Maxime Ripard Cc: Danilo Krummrich Reported-by: David Edelsohn Closes:

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-06 Thread Danilo Krummrich
On Mon, Nov 06, 2023 at 10:14:29AM +0100, Christian König wrote: > Am 03.11.23 um 16:34 schrieb Danilo Krummrich: > [SNIP] > > > > > > Especially we most likely don't want the VM to live longer than the > > > application which originally used it. If you make the GPUVM an > > > independent object

Re: [PATCH v2 3/9] PCI: Drop pci_is_thunderbolt_attached()

2023-11-06 Thread Ilpo Järvinen
On Fri, 3 Nov 2023, Mario Limonciello wrote: > All callers have switched to dev_is_removable() for detecting > hotpluggable PCIe devices. > > Signed-off-by: Mario Limonciello > --- > include/linux/pci.h | 22 -- > 1 file changed, 22 deletions(-) > > diff --git

Re: [PATCH v2 5/9] PCI: pciehp: Move check for is_thunderbolt into a quirk

2023-11-06 Thread Ilpo Järvinen
On Fri, 3 Nov 2023, Mario Limonciello wrote: > commit 493fb50e958c ("PCI: pciehp: Assume NoCompl+ for Thunderbolt > ports") added a check into pciehp code to explicitly set NoCompl+ > for all Intel Thunderbolt controllers, including those that don't > need it. > > This overloaded the purpose of

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-06 Thread Christian König
Am 06.11.23 um 13:16 schrieb Danilo Krummrich: [SNIP] This reference count just prevents that the VM is freed as long as other ressources are attached to it that carry a VM pointer, such as mappings and VM_BOs. The motivation for that are VM_BOs. For mappings it's indeed a bit paranoid, but it

[PATCH 4.19 47/61] fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2023-11-06 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Arnd Bergmann [ Upstream commit c1a8d1d0edb71dec15c9649cb56866c71c1ecd9e ] ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly

Re: [PATCH] drm/i915/vma: Fix potential UAF on multi-tile platforms

2023-11-06 Thread Jani Nikula
On Mon, 06 Nov 2023, Janusz Krzysztofik wrote: > Object debugging tools were sporadically reporting illegal attempts to > free a still active i915 VMA object from when parking a GPU tile believed > to be idle. > > [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 >

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-06 Thread Jani Nikula
On Mon, 06 Nov 2023, Bagas Sanjaya wrote: > On Sun, Nov 05, 2023 at 09:26:26PM -0800, Randy Dunlap wrote: >> >> >> On 11/5/23 21:15, Bagas Sanjaya wrote: >> > On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote: >> >> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> >>

Re: [PATCH] drm/mgag200: Flush the cache to improve latency

2023-11-06 Thread Jocelyn Falempe
On 23/10/2023 10:30, Jocelyn Falempe wrote: On 20/10/2023 14:06, Thomas Zimmermann wrote: (cc'ing lkml for feedback) Hi Jocelyn Am 19.10.23 um 15:55 schrieb Jocelyn Falempe: We found a regression in v5.10 on real-time server, using the rt-kernel and the mgag200 driver. It's some really

Re: (subset) [Intel-gfx] [PATCH 1/7] drm: Do not round to megabytes for greater than 1MiB sizes in fdinfo stats

2023-11-06 Thread Maxime Ripard
On Wed, 27 Sep 2023 14:38:37 +0100, Tvrtko Ursulin wrote: > It is better not to lose precision and not revert to 1 MiB size > granularity for every size greater than 1 MiB. > > Sizes in KiB should not be so troublesome to read (and in fact machine > parsing is I expect the norm here), they align

Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL

2023-11-06 Thread Jani Nikula
On Fri, 03 Nov 2023, Abhinav Singh wrote: > sparse static analysis tools generate a warning with this message > "Using plain integer as NULL pointer". In this case this warning is > being shown because we are trying to intialize a pointer to NULL using > integer value 0. > > Signed-off-by:

Re: [PATCH v2 2/9] drm/radeon: Switch from pci_is_thunderbolt_attached() to dev_is_removable()

2023-11-06 Thread Ilpo Järvinen
On Fri, 3 Nov 2023, Mario Limonciello wrote: > pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to > using dev_is_removable() to be able to detect USB4 devices as well. Same here as with 1/9. -- i. > Signed-off-by: Mario Limonciello > --- >

Re: [PATCH] drm/sched: Eliminate drm_sched_run_job_queue_if_ready()

2023-11-06 Thread Tvrtko Ursulin
On 04/11/2023 00:25, Luben Tuikov wrote: Hi Tvrtko, On 2023-11-03 06:39, Tvrtko Ursulin wrote: On 02/11/2023 22:46, Luben Tuikov wrote: Eliminate drm_sched_run_job_queue_if_ready() and instead just call drm_sched_run_job_queue() in drm_sched_free_job_work(). The problem is that the former

Re: [PATCH] drm/bridge: tc358767: Support input format negotiation hook

2023-11-06 Thread Sam Ravnborg
Hi Aradhya, On Tue, Oct 31, 2023 at 12:58:46AM +0530, Aradhya Bhatia wrote: > With new connector model, tc358767 will not create the connector, when > DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-controller driver will > rely on format negotiation to setup the encoder format. > > Add the

[PATCH 6.1 10/62] fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2023-11-06 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Arnd Bergmann [ Upstream commit c1a8d1d0edb71dec15c9649cb56866c71c1ecd9e ] ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly

[PATCH i-g-t 0/2] lib/kunit: Execute test cases synchronously

2023-11-06 Thread Janusz Krzysztofik
Load KUnit modules in a way that only one selected test case is executed per each IGT dynamic sub-subtest. Janusz Krzysztofik (2): lib/kunit: Split out reusable part of test case list gathering lib/kunit: Execute test cases synchronously lib/igt_kmod.c | 262

Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing

2023-11-06 Thread Jani Nikula
On Mon, 06 Nov 2023, Bagas Sanjaya wrote: > On Sat, Nov 04, 2023 at 09:47:08AM -0400, Hunter Chasens wrote: >> diff --git a/Documentation/gpu/rfc/i915_scheduler.rst >> b/Documentation/gpu/rfc/i915_scheduler.rst >> index c237ebc024cd..23ba7006929b 100644 >> ---

Re: [PULL] drm-misc-next

2023-11-06 Thread Thomas Hellström
Hi, On 11/6/23 11:20, Maxime Ripard wrote: On Mon, Nov 06, 2023 at 11:01:51AM +0100, Thomas Hellström wrote: Hi, David. On 11/3/23 17:37, David Edelsohn wrote: Dual-license drm_gpuvm to GPL-2.0 OR MIT. diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c index

Re: [PATCH] drm/i915/vma: Fix potential UAF on multi-tile platforms

2023-11-06 Thread Jani Nikula
On Mon, 06 Nov 2023, Janusz Krzysztofik wrote: > Hi Jani, > > Thanks for looking at this. > > On Monday, 6 November 2023 10:53:11 CET Jani Nikula wrote: >> On Mon, 06 Nov 2023, Janusz Krzysztofik > wrote: >> > Object debugging tools were sporadically reporting illegal attempts to >> > free a

Re: [PATCH 0/5] Some drm scheduler internal renames

2023-11-06 Thread Tvrtko Ursulin
On 05/11/2023 01:51, Luben Tuikov wrote: On 2023-11-02 06:55, Tvrtko Ursulin wrote: From: Tvrtko Ursulin I found some of the naming a bit incosistent and unclear so just a small attempt to clarify and tidy some of them. See what people think if my first stab improves things or not. Cc:

  1   2   3   >