Re: [PATCH v2 03/12] drm/rockchip: vop2: set half_block_en bit in all mode

2023-11-27 Thread Heiko Stübner
Am Mittwoch, 22. November 2023, 13:54:13 CET schrieb Andy Yan: > From: Andy Yan > > At first we thought the half_block_en bit in AFBCD_CTRL register > only work in afbc mode. But the fact is that it control the line > buffer in all mode(afbc/tile/line), so we need configure it in > all case. >

Re: [PATCH v2 04/12] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode

2023-11-27 Thread Heiko Stübner
Am Mittwoch, 22. November 2023, 13:54:25 CET schrieb Andy Yan: > From: Andy Yan > > The enable bit and transform offset of cluster windows should be > cleared when it work at linear mode, or we may have a iommu fault > issue. > > Signed-off-by: Andy Yan I guess same here? Fixes: 604be85547ce

Re: [PATCH 2/6] drm/bridge: tc358775: Fix getting dsi host data lanes

2023-11-27 Thread Tony Lindgren
* Michael Walle [231127 14:31]: > + dt maintainers > > > > I actually have the same fix, but with one additional detail, which > > > I'm > > > unsure about though: This looks at the data-lanes property of the > > > *remote* > > > endpoint whereas other bridge drivers (see tc358767, ti-sn65dsi83,

Re: [PATCH] Revert "drm/sched: Qualify drm_sched_wakeup() by drm_sched_entity_is_ready()"

2023-11-27 Thread Luben Tuikov
Hi Bert, # The title of the patch should be: drm/sched: Partial revert of "Qualify drm_sched_wakeup() by drm_sched_entity_is_ready()" On 2023-11-27 08:30, Bert Karwatzki wrote: > Commit f3123c25 (in combination with the use of work queues by the gpu Commit f3123c2590005c, in combination with

[PATCH v2 17/32] fbdev/au1200fb: Initialize fb_ops with fbdev macros

2023-11-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in DMA-able virtual address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary helpers in Kconfig. Fbdev drivers sometimes

[PATCH v2 12/32] fbdev/sh_mobile_lcdcfb: Set FBINFO_VIRTFB flag

2023-11-27 Thread Thomas Zimmermann
The sh_mobile_lcdcfb driver operates on DMA-able system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas ---

[PATCH v2 29/32] fbdev: Push pgprot_decrypted() into mmap implementations

2023-11-27 Thread Thomas Zimmermann
If a driver sets struct fb_ops.fb_mmap, the fbdev core automatically calls pgprot_decrypted(). But the default fb_mmap code doesn't handle pgprot_decrypted(). Move the call to pgprot_decrypted() into each drivers' fb_mmap function. This only concerns fb_mmap functions for system and DMA memory.

[PATCH v2 22/32] fbdev/vt8500lcdfb: Initialize fb_ops with fbdev macros

2023-11-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in DMA-able virtual address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary helpers in Kconfig. Fbdev drivers sometimes

[PATCH v2 08/32] auxdisplay/cfag12864bfb: Initialize fb_ops with fbdev macros

2023-11-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in virtual address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary helpers in Kconfig. Fbdev drivers sometimes rely on

[PATCH v2 14/32] fbdev/smscufx: Select correct helpers

2023-11-27 Thread Thomas Zimmermann
The driver uses deferred I/O. Select the correct helpers via FB_SYSMEM_HELPERS_DEFERRED in the Kconfig file. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/Kconfig | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH v2 26/32] staging/sm750fb: Initialize fb_ops with fbdev macros

2023-11-27 Thread Thomas Zimmermann
Initialize all instances of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH v2 09/32] auxdisplay/ht16k33: Set FBINFO_VIRTFB flag

2023-11-27 Thread Thomas Zimmermann
The ht16k33 driver operates on system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann Cc: Miguel Ojeda Cc: Robin van der Gracht Reviewed-by: Javier Martinez Canillas Acked-by:

[PATCH v2 04/32] fbdev/vfb: Initialize fb_ops with fbdev macros

2023-11-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in virtual address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary helpers in Kconfig. Fbdev drivers sometimes rely on

[PATCH v2 31/32] fbdev: Warn on incorrect framebuffer access

2023-11-27 Thread Thomas Zimmermann
Test in framebuffer read, write and drawing helpers if FBINFO_VIRTFB has been set correctly. Framebuffers in I/O memory should only be accessed with the architecture's respective helpers. Framebuffers in system memory should be accessed with the regular load and store operations. Presumably not

[PATCH v2 02/32] fbdev/sm712fb: Use correct initializer macros for struct fb_ops

2023-11-27 Thread Thomas Zimmermann
Only initialize mmap and draw helpers with macros; leave read/write callbacks to driver implementations. Fixes the following warnings: CC [M] drivers/video/fbdev/sm712fb.o sm712fb.c:1355:25: warning: initialized field overwritten [-Woverride-init] 1355 | .fb_fillrect =

[PATCH v2 05/32] fbdev/arcfb: Set FBINFO_VIRTFB flag

2023-11-27 Thread Thomas Zimmermann
The arcfb driver operates on system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann Cc: Jaya Kumar Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/arcfb.c | 1 + 1

[PATCH v2 11/32] hid/picolcd_fb: Set FBINFO_VIRTFB flag

2023-11-27 Thread Thomas Zimmermann
The picolcd_fb driver operates on system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann Cc: "Bruno Prémont" Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org

[PATCH v2 18/32] fbdev/ps3fb: Set FBINFO_VIRTFB flag

2023-11-27 Thread Thomas Zimmermann
The ps3fb driver operates on system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: linuxppc-...@lists.ozlabs.org

[PATCH v2 25/32] staging/sm750fb: Declare fb_ops as constant

2023-11-27 Thread Thomas Zimmermann
Split up lynxfb_ops and declare each as constant. The fb_ops instance used to be modified while initializing the driver. It is now constant and the driver picks the correct instance, depending on the settings for acceleration and cursor support. Signed-off-by: Thomas Zimmermann Cc: Sudip

[PATCH v2 10/32] auxdisplay/ht16k33: Initialize fb_ops with fbdev macros

2023-11-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in virtual address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary helpers in Kconfig. Fbdev drivers sometimes rely on

[PATCH v2 00/32] fbdev: Modularize helpers for struct fb_ops

2023-11-27 Thread Thomas Zimmermann
Convert the remaining fbdev drivers to use fbdev's helpers macros for struct fb_ops. Then push the current default code for file-I/O operations into a module and remove it as default. Each driver now selects the helpers its needs for file I/O and drawing to its framebuffer. If no helper has been

[PATCH v2 30/32] fbdev: Move default fb_mmap code into helper function

2023-11-27 Thread Thomas Zimmermann
Move the default fb_mmap code for I/O address spaces into the helper function fb_io_mmap(). The helper can either be called via struct fb_ops.fb_mmap or as the default if no fb_mmap has been set. Also set the new helper in __FB_DEFAULT_IOMEM_OPS_MMAP. In the mid-term, fb_io_mmap() is supposed to

[PATCH v2 32/32] fbdev: Remove default file-I/O implementations

2023-11-27 Thread Thomas Zimmermann
Drop the default implementations for file read, write and mmap operations. Each fbdev driver must now provide an implementation and select any necessary helpers. If no implementation has been set, fbdev returns an errno code to user space. The code is the same as if the operation had not been set

[PATCH v2 28/32] fbdev: Remove trailing whitespaces

2023-11-27 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/sbuslib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/sbuslib.c b/drivers/video/fbdev/sbuslib.c index

[PATCH v2 24/32] fbdev/cyber2000fb: Initialize fb_ops with fbdev macros

2023-11-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH v2 23/32] fbdev/wm8505fb: Initialize fb_ops to fbdev I/O-memory helpers

2023-11-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in DMA-able address space. This explictily sets the read/write, draw and mmap callbacks to the correct default implementation. Also select the necessary helpers in Kconfig. Fbdev drivers sometimes rely on the

[PATCH v2 01/32] fbdev/acornfb: Fix name of fb_ops initializer macro

2023-11-27 Thread Thomas Zimmermann
Fix build by using the correct name for the initializer macro for struct fb_ops. Signed-off-by: Thomas Zimmermann Fixes: 9037afde8b9d ("fbdev/acornfb: Use fbdev I/O helpers") Cc: Thomas Zimmermann Cc: Sam Ravnborg Cc: Helge Deller Cc: Javier Martinez Canillas Cc: Arnd Bergmann Cc: # v6.6+

[PATCH v2 03/32] fbdev/vfb: Set FBINFO_VIRTFB flag

2023-11-27 Thread Thomas Zimmermann
The vfb driver operates on system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/vfb.c | 1 + 1 file changed, 1

Re: (subset) [PATCH 00/31] Fix and improve Rockchip RK3128 support

2023-11-27 Thread Vinod Koul
On Tue, 29 Aug 2023 19:16:16 +0200, Alex Bee wrote: > this series fixes some issues I found when testing my "new" RK3128 board > with the mainline kernel and adds some core functionality like SMP bringup, > usb and networking. > > The propably most distinctive change is the split up of the DTs

Re: (subset) [PATCH v9 00/12] drm/meson: add support for MIPI DSI Display

2023-11-27 Thread Vinod Koul
On Fri, 24 Nov 2023 09:41:11 +0100, Neil Armstrong wrote: > The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver > (ver 1.21a), > with a custom glue managing the IP resets, clock and data input similar to > the DW-HDMI > glue on the same Amlogic SoCs. > > This is a

Re: [PATCH] phy: mediatek: mipi: mt8183: fix minimal supported frequency

2023-11-27 Thread Vinod Koul
On Thu, 23 Nov 2023 12:02:02 +0100, Michael Walle wrote: > The lowest supported clock frequency of the PHY is 125MHz (see also > mtk_mipi_tx_pll_enable()), but the clamping in .round_rate() has the > wrong minimal value, which will make the .enable() op return -EINVAL on > low frequencies. Fix

Re: [PATCH 3/6] drm/bridge: tc358775: Add jeida-24 support

2023-11-27 Thread Michael Walle
> The jeida-24 register values are the default hardware settings, but they > not listed in the driver. Let's add them. jeida-24 and jeida-18 should have the same mapping, jeida-18 is broken in this driver. could you test this patch: --snip-- >From 46da1d76d4908e5879ed746cce1faeacd69c432e Mon

Re: [PATCH 4/4] drm/mediatek: support the DSI0 output on the MT8195 VDOSYS0

2023-11-27 Thread AngeloGioacchino Del Regno
Il 23/11/23 14:37, Michael Walle ha scritto: With the latest dynamic selection of the output component, we can now support different outputs. Move current output component into the dynamic routes array and add the new DSI0 output. Signed-off-by: Michael Walle Reviewed-by: AngeloGioacchino

Re: [PATCH 1/4] dt-bindings: display: mediatek: dsi: add compatible for MediaTek MT8195

2023-11-27 Thread AngeloGioacchino Del Regno
Il 23/11/23 14:37, Michael Walle ha scritto: Add the compatible string for MediaTek MT8195 SoC, using the same DSI block as the MT8183. Signed-off-by: Michael Walle Reviewed-by: AngeloGioacchino Del Regno

[PATCH] Revert "drm/sched: Qualify drm_sched_wakeup() by drm_sched_entity_is_ready()"

2023-11-27 Thread Bert Karwatzki
Commit f3123c25 (in combination with the use of work queues by the gpu scheduler) leads to random lock ups of the GUI [1,2]. This is not a complete revert of commit f3123c25 as drm_sched_wakeup still needs its entity argument to pass it to drm_sched_can_queue. [1]

Re: [PATCH 3/6] drm/bridge: tc358775: Add jeida-24 support

2023-11-27 Thread Tony Lindgren
* Michael Walle [231127 13:25]: > > The jeida-24 register values are the default hardware settings, but they > > not listed in the driver. Let's add them. > > jeida-24 and jeida-18 should have the same mapping, jeida-18 is broken in > this driver. could you test this patch: Yes great works for

Re: [PATCH v2 01/12] drm/rockchip: move output interface related definition to rockchip_drm_drv.h

2023-11-27 Thread Sascha Hauer
On Wed, Nov 22, 2023 at 08:53:49PM +0800, Andy Yan wrote: > From: Andy Yan > > The output interface related definition can shared between > vop and vop2, move them to rockchip_drm_drv.h can avoid duplicated > definition. > > Signed-off-by: Andy Yan Reviewed-by: Sascha Hauer Sascha > > ---

Re: [PATCH v2 02/12] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume"

2023-11-27 Thread Sascha Hauer
On Wed, Nov 22, 2023 at 08:54:00PM +0800, Andy Yan wrote: > From: Andy Yan > > This reverts commit b63a553e8f5aa6574eeb535a551817a93c426d8c. > > regcache_sync will try to reload the configuration in regcache to > hardware, but the registers of 4 Cluster windows and Esmart1/2/3 on > the upcoming

Re: [PATCH v2 03/12] drm/rockchip: vop2: set half_block_en bit in all mode

2023-11-27 Thread Sascha Hauer
On Wed, Nov 22, 2023 at 08:54:13PM +0800, Andy Yan wrote: > From: Andy Yan > > At first we thought the half_block_en bit in AFBCD_CTRL register > only work in afbc mode. But the fact is that it control the line > buffer in all mode(afbc/tile/line), so we need configure it in > all case. > >

Re: [PATCH v2 06/12] drm/rockchip: vop2: rename grf to sys_grf

2023-11-27 Thread Sascha Hauer
On Wed, Nov 22, 2023 at 08:54:54PM +0800, Andy Yan wrote: > From: Andy Yan > > The vop2 need to reference more grf(system grf, vop grf, vo0/1 grf,etc) > in the upcoming rk3588. > > So we rename the current system grf to sys_grf. > > Signed-off-by: Andy Yan Reviewed-by: Sascha Hauer Sascha

Re: [PATCH v2 05/12] drm/rockchip: vop2: Set YUV/RGB overlay mode

2023-11-27 Thread Sascha Hauer
On Wed, Nov 22, 2023 at 08:54:38PM +0800, Andy Yan wrote: > From: Andy Yan > > Set overlay mode register according to the > output mode is yuv or rgb. > > Signed-off-by: Andy Yan > --- > > (no changes since v1) > > drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + >

Re: [PATCH 1/2] drm/sched: Rename priority MIN to LOW

2023-11-27 Thread Christian König
Am 27.11.23 um 15:13 schrieb Luben Tuikov: On 2023-11-27 08:55, Christian König wrote: Hi Luben, Am 24.11.23 um 08:57 schrieb Christian König: Am 24.11.23 um 06:27 schrieb Luben Tuikov: Rename DRM_SCHED_PRIORITY_MIN to DRM_SCHED_PRIORITY_LOW. This mirrors DRM_SCHED_PRIORITY_HIGH, for a list

[PATCH v2] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-27 Thread Thomas Zimmermann
Invoke drm_plane_helper_funcs.end_fb_access before drm_atomic_helper_commit_hw_done(). The latter function hands over ownership of the plane state to the following commit, which might free it. Releasing resources in end_fb_access then operates on undefined state. This bug has been observed with

Re: [PATCH 1/2] drm/sched: Rename priority MIN to LOW

2023-11-27 Thread Luben Tuikov
On 2023-11-27 09:20, Christian König wrote: > Am 27.11.23 um 15:13 schrieb Luben Tuikov: >> On 2023-11-27 08:55, Christian König wrote: >>> Hi Luben, >>> >>> Am 24.11.23 um 08:57 schrieb Christian König: Am 24.11.23 um 06:27 schrieb Luben Tuikov: > Rename DRM_SCHED_PRIORITY_MIN to

[PATCH 1/2] drm/ttm: replace busy placement with flags v3

2023-11-27 Thread Christian König
From: Somalapuram Amaranath Instead of a list of separate busy placement add flags which indicate that a placement should only be used when there is room or if we need to evict. v2: add missing TTM_PL_FLAG_IDLE for i915 v3: fix auto build test ERROR on drm-tip/drm-tip Signed-off-by: Christian

[PATCH 2/2] drm/amdgpu: use GTT only as fallback for VRAM|GTT

2023-11-27 Thread Christian König
Try to fill up VRAM as well by setting the busy flag on GTT allocations. This fixes the issue that when VRAM was evacuated for suspend it's never filled up again unless the application is restarted. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 ++ 1

[PATCH v2 05/12] iommu/arm-smmu-qcom: Add QCM2290 DPU compatible

2023-11-27 Thread Konrad Dybcio
Add the QCM2290 DPU compatible to clients compatible list, as it also needs the workarounds. Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c

[PATCH v2 02/12] dt-bindings: display: msm: Add reg bus and rotator interconnects

2023-11-27 Thread Konrad Dybcio
Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there are other connection paths: - a path that connects rotator block to the DDR. - a path that needs to be handled to ensure MDSS register access functions properly, namely the "reg bus", a.k.a the CPU-MDSS CFG interconnect.

[PATCH v2 01/12] dt-bindings: display: msm: qcm2290-mdss: Use the non-deprecated DSI compat

2023-11-27 Thread Konrad Dybcio
The "qcom,dsi-ctrl-6g-qcm2290" has been deprecated in commit 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC"), but the example hasn't been updated to reflect that. Fix that. Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add

[PATCH v2 04/12] dt-bindings: firmware: qcom,scm: Allow interconnect for everyone

2023-11-27 Thread Konrad Dybcio
Every Qualcomm SoC physically has a "CRYPTO0<->DDR" interconnect lane. Allow this property to be present, no matter the SoC. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 15 --- 1 file changed, 15

[PATCH v2 00/12] RB1/QCM2290 features

2023-11-27 Thread Konrad Dybcio
This series brings: - interconnect plumbing - display setup for QCM2290/QRB2210 and - CAN bus controller - HDMI display - wifi fw variant name for QTI RB1 and the necessary bindings changes Patch 1-2 is for Dmitry/freedreno Patch 3 for Georgi/icc Patch 5 for Will/iommu the rest are for

[PATCH] nouveau/gsp/r535: remove a stray unlock in r535_gsp_rpc_send()

2023-11-27 Thread Dan Carpenter
This unlock doesn't belong here and it leads to a double unlock in the caller, r535_gsp_rpc_push(). Fixes: 176fdcbddfd2 ("drm/nouveau/gsp/r535: add support for booting GSP-RM") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 4 +--- 1 file changed, 1

Re: [PATCH 2/6] drm/bridge: tc358775: Fix getting dsi host data lanes

2023-11-27 Thread Michael Walle
> The current code assume hardcoded dsi host endpoint 1, which may not > be the case. Let's fix that and simplify the code by getting the dsi > endpoint with of_graph_get_remote_endpoint() that does not assume any > endpoint numbering. > > Fixes: b26975593b17 ("display/drm/bridge: TC358775

Re: [PATCH 2/6] drm/bridge: tc358775: Fix getting dsi host data lanes

2023-11-27 Thread Tony Lindgren
* Michael Walle [231127 13:10]: > I actually have the same fix, but with one additional detail, which I'm > unsure about though: This looks at the data-lanes property of the *remote* > endpoint whereas other bridge drivers (see tc358767, ti-sn65dsi83, lt8912b, > anx7625) look at the local

Re: (subset) [PATCH 0/4] drm/mediatek: support DSI output on MT8195

2023-11-27 Thread Vinod Koul
On Thu, 23 Nov 2023 14:37:45 +0100, Michael Walle wrote: > Add support for a DSI output on VDOSYS0. Luckily, there is a new > feature to support dynamic selections of the output (connector). > Use it to add support for a DSI output. > > Apart from that, this is pretty straghtforward by just

Re: [PATCH] dma-buf: fix check in dma_resv_add_fence

2023-11-27 Thread Christian König
Ping? Can I get an rb or acked-by for that? Thanks, Christian. Am 15.11.23 um 10:30 schrieb Christian König: It's valid to add the same fence multiple times to a dma-resv object and we shouldn't need one extra slot for each. Signed-off-by: Christian König Fixes: a3f7c10a269d5

Re: [PATCH] drm/bridge: panel: Check device dependency before managing device link

2023-11-27 Thread Ville Syrjälä
On Thu, Nov 23, 2023 at 11:26:15AM +0800, Liu Ying wrote: > Some panel devices already depend on DRM device, like the panel in > arch/arm/boot/dts/st/ste-ux500-samsung-skomer.dts, because DRM device is > the ancestor of those panel devices. device_link_add() would fail by > returning a NULL

Re: [PATCH drm-misc-next 4/5] drm/gpuvm: fall back to drm_exec_lock_obj()

2023-11-27 Thread Christian König
Am 25.11.23 um 00:40 schrieb Danilo Krummrich: Hi Christian, do you think it makes sense to handle this in drm_exec_prepare_obj() or even dma_resv_reserve_fences() even? IIRC for drm_exec the discussion has gone a bit back and forth between handling 0 and having a separate function which

Re: [PATCH 1/2] drm/sched: Rename priority MIN to LOW

2023-11-27 Thread Christian König
Hi Luben, Am 24.11.23 um 08:57 schrieb Christian König: Am 24.11.23 um 06:27 schrieb Luben Tuikov: Rename DRM_SCHED_PRIORITY_MIN to DRM_SCHED_PRIORITY_LOW. This mirrors DRM_SCHED_PRIORITY_HIGH, for a list of DRM scheduler priorities in ascending order,    DRM_SCHED_PRIORITY_LOW,   

Re: [PATCH v2 04/12] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode

2023-11-27 Thread Sascha Hauer
On Wed, Nov 22, 2023 at 08:54:25PM +0800, Andy Yan wrote: > From: Andy Yan > > The enable bit and transform offset of cluster windows should be > cleared when it work at linear mode, or we may have a iommu fault > issue. > > Signed-off-by: Andy Yan Reviewed-by: Sascha Hauer Sascha > --- >

Re: [PATCH] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-27 Thread Thomas Zimmermann
Hi Am 26.11.23 um 16:08 schrieb Alyssa Ross: Thomas Zimmermann writes: Invoke drm_plane_helper_funcs.end_fb_access before drm_atomic_helper_commit_hw_done(). The latter function hands over ownership of the plane state to the following commit, which might free it. Releasing resources in

Re: [PATCH 2/6] drm/bridge: tc358775: Fix getting dsi host data lanes

2023-11-27 Thread Michael Walle
+ dt maintainers I actually have the same fix, but with one additional detail, which I'm unsure about though: This looks at the data-lanes property of the *remote* endpoint whereas other bridge drivers (see tc358767, ti-sn65dsi83, lt8912b, anx7625) look at the local endpoint and I'm not sure

Re: [PATCH 1/6] dt-bindings: tc358775: Add support for tc358765

2023-11-27 Thread Tony Lindgren
* Michael Walle [231127 12:44]: > Hi, > > > The tc358765 is similar to tc358775 except for the stdby-gpios. > > Bad timing (for me). I'm about to send a bigger patch series for the > tc358775 which fixes the (completely) broken initialialization. And also > contains some of your fixes. OK

Re: Bug in the error handling in TTMs pool implementation

2023-11-27 Thread Christian König
Am 27.11.23 um 13:24 schrieb Karolina Stolarek: On 24.11.2023 16:53, Christian König wrote: @Karolina do you of hand know a way how we could exercise this in a TTM unit test? Basically we would need to redirect the alloc_pages_node() symbol to an unit test internal function and let it return

[PATCH v2 15/32] fbdev/udlfb: Select correct helpers

2023-11-27 Thread Thomas Zimmermann
The driver uses deferred I/O. Select the correct helpers via FB_SYSMEM_HELPERS_DEFERRED in the Kconfig file. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/Kconfig | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH v2 20/32] media/ivtvfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-11-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. This explictily sets the read/write, draw and mmap callbacks to the correct default implementation. Fbdev drivers sometimes rely on the callbacks being NULL for a default implementation

[PATCH v2 06/32] fbdev/arcfb: Use generator macros for deferred I/O

2023-11-27 Thread Thomas Zimmermann
Implement the driver's fops with the generator macros for deferred I/O. Only requires per-driver code for the on-scren scanout buffer. The generated helpers implement reading, writing and drawing on top of that. Also update the selected Kconfig tokens accordingly. Actual support for deferred I/O

[PATCH v2 21/32] fbdev/clps711x-fb: Initialize fb_ops with fbdev macros

2023-11-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary helpers in Kconfig. The driver previously selected drawing

[PATCH v2 27/32] fbdev: Rename FB_SYS_FOPS token to FB_SYSMEM_FOPS

2023-11-27 Thread Thomas Zimmermann
Rename the token to harmonize naming among various helpers. For example, I/O-memory helpers use FB_IOMEM_FOPS. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/Kconfig | 4 ++-- drivers/video/fbdev/core/Kconfig | 6 +++---

[PATCH v2 16/32] fbdev/au1200fb: Set FBINFO_VIRTFB flag

2023-11-27 Thread Thomas Zimmermann
The au1200fb driver operates on DMA-able system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/au1200fb.c | 2 ++ 1

[PATCH v2 19/32] fbdev/ps3fb: Initialize fb_ops with fbdev macros

2023-11-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in virtual address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary helpers in Kconfig. Fbdev drivers sometimes rely on

[PATCH v2 07/32] auxdisplay/cfag12864bfb: Set FBINFO_VIRTFB flag

2023-11-27 Thread Thomas Zimmermann
The cfag12864bfb driver operates on system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann Cc: Miguel Ojeda Reviewed-by: Javier Martinez Canillas Acked-by: Miguel Ojeda ---

[PATCH v2 13/32] fbdev/sh_mobile_lcdcfb: Initialize fb_ops with fbdev macros

2023-11-27 Thread Thomas Zimmermann
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in DMA-able virtual address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary helpers in Kconfig. The driver uses a mixture

Re: [PATCH 1/6] dt-bindings: tc358775: Add support for tc358765

2023-11-27 Thread Alexander Stein
Hi, Am Montag, 27. November 2023, 13:44:30 CET schrieb Michael Walle: > Hi, > > > The tc358765 is similar to tc358775 except for the stdby-gpios. > > Bad timing (for me). I'm about to send a bigger patch series for the > tc358775 which fixes the (completely) broken initialialization. And also >

Re: [PATCH v2 13/17] drm/v3d: Create a CPU job extension for the timestamp query job

2023-11-27 Thread Maira Canal
Hi Iago, On 11/27/23 06:16, Iago Toral wrote: El jue, 23-11-2023 a las 21:47 -0300, Maíra Canal escribió: (...) +static void +v3d_timestamp_query(struct v3d_cpu_job *job) +{ +   struct v3d_timestamp_query_info *timestamp_query = timestamp_query; +   struct v3d_bo *bo =

Re: [PATCH 3/4] arm64: dts: mediatek: mt8195: add DSI and MIPI DPHY nodes

2023-11-27 Thread AngeloGioacchino Del Regno
Il 23/11/23 14:37, Michael Walle ha scritto: Add the two DSI controller node and the associated DPHY nodes. Individual boards have to enable them in the board device tree. Signed-off-by: Michael Walle Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v2 25/32] staging/sm750fb: Declare fb_ops as constant

2023-11-27 Thread Greg Kroah-Hartman
On Mon, Nov 27, 2023 at 02:15:54PM +0100, Thomas Zimmermann wrote: > Split up lynxfb_ops and declare each as constant. The fb_ops > instance used to be modified while initializing the driver. It is > now constant and the driver picks the correct instance, depending > on the settings for

Re: [PATCH v2 26/32] staging/sm750fb: Initialize fb_ops with fbdev macros

2023-11-27 Thread Greg Kroah-Hartman
On Mon, Nov 27, 2023 at 02:15:55PM +0100, Thomas Zimmermann wrote: > Initialize all instances of struct fb_ops with fbdev initializer > macros for framebuffers in I/O address space. Set the read/write, > draw and mmap callbacks to the correct implementation and avoid > implicit defaults. Also

Re: [PATCH 1/2] drm/sched: Rename priority MIN to LOW

2023-11-27 Thread Luben Tuikov
On 2023-11-27 08:55, Christian König wrote: > Hi Luben, > > Am 24.11.23 um 08:57 schrieb Christian König: >> Am 24.11.23 um 06:27 schrieb Luben Tuikov: >>> Rename DRM_SCHED_PRIORITY_MIN to DRM_SCHED_PRIORITY_LOW. >>> >>> This mirrors DRM_SCHED_PRIORITY_HIGH, for a list of DRM scheduler >>>

TTM improvement and amdgpu fix

2023-11-27 Thread Christian König
Hi guys, TTM has a feature which allows to specify placements for normal operation as well as when all domains are "busy" and don't have free space. Not very widely used since it was a bit inflexible and required making multiple placement lists. Replace the multiple lists with flags and start

Re: [PATCH v2] drm/atomic-helpers: Invoke end_fb_access while owning plane state

2023-11-27 Thread Alyssa Ross
Thomas Zimmermann writes: > Invoke drm_plane_helper_funcs.end_fb_access before > drm_atomic_helper_commit_hw_done(). The latter function hands over > ownership of the plane state to the following commit, which might > free it. Releasing resources in end_fb_access then operates on undefined >

Re: [PATCH v2 0/2] drm/bridge: panel: Check device dependency before managing device link

2023-11-27 Thread Maxime Ripard
On Mon, Nov 27, 2023 at 05:03:53PM +0100, Linus Walleij wrote: > On Mon, Nov 27, 2023 at 6:10 AM Liu Ying wrote: > > > This series aims to check panel device dependency upon DRM device before > > managing device link between them. It fixes eariler patches in v6.7-rc1 > > which tried to manage

Re: [PATCH v2 1/2] driver core: Export device_is_dependent() to modules

2023-11-27 Thread Maxime Ripard
Greg, Rafael, On Mon, Nov 27, 2023 at 01:14:13PM +0800, Liu Ying wrote: > Export device_is_dependent() since the drm_kms_helper module is starting > to use it. > > Signed-off-by: Liu Ying > --- > v2: > * Newly introduced as needed by patch 2. > > drivers/base/core.c | 1 + > 1 file changed, 1

Re: [PATCH v9 07/12] clk: meson: add vclk driver

2023-11-27 Thread Jerome Brunet
On Mon 27 Nov 2023 at 17:14, Neil Armstrong wrote: > On 24/11/2023 15:41, Jerome Brunet wrote: >> On Fri 24 Nov 2023 at 09:41, Neil Armstrong >> wrote: >> >>> The VCLK and VCLK_DIV clocks have supplementary bits. >>> >>> The VCLK has a "SOFT RESET" bit to toggle after the whole >>> VCLK

RE: [PATCH 2/2] drm/amdgpu: use GTT only as fallback for VRAM|GTT

2023-11-27 Thread Bhardwaj, Rajneesh
[AMD Official Use Only - General] -Original Message- From: amd-gfx On Behalf Of Hamza Mahfooz Sent: Monday, November 27, 2023 10:53 AM To: Christian König ; jani.nik...@linux.intel.com; kher...@redhat.com; d...@redhat.com; za...@vmware.com; Olsak, Marek ;

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: fix check in dma_resv_add_fence

2023-11-27 Thread Intel
On 11/27/23 14:24, Christian König wrote: Ping? Can I get an rb or acked-by for that? Thanks, Christian. Am 15.11.23 um 10:30 schrieb Christian König: It's valid to add the same fence multiple times to a dma-resv object and we shouldn't need one extra slot for each. Signed-off-by:

Re: [PATCH 1/2] dt-bindings: display: bridge: samsung-dsim: Add i.MX7D support

2023-11-27 Thread Conor Dooley
On Mon, Nov 27, 2023 at 05:12:28PM +0100, Roland Hieber wrote: > From: Philipp Zabel > > Add support for the "fsl,imx7d-mipi-dsim" compatible used on i.MX7D. > > Signed-off-by: Philipp Zabel > Signed-off-by: Roland Hieber Acked-by: Conor Dooley Cheers, Conor. > --- >

Re: [PATCH] dt-bindings: mxsfb: Remove power-domains requirements for i.MX7D

2023-11-27 Thread Conor Dooley
- power-domains >- if: >properties: > compatible: >contains: > enum: >- fsl,imx6sl-lcdif > - - fsl,imx6sx-lcdif >- fsl,imx8mm-lcdif >- fsl,imx8mn-lcdif >

Re: [PATCH v2 06/17] drm/v3d: Decouple job allocation from job initiation

2023-11-27 Thread Iago Toral
El jue, 23-11-2023 a las 21:47 -0300, Maíra Canal escribió: > We want to allow the IOCTLs to allocate the job without initiating > it. > This will be useful for the CPU job submission IOCTL, as the CPU job > has > the need to use information from the user extensions. Currently, the > user

Re: [PATCH v9 00/12] drm/meson: add support for MIPI DSI Display

2023-11-27 Thread Neil Armstrong
Hi Vinod, On 24/11/2023 09:41, Neil Armstrong wrote: --- Neil Armstrong (12): dt-bindings: clk: g12a-clkc: add CTS_ENCL clock ids dt-bindings: soc: amlogic,meson-gx-hhi-sysctrl: add example covering meson-axg-hhi-sysctrl dt-bindings: phy:

Re: [PATCH v2 07/17] drm/v3d: Add a CPU job submission

2023-11-27 Thread Iago Toral
El jue, 23-11-2023 a las 21:47 -0300, Maíra Canal escribió: > From: Melissa Wen > > Create a new type of job, a CPU job. A CPU job is a type of job that > performs operations that requires CPU intervention. The overall idea > is > to use user extensions to enable different types of CPU job,

Re: [PATCH] drm/mxsfb: Switch to drmm_mode_config_init

2023-11-27 Thread Thomas Zimmermann
Hi Am 25.11.23 um 23:25 schrieb Marek Vasut: Switch from deprecated unmanaged drm_mode_config_init() to managed drmm_mode_config_init(). No functional change. Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Maarten Lankhorst Cc: Maxime Ripard Cc:

Re: [PATCH] drm/mxsfb: Drop extra space in request_irq args

2023-11-27 Thread Thomas Zimmermann
Am 25.11.23 um 23:24 schrieb Marek Vasut: Drop extra space, no functional change. Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: NXP Linux Team Cc: Pengutronix Kernel Team Cc: Sascha Hauer Cc: Shawn Guo

Re: [PATCH v9 08/12] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2023-11-27 Thread Jerome Brunet
>> >>> >>> I suspect mipi_dsi_pxclk_div was added to achieve fractional vclk/bitclk >>> ratios, >>> since it doesn't exist on AXG. Not sure we would ever need it... and none >>> of the other upstream DSI drivers supports such setups. >>> >>> The main reasons I set only mipi_dsi_pxclk in DT is

Re: [PATCH 1/2] dt-bindings: display: simple: Add boe,bp101wx1-100 panel

2023-11-27 Thread Krzysztof Kozlowski
On 27/11/2023 06:15, Tony Lindgren wrote: > This panel is found on Motorola mapphone tablets mz615 to mz617. > > Signed-off-by: Tony Lindgren Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v9 07/12] clk: meson: add vclk driver

2023-11-27 Thread Neil Armstrong
On 24/11/2023 15:41, Jerome Brunet wrote: On Fri 24 Nov 2023 at 09:41, Neil Armstrong wrote: The VCLK and VCLK_DIV clocks have supplementary bits. The VCLK has a "SOFT RESET" bit to toggle after the whole VCLK sub-tree rate has been set, this is implemented in the gate enable callback. The

Re: [PATCH v9 08/12] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2023-11-27 Thread neil . armstrong
Hi, On 24/11/2023 16:32, Jerome Brunet wrote: On Fri 24 Nov 2023 at 16:15, Neil Armstrong wrote: On 24/11/2023 15:12, Jerome Brunet wrote: On Fri 24 Nov 2023 at 09:41, Neil Armstrong wrote: In order to setup the DSI clock, let's make the unused VCLK2 clock path configuration via CCF.

Re: [PATCH v9 03/20] dt-bindings: gpu: Add Imagination Technologies PowerVR/IMG GPU

2023-11-27 Thread Geert Uytterhoeven
Hi Donald, On Wed, Nov 22, 2023 at 5:36 PM Donald Robson wrote: > From: Sarah Walker > > Add the device tree binding documentation for the IMG AXE GPU used in > TI AM62 SoCs. > > Co-developed-by: Frank Binns > Signed-off-by: Frank Binns > Signed-off-by: Sarah Walker > Signed-off-by: Donald

Re: [PATCH v2 07/17] drm/v3d: Add a CPU job submission

2023-11-27 Thread Iago Toral
El jue, 23-11-2023 a las 21:47 -0300, Maíra Canal escribió: > From: Melissa Wen > > Create a new type of job, a CPU job. A CPU job is a type of job that > performs operations that requires CPU intervention. The overall idea > is > to use user extensions to enable different types of CPU job,

Re: [PATCH v1 0/3] Rockchip inno_hdmi update

2023-11-27 Thread Maxime Ripard
Hi Johan, On Sun, Nov 26, 2023 at 11:55:03AM +0100, Johan Jonker wrote: > Combined update for the Rockchip inno_hdmi driver in a > somewhat similar way to what is proposed for the > "Create HDMI Connector infrastructure patch serie". > Keeping the inno_hdmi and rk3066_hdmi driver functions >

  1   2   3   >