Re: [PATCH 1/5] drm/msm/adreno: Split up giant device table

2023-12-06 Thread Konrad Dybcio
On 12/5/23 23:03, Rob Clark wrote: From: Rob Clark Split into a separate table per generation, in preparation to move each gen's device table to it's own file. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 59 +++--- 1 file changed, 51

Re: [PATCH] backlight: ili922x: fix W=1 kernel-doc warnings

2023-12-06 Thread Lee Jones
On Wed, 06 Dec 2023, Daniel Thompson wrote: > On Tue, Dec 05, 2023 at 02:56:38PM -0800, Randy Dunlap wrote: > > Fix kernel-doc warnings found when using "W=1". > > > > ili922x.c:85: warning: This comment starts with '/**', but isn't a > > kernel-doc comment. Refer

[PATCH v3 2/4] fbdev/efifb: Use screen_info pointer from device

2023-12-06 Thread Thomas Zimmermann
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that efifb can modify it at will. v2: * comment on devm_kmemdup() usage (Javier) Signed-off-by: Thomas

[PATCH v3 4/4] fbdev/vesafb: Use screen_info pointer from device

2023-12-06 Thread Thomas Zimmermann
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that vesafb can modify it at will. v2: * comment on devm_kmemdup() usage (Javier) Signed-off-by: Thomas

[PATCH v3 0/4] fbdev: Remove global screen_info in efifb/vesafb

2023-12-06 Thread Thomas Zimmermann
Replace the global instance of screen_info with the per-device instance that is set by the sysfb code. The use of the global screen_info should be limited and ideally be pushed into per-architecture code. v3: * better const correctness in efifb (Sui) * fix build for deferred

[PATCH v3 1/4] fbdev/efifb: Replace references to global screen_info by local pointer

2023-12-06 Thread Thomas Zimmermann
Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. v3: * use const screen_info in several places (Sui) * fix build for deferred takeover (kernel test robot) Signed-off-by: Thomas Zimmermann Tested-by: Sui Jingfeng

[PATCH v3 3/4] fbdev/vesafb: Replace references to global screen_info by local pointer

2023-12-06 Thread Thomas Zimmermann
Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/vesafb.c | 66 +++- 1 file changed, 35 insertions(+),

[PATCH] drm/bridge: nxp-ptn3460: simplify some error checking

2023-12-06 Thread Dan Carpenter
The i2c_master_send/recv() functions return negative error codes or they return "len" on success. So the error handling here can be written as just normal checks for "if (ret < 0) return ret;". No need to complicate things. Btw, in this code the "len" parameter can never be zero, but even if it

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread Conor Dooley
On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: > > Am 05.12.2023 um 18:33 schrieb Andrew Davis : > > > > On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: > >>> + - enum: > >>> + - ti,omap3430-gpu # Rev 121 > >>> + - ti,omap3630-gpu # Rev

Re: [PATCH] drm/tests: Switch to kunit devices

2023-12-06 Thread kernel test robot
/20231205090405.153140-1-mripard%40kernel.org patch subject: [PATCH] drm/tests: Switch to kunit devices config: i386-buildonly-randconfig-004-20231206 (https://download.01.org/0day-ci/archive/20231207/202312070011.fdjyhkoz-...@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm

Re: [PATCH] backlight: ili922x: fix W=1 kernel-doc warnings

2023-12-06 Thread Randy Dunlap
On 12/6/23 05:25, Lee Jones wrote: > On Wed, 06 Dec 2023, Daniel Thompson wrote: > >> On Tue, Dec 05, 2023 at 02:56:38PM -0800, Randy Dunlap wrote: >>> Fix kernel-doc warnings found when using "W=1". >>> >>> ili922x.c:85: warning: This comment starts with '/**', but isn't a >>> kernel-doc

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-12-06 Thread Tomi Valkeinen
Hi mipi dsi maintainers (I'm not sure who that is =), On 21/09/2023 13:50, Tomi Valkeinen wrote: It's been reported that DSI host driver's detach can be called without the attach ever happening: https://lore.kernel.org/all/20230412073954.20601-1-t...@atomide.com/ After reading the code, I

Re: [v3 4/6] drm/vs: Add KMS crtc

2023-12-06 Thread Keith Zhao
On 2023/12/6 16:55, Maxime Ripard wrote: > On Mon, Dec 04, 2023 at 08:33:13PM +0800, Keith Zhao wrote: >> +static const struct vs_plane_info dc_hw_planes_rev0[PLANE_NUM] = { >> +{ >> +.name = "Primary", >> +.id = PRIMARY_PLANE_0,

Re: [RFC PATCH v3 05/23] drm/vkms: Avoid reading beyond LUT array

2023-12-06 Thread Melissa Wen
On 12/06, Melissa Wen wrote: > On 11/10, Arthur Grillo wrote: > > > > > > On 08/11/23 13:36, Harry Wentland wrote: > > > When the floor LUT index (drm_fixp2int(lut_index) is the last > > > index of the array the ceil LUT index will point to an entry > > > beyond the array. Make sure we guard

Re: [PATCH v2 0/4] drm: Fix errors about uninitialized/wrong variables

2023-12-06 Thread Maxime Ripard
On Wed, Dec 06, 2023 at 02:50:57PM +0200, Tomi Valkeinen wrote: > Hi all, > > On 03/11/2023 15:14, Tomi Valkeinen wrote: > > Fix cases where smatch reports a use of an uninitialized variable, and > > one where the variable is initialized but contains wrong value. > > > > Tomi > > > >

[PATCH] drm/debugfs: drop unneeded DEBUG_FS guard

2023-12-06 Thread Dario Binacchi
The Makefile enables/disables the file compilation depending on CONFIG_DEBUG_FS. Signed-off-by: Dario Binacchi --- drivers/gpu/drm/drm_debugfs.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index f291fb4b359f..f80d9cf3e71a

Re: [PATCH] drm/debugfs: fix potential NULL pointer dereference

2023-12-06 Thread Nishanth Menon
On 15:19-20231205, Dmitry Baryshkov wrote: > On Tue, 5 Dec 2023 at 15:06, Marek Szyprowski > wrote: > > > > encoder->funcs entry might be NULL, so check it first before calling its > > methods. This fixes NULL pointer dereference observed on Rasberry Pi > > 3b/4b boards. > > > > Fixes:

Re: [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts

2023-12-06 Thread Conor Dooley
On Wed, Dec 06, 2023 at 08:23:37AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > i.MX23 has two LCDIF interrupts instead of a single one like other > i.MX devices. > > Take this into account for properly describing the i.MX23 LCDIF > interrupts. > > This fixes the following dt-schema

Re: [v3 1/6] dt-bindings: display: Add yamls for JH7110 display system

2023-12-06 Thread Sui Jingfeng
Hi, On 2023/12/4 20:33, Keith Zhao wrote: StarFive SoCs JH7110 display system: dc controller, hdmi controller, encoder, vout syscon. add the path of yaml file in MAINTAINERS Signed-off-by: Keith Zhao --- .../starfive/starfive,display-subsystem.yaml | 104

Re: [PATCH 1/5] drm/msm/adreno: Split up giant device table

2023-12-06 Thread Dmitry Baryshkov
On Wed, 6 Dec 2023 at 14:29, Konrad Dybcio wrote: > > > > On 12/5/23 23:03, Rob Clark wrote: > > From: Rob Clark > > > > Split into a separate table per generation, in preparation to move each > > gen's device table to it's own file. > > > > Signed-off-by: Rob Clark > > --- > >

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-06 Thread Maxime Ripard
On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote: > >> +static const struct of_device_id starfive_hdmi_dt_ids[] = { > >> + { .compatible = "starfive,jh7110-inno-hdmi",}, > > > > So it's inno hdmi, just like Rockchip then? > > > > This should be a common driver. > > Rockchip has a inno

Re: [PATCH v3 101/108] drm/bridge: ti-sn65dsi86: Make use of devm_pwmchip_alloc() function

2023-12-06 Thread Uwe Kleine-König
On Wed, Dec 06, 2023 at 02:06:11PM +0200, Laurent Pinchart wrote: > On Thu, Nov 23, 2023 at 11:10:18AM +0100, Uwe Kleine-König wrote: > > Once the series is completely applied, the pwm_chip isn't allocated > > using devm_kzalloc any more. You're only looking at an intermediate > > state where I

[PATCH] drm/imagination: Move dereference after NULL check in pvr_mmu_backing_page_init()

2023-12-06 Thread Dan Carpenter
This code dereferences "page->pvr_dev" and then checked for NULL on the next line. Re-order it to avoid a potential NULL pointer dereference. Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/imagination/pvr_mmu.c | 4 +++- 1

Re: [PATCH] drm/bridge: nxp-ptn3460: simplify some error checking

2023-12-06 Thread Robert Foss
On Wed, 6 Dec 2023 18:05:15 +0300, Dan Carpenter wrote: > The i2c_master_send/recv() functions return negative error codes or > they return "len" on success. So the error handling here can be written > as just normal checks for "if (ret < 0) return ret;". No need to > complicate things. > >

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread Andrew Davis
On 12/6/23 10:02 AM, Conor Dooley wrote: On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: Am 05.12.2023 um 18:33 schrieb Andrew Davis : On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: + - enum: + - ti,omap3430-gpu # Rev 121 + -

[PATCH v2] backlight: ili922x: drop kernel-doc for local macros

2023-12-06 Thread Randy Dunlap
Don't use kernel-doc notation for the local macros START_BYTE() and CHECK_FREQ_REG(). This prevents these kernel-doc warnings: ili922x.c:85: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * START_BYTE(id, rs, rw)

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-12-06 Thread Maxime Ripard
Hi, On Wed, Dec 06, 2023 at 02:48:58PM +0200, Tomi Valkeinen wrote: > Hi mipi dsi maintainers (I'm not sure who that is =), > > On 21/09/2023 13:50, Tomi Valkeinen wrote: > > It's been reported that DSI host driver's detach can be called without > > the attach ever happening: > > > >

Re: [PATCH v4 02/10] drm/bridge: Fix a use case in the bridge disable logic

2023-12-06 Thread Michael Nazzareno Trimarchi
Hi Jagan On Wed, Dec 6, 2023 at 2:31 PM Jagan Teki wrote: > > Hi Dario, > > On Wed, Dec 6, 2023 at 6:57 PM Dario Binacchi > wrote: > > > > Hi Dave and Jagan, > > > > On Tue, Dec 5, 2023 at 4:39 PM Dave Stevenson > > wrote: > > > > > > Hi Dario > > > > > > On Tue, 5 Dec 2023 at 10:54, Dario

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-06 Thread Keith Zhao
On 2023/12/6 20:56, Maxime Ripard wrote: > On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote: >> >> +static const struct of_device_id starfive_hdmi_dt_ids[] = { >> >> + { .compatible = "starfive,jh7110-inno-hdmi",}, >> > >> > So it's inno hdmi, just like Rockchip then? >> > >> > This

Re: [PATCH v3 3/9] drm/amd/display: read gamut remap matrix in fixed-point 31.32 format

2023-12-06 Thread Rodrigo Siqueira Jordao
On 11/28/23 10:52, Melissa Wen wrote: Instead of read gamut remap data from hw values, convert HW register values (S2D13) into a fixed-point 31.32 matrix for color state log. Change DCN10 log to print data in the format of the gamut remap matrix. Signed-off-by: Melissa Wen ---

Re: [PATCH v3 03/14] drm/panthor: Add the device logical block

2023-12-06 Thread Steven Price
On 04/12/2023 17:32, Boris Brezillon wrote: > The panthor driver is designed in a modular way, where each logical > block is dealing with a specific HW-block or software feature. In order > for those blocks to communicate with each other, we need a central > panthor_device collecting all the

Re: [PATCH v2 0/4] drm: Fix errors about uninitialized/wrong variables

2023-12-06 Thread Tomi Valkeinen
Hi all, On 03/11/2023 15:14, Tomi Valkeinen wrote: Fix cases where smatch reports a use of an uninitialized variable, and one where the variable is initialized but contains wrong value. Tomi Signed-off-by: Tomi Valkeinen --- Changes in v2: - Added two more fixes - Link to v1:

[bug report] drm/imagination: Implement firmware infrastructure and META FW support

2023-12-06 Thread Dan Carpenter
Hello Sarah Walker, The patch cc1aeedb98ad: "drm/imagination: Implement firmware infrastructure and META FW support" from Nov 22, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/imagination/pvr_vm.c:631 pvr_vm_create_context() error:

Re: [PATCH v4 02/10] drm/bridge: Fix a use case in the bridge disable logic

2023-12-06 Thread Jagan Teki
Hi Dario, On Wed, Dec 6, 2023 at 6:57 PM Dario Binacchi wrote: > > Hi Dave and Jagan, > > On Tue, Dec 5, 2023 at 4:39 PM Dave Stevenson > wrote: > > > > Hi Dario > > > > On Tue, 5 Dec 2023 at 10:54, Dario Binacchi > > wrote: > > > > > > The patch fixes the code for finding the next bridge with

Re: [PATCH v3 1/9] drm/amd/display: decouple color state from hw state log

2023-12-06 Thread Rodrigo Siqueira Jordao
On 11/28/23 10:52, Melissa Wen wrote: Prepare to hook up color state log according to the DCN version. v3: - put functions in single line (Siqueira) Signed-off-by: Melissa Wen --- .../amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 26 +-- 1 file changed, 18 insertions(+), 8

Re: [PATCH v1 1/2] dt-bindings: display: panel: raspberrypi: Add compatible property for waveshare 7inch touchscreen panel

2023-12-06 Thread Conor Dooley
On Wed, Dec 06, 2023 at 05:43:48PM +0800, Shengyang Chen wrote: > Hi, Conor > > On 2023/11/24 20:31, Conor Dooley wrote: > > On Fri, Nov 24, 2023 at 06:44:50PM +0800, Shengyang Chen wrote: > >> The waveshare 7inch touchscreen panel is a kind of raspberrypi pi > >> panel > > > > Can you be more

Re: [PATCH v3 00/14] drm: Add a driver for CSF-based Mali GPUs

2023-12-06 Thread Steven Price
On 05/12/2023 08:48, Boris Brezillon wrote: > Hi Steve, > > I forgot to mention that I intentionally dropped your R-b, because > there was a gazillion of changes all over the place, and I thought it > deserved a fresh review. No problem, I'll re-review the patches. Thanks for getting the v3 out

[bug report] drm/imagination: Implement firmware infrastructure and META FW support

2023-12-06 Thread Dan Carpenter
Hello Sarah Walker, The patch cc1aeedb98ad: "drm/imagination: Implement firmware infrastructure and META FW support" from Nov 22, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/imagination/pvr_fw_startstop.c:210 pvr_fw_stop() warn: odd mask '0x &

Re: [PATCH v4 02/10] drm/bridge: Fix a use case in the bridge disable logic

2023-12-06 Thread Dario Binacchi
Hi Dave and Jagan, On Tue, Dec 5, 2023 at 4:39 PM Dave Stevenson wrote: > > Hi Dario > > On Tue, 5 Dec 2023 at 10:54, Dario Binacchi > wrote: > > > > The patch fixes the code for finding the next bridge with the > > "pre_enable_prev_first" flag set to false. In case this condition is > > not

Re: [PATCH] drm/imagination: Move dereference after NULL check in pvr_mmu_backing_page_init()

2023-12-06 Thread Frank Binns
Hi Dan, Thank you for the patch. On Wed, 2023-12-06 at 17:37 +0300, Dan Carpenter wrote: > This code dereferences "page->pvr_dev" and then checked for NULL on the > next line. Re-order it to avoid a potential NULL pointer dereference. > > Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM

Re: [PATCH v3 02/14] drm/panthor: Add GPU register definitions

2023-12-06 Thread Steven Price
On 04/12/2023 17:32, Boris Brezillon wrote: > Those are the registers directly accessible through the MMIO range. > > FW registers are exposed in panthor_fw.h. > > v3: > - Add macros to extract GPU ID info > - Formatting changes > - Remove AS_TRANSCFG_ADRMODE_LEGACY - it doesn't exist post-CSF >

Re: [PATCH 12/18] dt-bindings: pwm: add binding for mt8365 SoC

2023-12-06 Thread Uwe Kleine-König
Hello, On Mon, Oct 23, 2023 at 11:44:11PM +0200, Uwe Kleine-König wrote: > On Mon, Oct 23, 2023 at 04:40:12PM +0200, Alexandre Mergnat wrote: > > Display PWM for MT8365 is compatible with MT8183. Then, add MT8365 binding > > along with MT8183 SoC. > > > > Signed-off-by: Alexandre Mergnat > >

Re: [PATCH v4 07/10] dt-bindings: display: panel: Add Ilitek ili9805 panel controller

2023-12-06 Thread Rob Herring
On Tue, Dec 05, 2023 at 11:52:54AM +0100, Dario Binacchi wrote: > From: Michael Trimarchi > > Add documentation for "ilitek,ili9805" panel. > > Signed-off-by: Michael Trimarchi > Signed-off-by: Dario Binacchi Where's Krzysztof's Reviewed-by? Rob

Re: [PATCH v1 0/2] Add waveshare 7inch touchscreen panel support

2023-12-06 Thread Dave Stevenson
Hi Keith On Wed, 6 Dec 2023 at 08:55, Keith Zhao wrote: > > > > On 2023/11/25 0:04, Dave Stevenson wrote: > > On Fri, 24 Nov 2023 at 15:00, Stefan Wahren wrote: > >> > >> Hi Shengyang, > >> > >> [fix address of Emma] > > > > Not merged to master yet, but Emma has stepped back from maintenance.

Re: [PATCH v3 01/14] drm/panthor: Add uAPI

2023-12-06 Thread Steven Price
On 04/12/2023 17:32, Boris Brezillon wrote: > Panthor follows the lead of other recently submitted drivers with > ioctls allowing us to support modern Vulkan features, like sparse memory > binding: > > - Pretty standard GEM management ioctls (BO_CREATE and BO_MMAP_OFFSET), > with the

Re: [PATCH v3 00/14] drm: Add a driver for CSF-based Mali GPUs

2023-12-06 Thread Boris Brezillon
Hi Steve, On Wed, 6 Dec 2023 15:47:29 + Steven Price wrote: > On 05/12/2023 08:48, Boris Brezillon wrote: > > Hi Steve, > > > > I forgot to mention that I intentionally dropped your R-b, because > > there was a gazillion of changes all over the place, and I thought it > > deserved a fresh

Re: [PATCH] drm/tests: Switch to kunit devices

2023-12-06 Thread kernel test robot
/20231205090405.153140-1-mripard%40kernel.org patch subject: [PATCH] drm/tests: Switch to kunit devices config: i386-randconfig-012-20231206 (https://download.01.org/0day-ci/archive/20231207/202312070010.hafmuyfe-...@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1

[bug report] drm/imagination: Implement MIPS firmware processor and MMU support

2023-12-06 Thread Dan Carpenter
Hello Sarah Walker, The patch 927f3e0253c1: "drm/imagination: Implement MIPS firmware processor and MMU support" from Nov 22, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/imagination/pvr_vm_mips.c:204 pvr_vm_mips_map() warn: 'pfn' can

Re: (subset) [PATCH] drm/imagination: move update_logtype() into ifdef section

2023-12-06 Thread Maxime Ripard
On Mon, 04 Dec 2023 08:32:10 +0100, Arnd Bergmann wrote: > This function is only used when debugfs is enabled, and otherwise > causes a build warning: > > drivers/gpu/drm/imagination/pvr_fw_trace.c:135:1: error: 'update_logtype' > defined but not used [-Werror=unused-function] > > Move the

Re: (subset) [PATCH v2] drm/imagination: Removed unused functions in pvr_fw_trace

2023-12-06 Thread Maxime Ripard
On Mon, 04 Dec 2023 15:13:37 +, Donald Robson wrote: > Fixing the warning below due to an unused file level vtable. Removing > only this causes additional warnings for the now unused functions, so > I've removed those too. > > >> drivers/gpu/drm/imagination/pvr_fw_trace.c:205:37: warning: >

Re: [PATCH RESEND v2 1/3] drm/encoder: register per-encoder debugfs dir

2023-12-06 Thread Maxime Ripard
Hi Mark, On Tue, Dec 05, 2023 at 04:13:41PM +, Mark Brown wrote: > On Sun, Dec 03, 2023 at 02:53:13PM +0300, Dmitry Baryshkov wrote: > > > Each of connectors and CRTCs used by the DRM device provides debugfs > > directory, which is used by several standard debugfs files and can > > further

Re: [PATCH 1/5] drm/msm/adreno: Split up giant device table

2023-12-06 Thread Rob Clark
On Wed, Dec 6, 2023 at 4:29 AM Konrad Dybcio wrote: > > > > On 12/5/23 23:03, Rob Clark wrote: > > From: Rob Clark > > > > Split into a separate table per generation, in preparation to move each > > gen's device table to it's own file. > > > > Signed-off-by: Rob Clark > > --- > >

Re: [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-06 Thread Abhinav Kumar
On 12/5/2023 7:51 PM, Bjorn Andersson wrote: On Mon, Dec 04, 2023 at 11:22:24AM -0800, Abhinav Kumar wrote: On 12/3/2023 7:31 PM, Bjorn Andersson wrote: On Fri, Dec 01, 2023 at 11:43:36AM -0800, Abhinav Kumar wrote: On 12/1/2023 8:22 AM, Bjorn Andersson wrote: On Fri, Dec 01, 2023 at

Re: [PATCH] drm/plane: fix error handling in __drm_universal_plane_init

2023-12-06 Thread Thomas Zimmermann
Hi Am 06.12.23 um 08:27 schrieb Dinghao Liu: __drm_universal_plane_init() frees plane->format_types and plane->modifiers on failure. However, sometimes its callers will free these two pointers again, which may lead to a double-free. One possible call chain is: mdp5_plane_init |->

Re: [PATCH v3,16/21] media: medkatek: vcodec: support one plane capture buffer

2023-12-06 Thread Hans Verkuil
On 06/12/2023 09:15, Yunfei Dong wrote: > The capture buffer has two planes for format MM21, but user space only > allocate secure memory for plane[0], and the size is Y data + uv data. > The driver need to support one plane decoder for svp mode. For a future v4: note the typo in the Subject

Re: [PATCH v1 0/2] Add waveshare 7inch touchscreen panel support

2023-12-06 Thread Keith Zhao
On 2023/11/25 0:04, Dave Stevenson wrote: > On Fri, 24 Nov 2023 at 15:00, Stefan Wahren wrote: >> >> Hi Shengyang, >> >> [fix address of Emma] > > Not merged to master yet, but Emma has stepped back from maintenance. > https://lists.freedesktop.org/archives/dri-devel/2023-October/428829.html

Re: [v3 4/6] drm/vs: Add KMS crtc

2023-12-06 Thread Maxime Ripard
On Mon, Dec 04, 2023 at 08:33:13PM +0800, Keith Zhao wrote: > +static const struct vs_plane_info dc_hw_planes_rev0[PLANE_NUM] = { > + { > + .name = "Primary", > + .id = PRIMARY_PLANE_0, > + .type =

Re: [PATCH] drm/plane: fix error handling in __drm_universal_plane_init

2023-12-06 Thread Dmitry Baryshkov
On Wed, 6 Dec 2023 at 10:22, Thomas Zimmermann wrote: > > Hi > > Am 06.12.23 um 08:27 schrieb Dinghao Liu: > > __drm_universal_plane_init() frees plane->format_types and > > plane->modifiers on failure. However, sometimes its callers > > will free these two pointers again, which may lead to a > >

Re: [PATCH 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

2023-12-06 Thread Dmitry Baryshkov
On Wed, 6 Dec 2023 at 00:06, Rob Clark wrote: > > From: Rob Clark > > Introduce a6xx_info where we can stash gen specific stuff without > polluting the toplevel adreno_info struct. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 55 +-- >

[PATCH v3, 18/21] media: medkatek: vcodec: remove parse nal_info in kernel

2023-12-06 Thread Yunfei Dong
The hardware can parse syntax to get nal_info, needn't to use cpu. Signed-off-by: Yunfei Dong --- .../vcodec/decoder/vdec/vdec_h264_req_multi_if.c| 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git

[PATCH v3,15/21] media: mediatek: vcodec: Add one plane format

2023-12-06 Thread Yunfei Dong
Adding capture formats to support V4L2_PIX_FMT_MS21. This format has one plane and only be used for secure video playback at current period. Signed-off-by: Yunfei Dong --- .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec.c| 4 +++- .../mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c

[PATCH v3, 21/21] media: mediatek: vcodec: move vdec init interface to setup callback

2023-12-06 Thread Yunfei Dong
Getting secure video playback (svp) flag when request output buffer, then calling init interface to init svp parameters in optee-os. Signed-off-by: Yunfei Dong --- .../mediatek/vcodec/decoder/mtk_vcodec_dec.c | 144 -- 1 file changed, 94 insertions(+), 50 deletions(-) diff

[PATCH v3, 10/21] media: mediatek: vcodec: send share memory data to optee

2023-12-06 Thread Yunfei Dong
Setting msg and vsi information to shared buffer, then call tee invoke function to send it to optee-os. Signed-off-by: Yunfei Dong --- .../vcodec/decoder/mtk_vcodec_dec_optee.c | 140 ++ .../vcodec/decoder/mtk_vcodec_dec_optee.h | 51 +++ 2 files changed, 191

[PATCH v3, 19/21] media: medkatek: vcodec: disable wait interrupt for svp mode

2023-12-06 Thread Yunfei Dong
Waiting interrupt in optee-os for svp mode, need to disable it in kernel in case of interrupt is cleaned. Signed-off-by: Yunfei Dong --- .../vcodec/decoder/mtk_vcodec_dec_hw.c| 34 +-- .../vcodec/decoder/mtk_vcodec_dec_pm.c| 6 +-

[PATCH v3,06/21] dma-heap: Add proper kref handling on dma-buf heaps

2023-12-06 Thread Yunfei Dong
From: John Stultz Add proper refcounting on the dma_heap structure. While existing heaps are built-in, we may eventually have heaps loaded from modules, and we'll need to be able to properly handle the references to the heaps Signed-off-by: John Stultz Signed-off-by: T.J. Mercier

[PATCH v3, 07/21] dma-heap: Provide accessors so that in-kernel drivers can allocate dmabufs from specific heaps

2023-12-06 Thread Yunfei Dong
From: John Stultz This allows drivers who don't want to create their own DMA-BUF exporter to be able to allocate DMA-BUFs directly from existing DMA-BUF Heaps. There is some concern that the premise of DMA-BUF heaps is that userland knows better about what type of heap memory is needed for a

[PATCH v3,09/21] media: mediatek: vcodec: allocate tee share memory

2023-12-06 Thread Yunfei Dong
Allocate two share memory for each lat and core hardware used to share information with optee-os. Msg buffer used to send ipi command and get ack command with optee-os, data buffer used to store vsi information which used for hardware decode. Signed-off-by: Yunfei Dong ---

[PATCH v3, 08/21] media: mediatek: vcodec: add tee client interface to communiate with optee-os

2023-12-06 Thread Yunfei Dong
Open tee context to initialize the environment in order to communication with optee-os, then open tee session as the communication pipeline for lat and core to send data for hardware decode. Signed-off-by: Yunfei Dong --- .../platform/mediatek/vcodec/decoder/Makefile | 1 +

[PATCH v3, 14/21] media: mediatek: vcodec: Add capture format to support one plane memory

2023-12-06 Thread Yunfei Dong
Define one uncompressed capture format V4L2_PIX_FMT_MS21 in order to support one plane memory. The buffer size is luma + chroma, luma is stored at the start and chrome is stored at the end. Signed-off-by: Yunfei Dong --- Documentation/userspace-api/media/v4l/pixfmt-reserved.rst | 8

[PATCH v3, 11/21] media: mediatek: vcodec: initialize msg and vsi information

2023-12-06 Thread Yunfei Dong
Need to initialize msg and vsi information before sending to optee-os, then calling optee invoke command to send the information to optee-os. For the optee communication interface is different with scp, using flag to separate them. Signed-off-by: Yunfei Dong ---

[PATCH v3, 16/21] media: medkatek: vcodec: support one plane capture buffer

2023-12-06 Thread Yunfei Dong
The capture buffer has two planes for format MM21, but user space only allocate secure memory for plane[0], and the size is Y data + uv data. The driver need to support one plane decoder for svp mode. Signed-off-by: Yunfei Dong --- .../mediatek/vcodec/decoder/mtk_vcodec_dec.c | 7 -

[PATCH v3, 05/21] dma-buf: heaps: Deduplicate docs and adopt common format

2023-12-06 Thread Yunfei Dong
From: "T.J. Mercier" The docs for dma_heap_get_name were incorrect, and since they were duplicated in the header they were wrong there too. The docs formatting was inconsistent so I tried to make it more consistent across functions since I'm already in here doing cleanup. Remove multiple

[PATCH v3, 17/21] media: medkatek: vcodec: re-construct h264 driver to support svp mode

2023-12-06 Thread Yunfei Dong
Need secure buffer size to convert secure handle to secure pa in optee-os, re-construct the vsi struct to store each secure buffer size. Separate svp and normal wait interrupt condition for svp mode waiting hardware interrupt in optee-os. Signed-off-by: Yunfei Dong ---

[PATCH v3, 12/21] media: mediatek: vcodec: add interface to allocate/free secure memory

2023-12-06 Thread Yunfei Dong
Need to call dma heap interface to allocate/free secure memory when playing secure video. Signed-off-by: Yunfei Dong --- .../media/platform/mediatek/vcodec/Kconfig| 1 + .../mediatek/vcodec/common/mtk_vcodec_util.c | 122 +- .../mediatek/vcodec/common/mtk_vcodec_util.h |

[PATCH v3,20/21] media: medkatek: vcodec: support tee decoder

2023-12-06 Thread Yunfei Dong
Initialize tee private data to support secure decoder. Release tee related information for each instance when decoder done. Signed-off-by: Yunfei Dong --- .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v3, 03/21] v4l2: verify secure dmabufs are used in secure queue

2023-12-06 Thread Yunfei Dong
From: Jeffrey Kardatzke Verfies in the dmabuf implementations that if the secure memory flag is set for a queue that the dmabuf submitted to the queue is unmappable. Signed-off-by: Jeffrey Kardatzke Signed-off-by: Yunfei Dong --- drivers/media/common/videobuf2/videobuf2-dma-contig.c | 6

[PATCH v3, 13/21] media: mediatek: vcodec: using shared memory as vsi address

2023-12-06 Thread Yunfei Dong
The vsi buffer is allocated by tee share memory for svp mode, need to use the share memory as the vsi address to store vsi data. Signed-off-by: Yunfei Dong --- .../vcodec/decoder/vdec/vdec_h264_req_multi_if.c | 9 +++-- .../media/platform/mediatek/vcodec/decoder/vdec_vpu_if.c | 8

Re: [PATCH v2 1/4] fbdev/efifb: Replace references to global screen_info by local pointer

2023-12-06 Thread Thomas Zimmermann
-173019 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20231204092812.2612-2-tzimmermann%40suse.de patch subject: [PATCH v2 1/4] fbdev/efifb: Replace references to global screen_info by local pointer config: x86_64-randconfig-006-20231206

Re: [v2, 1/4] fbdev/efifb: Replace references to global screen_info by local pointer

2023-12-06 Thread Thomas Zimmermann
Hi Am 04.12.23 um 20:53 schrieb Sui Jingfeng: Hi, On 2023/12/4 17:27, Thomas Zimmermann wrote: Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas

Re: [PATCH 1/5] drm/msm/adreno: Split up giant device table

2023-12-06 Thread Dmitry Baryshkov
On Wed, 6 Dec 2023 at 00:05, Rob Clark wrote: > > From: Rob Clark > > Split into a separate table per generation, in preparation to move each > gen's device table to it's own file. > > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/adreno/adreno_device.c

Re: [RFT PATCH v2 04/12] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv at shutdown time

2023-12-06 Thread Maxime Ripard
On Tue, Dec 05, 2023 at 12:45:07PM -0800, Doug Anderson wrote: > Hi, > > On Fri, Nov 17, 2023 at 3:00 PM Doug Anderson wrote: > > > > Hi, > > > > On Fri, Sep 22, 2023 at 2:06 PM Lyude Paul wrote: > > > > > > actually very glad to see this because I think I've seen one bug in the > > > wild > >

[PATCH v3,00/21] add driver to support secure video decoder

2023-12-06 Thread Yunfei Dong
The patch series used to enable secure video playback (SVP) on MediaTek hardware in the Linux kernel. Memory Definitions: secure memory - Memory allocated in the TEE (Trusted Execution Environment) which is inaccessible in the REE (Rich Execution Environment, i.e. linux kernel/userspace). secure

[PATCH v3,01/21] v4l2: add secure memory flags

2023-12-06 Thread Yunfei Dong
From: Jeffrey Kardatzke Adds a V4L2 flag which indicates that a queue is using secure dmabufs and the corresponding capability flag. Signed-off-by: Jeffrey Kardatzke Signed-off-by: Yunfei Dong --- include/media/videobuf2-core.h | 8 +++- include/uapi/linux/videodev2.h | 2 ++ 2 files

[PATCH v3,02/21] v4l2: handle secure memory flags in queue setup

2023-12-06 Thread Yunfei Dong
From: Jeffrey Kardatzke Validates the secure memory flags when setting up a queue and ensures the queue has the proper capability. Signed-off-by: Jeffrey Kardatzke Signed-off-by: Yunfei Dong --- .../media/common/videobuf2/videobuf2-core.c | 23 +

[PATCH v3,04/21] v4l: add documentation for secure memory flag

2023-12-06 Thread Yunfei Dong
From: Jeffrey Kardatzke Adds documentation for V4L2_MEMORY_FLAG_SECURE. Signed-off-by: Jeffrey Kardatzke Signed-off-by: Yunfei Dong --- Documentation/userspace-api/media/v4l/buffer.rst | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

Re: [PATCH drm-misc-next v2 0/2] PowerVR VM fixes

2023-12-06 Thread Maxime Ripard
On Tue, Dec 05, 2023 at 04:40:40PM +0100, Danilo Krummrich wrote: > On Tue, Dec 05, 2023 at 04:35:00PM +0100, Maxime Ripard wrote: > > Hi, > > > > On Wed, Nov 29, 2023 at 11:07:59PM +0100, Danilo Krummrich wrote: > > > Some major GPUVM changes landed just before v8 of the PowerVR series. > > >

Re: [PATCH] dt-bindings: display: adi,adv75xx: Document #sound-dai-cells

2023-12-06 Thread Krzysztof Kozlowski
On 06/12/2023 02:28, Fabio Estevam wrote: > From: Fabio Estevam > > When using audio from ADV7533 or ADV7535 and describing the audio > card via simple-audio-card, the '#sound-dai-cells' needs to be passed. > > Document the '#sound-dai-cells' property to fix the following > dt-schema warning: >

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-06 Thread Maxime Ripard
On Mon, Dec 04, 2023 at 08:33:14PM +0800, Keith Zhao wrote: > add hdmi driver as encoder and connect > > Signed-off-by: Keith Zhao > --- > drivers/gpu/drm/verisilicon/Kconfig | 8 + > drivers/gpu/drm/verisilicon/Makefile| 1 + > drivers/gpu/drm/verisilicon/starfive_hdmi.c |

Re: [Linaro-mm-sig] Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-12-06 Thread Christian König
Am 05.12.23 um 18:14 schrieb Rob Clark: On Tue, Dec 5, 2023 at 8:56 AM Rob Clark wrote: On Tue, Dec 5, 2023 at 7:58 AM Christian König wrote: Am 05.12.23 um 16:41 schrieb Rob Clark: On Mon, Dec 4, 2023 at 10:46 PM Christian König wrote: Am 04.12.23 um 22:54 schrieb Rob Clark: On Thu,

Re: [PATCH 2/5] drm/msm/adreno: Split catalog into separate files

2023-12-06 Thread Dmitry Baryshkov
On Wed, 6 Dec 2023 at 00:06, Rob Clark wrote: > > From: Rob Clark > > Split each gen's gpu table into it's own file. Only code-motion, no > functional change. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/Makefile | 5 + > drivers/gpu/drm/msm/adreno/a2xx_catalog.c

Re: [PATCH 3/5] drm/msm/adreno: Move hwcg regs to a6xx hw catalog

2023-12-06 Thread Dmitry Baryshkov
On Wed, 6 Dec 2023 at 00:06, Rob Clark wrote: > > From: Rob Clark > > Move the hwcg tables into the hw catalog. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 560 ++ > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 558 - >

Re: [PATCH 00/14] drm: Remove infrastructure for user-space mode setting

2023-12-06 Thread Thomas Zimmermann
Merged into drm-misc-next, except for patch 1. It's fairly independent from the other patches and I'll resend it directly to the the PPC list. Best regards Thomas Am 22.11.23 um 13:09 schrieb Thomas Zimmermann: The old drivers for user-space mode setting have been removed in Linux v6.3. No

Re: [PATCH v1 1/2] dt-bindings: display: panel: raspberrypi: Add compatible property for waveshare 7inch touchscreen panel

2023-12-06 Thread Shengyang Chen
Hi, Conor On 2023/11/24 20:31, Conor Dooley wrote: > On Fri, Nov 24, 2023 at 06:44:50PM +0800, Shengyang Chen wrote: >> The waveshare 7inch touchscreen panel is a kind of raspberrypi pi >> panel > > Can you be more specific about what "is a kind of rpi panel" means? > Are they using identical

Re: [PATCH v1 0/2] Add waveshare 7inch touchscreen panel support

2023-12-06 Thread Shengyang Chen
Hi, Stefan Thanks for your comment and review On 2023/11/24 22:54, Stefan Wahren wrote: > Hi Shengyang, > > [fix address of Emma] > > Am 24.11.23 um 11:44 schrieb Shengyang Chen: >> This patchset adds waveshare 7inch touchscreen panel support >> for the StarFive JH7110 SoC. >> >> Patch 1 add

Re: Bug#1054514: linux-image-6.1.0-13-amd64: Debian VM with qxl graphics freezes frequently

2023-12-06 Thread Linux regression tracking (Thorsten Leemhuis)
Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone. Gerd, it seems this regression[1] fell through the cracks. Could you please take a look? Or is there a good reason why this can't be addressed? Or was it dealt with and I

Re: [PATCH v2] drm/i915/gt: Convert reset prepare failure log to trace

2023-12-06 Thread Nirmoy Das
Hi John, On 12/5/2023 8:50 PM, John Harrison wrote: On 12/5/2023 02:39, Nirmoy Das wrote: Hi John, On 12/5/2023 10:10 AM, John Harrison wrote: On 12/5/2023 00:52, Nirmoy Das wrote: gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases this is

Re: [PATCH] drm/plane: fix error handling in __drm_universal_plane_init

2023-12-06 Thread Thomas Zimmermann
Hi Am 06.12.23 um 10:09 schrieb Dmitry Baryshkov: On Wed, 6 Dec 2023 at 10:22, Thomas Zimmermann wrote: Hi Am 06.12.23 um 08:27 schrieb Dinghao Liu: __drm_universal_plane_init() frees plane->format_types and plane->modifiers on failure. However, sometimes its callers will free these two

[PATCH v2] dt-bindings: display: adi, adv75xx: Document #sound-dai-cells

2023-12-06 Thread Fabio Estevam
From: Fabio Estevam When using audio from ADV7533 or ADV7535 and describing the audio card via simple-audio-card, the '#sound-dai-cells' needs to be passed. Document the '#sound-dai-cells' property to fix the following dt-schema warning: imx8mn-beacon-kit.dtb: hdmi@3d: '#sound-dai-cells' does

Re: [PATCH v4 00/13] drm/msm/dpu: use managed memory allocations

2023-12-06 Thread Dmitry Baryshkov
On Sat, 02 Dec 2023 00:18:32 +0300, Dmitry Baryshkov wrote: > In a lots of places in DPU driver memory is allocated by using the > kzalloc and then manually freed using kfree. However thes memory chunks > have a well-defined life cycle. They are either a part of the driver's > runtime and can be

Re: [PATCH v2] drm/msm/dpu: correct clk bit for WB2 block

2023-12-06 Thread Dmitry Baryshkov
On Sun, 03 Dec 2023 03:24:37 +0300, Dmitry Baryshkov wrote: > On sc7280 there are two clk bits for WB2: vbif_cli and clk_ctrl. While > programming the VBIF params of WB, the driver should be toggling the > former bit, while the sc7180_mdp, sc7280_mdp and sm8250_mdp structs > list the latter one.

  1   2   >